)]}'
{"conf.d/file_size.yaml.example":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"87efa3e27166cc7ac3cba8b826bc9e1699fe7cdc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    # \"file_directory\" - string, the directory of the files to monitor."},{"line_number":16,"context_line":"    #                    Required"},{"line_number":17,"context_line":"    # \"file_name\" - string, names of the files to monitor. Defaults to \"*\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    # Check the size of one file under directory_1"},{"line_number":20,"context_line":"    -  file_directory: \"/path/to/directory_1\""},{"line_number":21,"context_line":"       file_name: \"file_name1\""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9a68dd71_6fa9297b","line":18,"updated":"2016-01-21 11:33:54.000000000","message":"Would it be possible to replace \u0027*\u0027 with RegExp based approach. With that you\u0027d still be able to watch every file\nbut one could configure check to monitor files by pattern, right ?","commit_id":"18f27c6b0f61629ce276e2ad745b81d113e49d67"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"270e741ad0bd3643718246057f90750d57b1a455","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    # \"file_directory\" - string, the directory of the files to monitor."},{"line_number":16,"context_line":"    #                    Required"},{"line_number":17,"context_line":"    # \"file_name\" - string, names of the files to monitor. Defaults to \"*\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    # Check the size of one file under directory_1"},{"line_number":20,"context_line":"    -  file_directory: \"/path/to/directory_1\""},{"line_number":21,"context_line":"       file_name: \"file_name1\""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9a68dd71_17b17b47","line":18,"in_reply_to":"9a68dd71_6fa9297b","updated":"2016-01-22 00:27:07.000000000","message":"Yes you are right! This will be a very good and helpful feature for this plugin. Thank you!","commit_id":"18f27c6b0f61629ce276e2ad745b81d113e49d67"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"76376dfcadadb6ae4dba05648c5e79bba04408f1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    # \"file_name\" - string, names of the files to monitor. Defaults to \"*\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    # Check the size of one file under directory_1"},{"line_number":20,"context_line":"    -  built_by: Logging"},{"line_number":21,"context_line":"       file_directory: /path/to/directory_1"},{"line_number":22,"context_line":"       file_names:"},{"line_number":23,"context_line":"       - \u0027*\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    # Check one file under directory_2"},{"line_number":26,"context_line":"    -  built_by: Logging"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"9a68dd71_09cbe973","line":23,"range":{"start_line":20,"start_character":0,"end_line":23,"end_character":12},"updated":"2016-01-26 17:10:44.000000000","message":"for this example take out the * and file_names. Above you pointed that it defaults to *. Good to have an example of that. Also is it one file ^ or all files under that directory?","commit_id":"1c524961235db7e401b6abe4a65f4378678665b5"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"f12a87d8edc0ae717cf9dfe85f7344e3e900364a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    # \"file_name\" - string, names of the files to monitor. Defaults to \"*\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    # Check the size of one file under directory_1"},{"line_number":20,"context_line":"    -  built_by: Logging"},{"line_number":21,"context_line":"       file_directory: /path/to/directory_1"},{"line_number":22,"context_line":"       file_names:"},{"line_number":23,"context_line":"       - \u0027*\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    # Check one file under directory_2"},{"line_number":26,"context_line":"    -  built_by: Logging"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"9a68dd71_0faa0486","line":23,"range":{"start_line":20,"start_character":0,"end_line":23,"end_character":12},"in_reply_to":"9a68dd71_09cbe973","updated":"2016-01-26 20:09:02.000000000","message":"I think making file_names to be required will work better here.","commit_id":"1c524961235db7e401b6abe4a65f4378678665b5"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"2a268330ef0a74246239e2122f5431a5d6fafa4e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2014-2016 Hewlett Packard Enterprise Development Company LP"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"init_config:"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"7a5de9d1_a54e71bf","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":21},"updated":"2016-01-28 01:18:56.000000000","message":"Since this is a new file, it should just say 2016","commit_id":"bd04c1da0446682f921e281237de820440c8b77c"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"ec287fbdc460a4693f7bcb6420241db4de1c6d83","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    #"},{"line_number":9,"context_line":"    # NOTE: This check is NOT currently supported on Windows systems"},{"line_number":10,"context_line":"    #"},{"line_number":11,"context_line":"    # For each instance, the \u0027directory\u0027 parameter is required, all others are optional."},{"line_number":12,"context_line":"    #"},{"line_number":13,"context_line":"    # WARNING: Ensure the user account running the Agent (typically dd-agent) has read"},{"line_number":14,"context_line":"    # access to the monitored directory and files."}],"source_content_type":"application/octet-stream","patch_set":11,"id":"7a5de9d1_fc2b6a92","line":11,"range":{"start_line":11,"start_character":64,"end_line":11,"end_character":87},"updated":"2016-01-28 23:46:50.000000000","message":"you made flle names required","commit_id":"3fcbc3dff5853591317441f834de9164954c1f83"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"33c7db71ef079218b63ea709d085b9ea16faafb6","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    #"},{"line_number":9,"context_line":"    # NOTE: This check is NOT currently supported on Windows systems"},{"line_number":10,"context_line":"    #"},{"line_number":11,"context_line":"    # For each instance, the \u0027directory\u0027 parameter is required, all others are optional."},{"line_number":12,"context_line":"    #"},{"line_number":13,"context_line":"    # WARNING: Ensure the user account running the Agent (typically dd-agent) has read"},{"line_number":14,"context_line":"    # access to the monitored directory and files."}],"source_content_type":"application/octet-stream","patch_set":11,"id":"7a5de9d1_323e09b9","line":11,"range":{"start_line":11,"start_character":64,"end_line":11,"end_character":87},"in_reply_to":"7a5de9d1_fc2b6a92","updated":"2016-01-29 00:09:02.000000000","message":"Good catch! Thank you Michael!","commit_id":"3fcbc3dff5853591317441f834de9164954c1f83"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"ec287fbdc460a4693f7bcb6420241db4de1c6d83","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    #"},{"line_number":11,"context_line":"    # For each instance, the \u0027directory\u0027 parameter is required, all others are optional."},{"line_number":12,"context_line":"    #"},{"line_number":13,"context_line":"    # WARNING: Ensure the user account running the Agent (typically dd-agent) has read"},{"line_number":14,"context_line":"    # access to the monitored directory and files."},{"line_number":15,"context_line":"    #"},{"line_number":16,"context_line":"    # Instances take the following parameters:"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"7a5de9d1_bc1c1278","line":13,"range":{"start_line":13,"start_character":68,"end_line":13,"end_character":70},"updated":"2016-01-28 23:46:50.000000000","message":"mon","commit_id":"3fcbc3dff5853591317441f834de9164954c1f83"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"ec287fbdc460a4693f7bcb6420241db4de1c6d83","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    # Instances take the following parameters:"},{"line_number":17,"context_line":"    # \"file_directory\" - string, the directory of the files to monitor."},{"line_number":18,"context_line":"    #                    Required"},{"line_number":19,"context_line":"    # \"file_names\" - list, names of the files to monitor. Required"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    # Check the size of all the files under directory_1"},{"line_number":22,"context_line":"#    -  built_by: Logging"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"7a5de9d1_1c0e863b","line":19,"range":{"start_line":19,"start_character":21,"end_line":19,"end_character":25},"updated":"2016-01-28 23:46:50.000000000","message":"list of strings","commit_id":"3fcbc3dff5853591317441f834de9164954c1f83"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"57768511d47129cdf9d01ed5c9496fe961ae8694","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    #"},{"line_number":9,"context_line":"    # NOTE: This check is NOT currently supported on Windows systems"},{"line_number":10,"context_line":"    #"},{"line_number":11,"context_line":"    # For each instance, both parameters \u0027file_directory\u0027 and \u0027file_names\u0027 are"},{"line_number":12,"context_line":"    # required"},{"line_number":13,"context_line":"    #"},{"line_number":14,"context_line":"    # WARNING: Ensure the user account running the Agent (typically mon-agent)"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"7a5de9d1_43a65211","line":11,"range":{"start_line":11,"start_character":15,"end_line":11,"end_character":23},"updated":"2016-01-29 03:59:45.000000000","message":"Sorry to be pick on names, but I\u0027m wondering if it would be better to call the parameter file_directory, directory_name, instead?","commit_id":"dc58f8ccdaed58c8db1aa7d18f1988e5208cb79f"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"a130faa167b69245e009bf195fb2122ee44a3f2a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    #"},{"line_number":9,"context_line":"    # NOTE: This check is NOT currently supported on Windows systems"},{"line_number":10,"context_line":"    #"},{"line_number":11,"context_line":"    # For each instance, both parameters \u0027file_directory\u0027 and \u0027file_names\u0027 are"},{"line_number":12,"context_line":"    # required"},{"line_number":13,"context_line":"    #"},{"line_number":14,"context_line":"    # WARNING: Ensure the user account running the Agent (typically mon-agent)"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"7a5de9d1_c34a42c5","line":11,"range":{"start_line":11,"start_character":15,"end_line":11,"end_character":23},"in_reply_to":"7a5de9d1_43a65211","updated":"2016-01-29 04:15:45.000000000","message":"Hmm do you think just call it directory will be better? I just feel that \"name\" is a little confusing with the \"file_names\"","commit_id":"dc58f8ccdaed58c8db1aa7d18f1988e5208cb79f"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"643b78b92b516af83ffe368dba5d191e10d7168c","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    #"},{"line_number":9,"context_line":"    # NOTE: This check is NOT currently supported on Windows systems"},{"line_number":10,"context_line":"    #"},{"line_number":11,"context_line":"    # For each instance, both parameters \u0027file_directory\u0027 and \u0027file_names\u0027 are"},{"line_number":12,"context_line":"    # required"},{"line_number":13,"context_line":"    #"},{"line_number":14,"context_line":"    # WARNING: Ensure the user account running the Agent (typically mon-agent)"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"7a5de9d1_647a5879","line":11,"range":{"start_line":11,"start_character":15,"end_line":11,"end_character":23},"in_reply_to":"7a5de9d1_b4e65eb2","updated":"2016-01-29 16:04:36.000000000","message":"Sounds good! Thank you Michael and Roland!","commit_id":"dc58f8ccdaed58c8db1aa7d18f1988e5208cb79f"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"e1aa153b6446d6e4dece7a168dd19ff7da286969","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    #"},{"line_number":9,"context_line":"    # NOTE: This check is NOT currently supported on Windows systems"},{"line_number":10,"context_line":"    #"},{"line_number":11,"context_line":"    # For each instance, both parameters \u0027file_directory\u0027 and \u0027file_names\u0027 are"},{"line_number":12,"context_line":"    # required"},{"line_number":13,"context_line":"    #"},{"line_number":14,"context_line":"    # WARNING: Ensure the user account running the Agent (typically mon-agent)"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"7a5de9d1_b4e65eb2","line":11,"range":{"start_line":11,"start_character":15,"end_line":11,"end_character":23},"in_reply_to":"7a5de9d1_c34a42c5","updated":"2016-01-29 06:31:13.000000000","message":"im with Roland on this I like directory_name as that follows what you did with file_names. If you did files, directory might make sense but still like the name on both of them","commit_id":"dc58f8ccdaed58c8db1aa7d18f1988e5208cb79f"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"d8dc8913754fe7b644439f33dfb1c6720562f1d1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    # \"directory_name\" - string, the directory of the files to monitor."},{"line_number":19,"context_line":"    #                    Required"},{"line_number":20,"context_line":"    # \"file_names\" - list of strings, names of the files to monitor. Required"},{"line_number":21,"context_line":"    # \"recursive\" - boolean, when true the stats will recurse into directories."},{"line_number":22,"context_line":"    #               Default False"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    # Check the size of all the files under directory_1"},{"line_number":25,"context_line":"#    -  built_by: Logging"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"5a5ae5dd_599a976f","line":22,"range":{"start_line":21,"start_character":20,"end_line":22,"end_character":33},"updated":"2016-02-05 18:43:04.000000000","message":"When true and file_name is set to * will recursively grab files under the given directory to gather stats on.","commit_id":"8d93f1d8f2f13bec798833e80e40c4bfb8a2b873"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"d8dc8913754fe7b644439f33dfb1c6720562f1d1","unresolved":false,"context_lines":[{"line_number":41,"context_line":"#       file_names:"},{"line_number":42,"context_line":"#       -file_name31"},{"line_number":43,"context_line":"#       -file_name32"},{"line_number":44,"context_line":"#       recursive: True"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"5a5ae5dd_c2b207e5","line":44,"range":{"start_line":44,"start_character":19,"end_line":44,"end_character":23},"updated":"2016-02-05 18:43:04.000000000","message":"this is deceiving as you dont do anything with recursive here and you never tell the end user you are not doing anything. You just grab the stats on the give files","commit_id":"8d93f1d8f2f13bec798833e80e40c4bfb8a2b873"}],"monasca_agent/collector/checks_d/file_size.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"07c6c135581b7b032d7488ae693a3b49c576828f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        abs_directory \u003d abspath(file_directory)"},{"line_number":48,"context_line":"        if not exists(abs_directory):"},{"line_number":49,"context_line":"            log.error(\u0027FileCheck: the file directory ({0}) does not exist\u0027."},{"line_number":50,"context_line":"                      format(abs_directory))"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if \"file_name\" in instance and instance[\"file_name\"] !\u003d \"*\":"},{"line_number":53,"context_line":"            file_name \u003d instance[\"file_name\"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_3cbd9e68","line":50,"range":{"start_line":50,"start_character":22,"end_line":50,"end_character":28},"updated":"2016-01-19 21:20:27.000000000","message":"Same here you go on even with logging an error.","commit_id":"8d3cdb5a91beca64a50a0e573e475ec11ad22239"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"07c6c135581b7b032d7488ae693a3b49c576828f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            file_name \u003d instance[\"file_name\"]"},{"line_number":54,"context_line":"            abs_name \u003d abspath(file_directory + \"/\" + file_name)"},{"line_number":55,"context_line":"            if not isfile(abs_name):"},{"line_number":56,"context_line":"                log.error(\u0027FileCheck: the file ({0}) does not exist\u0027."},{"line_number":57,"context_line":"                          format(abs_name))"},{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            file_name \u003d instance.get(\"file_name\") or \"*\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_bc8aeebd","line":56,"range":{"start_line":56,"start_character":27,"end_line":56,"end_character":36},"updated":"2016-01-19 21:20:27.000000000","message":"you log an error here but go on with the get stats is that what you are looking for?","commit_id":"8d3cdb5a91beca64a50a0e573e475ec11ad22239"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"05780b18c9f577c5febdf642594dd31958fe889a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            file_name \u003d instance[\"file_name\"]"},{"line_number":54,"context_line":"            abs_name \u003d abspath(file_directory + \"/\" + file_name)"},{"line_number":55,"context_line":"            if not isfile(abs_name):"},{"line_number":56,"context_line":"                log.error(\u0027FileCheck: the file ({0}) does not exist\u0027."},{"line_number":57,"context_line":"                          format(abs_name))"},{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            file_name \u003d instance.get(\"file_name\") or \"*\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_32ddf242","line":56,"range":{"start_line":56,"start_character":27,"end_line":56,"end_character":36},"in_reply_to":"ba63e191_bc8aeebd","updated":"2016-01-20 22:37:14.000000000","message":"Nope sorry this is a mistake!","commit_id":"8d3cdb5a91beca64a50a0e573e475ec11ad22239"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"07c6c135581b7b032d7488ae693a3b49c576828f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                log.error(\u0027FileCheck: the file ({0}) does not exist\u0027."},{"line_number":57,"context_line":"                          format(abs_name))"},{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            file_name \u003d instance.get(\"file_name\") or \"*\""},{"line_number":60,"context_line":"            abs_name \u003d abspath(file_directory + \"/\" + file_name)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        dimensions \u003d self._set_dimensions({\"name\": abs_name}, instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_bcdc2ee5","line":59,"range":{"start_line":59,"start_character":53,"end_line":59,"end_character":56},"updated":"2016-01-19 21:20:27.000000000","message":"you can just set it to * here as the only way it would get here is if file_name is * or not set.","commit_id":"8d3cdb5a91beca64a50a0e573e475ec11ad22239"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"05780b18c9f577c5febdf642594dd31958fe889a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                log.error(\u0027FileCheck: the file ({0}) does not exist\u0027."},{"line_number":57,"context_line":"                          format(abs_name))"},{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            file_name \u003d instance.get(\"file_name\") or \"*\""},{"line_number":60,"context_line":"            abs_name \u003d abspath(file_directory + \"/\" + file_name)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        dimensions \u003d self._set_dimensions({\"name\": abs_name}, instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_d217b6eb","line":59,"range":{"start_line":59,"start_character":53,"end_line":59,"end_character":56},"in_reply_to":"ba63e191_bcdc2ee5","updated":"2016-01-20 22:37:14.000000000","message":"Yes!","commit_id":"8d3cdb5a91beca64a50a0e573e475ec11ad22239"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"07c6c135581b7b032d7488ae693a3b49c576828f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            file_name \u003d instance.get(\"file_name\") or \"*\""},{"line_number":60,"context_line":"            abs_name \u003d abspath(file_directory + \"/\" + file_name)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        dimensions \u003d self._set_dimensions({\"name\": abs_name}, instance)"},{"line_number":63,"context_line":"        self._get_stats(abs_directory, file_name, dimensions)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _get_stats(self, directory, name, dimensions):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_7cab161e","line":62,"range":{"start_line":62,"start_character":44,"end_line":62,"end_character":48},"updated":"2016-01-19 21:20:27.000000000","message":"should we use file name instead of name? Also these could be long names and be confusing i wonder if we put the directory as another dimension and the file name as one. What do you think? Also shouldnt this only be in the conditional where the file name is set since below you set this again in the loop where it is *. Just a little confusing. Maybe put this in the _get_stats method as well","commit_id":"8d3cdb5a91beca64a50a0e573e475ec11ad22239"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"05780b18c9f577c5febdf642594dd31958fe889a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            file_name \u003d instance.get(\"file_name\") or \"*\""},{"line_number":60,"context_line":"            abs_name \u003d abspath(file_directory + \"/\" + file_name)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        dimensions \u003d self._set_dimensions({\"name\": abs_name}, instance)"},{"line_number":63,"context_line":"        self._get_stats(abs_directory, file_name, dimensions)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _get_stats(self, directory, name, dimensions):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_521426f4","line":62,"range":{"start_line":62,"start_character":44,"end_line":62,"end_character":48},"in_reply_to":"ba63e191_5ba08390","updated":"2016-01-20 22:37:14.000000000","message":"Yes I agree! This looks better! Thank you Tomasz!","commit_id":"8d3cdb5a91beca64a50a0e573e475ec11ad22239"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"5455db4e4734fb53a39eb8c4b3ed0d90013747c8","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            file_name \u003d instance.get(\"file_name\") or \"*\""},{"line_number":60,"context_line":"            abs_name \u003d abspath(file_directory + \"/\" + file_name)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        dimensions \u003d self._set_dimensions({\"name\": abs_name}, instance)"},{"line_number":63,"context_line":"        self._get_stats(abs_directory, file_name, dimensions)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _get_stats(self, directory, name, dimensions):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_5ba08390","line":62,"range":{"start_line":62,"start_character":44,"end_line":62,"end_character":48},"in_reply_to":"ba63e191_7cab161e","updated":"2016-01-20 06:54:13.000000000","message":"I like the idea of file name and directory combined into dimensions, meaning to say:\n\n fileName: \u0027some_file\u0027,\n directory: \u0027/var/dir/some/where\u0027","commit_id":"8d3cdb5a91beca64a50a0e573e475ec11ad22239"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"05780b18c9f577c5febdf642594dd31958fe889a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            file_name \u003d instance.get(\"file_name\") or \"*\""},{"line_number":60,"context_line":"            abs_name \u003d abspath(file_directory + \"/\" + file_name)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        dimensions \u003d self._set_dimensions({\"name\": abs_name}, instance)"},{"line_number":63,"context_line":"        self._get_stats(abs_directory, file_name, dimensions)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _get_stats(self, directory, name, dimensions):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_92a61ec0","line":62,"range":{"start_line":62,"start_character":44,"end_line":62,"end_character":48},"in_reply_to":"ba63e191_7cab161e","updated":"2016-01-20 22:37:14.000000000","message":"Yep I made some changes and will post it in patch2. Thanks Michael!","commit_id":"8d3cdb5a91beca64a50a0e573e475ec11ad22239"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"07c6c135581b7b032d7488ae693a3b49c576828f","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _get_stats(self, directory, name, dimensions):"},{"line_number":66,"context_line":"        if name !\u003d \"*\":"},{"line_number":67,"context_line":"            file_directory_name \u003d join(directory, name)"},{"line_number":68,"context_line":"            try:"},{"line_number":69,"context_line":"                file_stat \u003d stat(file_directory_name)"},{"line_number":70,"context_line":"            except OSError as ose:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_a2cac89f","line":67,"range":{"start_line":67,"start_character":12,"end_line":67,"end_character":31},"updated":"2016-01-19 21:20:27.000000000","message":"isnt this just the file_absolute_path","commit_id":"8d3cdb5a91beca64a50a0e573e475ec11ad22239"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"07c6c135581b7b032d7488ae693a3b49c576828f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            try:"},{"line_number":69,"context_line":"                file_stat \u003d stat(file_directory_name)"},{"line_number":70,"context_line":"            except OSError as ose:"},{"line_number":71,"context_line":"                log.warn(\"DirectoryCheck: could not stat file %s - %s\" % ("},{"line_number":72,"context_line":"                    file_directory_name, ose))"},{"line_number":73,"context_line":"            else:"},{"line_number":74,"context_line":"                file_bytes \u003d file_stat.st_size"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_0230749d","line":71,"range":{"start_line":71,"start_character":26,"end_line":71,"end_character":40},"updated":"2016-01-19 21:20:27.000000000","message":"File Check","commit_id":"8d3cdb5a91beca64a50a0e573e475ec11ad22239"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"05780b18c9f577c5febdf642594dd31958fe889a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            try:"},{"line_number":69,"context_line":"                file_stat \u003d stat(file_directory_name)"},{"line_number":70,"context_line":"            except OSError as ose:"},{"line_number":71,"context_line":"                log.warn(\"DirectoryCheck: could not stat file %s - %s\" % ("},{"line_number":72,"context_line":"                    file_directory_name, ose))"},{"line_number":73,"context_line":"            else:"},{"line_number":74,"context_line":"                file_bytes \u003d file_stat.st_size"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_32abb28b","line":71,"range":{"start_line":71,"start_character":26,"end_line":71,"end_character":40},"in_reply_to":"ba63e191_0230749d","updated":"2016-01-20 22:37:14.000000000","message":"Done","commit_id":"8d3cdb5a91beca64a50a0e573e475ec11ad22239"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"07c6c135581b7b032d7488ae693a3b49c576828f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                file_bytes \u003d file_stat.st_size"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"            # Create the gauge"},{"line_number":77,"context_line":"            self.gauge(\"system.disk.directory.file.bytes\", file_bytes,"},{"line_number":78,"context_line":"                       dimensions\u003ddimensions)"},{"line_number":79,"context_line":"        else:"},{"line_number":80,"context_line":"            num_files \u003d 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_0251540e","line":77,"range":{"start_line":77,"start_character":36,"end_line":77,"end_character":45},"updated":"2016-01-19 21:20:27.000000000","message":"i would take out directory as you are doing file checks","commit_id":"8d3cdb5a91beca64a50a0e573e475ec11ad22239"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"05780b18c9f577c5febdf642594dd31958fe889a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                file_bytes \u003d file_stat.st_size"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"            # Create the gauge"},{"line_number":77,"context_line":"            self.gauge(\"system.disk.directory.file.bytes\", file_bytes,"},{"line_number":78,"context_line":"                       dimensions\u003ddimensions)"},{"line_number":79,"context_line":"        else:"},{"line_number":80,"context_line":"            num_files \u003d 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_d29c966b","line":77,"range":{"start_line":77,"start_character":36,"end_line":77,"end_character":45},"in_reply_to":"ba63e191_0251540e","updated":"2016-01-20 22:37:14.000000000","message":"sounds good","commit_id":"8d3cdb5a91beca64a50a0e573e475ec11ad22239"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"07c6c135581b7b032d7488ae693a3b49c576828f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            num_files \u003d 0"},{"line_number":81,"context_line":"            for root, dirs, files in walk(directory):"},{"line_number":82,"context_line":"                for filename in files:"},{"line_number":83,"context_line":"                    filename \u003d join(root, filename)"},{"line_number":84,"context_line":"                    try:"},{"line_number":85,"context_line":"                        file_stat \u003d stat(filename)"},{"line_number":86,"context_line":"                    except OSError as ose:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_82e30405","line":83,"range":{"start_line":83,"start_character":20,"end_line":83,"end_character":28},"updated":"2016-01-19 21:20:27.000000000","message":"maybe use file_absolute_path here as well not filename which is the same name as the iterator variable","commit_id":"8d3cdb5a91beca64a50a0e573e475ec11ad22239"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"07c6c135581b7b032d7488ae693a3b49c576828f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                    try:"},{"line_number":85,"context_line":"                        file_stat \u003d stat(filename)"},{"line_number":86,"context_line":"                    except OSError as ose:"},{"line_number":87,"context_line":"                        log.warn(\"DirectoryCheck: could not stat file %s - \""},{"line_number":88,"context_line":"                                 \"%s\" % (filename, ose))"},{"line_number":89,"context_line":"                    else:"},{"line_number":90,"context_line":"                        file_bytes \u003d file_stat.st_size"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_42166cf2","line":87,"range":{"start_line":87,"start_character":34,"end_line":87,"end_character":48},"updated":"2016-01-19 21:20:27.000000000","message":"File Check","commit_id":"8d3cdb5a91beca64a50a0e573e475ec11ad22239"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"07c6c135581b7b032d7488ae693a3b49c576828f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                                 \"%s\" % (filename, ose))"},{"line_number":89,"context_line":"                    else:"},{"line_number":90,"context_line":"                        file_bytes \u003d file_stat.st_size"},{"line_number":91,"context_line":"                        dimensions \u003d self._set_dimensions({\"name\": filename})"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"                        # Create the gauge"},{"line_number":94,"context_line":"                        self.gauge(\"system.disk.directory.file.bytes\","}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_826ea494","line":91,"range":{"start_line":91,"start_character":57,"end_line":91,"end_character":60},"updated":"2016-01-19 21:20:27.000000000","message":"see above on the dimensions","commit_id":"8d3cdb5a91beca64a50a0e573e475ec11ad22239"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"07c6c135581b7b032d7488ae693a3b49c576828f","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                        dimensions \u003d self._set_dimensions({\"name\": filename})"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"                        # Create the gauge"},{"line_number":94,"context_line":"                        self.gauge(\"system.disk.directory.file.bytes\","},{"line_number":95,"context_line":"                                   file_bytes, dimensions\u003ddimensions)"},{"line_number":96,"context_line":"                        num_files +\u003d 1"},{"line_number":97,"context_line":"            log.debug(\u0027Collected {0} file_size metrics\u0027.format(num_files))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_6221304d","line":94,"range":{"start_line":94,"start_character":36,"end_line":94,"end_character":42},"updated":"2016-01-19 21:20:27.000000000","message":"see above with name","commit_id":"8d3cdb5a91beca64a50a0e573e475ec11ad22239"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"07c6c135581b7b032d7488ae693a3b49c576828f","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                        self.gauge(\"system.disk.directory.file.bytes\","},{"line_number":95,"context_line":"                                   file_bytes, dimensions\u003ddimensions)"},{"line_number":96,"context_line":"                        num_files +\u003d 1"},{"line_number":97,"context_line":"            log.debug(\u0027Collected {0} file_size metrics\u0027.format(num_files))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_a27c0873","line":97,"range":{"start_line":97,"start_character":63,"end_line":97,"end_character":72},"updated":"2016-01-19 21:20:27.000000000","message":"put from which directory here else the debug message wont make sense","commit_id":"8d3cdb5a91beca64a50a0e573e475ec11ad22239"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"05780b18c9f577c5febdf642594dd31958fe889a","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                        self.gauge(\"system.disk.directory.file.bytes\","},{"line_number":95,"context_line":"                                   file_bytes, dimensions\u003ddimensions)"},{"line_number":96,"context_line":"                        num_files +\u003d 1"},{"line_number":97,"context_line":"            log.debug(\u0027Collected {0} file_size metrics\u0027.format(num_files))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_ddbb470d","line":97,"range":{"start_line":97,"start_character":63,"end_line":97,"end_character":72},"in_reply_to":"ba63e191_a27c0873","updated":"2016-01-20 22:37:14.000000000","message":"Yes definitely.","commit_id":"8d3cdb5a91beca64a50a0e573e475ec11ad22239"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"76376dfcadadb6ae4dba05648c5e79bba04408f1","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class FileSizeCheck(checks.AgentCheck):"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    \"\"\"This check is for monitoring and reporting metrics on the size of the"},{"line_number":19,"context_line":"    files for a provided directory"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    Config options:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_a99e5d61","line":18,"range":{"start_line":18,"start_character":73,"end_line":18,"end_character":76},"updated":"2016-01-26 17:10:44.000000000","message":"take out the","commit_id":"1c524961235db7e401b6abe4a65f4378678665b5"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"76376dfcadadb6ae4dba05648c5e79bba04408f1","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    Config options:"},{"line_number":22,"context_line":"        \"file_directory\" - string, directory of the file (required)"},{"line_number":23,"context_line":"        \"file_name\" - string, the filename under file_directory to gather"},{"line_number":24,"context_line":"        stats for (defaults \"*\")"},{"line_number":25,"context_line":"    \"\"\""},{"line_number":26,"context_line":"    def __init__(self, name, init_config, agent_config, instances\u003dNone):"},{"line_number":27,"context_line":"        super(FileSizeCheck, self).__init__(name, init_config, agent_config,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_4986c114","line":24,"range":{"start_line":23,"start_character":8,"end_line":24,"end_character":32},"updated":"2016-01-26 17:10:44.000000000","message":"this is a list right? not just one string? Also it is files_names","commit_id":"1c524961235db7e401b6abe4a65f4378678665b5"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"f12a87d8edc0ae717cf9dfe85f7344e3e900364a","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    Config options:"},{"line_number":22,"context_line":"        \"file_directory\" - string, directory of the file (required)"},{"line_number":23,"context_line":"        \"file_name\" - string, the filename under file_directory to gather"},{"line_number":24,"context_line":"        stats for (defaults \"*\")"},{"line_number":25,"context_line":"    \"\"\""},{"line_number":26,"context_line":"    def __init__(self, name, init_config, agent_config, instances\u003dNone):"},{"line_number":27,"context_line":"        super(FileSizeCheck, self).__init__(name, init_config, agent_config,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_2f86e813","line":24,"range":{"start_line":23,"start_character":8,"end_line":24,"end_character":32},"in_reply_to":"9a68dd71_4986c114","updated":"2016-01-26 20:09:02.000000000","message":"Done","commit_id":"1c524961235db7e401b6abe4a65f4378678665b5"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"76376dfcadadb6ae4dba05648c5e79bba04408f1","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                                        dimensions)"},{"line_number":48,"context_line":"                        num_files +\u003d 1"},{"line_number":49,"context_line":"                    else:"},{"line_number":50,"context_line":"                        log.error(\u0027FileSizeCheck: the file ({0}) does not exist\u0027."},{"line_number":51,"context_line":"                                  format(abs_name))"},{"line_number":52,"context_line":"                log.debug(\u0027Collected #{0} file_size metrics from {1}\u0027."},{"line_number":53,"context_line":"                          format(num_files, abs_directory))"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_a9a97d26","line":50,"range":{"start_line":50,"start_character":62,"end_line":50,"end_character":64},"updated":"2016-01-26 17:10:44.000000000","message":"take out parenthesis","commit_id":"1c524961235db7e401b6abe4a65f4378678665b5"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"76376dfcadadb6ae4dba05648c5e79bba04408f1","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                    else:"},{"line_number":50,"context_line":"                        log.error(\u0027FileSizeCheck: the file ({0}) does not exist\u0027."},{"line_number":51,"context_line":"                                  format(abs_name))"},{"line_number":52,"context_line":"                log.debug(\u0027Collected #{0} file_size metrics from {1}\u0027."},{"line_number":53,"context_line":"                          format(num_files, abs_directory))"},{"line_number":54,"context_line":"            else:"},{"line_number":55,"context_line":"                num_files \u003d 0"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_29b58d7d","line":52,"range":{"start_line":52,"start_character":37,"end_line":52,"end_character":39},"updated":"2016-01-26 17:10:44.000000000","message":"take out #","commit_id":"1c524961235db7e401b6abe4a65f4378678665b5"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"76376dfcadadb6ae4dba05648c5e79bba04408f1","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                log.debug(\u0027Collected {0} file_size metrics from {1}\u0027.format("},{"line_number":64,"context_line":"                    num_files, abs_directory))"},{"line_number":65,"context_line":"        else:"},{"line_number":66,"context_line":"            log.error(\u0027FileSizeCheck: the file directory ({0}) does not exist\u0027."},{"line_number":67,"context_line":"                      format(abs_directory))"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _get_stats(self, directory, name, dimensions):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_89e119d3","line":66,"range":{"start_line":66,"start_character":60,"end_line":66,"end_character":62},"updated":"2016-01-26 17:10:44.000000000","message":"take out parenthesis","commit_id":"1c524961235db7e401b6abe4a65f4378678665b5"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"76376dfcadadb6ae4dba05648c5e79bba04408f1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            file_stat \u003d stat(file_directory_name)"},{"line_number":73,"context_line":"        except OSError as ose:"},{"line_number":74,"context_line":"            log.warn(\"FileSizeCheck: could not stat file %s - %s\" % ("},{"line_number":75,"context_line":"                file_directory_name, ose))"},{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            file_bytes \u003d file_stat.st_size"},{"line_number":78,"context_line":"        self.gauge(\"system.disk.file.bytes\", file_bytes, dimensions\u003ddimensions)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_2c403b07","line":75,"range":{"start_line":75,"start_character":16,"end_line":75,"end_character":35},"updated":"2016-01-26 17:10:44.000000000","message":"if it hits this do you just log a warn message and continue on to the self gauge. If so that is not what you want and will cause bad behavior. Also it will up the counter you have in the method above even though you shouldnt be counting this in your collected metrics counter.","commit_id":"1c524961235db7e401b6abe4a65f4378678665b5"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"f12a87d8edc0ae717cf9dfe85f7344e3e900364a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            file_stat \u003d stat(file_directory_name)"},{"line_number":73,"context_line":"        except OSError as ose:"},{"line_number":74,"context_line":"            log.warn(\"FileSizeCheck: could not stat file %s - %s\" % ("},{"line_number":75,"context_line":"                file_directory_name, ose))"},{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            file_bytes \u003d file_stat.st_size"},{"line_number":78,"context_line":"        self.gauge(\"system.disk.file.bytes\", file_bytes, dimensions\u003ddimensions)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_25a36951","line":75,"range":{"start_line":75,"start_character":16,"end_line":75,"end_character":35},"in_reply_to":"9a68dd71_2c403b07","updated":"2016-01-26 20:09:02.000000000","message":"Good catch! This is not what I want. Will make the change in next patch.","commit_id":"1c524961235db7e401b6abe4a65f4378678665b5"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"a03c06959b1f9a1bb5f949c38c041a80722327df","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                    else:"},{"line_number":49,"context_line":"                        log.error(\u0027FileSizeCheck: file {0} does not exist\u0027."},{"line_number":50,"context_line":"                                  format(abs_name))"},{"line_number":51,"context_line":"                log.debug(\u0027Collected #{0} file_size metrics from {1}\u0027."},{"line_number":52,"context_line":"                          format(num_files, abs_directory))"},{"line_number":53,"context_line":"            else:"},{"line_number":54,"context_line":"                for root, dirs, files in walk(abs_directory):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_f8e40fad","line":51,"range":{"start_line":51,"start_character":37,"end_line":51,"end_character":39},"updated":"2016-01-26 22:58:04.000000000","message":"take out the #!","commit_id":"87a29397e6f43ea3b0785c2b50f19847b1afecb6"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"dbec54247cbf2eb349ca3f09f3cfa45320db64c8","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                    else:"},{"line_number":49,"context_line":"                        log.error(\u0027FileSizeCheck: file {0} does not exist\u0027."},{"line_number":50,"context_line":"                                  format(abs_name))"},{"line_number":51,"context_line":"                log.debug(\u0027Collected #{0} file_size metrics from {1}\u0027."},{"line_number":52,"context_line":"                          format(num_files, abs_directory))"},{"line_number":53,"context_line":"            else:"},{"line_number":54,"context_line":"                for root, dirs, files in walk(abs_directory):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_1be47d39","line":51,"range":{"start_line":51,"start_character":37,"end_line":51,"end_character":39},"in_reply_to":"9a68dd71_f8e40fad","updated":"2016-01-26 23:08:55.000000000","message":"Sorry missed it again...","commit_id":"87a29397e6f43ea3b0785c2b50f19847b1afecb6"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"a03c06959b1f9a1bb5f949c38c041a80722327df","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                log.debug(\u0027Collected {0} file_size metrics from {1}\u0027.format("},{"line_number":62,"context_line":"                    num_files, abs_directory))"},{"line_number":63,"context_line":"        else:"},{"line_number":64,"context_line":"            log.error(\u0027FileSizeCheck: file directory {0} does not exist\u0027."},{"line_number":65,"context_line":"                      format(abs_directory))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _get_stats(self, directory, name, dimensions, num_files):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_58743bce","line":64,"range":{"start_line":64,"start_character":38,"end_line":64,"end_character":42},"updated":"2016-01-26 22:58:04.000000000","message":"take out file","commit_id":"87a29397e6f43ea3b0785c2b50f19847b1afecb6"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"dbec54247cbf2eb349ca3f09f3cfa45320db64c8","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                log.debug(\u0027Collected {0} file_size metrics from {1}\u0027.format("},{"line_number":62,"context_line":"                    num_files, abs_directory))"},{"line_number":63,"context_line":"        else:"},{"line_number":64,"context_line":"            log.error(\u0027FileSizeCheck: file directory {0} does not exist\u0027."},{"line_number":65,"context_line":"                      format(abs_directory))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _get_stats(self, directory, name, dimensions, num_files):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_fbe64943","line":64,"range":{"start_line":64,"start_character":38,"end_line":64,"end_character":42},"in_reply_to":"9a68dd71_58743bce","updated":"2016-01-26 23:08:55.000000000","message":"Done","commit_id":"87a29397e6f43ea3b0785c2b50f19847b1afecb6"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"a03c06959b1f9a1bb5f949c38c041a80722327df","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            log.error(\u0027FileSizeCheck: file directory {0} does not exist\u0027."},{"line_number":65,"context_line":"                      format(abs_directory))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _get_stats(self, directory, name, dimensions, num_files):"},{"line_number":68,"context_line":"        file_directory_name \u003d join(directory, name)"},{"line_number":69,"context_line":"        try:"},{"line_number":70,"context_line":"            file_stat \u003d stat(file_directory_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_d867cb23","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":18},"updated":"2016-01-26 22:58:04.000000000","message":"could be better to pass back true or false if this succeeded and then up the counter then instead of passing num_files here. You could also just pass back file_bytes and then you dont have to pass in dimensions and num_files. What do you think?","commit_id":"87a29397e6f43ea3b0785c2b50f19847b1afecb6"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"dbec54247cbf2eb349ca3f09f3cfa45320db64c8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            log.error(\u0027FileSizeCheck: file directory {0} does not exist\u0027."},{"line_number":65,"context_line":"                      format(abs_directory))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _get_stats(self, directory, name, dimensions, num_files):"},{"line_number":68,"context_line":"        file_directory_name \u003d join(directory, name)"},{"line_number":69,"context_line":"        try:"},{"line_number":70,"context_line":"            file_stat \u003d stat(file_directory_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_fb6ba983","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":18},"in_reply_to":"9a68dd71_d867cb23","updated":"2016-01-26 23:08:55.000000000","message":"I like to pass back true or false better. I will make the change in next patch. Thanks.","commit_id":"87a29397e6f43ea3b0785c2b50f19847b1afecb6"},{"author":{"_account_id":15799,"name":"Ben Motz","email":"ben.launchpad@ouat.co.uk","username":"bmotz"},"change_message_id":"d91ca2208c6c8b006ed8772ef8dcd8c83626859f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            if \"file_names\" in instance and instance[\"file_names\"] !\u003d [\u0027*\u0027]:"},{"line_number":40,"context_line":"                file_names \u003d instance[\"file_names\"]"},{"line_number":41,"context_line":"                for file_name in file_names:"},{"line_number":42,"context_line":"                    abs_name \u003d abspath(file_directory + \"/\" + file_name)"},{"line_number":43,"context_line":"                    if isfile(abs_name):"},{"line_number":44,"context_line":"                        dimensions \u003d self._set_dimensions({"},{"line_number":45,"context_line":"                            \"file_name\": file_name,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_b8a68cbf","line":42,"updated":"2016-01-28 10:15:23.000000000","message":"should use os.path.join","commit_id":"bd04c1da0446682f921e281237de820440c8b77c"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"2a268330ef0a74246239e2122f5431a5d6fafa4e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                for file_name in file_names:"},{"line_number":42,"context_line":"                    abs_name \u003d abspath(file_directory + \"/\" + file_name)"},{"line_number":43,"context_line":"                    if isfile(abs_name):"},{"line_number":44,"context_line":"                        dimensions \u003d self._set_dimensions({"},{"line_number":45,"context_line":"                            \"file_name\": file_name,"},{"line_number":46,"context_line":"                            \"directory\": file_directory}, instance)"},{"line_number":47,"context_line":"                        got_stats \u003d self._get_stats(abs_directory, file_name,"},{"line_number":48,"context_line":"                                                    dimensions)"},{"line_number":49,"context_line":"                        if got_stats:"},{"line_number":50,"context_line":"                            num_files +\u003d 1"},{"line_number":51,"context_line":"                    else:"},{"line_number":52,"context_line":"                        log.error(\u0027FileSize Check: file {0} does not exist\u0027."},{"line_number":53,"context_line":"                                  format(abs_name))"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_c5c12d30","line":50,"range":{"start_line":44,"start_character":0,"end_line":50,"end_character":42},"updated":"2016-01-28 01:18:56.000000000","message":"This code is duplicated below. You should move it into a method","commit_id":"bd04c1da0446682f921e281237de820440c8b77c"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"1b3924411a899e6d27f04f3919da7b3afee5fbec","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                for file_name in file_names:"},{"line_number":42,"context_line":"                    abs_name \u003d abspath(file_directory + \"/\" + file_name)"},{"line_number":43,"context_line":"                    if isfile(abs_name):"},{"line_number":44,"context_line":"                        dimensions \u003d self._set_dimensions({"},{"line_number":45,"context_line":"                            \"file_name\": file_name,"},{"line_number":46,"context_line":"                            \"directory\": file_directory}, instance)"},{"line_number":47,"context_line":"                        got_stats \u003d self._get_stats(abs_directory, file_name,"},{"line_number":48,"context_line":"                                                    dimensions)"},{"line_number":49,"context_line":"                        if got_stats:"},{"line_number":50,"context_line":"                            num_files +\u003d 1"},{"line_number":51,"context_line":"                    else:"},{"line_number":52,"context_line":"                        log.error(\u0027FileSize Check: file {0} does not exist\u0027."},{"line_number":53,"context_line":"                                  format(abs_name))"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_b638c23e","line":50,"range":{"start_line":44,"start_character":0,"end_line":50,"end_character":42},"in_reply_to":"7a5de9d1_c5c12d30","updated":"2016-01-28 19:59:39.000000000","message":"Done","commit_id":"bd04c1da0446682f921e281237de820440c8b77c"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"2a268330ef0a74246239e2122f5431a5d6fafa4e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                    else:"},{"line_number":52,"context_line":"                        log.error(\u0027FileSize Check: file {0} does not exist\u0027."},{"line_number":53,"context_line":"                                  format(abs_name))"},{"line_number":54,"context_line":"                log.debug(\u0027Collected {0} file_size metrics from {1}\u0027."},{"line_number":55,"context_line":"                          format(num_files, abs_directory))"},{"line_number":56,"context_line":"            else:"},{"line_number":57,"context_line":"                for root, dirs, files in walk(abs_directory):"},{"line_number":58,"context_line":"                    for file_name in files:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_45ec5dc7","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":59},"updated":"2016-01-28 01:18:56.000000000","message":"This statement is duplicated below. You should move it out of the if/else so it only exists once","commit_id":"bd04c1da0446682f921e281237de820440c8b77c"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"1b3924411a899e6d27f04f3919da7b3afee5fbec","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                    else:"},{"line_number":52,"context_line":"                        log.error(\u0027FileSize Check: file {0} does not exist\u0027."},{"line_number":53,"context_line":"                                  format(abs_name))"},{"line_number":54,"context_line":"                log.debug(\u0027Collected {0} file_size metrics from {1}\u0027."},{"line_number":55,"context_line":"                          format(num_files, abs_directory))"},{"line_number":56,"context_line":"            else:"},{"line_number":57,"context_line":"                for root, dirs, files in walk(abs_directory):"},{"line_number":58,"context_line":"                    for file_name in files:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_96358647","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":59},"in_reply_to":"7a5de9d1_45ec5dc7","updated":"2016-01-28 19:59:39.000000000","message":"Done","commit_id":"bd04c1da0446682f921e281237de820440c8b77c"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"2a268330ef0a74246239e2122f5431a5d6fafa4e","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                file_directory_name, ose))"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            file_bytes \u003d file_stat.st_size"},{"line_number":82,"context_line":"            self.gauge(\"system.disk.file.bytes\", file_bytes,"},{"line_number":83,"context_line":"                       dimensions\u003ddimensions)"},{"line_number":84,"context_line":"            got_stats \u003d True"},{"line_number":85,"context_line":"        return got_stats"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_c5efedae","line":82,"range":{"start_line":82,"start_character":31,"end_line":82,"end_character":46},"updated":"2016-01-28 01:18:56.000000000","message":"I believe this should be disk_file_bytes, please check with Roland","commit_id":"bd04c1da0446682f921e281237de820440c8b77c"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"ed08ba967217dbcc4af81e0d4d5a76f3eeacdad7","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                file_directory_name, ose))"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            file_bytes \u003d file_stat.st_size"},{"line_number":82,"context_line":"            self.gauge(\"system.disk.file.bytes\", file_bytes,"},{"line_number":83,"context_line":"                       dimensions\u003ddimensions)"},{"line_number":84,"context_line":"            got_stats \u003d True"},{"line_number":85,"context_line":"        return got_stats"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_951012aa","line":82,"range":{"start_line":82,"start_character":31,"end_line":82,"end_character":46},"in_reply_to":"7a5de9d1_95801248","updated":"2016-01-28 20:32:46.000000000","message":"file_size_bytes sounds good to me!","commit_id":"bd04c1da0446682f921e281237de820440c8b77c"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"1b3924411a899e6d27f04f3919da7b3afee5fbec","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                file_directory_name, ose))"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            file_bytes \u003d file_stat.st_size"},{"line_number":82,"context_line":"            self.gauge(\"system.disk.file.bytes\", file_bytes,"},{"line_number":83,"context_line":"                       dimensions\u003ddimensions)"},{"line_number":84,"context_line":"            got_stats \u003d True"},{"line_number":85,"context_line":"        return got_stats"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_d209c0de","line":82,"range":{"start_line":82,"start_character":31,"end_line":82,"end_character":46},"in_reply_to":"7a5de9d1_c5efedae","updated":"2016-01-28 19:59:39.000000000","message":"OK no problem! Thanks Craig!","commit_id":"bd04c1da0446682f921e281237de820440c8b77c"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"1ac66ac7660ee0537be86bef161cc3956618e0bc","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                file_directory_name, ose))"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            file_bytes \u003d file_stat.st_size"},{"line_number":82,"context_line":"            self.gauge(\"system.disk.file.bytes\", file_bytes,"},{"line_number":83,"context_line":"                       dimensions\u003ddimensions)"},{"line_number":84,"context_line":"            got_stats \u003d True"},{"line_number":85,"context_line":"        return got_stats"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_95801248","line":82,"range":{"start_line":82,"start_character":31,"end_line":82,"end_character":46},"in_reply_to":"7a5de9d1_d209c0de","updated":"2016-01-28 20:24:27.000000000","message":"How about file_size_bytes?\n\nThe metric name matches the name of the plugin.\n\nThe only other idea was to do something like\n\nfile_size.size_bytes\n\nwhich seems to be a bit verbose since there isn\u0027t a reason for grouping around \"file_size\".","commit_id":"bd04c1da0446682f921e281237de820440c8b77c"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"ec287fbdc460a4693f7bcb6420241db4de1c6d83","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    Config options:"},{"line_number":22,"context_line":"        \"file_directory\" - string, directory of the file (required)"},{"line_number":23,"context_line":"        \"file_names\" - list, file names under file_directory to gather stats"},{"line_number":24,"context_line":"                       for (required)"},{"line_number":25,"context_line":"    \"\"\""},{"line_number":26,"context_line":"    def __init__(self, name, init_config, agent_config, instances\u003dNone):"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_4f0afe22","line":23,"range":{"start_line":23,"start_character":23,"end_line":23,"end_character":27},"updated":"2016-01-28 23:46:50.000000000","message":"list of strings","commit_id":"3fcbc3dff5853591317441f834de9164954c1f83"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"33c7db71ef079218b63ea709d085b9ea16faafb6","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    Config options:"},{"line_number":22,"context_line":"        \"file_directory\" - string, directory of the file (required)"},{"line_number":23,"context_line":"        \"file_names\" - list, file names under file_directory to gather stats"},{"line_number":24,"context_line":"                       for (required)"},{"line_number":25,"context_line":"    \"\"\""},{"line_number":26,"context_line":"    def __init__(self, name, init_config, agent_config, instances\u003dNone):"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_cf77ce38","line":23,"range":{"start_line":23,"start_character":23,"end_line":23,"end_character":27},"in_reply_to":"7a5de9d1_4f0afe22","updated":"2016-01-29 00:09:02.000000000","message":"Done","commit_id":"3fcbc3dff5853591317441f834de9164954c1f83"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"ec287fbdc460a4693f7bcb6420241db4de1c6d83","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            \"file_name\": name,"},{"line_number":67,"context_line":"            \"directory\": directory}, instance)"},{"line_number":68,"context_line":"        got_stats \u003d False"},{"line_number":69,"context_line":"        file_directory_name \u003d join(directory, name)"},{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            file_stat \u003d stat(file_directory_name)"},{"line_number":72,"context_line":"        except OSError as ose:"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_cf634edb","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":27},"updated":"2016-01-28 23:46:50.000000000","message":"file_abs_path","commit_id":"3fcbc3dff5853591317441f834de9164954c1f83"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"33c7db71ef079218b63ea709d085b9ea16faafb6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            \"file_name\": name,"},{"line_number":67,"context_line":"            \"directory\": directory}, instance)"},{"line_number":68,"context_line":"        got_stats \u003d False"},{"line_number":69,"context_line":"        file_directory_name \u003d join(directory, name)"},{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            file_stat \u003d stat(file_directory_name)"},{"line_number":72,"context_line":"        except OSError as ose:"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_d23535da","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":27},"in_reply_to":"7a5de9d1_cf634edb","updated":"2016-01-29 00:09:02.000000000","message":"yep sounds better","commit_id":"3fcbc3dff5853591317441f834de9164954c1f83"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"d8dc8913754fe7b644439f33dfb1c6720562f1d1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        \"directory_name\" - string, directory of the file (required)"},{"line_number":25,"context_line":"        \"file_names\" - list of strings, file names under directory_name to"},{"line_number":26,"context_line":"                       gather stats for (required)"},{"line_number":27,"context_line":"        \"recursive\" - boolean, when true the stats will recurse into"},{"line_number":28,"context_line":"                      directories. Default False"},{"line_number":29,"context_line":"    \"\"\""},{"line_number":30,"context_line":"    def __init__(self, name, init_config, agent_config, instances\u003dNone):"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a5ae5dd_19965f3f","line":27,"range":{"start_line":27,"start_character":45,"end_line":27,"end_character":50},"updated":"2016-02-05 18:43:04.000000000","message":"change the description here as well","commit_id":"8d93f1d8f2f13bec798833e80e40c4bfb8a2b873"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"d8dc8913754fe7b644439f33dfb1c6720562f1d1","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        directory_name \u003d instance[\"directory_name\"]"},{"line_number":42,"context_line":"        abs_directory \u003d abspath(directory_name)"},{"line_number":43,"context_line":"        if exists(abs_directory):"},{"line_number":44,"context_line":"            if \"file_names\" in instance and instance[\"file_names\"] !\u003d [\u0027*\u0027]:"},{"line_number":45,"context_line":"                file_names \u003d instance[\"file_names\"]"},{"line_number":46,"context_line":"                self._get_stats(abs_directory, file_names, instance)"},{"line_number":47,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a5ae5dd_e22dc346","line":44,"range":{"start_line":44,"start_character":12,"end_line":44,"end_character":39},"updated":"2016-02-05 18:43:04.000000000","message":"can remove this since it is required now","commit_id":"8d93f1d8f2f13bec798833e80e40c4bfb8a2b873"}],"monasca_setup/detection/plugins/file_size.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"07c6c135581b7b032d7488ae693a3b49c576828f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        config \u003d monasca_setup.agent_config.Plugins()"},{"line_number":29,"context_line":"        log.info(\"\\tEnabling the file_size plugin\")"},{"line_number":30,"context_line":"        with open(os.path.join(self.template_dir,"},{"line_number":31,"context_line":"                               \u0027conf.d/file_size.yaml.example\u0027), \u0027r\u0027) as \\"},{"line_number":32,"context_line":"                file_template:"},{"line_number":33,"context_line":"            file_config \u003d yaml.load(file_template.read())"},{"line_number":34,"context_line":"        config[\u0027file\u0027] \u003d file_config"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_c586e6da","line":31,"range":{"start_line":31,"start_character":32,"end_line":31,"end_character":36},"updated":"2016-01-19 21:20:27.000000000","message":"we should not pull from a .example file. This detection plugin should use arguments to set up the yml file. We should also add a method to the utils class to set this up much like watch_process","commit_id":"8d3cdb5a91beca64a50a0e573e475ec11ad22239"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"ab00a31721346ad5791b3b6bc5526f833cc9c4d1","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        config \u003d monasca_setup.agent_config.Plugins()"},{"line_number":29,"context_line":"        log.info(\"\\tEnabling the file_size plugin\")"},{"line_number":30,"context_line":"        with open(os.path.join(self.template_dir,"},{"line_number":31,"context_line":"                               \u0027conf.d/file_size.yaml.example\u0027), \u0027r\u0027) as \\"},{"line_number":32,"context_line":"                file_template:"},{"line_number":33,"context_line":"            file_config \u003d yaml.load(file_template.read())"},{"line_number":34,"context_line":"        config[\u0027file\u0027] \u003d file_config"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_9d314fa5","line":31,"range":{"start_line":31,"start_character":32,"end_line":31,"end_character":36},"in_reply_to":"ba63e191_c586e6da","updated":"2016-01-20 22:38:09.000000000","message":"I\u0027m gonna make this change in patch 3. Thanks!","commit_id":"8d3cdb5a91beca64a50a0e573e475ec11ad22239"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"6cdb38d6b37617fee5dc81c7cb82f0489cc160ae","unresolved":false,"context_lines":[{"line_number":18,"context_line":"            \u0027template_dir\u0027: template_dir,"},{"line_number":19,"context_line":"            \u0027overwrite\u0027: overwrite,"},{"line_number":20,"context_line":"            \u0027service_name\u0027: \u0027file-size-service\u0027,"},{"line_number":21,"context_line":"            \u0027file_dirs_names\u0027: [],"},{"line_number":22,"context_line":"            \u0027search_pattern\u0027: \u0027\u0027}"},{"line_number":23,"context_line":"        super(FileSize, self).__init__(service_params)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a5de9d1_5ee5a7d9","line":21,"range":{"start_line":21,"start_character":13,"end_line":21,"end_character":28},"updated":"2016-01-29 18:19:05.000000000","message":"Hi Kaiyan, I hate to nit-pick, but you changed the name to directory_name in the config file, but then you didn\u0027t change the name in several other spots.\n\nI think it would be preferable to be consistent and use directory_name and directoy_names everywhere.","commit_id":"19c3423b63e44d8da4900b48e5de88a3b9a60de4"}],"monasca_setup/detection/plugins/logging.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"76376dfcadadb6ae4dba05648c5e79bba04408f1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"            \u0027overwrite\u0027: overwrite,"},{"line_number":17,"context_line":"            \u0027service_name\u0027: \u0027logging-service\u0027,"},{"line_number":18,"context_line":"            \u0027process_names\u0027: [\u0027logging\u0027],"},{"line_number":19,"context_line":"            \u0027file_dirs_names\u0027: [(\u0027/path/to/directory1\u0027, [\u0027file_name1\u0027]),"},{"line_number":20,"context_line":"                                (\u0027/path/to/directory2\u0027, [\u0027file_name21\u0027,"},{"line_number":21,"context_line":"                                                         \u0027file_name22\u0027]),"},{"line_number":22,"context_line":"                                (\u0027/path/to/directory3\u0027, [\u0027*\u0027])],"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_2cb59b7d","line":19,"range":{"start_line":19,"start_character":13,"end_line":19,"end_character":28},"updated":"2016-01-26 17:10:44.000000000","message":"not sure if i like file_dirs_names as this option\u0027s name","commit_id":"1c524961235db7e401b6abe4a65f4378678665b5"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"76376dfcadadb6ae4dba05648c5e79bba04408f1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"            \u0027process_names\u0027: [\u0027logging\u0027],"},{"line_number":19,"context_line":"            \u0027file_dirs_names\u0027: [(\u0027/path/to/directory1\u0027, [\u0027file_name1\u0027]),"},{"line_number":20,"context_line":"                                (\u0027/path/to/directory2\u0027, [\u0027file_name21\u0027,"},{"line_number":21,"context_line":"                                                         \u0027file_name22\u0027]),"},{"line_number":22,"context_line":"                                (\u0027/path/to/directory3\u0027, [\u0027*\u0027])],"},{"line_number":23,"context_line":"            \u0027search_pattern\u0027: \u0027\u0027}"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_2cdcbb45","line":21,"range":{"start_line":21,"start_character":58,"end_line":21,"end_character":69},"updated":"2016-01-26 17:10:44.000000000","message":"This will actually be used if run monasca-setup -d logging. Seems to me more of an example instead of something that is in our plugins directory.","commit_id":"1c524961235db7e401b6abe4a65f4378678665b5"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"f12a87d8edc0ae717cf9dfe85f7344e3e900364a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"            \u0027process_names\u0027: [\u0027logging\u0027],"},{"line_number":19,"context_line":"            \u0027file_dirs_names\u0027: [(\u0027/path/to/directory1\u0027, [\u0027file_name1\u0027]),"},{"line_number":20,"context_line":"                                (\u0027/path/to/directory2\u0027, [\u0027file_name21\u0027,"},{"line_number":21,"context_line":"                                                         \u0027file_name22\u0027]),"},{"line_number":22,"context_line":"                                (\u0027/path/to/directory3\u0027, [\u0027*\u0027])],"},{"line_number":23,"context_line":"            \u0027search_pattern\u0027: \u0027\u0027}"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_8f059415","line":21,"range":{"start_line":21,"start_character":58,"end_line":21,"end_character":69},"in_reply_to":"9a68dd71_2cdcbb45","updated":"2016-01-26 20:09:02.000000000","message":"Done","commit_id":"1c524961235db7e401b6abe4a65f4378678665b5"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"a03c06959b1f9a1bb5f949c38c041a80722327df","unresolved":false,"context_lines":[{"line_number":15,"context_line":"            \u0027template_dir\u0027: template_dir,"},{"line_number":16,"context_line":"            \u0027overwrite\u0027: overwrite,"},{"line_number":17,"context_line":"            \u0027service_name\u0027: \u0027logging-service\u0027,"},{"line_number":18,"context_line":"            \u0027process_names\u0027: [\u0027logging\u0027],"},{"line_number":19,"context_line":"            \u0027file_dirs_names\u0027: [(\u0027/var/log/monasca/agent/\u0027, [\u0027*\u0027]),"},{"line_number":20,"context_line":"                                (\u0027/var/log/monasca/api\u0027,"},{"line_number":21,"context_line":"                                 [\u0027monasca-api.log\u0027, \u0027request.log\u0027]),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_585bdb54","line":18,"range":{"start_line":18,"start_character":31,"end_line":18,"end_character":38},"updated":"2016-01-26 22:58:04.000000000","message":"lets talk more about this i think we should take this file out.","commit_id":"87a29397e6f43ea3b0785c2b50f19847b1afecb6"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"dbec54247cbf2eb349ca3f09f3cfa45320db64c8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"            \u0027template_dir\u0027: template_dir,"},{"line_number":16,"context_line":"            \u0027overwrite\u0027: overwrite,"},{"line_number":17,"context_line":"            \u0027service_name\u0027: \u0027logging-service\u0027,"},{"line_number":18,"context_line":"            \u0027process_names\u0027: [\u0027logging\u0027],"},{"line_number":19,"context_line":"            \u0027file_dirs_names\u0027: [(\u0027/var/log/monasca/agent/\u0027, [\u0027*\u0027]),"},{"line_number":20,"context_line":"                                (\u0027/var/log/monasca/api\u0027,"},{"line_number":21,"context_line":"                                 [\u0027monasca-api.log\u0027, \u0027request.log\u0027]),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_7b0ed9e6","line":18,"range":{"start_line":18,"start_character":31,"end_line":18,"end_character":38},"in_reply_to":"9a68dd71_585bdb54","updated":"2016-01-26 23:08:55.000000000","message":"Sounds good!","commit_id":"87a29397e6f43ea3b0785c2b50f19847b1afecb6"}],"monasca_setup/detection/service_plugin.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"76376dfcadadb6ae4dba05648c5e79bba04408f1","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            for i in xrange(len(self.file_dirs_names)):"},{"line_number":85,"context_line":"                # Watch file size"},{"line_number":86,"context_line":"                file_dir \u003d self.file_dirs_names[i][0]"},{"line_number":87,"context_line":"                file_names \u003d self.file_dirs_names[i][1]"},{"line_number":88,"context_line":"                log.info(\"\\tMonitoring the size of file {0} at {1}.\".format("},{"line_number":89,"context_line":"                    file_names, file_dir))"},{"line_number":90,"context_line":"                config.merge(watch_file_size(file_dir, file_names))"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_8ccb671e","line":87,"range":{"start_line":87,"start_character":16,"end_line":87,"end_character":26},"updated":"2016-01-26 17:10:44.000000000","message":"Is this files_names optional? if it is will this fail?","commit_id":"1c524961235db7e401b6abe4a65f4378678665b5"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"f12a87d8edc0ae717cf9dfe85f7344e3e900364a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            for i in xrange(len(self.file_dirs_names)):"},{"line_number":85,"context_line":"                # Watch file size"},{"line_number":86,"context_line":"                file_dir \u003d self.file_dirs_names[i][0]"},{"line_number":87,"context_line":"                file_names \u003d self.file_dirs_names[i][1]"},{"line_number":88,"context_line":"                log.info(\"\\tMonitoring the size of file {0} at {1}.\".format("},{"line_number":89,"context_line":"                    file_names, file_dir))"},{"line_number":90,"context_line":"                config.merge(watch_file_size(file_dir, file_names))"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_220d9f37","line":87,"range":{"start_line":87,"start_character":16,"end_line":87,"end_character":26},"in_reply_to":"9a68dd71_8ccb671e","updated":"2016-01-26 20:09:02.000000000","message":"file_names will be required.","commit_id":"1c524961235db7e401b6abe4a65f4378678665b5"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"76376dfcadadb6ae4dba05648c5e79bba04408f1","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                # Watch file size"},{"line_number":86,"context_line":"                file_dir \u003d self.file_dirs_names[i][0]"},{"line_number":87,"context_line":"                file_names \u003d self.file_dirs_names[i][1]"},{"line_number":88,"context_line":"                log.info(\"\\tMonitoring the size of file {0} at {1}.\".format("},{"line_number":89,"context_line":"                    file_names, file_dir))"},{"line_number":90,"context_line":"                config.merge(watch_file_size(file_dir, file_names))"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_cc54ff22","line":88,"range":{"start_line":88,"start_character":57,"end_line":88,"end_character":58},"updated":"2016-01-26 17:10:44.000000000","message":"if this is not set the message will look misleading \"monitoring the size of file at /path/to/directory\" Looks like it will be watching the path as the file. Even if the wildcard is in there will look weird","commit_id":"1c524961235db7e401b6abe4a65f4378678665b5"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"a03c06959b1f9a1bb5f949c38c041a80722327df","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                file_dir \u003d self.file_dirs_names[i][0]"},{"line_number":87,"context_line":"                file_names \u003d self.file_dirs_names[i][1]"},{"line_number":88,"context_line":"                if file_names \u003d\u003d [\u0027*\u0027]:"},{"line_number":89,"context_line":"                    log.info(\"\\tMonitoring the size of all the files in \""},{"line_number":90,"context_line":"                             \"directory {0}.\".format(file_dir))"},{"line_number":91,"context_line":"                else:"},{"line_number":92,"context_line":"                    log.info(\"\\tMonitoring the size of files {0} in directory\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_3825c7c1","line":89,"range":{"start_line":89,"start_character":71,"end_line":89,"end_character":72},"updated":"2016-01-26 22:58:04.000000000","message":"the","commit_id":"87a29397e6f43ea3b0785c2b50f19847b1afecb6"},{"author":{"_account_id":15799,"name":"Ben Motz","email":"ben.launchpad@ouat.co.uk","username":"bmotz"},"change_message_id":"d91ca2208c6c8b006ed8772ef8dcd8c83626859f","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            for i in xrange(len(self.file_dirs_names)):"},{"line_number":88,"context_line":"                # Watch file size"},{"line_number":89,"context_line":"                file_dir \u003d self.file_dirs_names[i][0]"},{"line_number":90,"context_line":"                file_names \u003d self.file_dirs_names[i][1]"},{"line_number":91,"context_line":"                if file_names \u003d\u003d [\u0027*\u0027]:"},{"line_number":92,"context_line":"                    log.info(\"\\tMonitoring the size of all the files in \""},{"line_number":93,"context_line":"                             \"directory {0}.\".format(file_dir))"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_d85588c6","line":90,"updated":"2016-01-28 10:15:23.000000000","message":"This would be more pythonic written as;\n\n    for file_dir_name in self.file_dirs_names:\n        file_dir \u003d file_dir_name[0]\n        file_names \u003d file_dir_name[1]","commit_id":"bd04c1da0446682f921e281237de820440c8b77c"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"1b3924411a899e6d27f04f3919da7b3afee5fbec","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            for i in xrange(len(self.file_dirs_names)):"},{"line_number":88,"context_line":"                # Watch file size"},{"line_number":89,"context_line":"                file_dir \u003d self.file_dirs_names[i][0]"},{"line_number":90,"context_line":"                file_names \u003d self.file_dirs_names[i][1]"},{"line_number":91,"context_line":"                if file_names \u003d\u003d [\u0027*\u0027]:"},{"line_number":92,"context_line":"                    log.info(\"\\tMonitoring the size of all the files in \""},{"line_number":93,"context_line":"                             \"directory {0}.\".format(file_dir))"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_d660de37","line":90,"in_reply_to":"7a5de9d1_d85588c6","updated":"2016-01-28 19:59:39.000000000","message":"Hi Ben, thank you for pointing this out! I will post a new patch with the changes.","commit_id":"bd04c1da0446682f921e281237de820440c8b77c"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"ec287fbdc460a4693f7bcb6420241db4de1c6d83","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                file_dir \u003d file_dir_name[0]"},{"line_number":90,"context_line":"                file_names \u003d file_dir_name[1]"},{"line_number":91,"context_line":"                if file_names \u003d\u003d [\u0027*\u0027]:"},{"line_number":92,"context_line":"                    log.info(\"\\tMonitoring the size of all the files in \""},{"line_number":93,"context_line":"                             \"directory {0}.\".format(file_dir))"},{"line_number":94,"context_line":"                else:"},{"line_number":95,"context_line":"                    log.info(\"\\tMonitoring the size of files {0} in directory\""}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_ef8c0a81","line":92,"range":{"start_line":92,"start_character":71,"end_line":92,"end_character":72},"updated":"2016-01-28 23:46:50.000000000","message":"the","commit_id":"3fcbc3dff5853591317441f834de9164954c1f83"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"33c7db71ef079218b63ea709d085b9ea16faafb6","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                file_dir \u003d file_dir_name[0]"},{"line_number":90,"context_line":"                file_names \u003d file_dir_name[1]"},{"line_number":91,"context_line":"                if file_names \u003d\u003d [\u0027*\u0027]:"},{"line_number":92,"context_line":"                    log.info(\"\\tMonitoring the size of all the files in \""},{"line_number":93,"context_line":"                             \"directory {0}.\".format(file_dir))"},{"line_number":94,"context_line":"                else:"},{"line_number":95,"context_line":"                    log.info(\"\\tMonitoring the size of files {0} in directory\""}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_eff88a4b","line":92,"range":{"start_line":92,"start_character":71,"end_line":92,"end_character":72},"in_reply_to":"7a5de9d1_ef8c0a81","updated":"2016-01-29 00:09:02.000000000","message":"Done","commit_id":"3fcbc3dff5853591317441f834de9164954c1f83"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"ec287fbdc460a4693f7bcb6420241db4de1c6d83","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                    log.info(\"\\tMonitoring the size of all the files in \""},{"line_number":93,"context_line":"                             \"directory {0}.\".format(file_dir))"},{"line_number":94,"context_line":"                else:"},{"line_number":95,"context_line":"                    log.info(\"\\tMonitoring the size of files {0} in directory\""},{"line_number":96,"context_line":"                             \" {1}.\".format(\", \".join(str(name) for name in"},{"line_number":97,"context_line":"                                                      file_names), file_dir))"},{"line_number":98,"context_line":"                config.merge(watch_file_size(file_dir, file_names))"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_4ff43ef1","line":95,"range":{"start_line":95,"start_character":68,"end_line":95,"end_character":77},"updated":"2016-01-28 23:46:50.000000000","message":"the","commit_id":"3fcbc3dff5853591317441f834de9164954c1f83"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"33c7db71ef079218b63ea709d085b9ea16faafb6","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                    log.info(\"\\tMonitoring the size of all the files in \""},{"line_number":93,"context_line":"                             \"directory {0}.\".format(file_dir))"},{"line_number":94,"context_line":"                else:"},{"line_number":95,"context_line":"                    log.info(\"\\tMonitoring the size of files {0} in directory\""},{"line_number":96,"context_line":"                             \" {1}.\".format(\", \".join(str(name) for name in"},{"line_number":97,"context_line":"                                                      file_names), file_dir))"},{"line_number":98,"context_line":"                config.merge(watch_file_size(file_dir, file_names))"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_8f96b6ee","line":95,"range":{"start_line":95,"start_character":68,"end_line":95,"end_character":77},"in_reply_to":"7a5de9d1_4ff43ef1","updated":"2016-01-29 00:09:02.000000000","message":"Done","commit_id":"3fcbc3dff5853591317441f834de9164954c1f83"},{"author":{"_account_id":15799,"name":"Ben Motz","email":"ben.launchpad@ouat.co.uk","username":"bmotz"},"change_message_id":"04192902edb8224b0efca01ca3f44374f8d03192","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                    log.info(\"\\tMonitoring the size of all the files in the \""},{"line_number":93,"context_line":"                             \"directory {0}.\".format(file_dir))"},{"line_number":94,"context_line":"                else:"},{"line_number":95,"context_line":"                    log.info(\"\\tMonitoring the size of files {0} in the directory{1}.\".format("},{"line_number":96,"context_line":"                        \", \".join(str(name) for name in file_names), file_dir))"},{"line_number":97,"context_line":"                config.merge(watch_file_size(file_dir, file_names))"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7a5de9d1_bb7de6b2","line":95,"updated":"2016-01-29 09:47:26.000000000","message":"minor nit; missing space in \"...directory{1}\"","commit_id":"dc58f8ccdaed58c8db1aa7d18f1988e5208cb79f"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"643b78b92b516af83ffe368dba5d191e10d7168c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                    log.info(\"\\tMonitoring the size of all the files in the \""},{"line_number":93,"context_line":"                             \"directory {0}.\".format(file_dir))"},{"line_number":94,"context_line":"                else:"},{"line_number":95,"context_line":"                    log.info(\"\\tMonitoring the size of files {0} in the directory{1}.\".format("},{"line_number":96,"context_line":"                        \", \".join(str(name) for name in file_names), file_dir))"},{"line_number":97,"context_line":"                config.merge(watch_file_size(file_dir, file_names))"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7a5de9d1_64a33801","line":95,"in_reply_to":"7a5de9d1_bb7de6b2","updated":"2016-01-29 16:04:36.000000000","message":"Yes! Thank you!","commit_id":"dc58f8ccdaed58c8db1aa7d18f1988e5208cb79f"}],"monasca_setup/detection/utils.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"76376dfcadadb6ae4dba05648c5e79bba04408f1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2016 Hewlett Packard Enterprise Development Company LP"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"\"\"\" Util functions to assist in detection."},{"line_number":4,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_f712ec57","line":1,"range":{"start_line":1,"start_character":29,"end_line":1,"end_character":36},"updated":"2016-01-26 17:10:44.000000000","message":"good catch on these copyrights :) just know we need to add 2015 or 2014 to each if that particular file was edited in that year. You can do that or i can when I go through and add copyrights upstream.","commit_id":"1c524961235db7e401b6abe4a65f4378678665b5"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"f12a87d8edc0ae717cf9dfe85f7344e3e900364a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2016 Hewlett Packard Enterprise Development Company LP"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"\"\"\" Util functions to assist in detection."},{"line_number":4,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_c0303beb","line":1,"range":{"start_line":1,"start_character":29,"end_line":1,"end_character":36},"in_reply_to":"9a68dd71_f712ec57","updated":"2016-01-26 20:09:02.000000000","message":"I can do it for the ones I\u0027m making changes on :-)","commit_id":"1c524961235db7e401b6abe4a65f4378678665b5"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"76376dfcadadb6ae4dba05648c5e79bba04408f1","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"def watch_file_size(file_directory, file_names):"},{"line_number":113,"context_line":"    \"\"\"Take a list of files and returns a Plugins object with the config set."},{"line_number":114,"context_line":"    \"\"\""},{"line_number":115,"context_line":"    config \u003d agent_config.Plugins()"},{"line_number":116,"context_line":"    parameters \u003d {\u0027file_directory\u0027: file_directory,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_972a907d","line":113,"range":{"start_line":113,"start_character":22,"end_line":113,"end_character":27},"updated":"2016-01-26 17:10:44.000000000","message":"takes a directory and a list of files","commit_id":"1c524961235db7e401b6abe4a65f4378678665b5"}]}