)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"9c589f96b5c754893b7765b09f2fe0695a22d769","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michael James Hoppal \u003cmichael.jam.hoppal@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-02 10:07:50 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the default behavior of detail processing checking"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7dd310a435f5cd2e9fc53ba1f3ed03e9cc079ed1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a5ae5dd_7517cfa3","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":54},"updated":"2016-02-03 16:08:08.000000000","message":"There is more going on in this change than mentioned above. Please update the commit message","commit_id":"a0dee241ca2827db1fbfca7e93677000f7345428"}],"monasca_setup/detection/plugins/mon.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"2e580dd186895f2e6f53a642a3814245451ea870","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        agent_process_list \u003d [\u0027monasca-collector\u0027, \u0027monasca-forwarder\u0027, \u0027monasca-statsd\u0027]"},{"line_number":26,"context_line":"        for process in agent_process_list:"},{"line_number":27,"context_line":"            if find_process_cmdline(process) is not None:"},{"line_number":28,"context_line":"                self.available \u003d False"},{"line_number":29,"context_line":"                return"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def build_config(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_906bacb6","line":28,"range":{"start_line":28,"start_character":33,"end_line":28,"end_character":38},"updated":"2016-01-25 20:47:16.000000000","message":"Isn\u0027t this backwards? You are setting self.available to False if any of the processes are found?","commit_id":"98c757b442c1f830ad30eb73e79041b951f0cbf3"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"e062ff7d252d3322307fb3be680232f87342514e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        agent_process_list \u003d [\u0027monasca-collector\u0027, \u0027monasca-forwarder\u0027, \u0027monasca-statsd\u0027]"},{"line_number":26,"context_line":"        for process in agent_process_list:"},{"line_number":27,"context_line":"            if find_process_cmdline(process) is not None:"},{"line_number":28,"context_line":"                self.available \u003d False"},{"line_number":29,"context_line":"                return"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def build_config(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_f0830801","line":28,"range":{"start_line":28,"start_character":33,"end_line":28,"end_character":38},"in_reply_to":"9a68dd71_906bacb6","updated":"2016-01-25 20:57:34.000000000","message":"meant to say if none so it quits out sooner if one of the agent processes is not found. Let me change that","commit_id":"98c757b442c1f830ad30eb73e79041b951f0cbf3"}],"monasca_setup/detection/plugins/rabbitmq.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"8a429af9051b7ba5695092a15f5377061d70b694","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        \"\"\""},{"line_number":121,"context_line":"        config \u003d monasca_setup.agent_config.Plugins()"},{"line_number":122,"context_line":"        # First watch the process"},{"line_number":123,"context_line":"        config.merge(monasca_setup.detection.watch_process([\u0027rabbitmq-server\u0027], \u0027rabbitmq\u0027, detailed\u003dFalse))"},{"line_number":124,"context_line":"        log.info(\"\\tWatching the rabbitmq-server process.\")"},{"line_number":125,"context_line":"        config.merge(monasca_setup.detection.watch_process_by_username(\u0027rabbitmq\u0027, \u0027rabbitmq\u0027))"},{"line_number":126,"context_line":"        log.info(\"\\tWatching all processes owned by the rabbitmq user.\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_ead0c3f9","line":123,"range":{"start_line":123,"start_character":61,"end_line":123,"end_character":76},"updated":"2016-02-02 17:48:53.000000000","message":"Isn\u0027t the rabbitmq-server process also run by the rabbitmq user? So, why have it separately checked?","commit_id":"a0dee241ca2827db1fbfca7e93677000f7345428"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"73eff7c9ba02dcfbadc9cb5b7f5cf8550d16dd92","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        \"\"\""},{"line_number":121,"context_line":"        config \u003d monasca_setup.agent_config.Plugins()"},{"line_number":122,"context_line":"        # First watch the process"},{"line_number":123,"context_line":"        config.merge(monasca_setup.detection.watch_process([\u0027rabbitmq-server\u0027], \u0027rabbitmq\u0027, detailed\u003dFalse))"},{"line_number":124,"context_line":"        log.info(\"\\tWatching the rabbitmq-server process.\")"},{"line_number":125,"context_line":"        config.merge(monasca_setup.detection.watch_process_by_username(\u0027rabbitmq\u0027, \u0027rabbitmq\u0027))"},{"line_number":126,"context_line":"        log.info(\"\\tWatching all processes owned by the rabbitmq user.\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_0a6aff1a","line":123,"range":{"start_line":123,"start_character":61,"end_line":123,"end_character":76},"in_reply_to":"7a5de9d1_ead0c3f9","updated":"2016-02-02 17:51:58.000000000","message":"the reason I do this is because rabbitmq has separate processes running. And if the server is down and other processes owned by rabbitmq are still running then our process check by user will still have process.pid_count \u003e 0 and no alarm will go off. So I decided to do both. So we can detect if the rabbitmq server is down or not","commit_id":"a0dee241ca2827db1fbfca7e93677000f7345428"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"f71cbc80cf6060e7db71c0c2473d90cd66d13386","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2015 Hewlett Packard Enterprise Development Company LP"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import logging"},{"line_number":4,"context_line":"import urllib2"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_88561705","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2016-02-02 23:37:46.000000000","message":"Should this one be 2015-2016?","commit_id":"ed21e7a6058b025e202324b8167c0f2a02769a09"}],"monasca_setup/detection/utils.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"9c589f96b5c754893b7765b09f2fe0695a22d769","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"def watch_process(search_strings, service\u003dNone, component\u003dNone,"},{"line_number":71,"context_line":"                  exact_match\u003dTrue, detailed\u003dTrue, process_name\u003dNone):"},{"line_number":72,"context_line":"    \"\"\"Takes a list of process search strings and returns a Plugins object with the config set."},{"line_number":73,"context_line":"        This was built as a helper as many plugins setup process watching"},{"line_number":74,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_95584b58","line":71,"range":{"start_line":71,"start_character":36,"end_line":71,"end_character":49},"updated":"2016-02-03 16:08:08.000000000","message":"Was this the behavior previously? This seems like it will really increase the amount of metros","commit_id":"a0dee241ca2827db1fbfca7e93677000f7345428"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"786d85244e8024957cc572d9cbf8780450a36375","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"def watch_process(search_strings, service\u003dNone, component\u003dNone,"},{"line_number":71,"context_line":"                  exact_match\u003dTrue, detailed\u003dTrue, process_name\u003dNone):"},{"line_number":72,"context_line":"    \"\"\"Takes a list of process search strings and returns a Plugins object with the config set."},{"line_number":73,"context_line":"        This was built as a helper as many plugins setup process watching"},{"line_number":74,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_7a57b302","line":71,"range":{"start_line":71,"start_character":36,"end_line":71,"end_character":49},"in_reply_to":"5a5ae5dd_95584b58","updated":"2016-02-03 18:14:48.000000000","message":"This will increase the amount of metrics from the control plane but we don\u0027t have that many process checks and the control plane metrics are a pretty trivial part of our overall load.  My expectation is that we won\u0027t be able to see any difference.","commit_id":"a0dee241ca2827db1fbfca7e93677000f7345428"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"f71cbc80cf6060e7db71c0c2473d90cd66d13386","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2015 Hewlett Packard Enterprise Development Company LP"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"\"\"\" Util functions to assist in detection."},{"line_number":4,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_2848435b","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2016-02-02 23:37:46.000000000","message":"Same here","commit_id":"ed21e7a6058b025e202324b8167c0f2a02769a09"}]}