)]}'
{"monasca_agent/collector/checks_d/http_check.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"d93fee931c4b27348eaa4b6fb7c0c0dfebb48c82","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            except (socket.timeout, HttpLib2Error, socket.error) as e:"},{"line_number":100,"context_line":"                length \u003d int((time.time() - start) * 1000)"},{"line_number":101,"context_line":"                error_string \u003d \u0027{0} is DOWN, error: {1}. Connection failed after {2} ms\u0027.format(addr, repr(e), length)"},{"line_number":102,"context_line":"                self.log.info(error_string)"},{"line_number":103,"context_line":"                return False, error_string"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"            except httplib.ResponseNotReady as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_f94ee36d","line":102,"range":{"start_line":102,"start_character":25,"end_line":102,"end_character":29},"updated":"2016-02-05 15:52:58.000000000","message":"is there a reason why this is a info instead of error?","commit_id":"65059769cbac46ee2a0d2e829335e4dccbb38d30"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"14ac942d19c65f835c8c8cccb77697ff4d73e0b4","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            except (socket.timeout, HttpLib2Error, socket.error) as e:"},{"line_number":100,"context_line":"                length \u003d int((time.time() - start) * 1000)"},{"line_number":101,"context_line":"                error_string \u003d \u0027{0} is DOWN, error: {1}. Connection failed after {2} ms\u0027.format(addr, repr(e), length)"},{"line_number":102,"context_line":"                self.log.info(error_string)"},{"line_number":103,"context_line":"                return False, error_string"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"            except httplib.ResponseNotReady as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_fca251ad","line":102,"range":{"start_line":102,"start_character":25,"end_line":102,"end_character":29},"in_reply_to":"5a5ae5dd_f94ee36d","updated":"2016-02-05 16:11:59.000000000","message":"In my opinion error is more appropriate here instead of info. But I don\u0027t know why info is set at the beginning. Thanks Michael!","commit_id":"65059769cbac46ee2a0d2e829335e4dccbb38d30"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"d93fee931c4b27348eaa4b6fb7c0c0dfebb48c82","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            except httplib.ResponseNotReady as e:"},{"line_number":106,"context_line":"                length \u003d int((time.time() - start) * 1000)"},{"line_number":107,"context_line":"                error_string \u003d \u0027{0} is DOWN, error: {1}. Network is not routable after {2} ms\u0027.format(addr, repr(e), length)"},{"line_number":108,"context_line":"                self.log.info(error_string)"},{"line_number":109,"context_line":"                return False, error_string"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"            except Exception as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_b96b8bb8","line":108,"range":{"start_line":108,"start_character":25,"end_line":108,"end_character":29},"updated":"2016-02-05 15:52:58.000000000","message":"same here","commit_id":"65059769cbac46ee2a0d2e829335e4dccbb38d30"},{"author":{"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},"change_message_id":"3f7aa196cf2e57c6d7c82db6ad4cdd441382ca0b","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            except Exception as e:"},{"line_number":112,"context_line":"                length \u003d int((time.time() - start) * 1000)"},{"line_number":113,"context_line":"                error_string \u003d \u0027{0} is DOWN, error: {1}. Connection failed after {2} ms\u0027.format(addr, repr(e), length)"},{"line_number":114,"context_line":"                self.log.error(\u0027Unhandled exception {0} for {1}. Connection failed after {2} ms\u0027.format(repr(e), addr, length))"},{"line_number":115,"context_line":"                return False, error_string"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"            if response_time:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_474f006b","line":114,"range":{"start_line":114,"start_character":16,"end_line":114,"end_character":31},"updated":"2016-02-05 22:23:39.000000000","message":"Why don\u0027t you simply use the error_string as body for the log.error?\nThis is what is done in all the previous cases","commit_id":"1ed6c10382d3f1a89edcd9e0659be3c71a72f83e"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"b9d213a1370001e0f1478f5729ad473178e1449a","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            except Exception as e:"},{"line_number":112,"context_line":"                length \u003d int((time.time() - start) * 1000)"},{"line_number":113,"context_line":"                error_string \u003d \u0027{0} is DOWN, error: {1}. Connection failed after {2} ms\u0027.format(addr, repr(e), length)"},{"line_number":114,"context_line":"                self.log.error(\u0027Unhandled exception {0} for {1}. Connection failed after {2} ms\u0027.format(repr(e), addr, length))"},{"line_number":115,"context_line":"                return False, error_string"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"            if response_time:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_879df867","line":114,"range":{"start_line":114,"start_character":16,"end_line":114,"end_character":31},"in_reply_to":"5a5ae5dd_474f006b","updated":"2016-02-05 23:01:06.000000000","message":"Hi Fabio, thank you for pointing this out. That\u0027s definitely better.","commit_id":"1ed6c10382d3f1a89edcd9e0659be3c71a72f83e"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"831107c807207df6787b0294a368e48e52d9f111","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            except (socket.timeout, HttpLib2Error, socket.error) as e:"},{"line_number":100,"context_line":"                length \u003d int((time.time() - start) * 1000)"},{"line_number":101,"context_line":"                error_string \u003d \u0027{0} is DOWN, error: {1}. Connection failed after {2} ms\u0027.format(addr, repr(e), length)"},{"line_number":102,"context_line":"                self.log.warn(error_string)"},{"line_number":103,"context_line":"                return False, error_string"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"            except httplib.ResponseNotReady as e:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_7d6f1ffc","line":102,"range":{"start_line":102,"start_character":30,"end_line":102,"end_character":42},"updated":"2016-02-06 19:43:25.000000000","message":"Don\u0027t want to be picky, but if you use log.warn here, I\u0027d have\n\n warn_string\ninstead of\n error_string\n\nSame applies to line @108 and @136. In line @114 you have log.error and there you use error_string. \nJust a small suggestion for the sake of clear code :)","commit_id":"34227db398a5c6e3c0c24e74bc3a6216caec9abe"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"843deb42cfb83107cd390699564c8f598b29c221","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            except (socket.timeout, HttpLib2Error, socket.error) as e:"},{"line_number":100,"context_line":"                length \u003d int((time.time() - start) * 1000)"},{"line_number":101,"context_line":"                error_string \u003d \u0027{0} is DOWN, error: {1}. Connection failed after {2} ms\u0027.format(addr, repr(e), length)"},{"line_number":102,"context_line":"                self.log.warn(error_string)"},{"line_number":103,"context_line":"                return False, error_string"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"            except httplib.ResponseNotReady as e:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_1ae4a9aa","line":102,"range":{"start_line":102,"start_character":30,"end_line":102,"end_character":42},"in_reply_to":"5a5ae5dd_7d6f1ffc","updated":"2016-02-09 00:57:19.000000000","message":"Small things matter too :-) thank  you!","commit_id":"34227db398a5c6e3c0c24e74bc3a6216caec9abe"}]}