)]}'
{"conf.d/vertica.yaml.example":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"fc6b845f92e15d0adf211cce2b183562faeb3785","unresolved":false,"context_lines":[{"line_number":5,"context_line":"instances:"},{"line_number":6,"context_line":"#  - name: localhost"},{"line_number":7,"context_line":"#    user: dbadmin"},{"line_number":8,"context_line":"#    password: my_password"},{"line_number":9,"context_line":"#    service: monasca # Optional"},{"line_number":10,"context_line":"#    timeout: 3       # Optional (secs)"},{"line_number":11,"context_line":"#    vsql_path: /opt/vertica/bin/vsql # Optional"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9aed3d3a_44b925e9","line":8,"range":{"start_line":8,"start_character":15,"end_line":8,"end_character":26},"updated":"2016-02-26 03:41:31.000000000","message":"do we need to use dbadmin i know we used to have a monitor user on top of dbadmin, api and persister user i am not sure of what we all have now.","commit_id":"4ae78df27ad9666488d1a28dc8b7a64277bc4fdc"},{"author":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"change_message_id":"5c2bbb227dac660d2f23899a910d83d7c323e620","unresolved":false,"context_lines":[{"line_number":5,"context_line":"instances:"},{"line_number":6,"context_line":"#  - name: localhost"},{"line_number":7,"context_line":"#    user: dbadmin"},{"line_number":8,"context_line":"#    password: my_password"},{"line_number":9,"context_line":"#    service: monasca # Optional"},{"line_number":10,"context_line":"#    timeout: 3       # Optional (secs)"},{"line_number":11,"context_line":"#    vsql_path: /opt/vertica/bin/vsql # Optional"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9aed3d3a_9b58a7fc","line":8,"range":{"start_line":8,"start_character":15,"end_line":8,"end_character":26},"in_reply_to":"9aed3d3a_44b925e9","updated":"2016-02-26 04:36:32.000000000","message":"I tested and found it can be any user.  I\u0027ll change this.","commit_id":"4ae78df27ad9666488d1a28dc8b7a64277bc4fdc"}],"monasca_agent/collector/checks_d/vertica.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"fc6b845f92e15d0adf211cce2b183562faeb3785","unresolved":false,"context_lines":[{"line_number":3,"context_line":"import monasca_agent.collector.checks as checks"},{"line_number":4,"context_line":"from monasca_agent.common.util import timeout_command"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"VSQL_PATH \u003d \u0027/opt/vertica/bin/vsql\u0027"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"class Vertica(checks.AgentCheck):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_04c1dde4","line":6,"range":{"start_line":6,"start_character":18,"end_line":6,"end_character":25},"updated":"2016-02-26 03:41:31.000000000","message":"not sure if we need this","commit_id":"4ae78df27ad9666488d1a28dc8b7a64277bc4fdc"},{"author":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"change_message_id":"5c2bbb227dac660d2f23899a910d83d7c323e620","unresolved":false,"context_lines":[{"line_number":3,"context_line":"import monasca_agent.collector.checks as checks"},{"line_number":4,"context_line":"from monasca_agent.common.util import timeout_command"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"VSQL_PATH \u003d \u0027/opt/vertica/bin/vsql\u0027"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"class Vertica(checks.AgentCheck):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_fb5293dc","line":6,"range":{"start_line":6,"start_character":18,"end_line":6,"end_character":25},"in_reply_to":"9aed3d3a_04c1dde4","updated":"2016-02-26 04:36:32.000000000","message":"I wasn\u0027t sure, I can remove.  it is correct for HLM","commit_id":"4ae78df27ad9666488d1a28dc8b7a64277bc4fdc"}],"monasca_setup/detection/plugins/vertica.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"fc6b845f92e15d0adf211cce2b183562faeb3785","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            - timeout   (optional - timeout for connection attempt in seconds)"},{"line_number":31,"context_line":"        /root/.vertica.cnf in a format such as"},{"line_number":32,"context_line":"        [client]"},{"line_number":33,"context_line":"            user \u003d dbadmin"},{"line_number":34,"context_line":"            password \u003d yourpassword"},{"line_number":35,"context_line":"            vsql_path \u003d /opt/vertica/bin/vsql"},{"line_number":36,"context_line":"            service \u003d monitoring"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_c4c1b530","line":33,"range":{"start_line":33,"start_character":19,"end_line":33,"end_character":26},"updated":"2016-02-26 03:41:31.000000000","message":"same here dod we need the dbadmin or could we use another one of the users?","commit_id":"4ae78df27ad9666488d1a28dc8b7a64277bc4fdc"},{"author":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"change_message_id":"5c2bbb227dac660d2f23899a910d83d7c323e620","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            - timeout   (optional - timeout for connection attempt in seconds)"},{"line_number":31,"context_line":"        /root/.vertica.cnf in a format such as"},{"line_number":32,"context_line":"        [client]"},{"line_number":33,"context_line":"            user \u003d dbadmin"},{"line_number":34,"context_line":"            password \u003d yourpassword"},{"line_number":35,"context_line":"            vsql_path \u003d /opt/vertica/bin/vsql"},{"line_number":36,"context_line":"            service \u003d monitoring"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_db722f7c","line":33,"range":{"start_line":33,"start_character":19,"end_line":33,"end_character":26},"in_reply_to":"9aed3d3a_c4c1b530","updated":"2016-02-26 04:36:32.000000000","message":"any user will work, changing this.","commit_id":"4ae78df27ad9666488d1a28dc8b7a64277bc4fdc"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"fc6b845f92e15d0adf211cce2b183562faeb3785","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        [client]"},{"line_number":33,"context_line":"            user \u003d dbadmin"},{"line_number":34,"context_line":"            password \u003d yourpassword"},{"line_number":35,"context_line":"            vsql_path \u003d /opt/vertica/bin/vsql"},{"line_number":36,"context_line":"            service \u003d monitoring"},{"line_number":37,"context_line":"            timeout \u003d 3"},{"line_number":38,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_e4fcb940","line":35,"range":{"start_line":35,"start_character":29,"end_line":35,"end_character":36},"updated":"2016-02-26 03:41:31.000000000","message":"not sure if we need this I have not seen it be different it comes right when you install vertica","commit_id":"4ae78df27ad9666488d1a28dc8b7a64277bc4fdc"},{"author":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"change_message_id":"5c2bbb227dac660d2f23899a910d83d7c323e620","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        [client]"},{"line_number":33,"context_line":"            user \u003d dbadmin"},{"line_number":34,"context_line":"            password \u003d yourpassword"},{"line_number":35,"context_line":"            vsql_path \u003d /opt/vertica/bin/vsql"},{"line_number":36,"context_line":"            service \u003d monitoring"},{"line_number":37,"context_line":"            timeout \u003d 3"},{"line_number":38,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_bb6f6b91","line":35,"range":{"start_line":35,"start_character":29,"end_line":35,"end_character":36},"in_reply_to":"9aed3d3a_e4fcb940","updated":"2016-02-26 04:36:32.000000000","message":"If you are sure, i\u0027ll remove this","commit_id":"4ae78df27ad9666488d1a28dc8b7a64277bc4fdc"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"fc6b845f92e15d0adf211cce2b183562faeb3785","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        \"\"\""},{"line_number":84,"context_line":"        # Read the Vertica config file to extract the needed variables."},{"line_number":85,"context_line":"        client_section \u003d False"},{"line_number":86,"context_line":"        with open(config_file, \"r\") as conf:"},{"line_number":87,"context_line":"            for row in conf:"},{"line_number":88,"context_line":"                if \"[client]\" in row:"},{"line_number":89,"context_line":"                    client_section \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_241221b5","line":86,"range":{"start_line":86,"start_character":18,"end_line":86,"end_character":29},"updated":"2016-02-26 03:41:31.000000000","message":"what if we can not open the file? no message letting the user know","commit_id":"4ae78df27ad9666488d1a28dc8b7a64277bc4fdc"},{"author":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"change_message_id":"5c2bbb227dac660d2f23899a910d83d7c323e620","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        \"\"\""},{"line_number":84,"context_line":"        # Read the Vertica config file to extract the needed variables."},{"line_number":85,"context_line":"        client_section \u003d False"},{"line_number":86,"context_line":"        with open(config_file, \"r\") as conf:"},{"line_number":87,"context_line":"            for row in conf:"},{"line_number":88,"context_line":"                if \"[client]\" in row:"},{"line_number":89,"context_line":"                    client_section \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_1b0497be","line":86,"range":{"start_line":86,"start_character":18,"end_line":86,"end_character":29},"in_reply_to":"9aed3d3a_241221b5","updated":"2016-02-26 04:36:32.000000000","message":"You will get an info message \u0027Unable to configure the Vertica plugin.","commit_id":"4ae78df27ad9666488d1a28dc8b7a64277bc4fdc"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"fc6b845f92e15d0adf211cce2b183562faeb3785","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                        self.user \u003d row.split(\"\u003d\")[1].strip()"},{"line_number":95,"context_line":"                    if \"password\" in row:"},{"line_number":96,"context_line":"                        self.password \u003d row.split(\"\u003d\")[1].strip()"},{"line_number":97,"context_line":"                    if \"vsql_path\" in row:"},{"line_number":98,"context_line":"                        self.vsql_path \u003d row.split(\"\u003d\")[1].strip()"},{"line_number":99,"context_line":"                    if \"service\" in row:"},{"line_number":100,"context_line":"                        self.service \u003d row.split(\"\u003d\")[1].strip()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_e44e79c0","line":97,"range":{"start_line":97,"start_character":24,"end_line":97,"end_character":33},"updated":"2016-02-26 03:41:31.000000000","message":"have you seen where the vsql path is different I have not","commit_id":"4ae78df27ad9666488d1a28dc8b7a64277bc4fdc"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"fc6b845f92e15d0adf211cce2b183562faeb3785","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            self._get_config()"},{"line_number":111,"context_line":"            for process in [\u0027vertica\u0027, \u0027spread\u0027]:"},{"line_number":112,"context_line":"                config.merge(monasca_setup.detection.watch_process([process], self.service, process,"},{"line_number":113,"context_line":"                             exact_match\u003dFalse))"},{"line_number":114,"context_line":"            log.info(\"\\tWatching the vertica process.\")"},{"line_number":115,"context_line":"            if self._connection_test():"},{"line_number":116,"context_line":"                log.info(\"\\tBuilding vertica config.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_a48911cd","line":113,"range":{"start_line":113,"start_character":29,"end_line":113,"end_character":40},"updated":"2016-02-26 03:41:31.000000000","message":"should we also watch by user? Also if we do this here make sure you remove the vertia process check set up in the mon.py detection plugin","commit_id":"4ae78df27ad9666488d1a28dc8b7a64277bc4fdc"},{"author":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"change_message_id":"5c2bbb227dac660d2f23899a910d83d7c323e620","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            self._get_config()"},{"line_number":111,"context_line":"            for process in [\u0027vertica\u0027, \u0027spread\u0027]:"},{"line_number":112,"context_line":"                config.merge(monasca_setup.detection.watch_process([process], self.service, process,"},{"line_number":113,"context_line":"                             exact_match\u003dFalse))"},{"line_number":114,"context_line":"            log.info(\"\\tWatching the vertica process.\")"},{"line_number":115,"context_line":"            if self._connection_test():"},{"line_number":116,"context_line":"                log.info(\"\\tBuilding vertica config.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_7b2b2331","line":113,"range":{"start_line":113,"start_character":29,"end_line":113,"end_character":40},"in_reply_to":"9aed3d3a_a48911cd","updated":"2016-02-26 04:36:32.000000000","message":"what does watch by user do?  It is currently watching by process name","commit_id":"4ae78df27ad9666488d1a28dc8b7a64277bc4fdc"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"fc6b845f92e15d0adf211cce2b183562faeb3785","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                                   \u0027timeout\u0027: self.timeout}"},{"line_number":123,"context_line":"                config[\u0027vertica\u0027] \u003d {\u0027init_config\u0027: None, \u0027instances\u0027: [instance_config]}"},{"line_number":124,"context_line":"            else:"},{"line_number":125,"context_line":"                log.warn(\u0027Unable to configure the Vertica plugin.\u0027 +"},{"line_number":126,"context_line":"                         \u0027 Please correct and re-run monasca-setup.\u0027)"},{"line_number":127,"context_line":"        except Exception:"},{"line_number":128,"context_line":"            log.exception(\u0027Error configuring the Vertica check plugin\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_44a48556","line":125,"range":{"start_line":125,"start_character":50,"end_line":125,"end_character":57},"updated":"2016-02-26 03:41:31.000000000","message":"did we want to exit here because in this case we are still setting up the process check when we return the config","commit_id":"4ae78df27ad9666488d1a28dc8b7a64277bc4fdc"},{"author":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"change_message_id":"5c2bbb227dac660d2f23899a910d83d7c323e620","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                                   \u0027timeout\u0027: self.timeout}"},{"line_number":123,"context_line":"                config[\u0027vertica\u0027] \u003d {\u0027init_config\u0027: None, \u0027instances\u0027: [instance_config]}"},{"line_number":124,"context_line":"            else:"},{"line_number":125,"context_line":"                log.warn(\u0027Unable to configure the Vertica plugin.\u0027 +"},{"line_number":126,"context_line":"                         \u0027 Please correct and re-run monasca-setup.\u0027)"},{"line_number":127,"context_line":"        except Exception:"},{"line_number":128,"context_line":"            log.exception(\u0027Error configuring the Vertica check plugin\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_fbee13eb","line":125,"range":{"start_line":125,"start_character":50,"end_line":125,"end_character":57},"in_reply_to":"9aed3d3a_44a48556","updated":"2016-02-26 04:36:32.000000000","message":"Yes we want to exit. If we got here the process check was already setup.","commit_id":"4ae78df27ad9666488d1a28dc8b7a64277bc4fdc"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"685463d90a438bb6f87b05ccd24849913036e2af","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            else:"},{"line_number":126,"context_line":"                log.warn(\u0027Unable to configure the Vertica plugin.\u0027 +"},{"line_number":127,"context_line":"                         \u0027 Please correct and re-run monasca-setup.\u0027)"},{"line_number":128,"context_line":"        except Exception:"},{"line_number":129,"context_line":"            log.exception(\u0027Error configuring the Vertica check plugin\u0027)"},{"line_number":130,"context_line":"        return config"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_587d4fb0","line":128,"range":{"start_line":128,"start_character":15,"end_line":128,"end_character":24},"updated":"2016-02-26 20:21:52.000000000","message":"okay for this exception and the else conditional above we are not exiting the detection and still returning a config right (with a process check configuration) because you are just logging. Meaning that if we were running this detection plugin and we hit these two cases we will log an error message but still return that it completed. In the case of the command line its not as big of deal as you would be able to see the error messages but if you are running this via ansible or in an automated fashion it will look like it completed successfully. Should we be raising an exception here? What are your thoughts?\n\nFWIW i tried this on mini-mon and this is my result\n\n(monasca)root@mini-mon:~# monasca-setup -d vertica -a \"password\u003df\"\nINFO: Configuring Vertica\nINFO: \tWatching the vertica process.\nINFO: \tVertica connection test.\nWARNING: Unable to configure the Vertica plugin. Please correct and re-run monasca-setup.\nINFO: Starting monasca-agent service via SysV init script\nStopping Monasca Monitoring Agent (stopping supervisord) monasca-agent\nStarting Monasca Monitoring Agent (using supervisord) monasca-agent\n\n\nAlso should the log.warn above be error?","commit_id":"e27c31a8a2671565ad07bf682fc81baade61f511"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"7938c9a74dc96d67dfda4ed0dd6bfca1e55ac9c9","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                            \u0027The Vertica plugin is not configured. \u0027 \\"},{"line_number":105,"context_line":"                            \u0027Please correct and re-run monasca-setup.\u0027.format(VERTICA_CONF)"},{"line_number":106,"context_line":"            log.error(exception_msg)"},{"line_number":107,"context_line":"            raise Exception(exception_msg)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def build_config(self):"},{"line_number":110,"context_line":"        \"\"\"Build the config as a Plugins object and return."}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_b380f447","line":107,"range":{"start_line":107,"start_character":17,"end_line":107,"end_character":18},"updated":"2016-02-27 01:06:37.000000000","message":"i wonder if we only want the exception below as it will catch if you can not log in. I installed it on mini-mon and ran monasca-reconfigure and i am getting this output \n\nERROR: Error configuring the Vertica check plugin\nTraceback (most recent call last):\n  File \"/opt/monasca/bin/monasca-setup\", line 11, in \u003cmodule\u003e\n    sys.exit(main())\n  File \"/opt/monasca/local/lib/python2.7/site-packages/monasca_setup/main.py\", line 74, in main\n    skip_failed\u003d(args.detection_plugins is None))\n  File \"/opt/monasca/local/lib/python2.7/site-packages/monasca_setup/main.py\", line 239, in plugin_detection\n    new_config \u003d detect.build_config_with_name()\n  File \"/opt/monasca/local/lib/python2.7/site-packages/monasca_setup/detection/plugin.py\", line 52, in build_config_with_name\n    conf \u003d self.build_config()\n  File \"/opt/monasca/lib/python2.7/site-packages/monasca_setup/detection/plugins/vertica.py\", line 138, in build_config\n    raise Exception(exception_msg)\nException: Error configuring the Vertica check plugin\n\nBecause it think it is getting passed arguments (not related to vertica (might be another bug by itself)) \n\nwhat do you think?","commit_id":"5afd5bf318ebf561c1e368742721ebd2282edbc3"}]}