)]}'
{"monasca_agent/collector/checks/collector.py":[{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"6a613f18f8802f5ff5e2ec67145462919108b4fb","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            except Exception:"},{"line_number":155,"context_line":"                log.exception(\"Error running check %s\" % check.name)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"            status_check \u003d check_status.CheckStatus(check.name, instance_statuses, metric_count, 0,"},{"line_number":158,"context_line":"                                                    library_versions\u003dcheck.get_library_info())"},{"line_number":159,"context_line":"            check_statuses.append(status_check)"},{"line_number":160,"context_line":"            sub_collect_duration \u003d sub_timer.step()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_4008ab2c","line":157,"range":{"start_line":157,"start_character":98,"end_line":157,"end_character":99},"updated":"2016-03-16 22:17:26.000000000","message":"Can we put None here? Do we still need this event_count in CheckStatus then?","commit_id":"0f2af82a938897439b37b06e0f11ad5b3a715ee7"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"bd9c54650535318fe1f9236c2c919e541b908bbc","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            except Exception:"},{"line_number":155,"context_line":"                log.exception(\"Error running check %s\" % check.name)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"            status_check \u003d check_status.CheckStatus(check.name, instance_statuses, metric_count, 0,"},{"line_number":158,"context_line":"                                                    library_versions\u003dcheck.get_library_info())"},{"line_number":159,"context_line":"            check_statuses.append(status_check)"},{"line_number":160,"context_line":"            sub_collect_duration \u003d sub_timer.step()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_03150d3f","line":157,"range":{"start_line":157,"start_character":98,"end_line":157,"end_character":99},"in_reply_to":"1af94dfe_4008ab2c","updated":"2016-03-16 22:18:24.000000000","message":"I will look into it good point, was just trying to get something to work real quick","commit_id":"0f2af82a938897439b37b06e0f11ad5b3a715ee7"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"3258fe2e0c9b0052c6db5f965b7a791d8f7f933e","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            except Exception:"},{"line_number":155,"context_line":"                log.exception(\"Error running check %s\" % check.name)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"            status_check \u003d check_status.CheckStatus(check.name, instance_statuses, metric_count,"},{"line_number":158,"context_line":"                                                    library_versions\u003dcheck.get_library_info())"},{"line_number":159,"context_line":"            check_statuses.append(status_check)"},{"line_number":160,"context_line":"            sub_collect_duration \u003d sub_timer.step()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_234be9b1","line":157,"range":{"start_line":157,"start_character":40,"end_line":157,"end_character":51},"updated":"2016-03-16 22:49:43.000000000","message":"It would be good if we could figure out what these objects are for.  From my quick read of it earlier it doesn\u0027t seem like they do anything.","commit_id":"f71565b801eef202d5fd2b4b45baa2224a6160b6"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"1c1d5afdb3e5f09bdc9ab0669f9bedd64e1526b7","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            except Exception:"},{"line_number":155,"context_line":"                log.exception(\"Error running check %s\" % check.name)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"            status_check \u003d check_status.CheckStatus(check.name, instance_statuses, metric_count,"},{"line_number":158,"context_line":"                                                    library_versions\u003dcheck.get_library_info())"},{"line_number":159,"context_line":"            check_statuses.append(status_check)"},{"line_number":160,"context_line":"            sub_collect_duration \u003d sub_timer.step()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_ca421210","line":157,"range":{"start_line":157,"start_character":40,"end_line":157,"end_character":51},"in_reply_to":"1af94dfe_234be9b1","updated":"2016-03-17 02:03:33.000000000","message":"I came to the same conclusion it is not doing anything that we need. I want to remove this along with all windows related classes in the agent. But I was going to do that in a different review. I just want to get our refactor in for our deadline with the least amount of changes. What do you think?","commit_id":"f71565b801eef202d5fd2b4b45baa2224a6160b6"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"b24260c34ebf6784bae2cda9004fc61c8e7e9731","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            except Exception:"},{"line_number":155,"context_line":"                log.exception(\"Error running check %s\" % check.name)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"            status_check \u003d check_status.CheckStatus(check.name, instance_statuses, metric_count,"},{"line_number":158,"context_line":"                                                    library_versions\u003dcheck.get_library_info())"},{"line_number":159,"context_line":"            check_statuses.append(status_check)"},{"line_number":160,"context_line":"            sub_collect_duration \u003d sub_timer.step()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_9d104d03","line":157,"range":{"start_line":157,"start_character":40,"end_line":157,"end_character":51},"in_reply_to":"1af94dfe_ca421210","updated":"2016-03-17 06:34:07.000000000","message":"That sounds fine so long as these things don\u0027t get in the way.","commit_id":"f71565b801eef202d5fd2b4b45baa2224a6160b6"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"3258fe2e0c9b0052c6db5f965b7a791d8f7f933e","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                                                    init_failed_traceback\u003dinfo[\u0027traceback\u0027])"},{"line_number":174,"context_line":"            check_statuses.append(status_check)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        return measurements, emitter_statuses, check_statuses"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def stop(self):"},{"line_number":179,"context_line":"        \"\"\"Tell the collector to stop at the next logical point."}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_83ef5d86","line":176,"range":{"start_line":176,"start_character":47,"end_line":176,"end_character":61},"updated":"2016-03-16 22:49:43.000000000","message":"The ever changing plurality of this variable is really annoying.  If we can\u0027t just get rid of it we should make it consistent.","commit_id":"f71565b801eef202d5fd2b4b45baa2224a6160b6"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"09d090f88100f98fed24febb3a6031bf822d51f8","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                    log.exception(\u0027Error running check.\u0027)"},{"line_number":133,"context_line":"        else:"},{"line_number":134,"context_line":"            for check_type in self._checks:"},{"line_number":135,"context_line":"                metrics_list.extend(check_type.check())"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        # checks_d checks"},{"line_number":138,"context_line":"        checks_d_metrics, checks_d_events, checks_statuses \u003d self.run_checks_d()"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_01afd394","side":"PARENT","line":135,"range":{"start_line":135,"start_character":29,"end_line":135,"end_character":35},"updated":"2016-03-22 14:42:26.000000000","message":"need to investigate if we use this and if it needs to be added back in","commit_id":"32f7c80468a4cf52ac7065244a95451438e6b803"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"3ba6d23f76d0ce8e3b7fa75a3c24e284c24c7c2b","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.run_count +\u003d 1"},{"line_number":103,"context_line":"        log.debug(\"Starting collection run #%s\" % self.run_count)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        timestamp \u003d time.time()"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # checks_d checks"},{"line_number":108,"context_line":"        num_metrics, emitter_statuses, checks_statuses \u003d self.run_checks_d()"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_ab0408c0","line":105,"range":{"start_line":105,"start_character":8,"end_line":105,"end_character":31},"updated":"2016-03-22 14:17:08.000000000","message":"I think this should be moved to where it is used. This will give it an old time which could give the Threshold Engine issues. The longer the collection takes, the more out of date this timestamp will be.","commit_id":"8dfd573bde23eb2a5a1db9ca1b2e0a296aac0902"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"09d090f88100f98fed24febb3a6031bf822d51f8","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.run_count +\u003d 1"},{"line_number":103,"context_line":"        log.debug(\"Starting collection run #%s\" % self.run_count)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        timestamp \u003d time.time()"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # checks_d checks"},{"line_number":108,"context_line":"        num_metrics, emitter_statuses, checks_statuses \u003d self.run_checks_d()"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_81c4835f","line":105,"range":{"start_line":105,"start_character":8,"end_line":105,"end_character":31},"in_reply_to":"fa0719c6_ab0408c0","updated":"2016-03-22 14:42:26.000000000","message":"agreed moving","commit_id":"8dfd573bde23eb2a5a1db9ca1b2e0a296aac0902"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"3ba6d23f76d0ce8e3b7fa75a3c24e284c24c7c2b","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        # checks_d checks"},{"line_number":108,"context_line":"        num_metrics, emitter_statuses, checks_statuses \u003d self.run_checks_d()"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # Store the metrics in the payload."},{"line_number":111,"context_line":"        collect_duration \u003d timer.step()"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        collect_stats \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_eb3720ae","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":43},"updated":"2016-03-22 14:17:08.000000000","message":"This comment doesn\u0027t make sense anymore","commit_id":"8dfd573bde23eb2a5a1db9ca1b2e0a296aac0902"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"09d090f88100f98fed24febb3a6031bf822d51f8","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        # checks_d checks"},{"line_number":108,"context_line":"        num_metrics, emitter_statuses, checks_statuses \u003d self.run_checks_d()"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # Store the metrics in the payload."},{"line_number":111,"context_line":"        collect_duration \u003d timer.step()"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        collect_stats \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_a6771d39","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":43},"in_reply_to":"fa0719c6_eb3720ae","updated":"2016-03-22 14:42:26.000000000","message":"good catch","commit_id":"8dfd573bde23eb2a5a1db9ca1b2e0a296aac0902"}]}