)]}'
{"monasca_agent/collector/checks_d/directory.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"0a008b8895f62c5565900745ee2afeb1fae9b582","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            directory \u003d instance[\"directory\"]"},{"line_number":41,"context_line":"            abs_directory \u003d abspath(directory)"},{"line_number":42,"context_line":"            if not exists(abs_directory) and abs_directory not in non_exist_dir:"},{"line_number":43,"context_line":"                non_exist_dir.update({abs_directory: 1})"},{"line_number":44,"context_line":"                log.error(\"DirectoryCheck: the directory (%s) does not exist\" % abs_directory)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"            dimensions \u003d self._set_dimensions({\"path\": directory}, instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_6fbdc767","line":43,"range":{"start_line":43,"start_character":30,"end_line":43,"end_character":36},"updated":"2016-03-22 20:01:20.000000000","message":"since you are not using the values in the dictionary you could just use a set.","commit_id":"c88a9521056c0e811be5f3eda77c1e3b7b1725e9"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"4ab4e8aad8de3efa393a45d2fee091673831386f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            directory \u003d instance[\"directory\"]"},{"line_number":41,"context_line":"            abs_directory \u003d abspath(directory)"},{"line_number":42,"context_line":"            if not exists(abs_directory) and abs_directory not in non_exist_dir:"},{"line_number":43,"context_line":"                non_exist_dir.update({abs_directory: 1})"},{"line_number":44,"context_line":"                log.error(\"DirectoryCheck: the directory (%s) does not exist\" % abs_directory)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"            dimensions \u003d self._set_dimensions({\"path\": directory}, instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_9224c2af","line":43,"range":{"start_line":43,"start_character":30,"end_line":43,"end_character":36},"in_reply_to":"fa0719c6_6fbdc767","updated":"2016-03-22 20:11:01.000000000","message":"Yes!! set.add will do the same but more clear! Thanks Michael!","commit_id":"c88a9521056c0e811be5f3eda77c1e3b7b1725e9"}]}