)]}'
{"monasca_agent/collector/checks_d/libvirt.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"f68b7fa49720644df7e3a4bd0a8a87ae36b3ab13","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                if ((secgroup[\u0027tenant_id\u0027] \u003d\u003d instance.tenant_id and"},{"line_number":73,"context_line":"                     secgroup[\u0027name\u0027] \u003d\u003d instance_secgroup[\u0027name\u0027])):"},{"line_number":74,"context_line":"                    for rule in secgroup[\u0027security_group_rules\u0027]:"},{"line_number":75,"context_line":"                        remote \u003d rule[\u0027remote_ip_prefix\u0027] if rule[\u0027remote_ip_prefix\u0027] else \u00270.0.0.0/0\u0027"},{"line_number":76,"context_line":"                        if ((rule[\u0027protocol\u0027] \u003d\u003d \u0027icmp\u0027 and"},{"line_number":77,"context_line":"                             all_matching_cidrs(source_ip, [remote]))):"},{"line_number":78,"context_line":"                                return True"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _update_instance_cache(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_75905fed","line":77,"range":{"start_line":75,"start_character":0,"end_line":77,"end_character":71},"updated":"2016-03-28 18:47:50.000000000","message":"I think this would be much clearer if you did:\n\nif ((rule[\u0027protocol\u0027] \u003d\u003d \u0027icmp\u0027:\n  if (not rule[\u0027remote_ip_prefix\u0027] or\n      all_matching_cidrs(source_ip,            \n                                   [rule[\u0027remote_ip_prefix\u0027]])):\n     return True\n\nYour use of 0.0.0.0/0 is just causing all_matching_cidrs to return True anyways, right?","commit_id":"96dfeb788ae1fc2be71214d2023c52cd12096ec2"},{"author":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"change_message_id":"a9235d91d753e4091b4169dd4cd57ffec5093d14","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                if ((secgroup[\u0027tenant_id\u0027] \u003d\u003d instance.tenant_id and"},{"line_number":73,"context_line":"                     secgroup[\u0027name\u0027] \u003d\u003d instance_secgroup[\u0027name\u0027])):"},{"line_number":74,"context_line":"                    for rule in secgroup[\u0027security_group_rules\u0027]:"},{"line_number":75,"context_line":"                        remote \u003d rule[\u0027remote_ip_prefix\u0027] if rule[\u0027remote_ip_prefix\u0027] else \u00270.0.0.0/0\u0027"},{"line_number":76,"context_line":"                        if ((rule[\u0027protocol\u0027] \u003d\u003d \u0027icmp\u0027 and"},{"line_number":77,"context_line":"                             all_matching_cidrs(source_ip, [remote]))):"},{"line_number":78,"context_line":"                                return True"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _update_instance_cache(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_3309df2d","line":77,"range":{"start_line":75,"start_character":0,"end_line":77,"end_character":71},"in_reply_to":"ba0121b8_75905fed","updated":"2016-03-28 19:22:14.000000000","message":"Valid point.  I\u0027ll put up a new patch.","commit_id":"96dfeb788ae1fc2be71214d2023c52cd12096ec2"}]}