)]}'
{"monasca_setup/main.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"20b1267de4ebee5fddd5ba2db7010d7bbea1624d","unresolved":false,"context_lines":[{"line_number":253,"context_line":"       Note there is no concept of overwrite for removal."},{"line_number":254,"context_line":"    :param args: specified arguments"},{"line_number":255,"context_line":"    :param plugin_names: A list of the plugin names to remove from the config"},{"line_number":256,"context_line":"    :return: True if changes, false otherwise"},{"line_number":257,"context_line":"    \"\"\""},{"line_number":258,"context_line":"    existing_config_files \u003d glob(os.path.join(args.config_dir, \u0027conf.d\u0027, \u0027*.yaml\u0027))"},{"line_number":259,"context_line":"    detected_plugins \u003d utils.discover_plugins(CUSTOM_PLUGIN_PATH)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_cc7d24b3","line":256,"range":{"start_line":256,"start_character":4,"end_line":256,"end_character":45},"updated":"2016-03-29 22:45:11.000000000","message":"You are no longer returning anything. The caller expects this to determine whether to restart the agent","commit_id":"e3e5e445dbe7cdf0a0c8deed86049b2e4b9bfcd4"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"1cf82a21d1f266399790dd00be3b32eabba3c864","unresolved":false,"context_lines":[{"line_number":253,"context_line":"       Note there is no concept of overwrite for removal."},{"line_number":254,"context_line":"    :param args: specified arguments"},{"line_number":255,"context_line":"    :param plugin_names: A list of the plugin names to remove from the config"},{"line_number":256,"context_line":"    :return: True if changes, false otherwise"},{"line_number":257,"context_line":"    \"\"\""},{"line_number":258,"context_line":"    existing_config_files \u003d glob(os.path.join(args.config_dir, \u0027conf.d\u0027, \u0027*.yaml\u0027))"},{"line_number":259,"context_line":"    detected_plugins \u003d utils.discover_plugins(CUSTOM_PLUGIN_PATH)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_32f516cb","line":256,"range":{"start_line":256,"start_character":4,"end_line":256,"end_character":45},"in_reply_to":"ba0121b8_cc7d24b3","updated":"2016-03-29 22:57:15.000000000","message":"Good catch! Thank you Craig","commit_id":"e3e5e445dbe7cdf0a0c8deed86049b2e4b9bfcd4"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"be1d9f253ab8a941d6d758cae20aef52c4d71b5d","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        deletes \u003d False"},{"line_number":265,"context_line":"        plugin_name \u003d os.path.splitext(os.path.basename(file_path))[0]"},{"line_number":266,"context_line":"        config \u003d agent_config.read_plugin_config_from_disk(args.config_dir, plugin_name)"},{"line_number":267,"context_line":"        new_instances \u003d []  # To avoid odd issues from iterating over a list you delete from build a new instead"},{"line_number":268,"context_line":"        if args.detection_args is None:"},{"line_number":269,"context_line":"            for inst in config[\u0027instances\u0027]:"},{"line_number":270,"context_line":"                if \u0027built_by\u0027 in inst and inst[\u0027built_by\u0027] in plugin_names:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_e92c4a4c","line":267,"range":{"start_line":267,"start_character":88,"end_line":267,"end_character":98},"updated":"2016-04-05 16:52:35.000000000","message":"\"from, build\" would make this sentence much more readable","commit_id":"7e279cd111284d96f99a49e803a769e2ab379e7a"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"a438c7368aaebf0d41b57cd91559e9d37b8146a4","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                new_instances.append(inst)"},{"line_number":275,"context_line":"            config[\u0027instances\u0027] \u003d new_instances"},{"line_number":276,"context_line":"            if deletes:"},{"line_number":277,"context_line":"                log.info(agent_config.delete_from_config(args, config, file_path, plugin_name))"},{"line_number":278,"context_line":"        else:"},{"line_number":279,"context_line":"            detected_config \u003d plugin_detection("},{"line_number":280,"context_line":"                plugins, args.template_dir, args.detection_args,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a061dce_4169ca8a","line":277,"range":{"start_line":277,"start_character":25,"end_line":277,"end_character":37},"updated":"2016-04-05 17:54:49.000000000","message":"why dont you just log in the method you are calling instead of returning a log message and logging it here?","commit_id":"ed50c858c58acb5ffdee2ca585043b4c499dce9e"}]}