)]}'
{"monasca_agent/collector/checks/services_checks.py":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"85d55bb7f905749609141f3a0ac8403e32c528f7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"import collections"},{"line_number":4,"context_line":"import logging"},{"line_number":5,"context_line":"import multiprocessing"},{"line_number":6,"context_line":"import Queue"},{"line_number":7,"context_line":"import threading"},{"line_number":8,"context_line":"import time"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_771fd0b7","line":6,"range":{"start_line":6,"start_character":7,"end_line":6,"end_character":12},"updated":"2016-04-08 07:18:29.000000000","message":"Just a minor comment.\n\nIs python 3.x supported ? If it does, I think that should be done with try..catch import, because Queue cannot be imported if ran in 3.x python.","commit_id":"c4774ccadbfd66e29bbd94254aa31526460b2dd7"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"df683fdc6e31ccbf4ed67b059e134c4879e6fb82","unresolved":false,"context_lines":[{"line_number":3,"context_line":"import collections"},{"line_number":4,"context_line":"import logging"},{"line_number":5,"context_line":"import multiprocessing"},{"line_number":6,"context_line":"import Queue"},{"line_number":7,"context_line":"import threading"},{"line_number":8,"context_line":"import time"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_619d2159","line":6,"range":{"start_line":6,"start_character":7,"end_line":6,"end_character":12},"in_reply_to":"9a061dce_30ba55c1","updated":"2016-04-08 22:01:47.000000000","message":"Oh...I see now, sorry.\nAs far as I remember currently Py3 is not supported, so just a thing to keep in mind I guess.","commit_id":"c4774ccadbfd66e29bbd94254aa31526460b2dd7"},{"author":{"_account_id":11155,"name":"Ryan Bak","email":"ryan.bak@twcable.com","username":"ryanmbak"},"change_message_id":"46bb609dfc76059b984a5f3d11120973a5ec9673","unresolved":false,"context_lines":[{"line_number":3,"context_line":"import collections"},{"line_number":4,"context_line":"import logging"},{"line_number":5,"context_line":"import multiprocessing"},{"line_number":6,"context_line":"import Queue"},{"line_number":7,"context_line":"import threading"},{"line_number":8,"context_line":"import time"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_30ba55c1","line":6,"range":{"start_line":6,"start_character":7,"end_line":6,"end_character":12},"in_reply_to":"9a061dce_771fd0b7","updated":"2016-04-08 20:28:46.000000000","message":"I could be wrong, but I don\u0027t think OpenStack supports python 3 in general.  Either way this was pre-existing, so that shouldn\u0027t change anything.","commit_id":"c4774ccadbfd66e29bbd94254aa31526460b2dd7"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"f94eaf729c4fcaad93602c3d2067a9c0b870fba9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        The main agent loop will call the check function for each instance for"},{"line_number":33,"context_line":"        each iteration of the loop."},{"line_number":34,"context_line":"        The check method will make an asynchronous call to the _process method in"},{"line_number":35,"context_line":"        one of the thread initiated in the thread pool created in this class constructor."},{"line_number":36,"context_line":"        The _process method will call the _check method of the inherited class"},{"line_number":37,"context_line":"        which will perform the actual check."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_4cf1c494","line":35,"range":{"start_line":35,"start_character":43,"end_line":35,"end_character":49},"updated":"2016-04-07 20:37:16.000000000","message":"update comment","commit_id":"272c22b1384262ee6616185cbcd70ce5b3fa54e6"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"f94eaf729c4fcaad93602c3d2067a9c0b870fba9","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def start_pool(self):"},{"line_number":59,"context_line":"        # The pool size should be the minimum between the number of instances"},{"line_number":60,"context_line":"        # and the DEFAULT_SIZE_POOL. It can also be overridden by the \u0027threads_count\u0027"},{"line_number":61,"context_line":"        # parameter in the init_config of the check"},{"line_number":62,"context_line":"        self.log.info(\"Starting Process Pool\")"},{"line_number":63,"context_line":"        default_size \u003d min(self.instance_count(), DEFAULT_SIZE_POOL)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_2cd730ee","line":60,"range":{"start_line":60,"start_character":71,"end_line":60,"end_character":84},"updated":"2016-04-07 20:37:16.000000000","message":"update this comment to remove threads_count","commit_id":"272c22b1384262ee6616185cbcd70ce5b3fa54e6"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"f94eaf729c4fcaad93602c3d2067a9c0b870fba9","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self.pool_started \u003d True"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def stop_pool(self):"},{"line_number":74,"context_line":"        self.log.info(\"Stopping Thread Pool\")"},{"line_number":75,"context_line":"        if self.pool_started:"},{"line_number":76,"context_line":"            self.pool.terminate()"},{"line_number":77,"context_line":"            self.pool.join()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_ac0fc086","line":74,"range":{"start_line":74,"start_character":32,"end_line":74,"end_character":38},"updated":"2016-04-07 20:37:16.000000000","message":"process pool","commit_id":"272c22b1384262ee6616185cbcd70ce5b3fa54e6"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"3ed109d4cf881b7a4e338a7e3837ea7162818718","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        else:"},{"line_number":99,"context_line":"            self.log.info(\"Instance: %s skipped because it\u0027s already running.\" % name)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def _collect_results(self, result):"},{"line_number":102,"context_line":"        status, msg, name, queue_instance, data \u003d result"},{"line_number":103,"context_line":"        if status \u003d\u003d NO_RESULT:"},{"line_number":104,"context_line":"            del self.jobs_status[name]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_a314a1e8","line":101,"range":{"start_line":101,"start_character":8,"end_line":101,"end_character":24},"updated":"2016-04-07 20:39:45.000000000","message":"i think I would have preferred a method name like _results_callback or _results_handler.","commit_id":"272c22b1384262ee6616185cbcd70ce5b3fa54e6"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"3ed109d4cf881b7a4e338a7e3837ea7162818718","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        # We put the results in the result queue"},{"line_number":197,"context_line":"        return result"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    except Exception:"},{"line_number":200,"context_line":"        log.exception(\u0027Failure in ServiceCheck {0}\u0027.format(name))"},{"line_number":201,"context_line":"        result \u003d (FAILURE, FAILURE, FAILURE, FAILURE, FAILURE)"},{"line_number":202,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_de2b6880","line":199,"range":{"start_line":199,"start_character":11,"end_line":199,"end_character":20},"updated":"2016-04-07 20:39:45.000000000","message":"do you want to catch the exception, for example\n\nexcept Exception as ex:\n\nand log it, to just provide a little more information?","commit_id":"272c22b1384262ee6616185cbcd70ce5b3fa54e6"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"09d0f9baf16e4de026e867e8fc2713cb58a898e6","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    def __init__(self, agent_config\u003dNone):"},{"line_number":171,"context_line":"        super(ServicesStaticCheck, self).__init__(agent_config)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def proxy(self, data, type, *args, **kwargs):"},{"line_number":174,"context_line":"        metric \u003d {"},{"line_number":175,"context_line":"            \u0027metrictype\u0027: type,"},{"line_number":176,"context_line":"            \u0027args\u0027: args,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_412a9de8","line":173,"range":{"start_line":173,"start_character":26,"end_line":173,"end_character":30},"updated":"2016-04-08 22:10:33.000000000","message":"Isn\u0027t a reserved keyword ?","commit_id":"e5ff73f3e45ef46e590fdfaaa968354ff70ac630"},{"author":{"_account_id":11155,"name":"Ryan Bak","email":"ryan.bak@twcable.com","username":"ryanmbak"},"change_message_id":"cf5faf04a548ec901dcb885825193a64079bd589","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    def __init__(self, agent_config\u003dNone):"},{"line_number":171,"context_line":"        super(ServicesStaticCheck, self).__init__(agent_config)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def proxy(self, data, type, *args, **kwargs):"},{"line_number":174,"context_line":"        metric \u003d {"},{"line_number":175,"context_line":"            \u0027metrictype\u0027: type,"},{"line_number":176,"context_line":"            \u0027args\u0027: args,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a1b2928_83a4c857","line":173,"range":{"start_line":173,"start_character":26,"end_line":173,"end_character":30},"in_reply_to":"9a061dce_412a9de8","updated":"2016-04-11 14:32:18.000000000","message":"It works this way, but you\u0027re right I probably should rename this.  I\u0027ll have a patch up shortly.","commit_id":"e5ff73f3e45ef46e590fdfaaa968354ff70ac630"}],"monasca_agent/collector/checks_d/host_alive.py":[{"author":{"_account_id":11515,"name":"Syd Logan","email":"syd.logan@broadcom.com","username":"slogan621"},"change_message_id":"82a9cbf7335f59929b29ecfe44c7448854518ed2","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        ping_prefix \u003d \"ping -c 1 -q \""},{"line_number":68,"context_line":"        if timeout is not None:"},{"line_number":69,"context_line":"            ping_prefix +\u003d \"-W \" + str(timeout) + \" \""},{"line_number":70,"context_line":"        if sys.platform.startswith(\u0027win\u0027):"},{"line_number":71,"context_line":"            ping_prefix \u003d \"ping -n 1 \""},{"line_number":72,"context_line":"            if timeout is not None:"},{"line_number":73,"context_line":"                # On Windows, timeout is in milliseconds"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_4b311c0b","line":70,"updated":"2016-04-06 15:12:44.000000000","message":"Can this code get removed? Or does the agent actually run on a Windows host?","commit_id":"272c22b1384262ee6616185cbcd70ce5b3fa54e6"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"f94eaf729c4fcaad93602c3d2067a9c0b870fba9","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        ping_prefix \u003d \"ping -c 1 -q \""},{"line_number":68,"context_line":"        if timeout is not None:"},{"line_number":69,"context_line":"            ping_prefix +\u003d \"-W \" + str(timeout) + \" \""},{"line_number":70,"context_line":"        if sys.platform.startswith(\u0027win\u0027):"},{"line_number":71,"context_line":"            ping_prefix \u003d \"ping -n 1 \""},{"line_number":72,"context_line":"            if timeout is not None:"},{"line_number":73,"context_line":"                # On Windows, timeout is in milliseconds"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_fe846c5e","line":70,"in_reply_to":"9a061dce_16668050","updated":"2016-04-07 20:37:16.000000000","message":"we are in the process of removing windows support in the review https://review.openstack.org/#/c/295612/ as we are not aware of anyone that uses it and we are under the impression that it as lost support over time since no one is actively testing it under windows. Roland can comment though","commit_id":"272c22b1384262ee6616185cbcd70ce5b3fa54e6"},{"author":{"_account_id":11155,"name":"Ryan Bak","email":"ryan.bak@twcable.com","username":"ryanmbak"},"change_message_id":"a1e8ee9b02bb648d5a504749725ffaedb76363af","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        ping_prefix \u003d \"ping -c 1 -q \""},{"line_number":68,"context_line":"        if timeout is not None:"},{"line_number":69,"context_line":"            ping_prefix +\u003d \"-W \" + str(timeout) + \" \""},{"line_number":70,"context_line":"        if sys.platform.startswith(\u0027win\u0027):"},{"line_number":71,"context_line":"            ping_prefix \u003d \"ping -n 1 \""},{"line_number":72,"context_line":"            if timeout is not None:"},{"line_number":73,"context_line":"                # On Windows, timeout is in milliseconds"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_16668050","line":70,"in_reply_to":"9a061dce_4b311c0b","updated":"2016-04-07 14:41:22.000000000","message":"We don\u0027t run it on Windows, but there might be someone who does.","commit_id":"272c22b1384262ee6616185cbcd70ce5b3fa54e6"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"3ed109d4cf881b7a4e338a7e3837ea7162818718","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        ping_prefix \u003d \"ping -c 1 -q \""},{"line_number":68,"context_line":"        if timeout is not None:"},{"line_number":69,"context_line":"            ping_prefix +\u003d \"-W \" + str(timeout) + \" \""},{"line_number":70,"context_line":"        if sys.platform.startswith(\u0027win\u0027):"},{"line_number":71,"context_line":"            ping_prefix \u003d \"ping -n 1 \""},{"line_number":72,"context_line":"            if timeout is not None:"},{"line_number":73,"context_line":"                # On Windows, timeout is in milliseconds"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_1e432014","line":70,"in_reply_to":"9a061dce_fe846c5e","updated":"2016-04-07 20:39:45.000000000","message":"Yeah, the windows support in the Agent is basically deprecated.","commit_id":"272c22b1384262ee6616185cbcd70ce5b3fa54e6"}]}