)]}'
{"monasca_agent/collector/daemon.py":[{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"6656b723aa9d294e3055d01a7451ab85d556dae3","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            jmxfetch.JMXFetch.stop()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if self.collector:"},{"line_number":61,"context_line":"            self.collector.stop()"},{"line_number":62,"context_line":"        log.debug(\"Collector is stopped.\")"},{"line_number":63,"context_line":"        sys.exit(0)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_1f37d64d","line":61,"range":{"start_line":61,"start_character":27,"end_line":61,"end_character":31},"updated":"2016-05-26 19:58:35.000000000","message":"If the intent here is to exit even if checks are still running won\u0027t we still be waiting here?  The only checks that implement a stop method are the ones inheriting from ServicesCheck and it looks like they still try to shut the threads down cleanly.  Should the exit be above the stop call?","commit_id":"808745139061759dec2b7869a378e7d39892c613"}]}