)]}'
{"monasca_setup/detection/plugins/vcenter.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"84c5241a5e369f8b6fbdc577dc8f47742109d120","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        # we will configure the plugin with given args."},{"line_number":37,"context_line":"        # so, we have to set these below variables"},{"line_number":38,"context_line":"        self.nova_conf \u003d nova_conf"},{"line_number":39,"context_line":"        self.available \u003d True if nova_conf else False"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def build_config(self):"},{"line_number":42,"context_line":"        \"\"\"Build the config as a Plugins object and return back."}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_07e685af","line":39,"range":{"start_line":39,"start_character":33,"end_line":39,"end_character":42},"updated":"2016-05-31 20:03:35.000000000","message":"i wonder if we log in the case that nova_conf is none so the user knows why the detection showed it was not available.","commit_id":"958ea2f7f430dd671aa6f9d36ae26a3d8c0db130"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"fcd58d5b03a4644ef61bd99259364a4325361248","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.available \u003d True"},{"line_number":40,"context_line":"        if not nova_conf:"},{"line_number":41,"context_line":"            self.available \u003d False"},{"line_number":42,"context_line":"            log.info((\u0027Nova-compute configuration is not detected. \u0027"},{"line_number":43,"context_line":"                      \u0027Plugin for VCenter will not be configured.\u0027))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def build_config(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_f0ce2cb6","line":42,"range":{"start_line":42,"start_character":16,"end_line":42,"end_character":20},"updated":"2016-06-02 13:42:46.000000000","message":"the more i think about this i wonder if we have this at error level for the log. What do you think?","commit_id":"2b195fb5b281e2bfce0a86fc0d6527fe6bc41a39"},{"author":{"_account_id":20033,"name":"Artur Basiak","email":"artur.basiak@ts.fujitsu.com","username":"abasiak"},"change_message_id":"e151ff6bbfc9f88bc9befe579eda41e7237eab18","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.available \u003d True"},{"line_number":40,"context_line":"        if not nova_conf:"},{"line_number":41,"context_line":"            self.available \u003d False"},{"line_number":42,"context_line":"            log.info((\u0027Nova-compute configuration is not detected. \u0027"},{"line_number":43,"context_line":"                      \u0027Plugin for VCenter will not be configured.\u0027))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def build_config(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_a5f29604","line":42,"range":{"start_line":42,"start_character":16,"end_line":42,"end_character":20},"in_reply_to":"9abb7d3a_f0ce2cb6","updated":"2016-06-02 17:53:24.000000000","message":"Hmmmm.... Yeah.I think the error level will be better here , because what if\nthere is a process nova-compute but without configuration? So this is an error. To more think about it I need here also check if there is a config file for the process or the args was passed. If the both values are missing there is an error, Because configuration can be passed via config file or args.\nI will change it.\nI will also the same for my other change about supervisord:\nhttps://review.openstack.org/#/c/324381/","commit_id":"2b195fb5b281e2bfce0a86fc0d6527fe6bc41a39"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d0ea685be931893ac71f99e242fc5f7c4bd06099","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.available \u003d True"},{"line_number":40,"context_line":"        if not (nova_conf or self.args):"},{"line_number":41,"context_line":"            self.available \u003d False"},{"line_number":42,"context_line":"            log.error((\u0027Nova-compute configuration is not detected. \u0027"},{"line_number":43,"context_line":"                      \u0027Plugin for VCenter will not be configured.\u0027))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def build_config(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_c1ffa9a8","line":42,"range":{"start_line":42,"start_character":36,"end_line":42,"end_character":37},"updated":"2016-06-06 20:14:42.000000000","message":"I wonder...Micheal posted interesting comment in MySQL detection. Perhaps it would be worth considering here to make error message dependent on nova_conf and args ?\n\nMeaning to say\n\n  self.available \u003d (nova_conf or self._args):\n  if not self.available:\n    if not nova_conf:\n      # no nova configuration\n    elif not self.args:\n      # no nova args\n\nwhere both comments would be swapped with better error message ?","commit_id":"24caf0a8377094ee054edda8e305ab624561f119"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"de35894abe770b7bcaccef3e69ef212c60dab853","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.available \u003d True"},{"line_number":40,"context_line":"        if not (nova_conf or self.args):"},{"line_number":41,"context_line":"            self.available \u003d False"},{"line_number":42,"context_line":"            log.error((\u0027Nova-compute configuration is not detected. \u0027"},{"line_number":43,"context_line":"                      \u0027Plugin for VCenter will not be configured.\u0027))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def build_config(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_bd79ddfe","line":42,"range":{"start_line":42,"start_character":36,"end_line":42,"end_character":37},"in_reply_to":"7aa08908_018c1134","updated":"2016-06-06 23:09:49.000000000","message":"Sounds like a good idea to me too.","commit_id":"24caf0a8377094ee054edda8e305ab624561f119"},{"author":{"_account_id":20033,"name":"Artur Basiak","email":"artur.basiak@ts.fujitsu.com","username":"abasiak"},"change_message_id":"c98b4cea4869aac4f55479b7810ba1b67660142d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.available \u003d True"},{"line_number":40,"context_line":"        if not (nova_conf or self.args):"},{"line_number":41,"context_line":"            self.available \u003d False"},{"line_number":42,"context_line":"            log.error((\u0027Nova-compute configuration is not detected. \u0027"},{"line_number":43,"context_line":"                      \u0027Plugin for VCenter will not be configured.\u0027))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def build_config(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_3642dc68","line":42,"range":{"start_line":42,"start_character":36,"end_line":42,"end_character":37},"in_reply_to":"7aa08908_c1ffa9a8","updated":"2016-06-08 05:05:19.000000000","message":"Done","commit_id":"24caf0a8377094ee054edda8e305ab624561f119"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"a48e84988181da00d98076c092acc53daf933725","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.available \u003d True"},{"line_number":40,"context_line":"        if not (nova_conf or self.args):"},{"line_number":41,"context_line":"            self.available \u003d False"},{"line_number":42,"context_line":"            log.error((\u0027Nova-compute configuration is not detected. \u0027"},{"line_number":43,"context_line":"                      \u0027Plugin for VCenter will not be configured.\u0027))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def build_config(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_e41df773","line":42,"range":{"start_line":42,"start_character":36,"end_line":42,"end_character":37},"in_reply_to":"7aa08908_c1ffa9a8","updated":"2016-06-08 22:09:40.000000000","message":"This would only work if self.available \u003d (nova_conf and self._args)\nDoes not work with the or","commit_id":"24caf0a8377094ee054edda8e305ab624561f119"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"57484594b389831ad84f936847549c82408eaf1e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.available \u003d True"},{"line_number":40,"context_line":"        if not (nova_conf or self.args):"},{"line_number":41,"context_line":"            self.available \u003d False"},{"line_number":42,"context_line":"            log.error((\u0027Nova-compute configuration is not detected. \u0027"},{"line_number":43,"context_line":"                      \u0027Plugin for VCenter will not be configured.\u0027))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def build_config(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_018c1134","line":42,"range":{"start_line":42,"start_character":36,"end_line":42,"end_character":37},"in_reply_to":"7aa08908_c1ffa9a8","updated":"2016-06-06 20:18:37.000000000","message":"i think that is a great idea","commit_id":"24caf0a8377094ee054edda8e305ab624561f119"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"8a601a6aba6828c39f321b06f6a82ae29c4b6991","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        if not self.available:"},{"line_number":41,"context_line":"            if not nova_conf:"},{"line_number":42,"context_line":"                log.error(\u0027Nova-compute configuration was not detected.\u0027)"},{"line_number":43,"context_line":"            elif not self.args:"},{"line_number":44,"context_line":"                log.error(\u0027Nova-compute arguments were not given.\u0027)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def build_config(self):"},{"line_number":47,"context_line":"        \"\"\"Build the config as a Plugins object and return back."}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_84619307","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":67},"updated":"2016-06-08 22:08:53.000000000","message":"This will never be executed. If nova_conf is set to not None, then self.available will be True. There is only one error message which is the combination of the two above.","commit_id":"7660a578c3990640661cb8cf1f0a4680af3e4509"},{"author":{"_account_id":20033,"name":"Artur Basiak","email":"artur.basiak@ts.fujitsu.com","username":"abasiak"},"change_message_id":"37c32c9ce815e35598e4bab4b5bca892105c070e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        if not self.available:"},{"line_number":41,"context_line":"            if not nova_conf:"},{"line_number":42,"context_line":"                log.error(\u0027Nova-compute configuration was not detected.\u0027)"},{"line_number":43,"context_line":"            elif not self.args:"},{"line_number":44,"context_line":"                log.error(\u0027Nova-compute arguments were not given.\u0027)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def build_config(self):"},{"line_number":47,"context_line":"        \"\"\"Build the config as a Plugins object and return back."}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_19db3a7d","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":67},"in_reply_to":"7aa08908_84619307","updated":"2016-06-09 09:16:16.000000000","message":"I agree with you. I created new patch where at first a check if nova-compute process exist and after that check if config file exist or args were given. I also combined those two messages into one.","commit_id":"7660a578c3990640661cb8cf1f0a4680af3e4509"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"32c42cc4ea1c555355374360f5c06a2c8b829ba7","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            if not process_exist:"},{"line_number":47,"context_line":"                log.error(\u0027Nova-compute process does not exist.\u0027)"},{"line_number":48,"context_line":"            elif not has_config_file_or_args:"},{"line_number":49,"context_line":"                log.error((\u0027Nova-compute process exist but \u0027"},{"line_number":50,"context_line":"                           \u0027configuration file was not detected and no \u0027"},{"line_number":51,"context_line":"                           \u0027arguments were given.\u0027))"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_081d7466","line":49,"range":{"start_line":49,"start_character":49,"end_line":49,"end_character":54},"updated":"2016-06-09 22:29:51.000000000","message":"exists","commit_id":"84dac90cdb0f491753973f9aecaffa09c22b54c6"},{"author":{"_account_id":20033,"name":"Artur Basiak","email":"artur.basiak@ts.fujitsu.com","username":"abasiak"},"change_message_id":"c0261192a77baf90dc76b008844933b0e633a03e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            if not process_exist:"},{"line_number":47,"context_line":"                log.error(\u0027Nova-compute process does not exist.\u0027)"},{"line_number":48,"context_line":"            elif not has_config_file_or_args:"},{"line_number":49,"context_line":"                log.error((\u0027Nova-compute process exist but \u0027"},{"line_number":50,"context_line":"                           \u0027configuration file was not detected and no \u0027"},{"line_number":51,"context_line":"                           \u0027arguments were given.\u0027))"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_d5a49c09","line":49,"range":{"start_line":49,"start_character":49,"end_line":49,"end_character":54},"in_reply_to":"7aa08908_081d7466","updated":"2016-06-10 05:02:41.000000000","message":"Done","commit_id":"84dac90cdb0f491753973f9aecaffa09c22b54c6"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"32c42cc4ea1c555355374360f5c06a2c8b829ba7","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                log.error(\u0027Nova-compute process does not exist.\u0027)"},{"line_number":48,"context_line":"            elif not has_config_file_or_args:"},{"line_number":49,"context_line":"                log.error((\u0027Nova-compute process exist but \u0027"},{"line_number":50,"context_line":"                           \u0027configuration file was not detected and no \u0027"},{"line_number":51,"context_line":"                           \u0027arguments were given.\u0027))"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def build_config(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_e819087b","line":50,"range":{"start_line":50,"start_character":28,"end_line":50,"end_character":41},"updated":"2016-06-09 22:29:51.000000000","message":"the configuration file","commit_id":"84dac90cdb0f491753973f9aecaffa09c22b54c6"},{"author":{"_account_id":20033,"name":"Artur Basiak","email":"artur.basiak@ts.fujitsu.com","username":"abasiak"},"change_message_id":"c0261192a77baf90dc76b008844933b0e633a03e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                log.error(\u0027Nova-compute process does not exist.\u0027)"},{"line_number":48,"context_line":"            elif not has_config_file_or_args:"},{"line_number":49,"context_line":"                log.error((\u0027Nova-compute process exist but \u0027"},{"line_number":50,"context_line":"                           \u0027configuration file was not detected and no \u0027"},{"line_number":51,"context_line":"                           \u0027arguments were given.\u0027))"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def build_config(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_b5a910e2","line":50,"range":{"start_line":50,"start_character":28,"end_line":50,"end_character":41},"in_reply_to":"7aa08908_e819087b","updated":"2016-06-10 05:02:41.000000000","message":"Done","commit_id":"84dac90cdb0f491753973f9aecaffa09c22b54c6"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"8bf5b9685a1cf2a01e68bf06b70db5199bad2cf3","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            elif not has_config_file_or_args:"},{"line_number":49,"context_line":"                log.error((\u0027Nova-compute process exist but \u0027"},{"line_number":50,"context_line":"                           \u0027configuration file was not detected and no \u0027"},{"line_number":51,"context_line":"                           \u0027arguments were given.\u0027))"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def build_config(self):"},{"line_number":54,"context_line":"        \"\"\"Build the config as a Plugins object and return back."}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_8c133f0d","line":51,"range":{"start_line":51,"start_character":28,"end_line":51,"end_character":37},"updated":"2016-06-10 20:44:24.000000000","message":"I was wonder if we should make a helpers.py or utils.py file for some of this code that is looking commong. For example, the above lines from 42-51 look similar to the https://review.openstack.org/#/c/325239/5/monasca_setup/detection/plugins/mysql.py, lines 4-51.","commit_id":"84dac90cdb0f491753973f9aecaffa09c22b54c6"},{"author":{"_account_id":20033,"name":"Artur Basiak","email":"artur.basiak@ts.fujitsu.com","username":"abasiak"},"change_message_id":"6398711e230648935c3a504f836864dcea907b13","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            elif not has_config_file_or_args:"},{"line_number":49,"context_line":"                log.error((\u0027Nova-compute process exist but \u0027"},{"line_number":50,"context_line":"                           \u0027configuration file was not detected and no \u0027"},{"line_number":51,"context_line":"                           \u0027arguments were given.\u0027))"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def build_config(self):"},{"line_number":54,"context_line":"        \"\"\"Build the config as a Plugins object and return back."}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_7b0bc824","line":51,"range":{"start_line":51,"start_character":28,"end_line":51,"end_character":37},"in_reply_to":"7aa08908_8c133f0d","updated":"2016-06-13 05:09:28.000000000","message":"I agree. Maybe lets merge those changes and after that I will try to refactor the code.","commit_id":"84dac90cdb0f491753973f9aecaffa09c22b54c6"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"4ef705a8747f836fd05a9a5e6d96779d5a28388c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.available \u003d process_exist and has_config_file_or_args"},{"line_number":45,"context_line":"        if not self.available:"},{"line_number":46,"context_line":"            if not process_exist:"},{"line_number":47,"context_line":"                log.error(\u0027Nova-compute process does not exist.\u0027)"},{"line_number":48,"context_line":"            elif not has_config_file_or_args:"},{"line_number":49,"context_line":"                log.error((\u0027Nova-compute process exists but \u0027"},{"line_number":50,"context_line":"                           \u0027the configuration file was not detected and no \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_d504f54a","line":47,"range":{"start_line":47,"start_character":20,"end_line":47,"end_character":25},"updated":"2016-06-14 15:31:08.000000000","message":"Can you maybe move this log.error right after line 37 with \"else\"?","commit_id":"0ac45021a52b095c51582bf9a71c410d10b71922"},{"author":{"_account_id":20033,"name":"Artur Basiak","email":"artur.basiak@ts.fujitsu.com","username":"abasiak"},"change_message_id":"c78550a304ff9ae9b9e1cbb0db89d09e6683d117","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.available \u003d process_exist and has_config_file_or_args"},{"line_number":45,"context_line":"        if not self.available:"},{"line_number":46,"context_line":"            if not process_exist:"},{"line_number":47,"context_line":"                log.error(\u0027Nova-compute process does not exist.\u0027)"},{"line_number":48,"context_line":"            elif not has_config_file_or_args:"},{"line_number":49,"context_line":"                log.error((\u0027Nova-compute process exists but \u0027"},{"line_number":50,"context_line":"                           \u0027the configuration file was not detected and no \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_d420579c","line":47,"range":{"start_line":47,"start_character":20,"end_line":47,"end_character":25},"in_reply_to":"7aa08908_d504f54a","updated":"2016-06-15 06:03:20.000000000","message":"Could you look on the others changes about detection? I think the best idea is to stay with the way it is right now. In first step we are checking if the process exists and if configuration exists. In the second step we are loggin exception if available is False. This idea of this type of logging was agreed earlier. \nI will refactor the code in lines 26-37 and move it to new method","commit_id":"0ac45021a52b095c51582bf9a71c410d10b71922"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"4ef705a8747f836fd05a9a5e6d96779d5a28388c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            if not process_exist:"},{"line_number":47,"context_line":"                log.error(\u0027Nova-compute process does not exist.\u0027)"},{"line_number":48,"context_line":"            elif not has_config_file_or_args:"},{"line_number":49,"context_line":"                log.error((\u0027Nova-compute process exists but \u0027"},{"line_number":50,"context_line":"                           \u0027the configuration file was not detected and no \u0027"},{"line_number":51,"context_line":"                           \u0027arguments were given.\u0027))"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_5565a51b","line":49,"range":{"start_line":49,"start_character":20,"end_line":49,"end_character":25},"updated":"2016-06-14 15:31:08.000000000","message":"I think you can move this after line 43. So you can avoid the if... if... elif here.","commit_id":"0ac45021a52b095c51582bf9a71c410d10b71922"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d97da2627e731d7d05fe60191d2071b1b7f70251","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        \"\"\""},{"line_number":58,"context_line":"        config \u003d monasca_setup.agent_config.Plugins()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if self.dependencies_installed():"},{"line_number":61,"context_line":"            nova_cfg \u003d ConfigParser.SafeConfigParser()"},{"line_number":62,"context_line":"            instance \u003d {}"},{"line_number":63,"context_line":"            if self.nova_conf is None:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_62ee65ee","line":60,"updated":"2016-06-17 18:34:15.000000000","message":"Can we also move dependencies_installed to _detect here ?","commit_id":"a73be88ec3f94a6857201271779e6a56d19c92c8"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"449d2c7e74b1fbea95f4710b15475a88ee544364","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        \"\"\""},{"line_number":58,"context_line":"        config \u003d monasca_setup.agent_config.Plugins()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if self.dependencies_installed():"},{"line_number":61,"context_line":"            nova_cfg \u003d ConfigParser.SafeConfigParser()"},{"line_number":62,"context_line":"            instance \u003d {}"},{"line_number":63,"context_line":"            if self.nova_conf is None:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a9d85d2_b562d2d6","line":60,"in_reply_to":"5a9d85d2_fbec5291","updated":"2016-06-20 09:40:46.000000000","message":"Fine with me.","commit_id":"a73be88ec3f94a6857201271779e6a56d19c92c8"},{"author":{"_account_id":20033,"name":"Artur Basiak","email":"artur.basiak@ts.fujitsu.com","username":"abasiak"},"change_message_id":"d7b530d0bedad82f91893506aff06e94aaadf91e","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        \"\"\""},{"line_number":58,"context_line":"        config \u003d monasca_setup.agent_config.Plugins()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if self.dependencies_installed():"},{"line_number":61,"context_line":"            nova_cfg \u003d ConfigParser.SafeConfigParser()"},{"line_number":62,"context_line":"            instance \u003d {}"},{"line_number":63,"context_line":"            if self.nova_conf is None:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a9d85d2_fbec5291","line":60,"in_reply_to":"7aa08908_62ee65ee","updated":"2016-06-20 05:17:04.000000000","message":"This method is only implemented and always return True. The solution same is made in other checks, so maybe let it stay like this. If some extra module will be needed to import that will helps with check this method should be moved to _dected.","commit_id":"a73be88ec3f94a6857201271779e6a56d19c92c8"}]}