)]}'
{"conf.d/hypervisor.yaml.example":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"ec1eca8bd1c2e28682fdf5f2d8dcc8769464fcd2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    identity_uri: \u0027http://192.168.10.5:35357/v2.0\u0027"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    # Location of temporary files maintained by the plugin.  Ramdisk preferred."},{"line_number":16,"context_line":"    cache_dir: /dev/shm"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    # How long to wait before querying Nova for instance updates? (seconds)"},{"line_number":19,"context_line":"    # Note that there is an automatic refresh if new instances are encountered."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7aa08908_8a3e18d8","line":16,"updated":"2016-06-07 19:47:56.000000000","message":"Just wondering if there is a recommended location for on win32?","commit_id":"c4f9c309ace1e67adc514afba33bbd468049ec1e"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"b21faf77ed339c30824ee53ccb58eddcf45af121","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    identity_uri: \u0027http://192.168.10.5:35357/v2.0\u0027"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    # Location of temporary files maintained by the plugin.  Ramdisk preferred."},{"line_number":16,"context_line":"    cache_dir: /dev/shm"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    # How long to wait before querying Nova for instance updates? (seconds)"},{"line_number":19,"context_line":"    # Note that there is an automatic refresh if new instances are encountered."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7aa08908_4893235d","line":16,"in_reply_to":"7aa08908_8a3e18d8","updated":"2016-06-15 09:19:42.000000000","message":"Done","commit_id":"c4f9c309ace1e67adc514afba33bbd468049ec1e"}],"monasca_agent/collector/checks_d/hyperv.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"ec1eca8bd1c2e28682fdf5f2d8dcc8769464fcd2","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class HyperVCheck(hypervisor.HypervisorCheck):"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    \"\"\"Inherit Agent class and gather Hyper-V metrics\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    HYPERVISOR_NAME \u003d \u0027hyperv\u0027"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_f25d1248","line":35,"range":{"start_line":35,"start_character":15,"end_line":35,"end_character":20},"updated":"2016-06-07 19:47:56.000000000","message":"Actually inheriting from HypervisorCheck, not Agent.","commit_id":"c4f9c309ace1e67adc514afba33bbd468049ec1e"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"b21faf77ed339c30824ee53ccb58eddcf45af121","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class HyperVCheck(hypervisor.HypervisorCheck):"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    \"\"\"Inherit Agent class and gather Hyper-V metrics\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    HYPERVISOR_NAME \u003d \u0027hyperv\u0027"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_08a91b91","line":35,"range":{"start_line":35,"start_character":15,"end_line":35,"end_character":20},"in_reply_to":"7aa08908_f25d1248","updated":"2016-06-15 09:19:42.000000000","message":"Done","commit_id":"c4f9c309ace1e67adc514afba33bbd468049ec1e"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"ec1eca8bd1c2e28682fdf5f2d8dcc8769464fcd2","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    \"\"\"Inherit Agent class and gather Hyper-V metrics\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    HYPERVISOR_NAME \u003d \u0027hyperv\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def _inspect_state(self, inst, instance_cache, dims_customer, dims_operations):"},{"line_number":40,"context_line":"        \"\"\"Look at the state of the instance, publish a metric using a"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_d239f6f3","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":19},"updated":"2016-06-07 19:47:56.000000000","message":"Is this use anywhere? Should you declare a method \"get_name\" to return the hypervisor name?\n\nShould this really bye \"HYPERVISOR_TYPE\"?","commit_id":"c4f9c309ace1e67adc514afba33bbd468049ec1e"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"b21faf77ed339c30824ee53ccb58eddcf45af121","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    \"\"\"Inherit Agent class and gather Hyper-V metrics\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    HYPERVISOR_NAME \u003d \u0027hyperv\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def _inspect_state(self, inst, instance_cache, dims_customer, dims_operations):"},{"line_number":40,"context_line":"        \"\"\"Look at the state of the instance, publish a metric using a"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_a891e748","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":19},"in_reply_to":"7aa08908_d239f6f3","updated":"2016-06-15 09:19:42.000000000","message":"yeah, it is used in the hypervisor checker, in the constructor. \n\nHYPERVISOR_TYPE sounds better.","commit_id":"c4f9c309ace1e67adc514afba33bbd468049ec1e"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"ec1eca8bd1c2e28682fdf5f2d8dcc8769464fcd2","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    HYPERVISOR_NAME \u003d \u0027hyperv\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def _inspect_state(self, inst, instance_cache, dims_customer, dims_operations):"},{"line_number":40,"context_line":"        \"\"\"Look at the state of the instance, publish a metric using a"},{"line_number":41,"context_line":"           user-friendly description in the \u0027detail\u0027 metadata, and return"},{"line_number":42,"context_line":"           a status code (calibrated to UNIX status codes where 0 is OK)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_d2245661","line":39,"updated":"2016-06-07 19:47:56.000000000","message":"As I reviewed this I thought a more descriptive method name would be \"lifecycle_state\". \n\nI was also wondering if we should remove or change to _inspect prefix. _lifecycle_state or _get_lifecycle_state, might be clearer.","commit_id":"c4f9c309ace1e67adc514afba33bbd468049ec1e"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"b21faf77ed339c30824ee53ccb58eddcf45af121","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    HYPERVISOR_NAME \u003d \u0027hyperv\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def _inspect_state(self, inst, instance_cache, dims_customer, dims_operations):"},{"line_number":40,"context_line":"        \"\"\"Look at the state of the instance, publish a metric using a"},{"line_number":41,"context_line":"           user-friendly description in the \u0027detail\u0027 metadata, and return"},{"line_number":42,"context_line":"           a status code (calibrated to UNIX status codes where 0 is OK)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_68ed3fb7","line":39,"in_reply_to":"7aa08908_d2245661","updated":"2016-06-15 09:19:42.000000000","message":"yeah, sounds better, but this can be addressed in another patch, IMO.","commit_id":"c4f9c309ace1e67adc514afba33bbd468049ec1e"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"ec1eca8bd1c2e28682fdf5f2d8dcc8769464fcd2","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        inst_name \u003d inst.name"},{"line_number":47,"context_line":"        inst_state \u003d self.inspector.inspect_state(inst)"},{"line_number":48,"context_line":"        dom_status \u003d (0 if inst_state \u003d\u003d constants.HYPERV_VM_STATE_ENABLED"},{"line_number":49,"context_line":"                      else inst_state)"},{"line_number":50,"context_line":"        metatag \u003d None"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if inst_state in VM_STATES:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_f2e6b213","line":49,"range":{"start_line":49,"start_character":22,"end_line":49,"end_character":26},"updated":"2016-06-07 19:47:56.000000000","message":"\"inst\" seems clear enough, but I dont\u0027 know what \"dom\" is supposed to mean.","commit_id":"c4f9c309ace1e67adc514afba33bbd468049ec1e"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"b21faf77ed339c30824ee53ccb58eddcf45af121","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        inst_name \u003d inst.name"},{"line_number":47,"context_line":"        inst_state \u003d self.inspector.inspect_state(inst)"},{"line_number":48,"context_line":"        dom_status \u003d (0 if inst_state \u003d\u003d constants.HYPERV_VM_STATE_ENABLED"},{"line_number":49,"context_line":"                      else inst_state)"},{"line_number":50,"context_line":"        metatag \u003d None"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if inst_state in VM_STATES:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_c8b393eb","line":49,"range":{"start_line":49,"start_character":22,"end_line":49,"end_character":26},"in_reply_to":"7aa08908_f2e6b213","updated":"2016-06-15 09:19:42.000000000","message":"Done","commit_id":"c4f9c309ace1e67adc514afba33bbd468049ec1e"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"ec1eca8bd1c2e28682fdf5f2d8dcc8769464fcd2","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        metatag \u003d None"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if inst_state in VM_STATES:"},{"line_number":53,"context_line":"            metatag \u003d {\u0027detail\u0027: VM_STATES[inst_state]}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self.gauge(\u0027host_alive_status\u0027, dom_status, dimensions\u003ddims_customer,"},{"line_number":56,"context_line":"                   delegated_tenant\u003dinstance_cache.get(inst_name)[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_1257fe58","line":53,"range":{"start_line":53,"start_character":24,"end_line":53,"end_character":30},"updated":"2016-06-07 19:47:56.000000000","message":"Just wondering if you wanted to convert this to \n\nmetatag \u003d VM_STATES.get(inst_state)","commit_id":"c4f9c309ace1e67adc514afba33bbd468049ec1e"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"b21faf77ed339c30824ee53ccb58eddcf45af121","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        metatag \u003d None"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if inst_state in VM_STATES:"},{"line_number":53,"context_line":"            metatag \u003d {\u0027detail\u0027: VM_STATES[inst_state]}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self.gauge(\u0027host_alive_status\u0027, dom_status, dimensions\u003ddims_customer,"},{"line_number":56,"context_line":"                   delegated_tenant\u003dinstance_cache.get(inst_name)[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_28ccd760","line":53,"range":{"start_line":53,"start_character":24,"end_line":53,"end_character":30},"in_reply_to":"7aa08908_1257fe58","updated":"2016-06-15 09:19:42.000000000","message":"libvirt does it in a similar fashion:\n\n    metatag \u003d {\u0027detail\u0027: DOM_STATES[inst_state[0]]}","commit_id":"c4f9c309ace1e67adc514afba33bbd468049ec1e"}]}