)]}'
{"monasca_agent/collector/checks_d/libvirt.py":[{"author":{"_account_id":10781,"name":"selvakumar","email":"selvakumar.s2@hpe.com","username":"selvakumar"},"change_message_id":"aa1f32d4f0f4e8c1b5eb727c1f2a84934cf804fc","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                            \"tx\", metric_map[\"tx\"]).replace("},{"line_number":71,"context_line":"                                            \"rx\", metric_map[\"rx\"])"},{"line_number":72,"context_line":"        if self.init_config.get(\u0027network_use_bits\u0027):"},{"line_number":73,"context_line":"            val \u003d value * 8"},{"line_number":74,"context_line":"            metric_name.replace(\"bytes\", \"bits\")"},{"line_number":75,"context_line":"        return metric_name"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_59f094fe","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":12},"updated":"2016-06-07 17:32:56.000000000","message":"This code will give error for value as it is not defined","commit_id":"50193fc5bb8824e8fc8b5fbee959eb6e453cfc41"},{"author":{"_account_id":10781,"name":"selvakumar","email":"selvakumar.s2@hpe.com","username":"selvakumar"},"change_message_id":"aa1f32d4f0f4e8c1b5eb727c1f2a84934cf804fc","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                                            \"rx\", metric_map[\"rx\"])"},{"line_number":72,"context_line":"        if self.init_config.get(\u0027network_use_bits\u0027):"},{"line_number":73,"context_line":"            val \u003d value * 8"},{"line_number":74,"context_line":"            metric_name.replace(\"bytes\", \"bits\")"},{"line_number":75,"context_line":"        return metric_name"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_99f67cf7","line":74,"range":{"start_line":74,"start_character":12,"end_line":74,"end_character":23},"updated":"2016-06-07 17:32:56.000000000","message":"also val is not used anywhere","commit_id":"50193fc5bb8824e8fc8b5fbee959eb6e453cfc41"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"83e789a308dbf52a48029bf1b0d9be44b4a980f2","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @staticmethod"},{"line_number":67,"context_line":"    def _get_metric_name(self, orig_name):"},{"line_number":68,"context_line":"        metric_map \u003d {\"tx\": \"out\", \"rx\": \"in\"}"},{"line_number":69,"context_line":"        metric_name \u003d orig_name.replace(\"tx\", metric_map[\"tx\"]).replace(\"rx\","},{"line_number":70,"context_line":"                                                                        metric_map[\"rx\"])"},{"line_number":71,"context_line":"        if self.init_config.get(\u0027network_use_bits\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_cfa2f298","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":46},"updated":"2016-06-07 18:22:30.000000000","message":"Code would be simpler without metric_map","commit_id":"a45c0525258af976253ed3423d929a85245ba49a"},{"author":{"_account_id":15130,"name":"Sonu","email":"sonu.sudhakaran@gmail.com","username":"sonu"},"change_message_id":"8b3cf4936e8fa573cbfb66a9f5300c1204300d36","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @staticmethod"},{"line_number":67,"context_line":"    def _get_metric_name(self, orig_name):"},{"line_number":68,"context_line":"        metric_map \u003d {\"tx\": \"out\", \"rx\": \"in\"}"},{"line_number":69,"context_line":"        metric_name \u003d orig_name.replace(\"tx\", metric_map[\"tx\"]).replace(\"rx\","},{"line_number":70,"context_line":"                                                                        metric_map[\"rx\"])"},{"line_number":71,"context_line":"        if self.init_config.get(\u0027network_use_bits\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_c8501735","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":46},"in_reply_to":"7aa08908_cfa2f298","updated":"2016-06-08 03:52:57.000000000","message":"Done","commit_id":"a45c0525258af976253ed3423d929a85245ba49a"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"83e789a308dbf52a48029bf1b0d9be44b4a980f2","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                    # gets converted to \"net.rx_bytes_sec\""},{"line_number":296,"context_line":"                    rate_name \u003d self._get_metric_rate_name(metric_name)"},{"line_number":297,"context_line":"                    # Rename \"tx\" to \"out\" and \"rx\" to \"in\""},{"line_number":298,"context_line":"                    rate_name \u003d self._get_metric_name(rate_name)"},{"line_number":299,"context_line":"                    # Customer"},{"line_number":300,"context_line":"                    this_dimensions \u003d vnic_dimensions.copy()"},{"line_number":301,"context_line":"                    this_dimensions.update(dims_customer)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_6f149e9f","line":298,"range":{"start_line":298,"start_character":20,"end_line":298,"end_character":64},"updated":"2016-06-07 18:22:30.000000000","message":"You removed this line:\nval_diff \u003d val_diff * 8\nso your code computes the wrong value if network_use_bits is set","commit_id":"a45c0525258af976253ed3423d929a85245ba49a"},{"author":{"_account_id":15130,"name":"Sonu","email":"sonu.sudhakaran@gmail.com","username":"sonu"},"change_message_id":"8b3cf4936e8fa573cbfb66a9f5300c1204300d36","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                    # gets converted to \"net.rx_bytes_sec\""},{"line_number":296,"context_line":"                    rate_name \u003d self._get_metric_rate_name(metric_name)"},{"line_number":297,"context_line":"                    # Rename \"tx\" to \"out\" and \"rx\" to \"in\""},{"line_number":298,"context_line":"                    rate_name \u003d self._get_metric_name(rate_name)"},{"line_number":299,"context_line":"                    # Customer"},{"line_number":300,"context_line":"                    this_dimensions \u003d vnic_dimensions.copy()"},{"line_number":301,"context_line":"                    this_dimensions.update(dims_customer)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_2839dbf2","line":298,"range":{"start_line":298,"start_character":20,"end_line":298,"end_character":64},"in_reply_to":"7aa08908_6f149e9f","updated":"2016-06-08 03:52:57.000000000","message":"Thank you.","commit_id":"a45c0525258af976253ed3423d929a85245ba49a"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"83e789a308dbf52a48029bf1b0d9be44b4a980f2","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                # Customer"},{"line_number":314,"context_line":"                this_dimensions \u003d vnic_dimensions.copy()"},{"line_number":315,"context_line":"                this_dimensions.update(dims_customer)"},{"line_number":316,"context_line":"                self.gauge(raw_name, value,"},{"line_number":317,"context_line":"                           dimensions\u003dthis_dimensions,"},{"line_number":318,"context_line":"                           delegated_tenant\u003dinstance_cache.get(inst_name)[\u0027tenant_id\u0027],"},{"line_number":319,"context_line":"                           hostname\u003dinstance_cache.get(inst_name)[\u0027hostname\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_4f67224d","line":316,"range":{"start_line":316,"start_character":37,"end_line":316,"end_character":42},"updated":"2016-06-07 18:22:30.000000000","message":"value is not computed properly if network_use_bits is set","commit_id":"a45c0525258af976253ed3423d929a85245ba49a"},{"author":{"_account_id":15130,"name":"Sonu","email":"sonu.sudhakaran@gmail.com","username":"sonu"},"change_message_id":"8b3cf4936e8fa573cbfb66a9f5300c1204300d36","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                # Customer"},{"line_number":314,"context_line":"                this_dimensions \u003d vnic_dimensions.copy()"},{"line_number":315,"context_line":"                this_dimensions.update(dims_customer)"},{"line_number":316,"context_line":"                self.gauge(raw_name, value,"},{"line_number":317,"context_line":"                           dimensions\u003dthis_dimensions,"},{"line_number":318,"context_line":"                           delegated_tenant\u003dinstance_cache.get(inst_name)[\u0027tenant_id\u0027],"},{"line_number":319,"context_line":"                           hostname\u003dinstance_cache.get(inst_name)[\u0027hostname\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_682763ca","line":316,"range":{"start_line":316,"start_character":37,"end_line":316,"end_character":42},"in_reply_to":"7aa08908_4f67224d","updated":"2016-06-08 03:52:57.000000000","message":"Thank you. Done.","commit_id":"a45c0525258af976253ed3423d929a85245ba49a"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"3b87202f30240f446adfba2d086098bbba616734","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                        continue"},{"line_number":306,"context_line":"                    rate_name \u003d self._get_metric_rate_name(metric_name)"},{"line_number":307,"context_line":"                    rate_name \u003d self._get_metric_name(rate_name)"},{"line_number":308,"context_line":"                    val_diff \u003d val_diff * 8 if self.use_bits else val_diff"},{"line_number":309,"context_line":"                    # Customer"},{"line_number":310,"context_line":"                    this_dimensions \u003d vnic_dimensions.copy()"},{"line_number":311,"context_line":"                    this_dimensions.update(dims_customer)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_16ea4074","line":308,"range":{"start_line":308,"start_character":20,"end_line":308,"end_character":74},"updated":"2016-06-13 16:08:23.000000000","message":"This is truly more readable as:\nif self.use_bits:\n   val_diff *\u003d 8","commit_id":"ddfe031bedc9619f5f6779e4c0854b77233a1450"},{"author":{"_account_id":10781,"name":"selvakumar","email":"selvakumar.s2@hpe.com","username":"selvakumar"},"change_message_id":"9930bfeadab56550ec22ed5fd91c99ed073eeceb","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                        continue"},{"line_number":306,"context_line":"                    rate_name \u003d self._get_metric_rate_name(metric_name)"},{"line_number":307,"context_line":"                    rate_name \u003d self._get_metric_name(rate_name)"},{"line_number":308,"context_line":"                    val_diff \u003d val_diff * 8 if self.use_bits else val_diff"},{"line_number":309,"context_line":"                    # Customer"},{"line_number":310,"context_line":"                    this_dimensions \u003d vnic_dimensions.copy()"},{"line_number":311,"context_line":"                    this_dimensions.update(dims_customer)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_7778dec4","line":308,"range":{"start_line":308,"start_character":20,"end_line":308,"end_character":74},"in_reply_to":"7aa08908_16ea4074","updated":"2016-06-13 17:17:23.000000000","message":"Done","commit_id":"ddfe031bedc9619f5f6779e4c0854b77233a1450"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"3b87202f30240f446adfba2d086098bbba616734","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                               dimensions\u003dthis_dimensions)"},{"line_number":321,"context_line":"                # Report raw counters."},{"line_number":322,"context_line":"                mapped_name \u003d self._get_metric_name(metric_name)"},{"line_number":323,"context_line":"                weighted_value \u003d value * 8 if self.use_bits else value"},{"line_number":324,"context_line":"                # Customer"},{"line_number":325,"context_line":"                this_dimensions \u003d vnic_dimensions.copy()"},{"line_number":326,"context_line":"                this_dimensions.update(dims_customer)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_36793c83","line":323,"range":{"start_line":323,"start_character":16,"end_line":323,"end_character":70},"updated":"2016-06-13 16:08:23.000000000","message":"This is truly more readable as:\nif self.use_bits:\n   weighted_value \u003d value * 8","commit_id":"ddfe031bedc9619f5f6779e4c0854b77233a1450"},{"author":{"_account_id":10781,"name":"selvakumar","email":"selvakumar.s2@hpe.com","username":"selvakumar"},"change_message_id":"916bbcefb1397bc46c4b007909017748704ef9a1","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                               dimensions\u003dthis_dimensions)"},{"line_number":321,"context_line":"                # Report raw counters."},{"line_number":322,"context_line":"                mapped_name \u003d self._get_metric_name(metric_name)"},{"line_number":323,"context_line":"                weighted_value \u003d value * 8 if self.use_bits else value"},{"line_number":324,"context_line":"                # Customer"},{"line_number":325,"context_line":"                this_dimensions \u003d vnic_dimensions.copy()"},{"line_number":326,"context_line":"                this_dimensions.update(dims_customer)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_c9e9361c","line":323,"range":{"start_line":323,"start_character":16,"end_line":323,"end_character":70},"in_reply_to":"7aa08908_36793c83","updated":"2016-06-13 17:20:13.000000000","message":"Done","commit_id":"ddfe031bedc9619f5f6779e4c0854b77233a1450"},{"author":{"_account_id":11155,"name":"Ryan Bak","email":"ryan.bak@twcable.com","username":"ryanmbak"},"change_message_id":"3068a60c0874b14d6fe12756695dc5708d7f485d","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        # Rename \"tx\" to \"out\" and \"rx\" to \"in\""},{"line_number":69,"context_line":"        metric_name \u003d orig_name.replace(\"tx\", \"out\").replace(\"rx\", \"in\")"},{"line_number":70,"context_line":"        if self.use_bits:"},{"line_number":71,"context_line":"            metric_name.replace(\"bytes\", \"bits\")"},{"line_number":72,"context_line":"        return metric_name"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":12,"id":"7aa08908_6bc9e825","line":71,"updated":"2016-06-14 14:13:54.000000000","message":"This should be \u0027metric_name \u003d metric_name.replace...\u0027 or \u0027return metric_name.replace...\u0027","commit_id":"236f3692c5dddb497d2df45c8e260946ab6b69b4"},{"author":{"_account_id":15130,"name":"Sonu","email":"sonu.sudhakaran@gmail.com","username":"sonu"},"change_message_id":"26453b98ab7bf03e555c59760436a1c70656d36c","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        # Rename \"tx\" to \"out\" and \"rx\" to \"in\""},{"line_number":69,"context_line":"        metric_name \u003d orig_name.replace(\"tx\", \"out\").replace(\"rx\", \"in\")"},{"line_number":70,"context_line":"        if self.use_bits:"},{"line_number":71,"context_line":"            metric_name.replace(\"bytes\", \"bits\")"},{"line_number":72,"context_line":"        return metric_name"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":12,"id":"7aa08908_d9353245","line":71,"in_reply_to":"7aa08908_6bc9e825","updated":"2016-06-15 05:48:19.000000000","message":"Thanks for noting this.","commit_id":"236f3692c5dddb497d2df45c8e260946ab6b69b4"},{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"c85d09adcd76fbf5d71458472c593c3277ce8b7f","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                            \u0027timestamp\u0027: sample_time,"},{"line_number":305,"context_line":"                            \u0027value\u0027: value}"},{"line_number":306,"context_line":"                        continue"},{"line_number":307,"context_line":"                    rate_name \u003d self._get_metric_rate_name(metric_name)"},{"line_number":308,"context_line":"                    rate_name \u003d self._get_metric_name(rate_name)"},{"line_number":309,"context_line":"                    if self.use_bits:"},{"line_number":310,"context_line":"                        val_diff *\u003d 8"},{"line_number":311,"context_line":"                    # Customer"}],"source_content_type":"text/x-python","patch_set":12,"id":"7aa08908_47d509e3","line":308,"range":{"start_line":307,"start_character":20,"end_line":308,"end_character":64},"updated":"2016-06-14 11:56:53.000000000","message":"I like the refactor here. Could you squash this to one function. I mean, there would be only\n\nrate_name \u003d self._get_metric_rate_name(metric_name)\n\nhere and maybe you can move the call of _get_metric_name into _get_metric_rate_name.","commit_id":"236f3692c5dddb497d2df45c8e260946ab6b69b4"},{"author":{"_account_id":15130,"name":"Sonu","email":"sonu.sudhakaran@gmail.com","username":"sonu"},"change_message_id":"26453b98ab7bf03e555c59760436a1c70656d36c","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                            \u0027timestamp\u0027: sample_time,"},{"line_number":305,"context_line":"                            \u0027value\u0027: value}"},{"line_number":306,"context_line":"                        continue"},{"line_number":307,"context_line":"                    rate_name \u003d self._get_metric_rate_name(metric_name)"},{"line_number":308,"context_line":"                    rate_name \u003d self._get_metric_name(rate_name)"},{"line_number":309,"context_line":"                    if self.use_bits:"},{"line_number":310,"context_line":"                        val_diff *\u003d 8"},{"line_number":311,"context_line":"                    # Customer"}],"source_content_type":"text/x-python","patch_set":12,"id":"7aa08908_39d39605","line":308,"range":{"start_line":307,"start_character":20,"end_line":308,"end_character":64},"in_reply_to":"7aa08908_47d509e3","updated":"2016-06-15 05:48:19.000000000","message":"Thanks for the comment. The intent of separating these into different functions were they are doing two different things. \n\nThere are couple of things in my list for a re-factor. I will take up a better approach when I submit a re-factor patch for this check.","commit_id":"236f3692c5dddb497d2df45c8e260946ab6b69b4"},{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"c85d09adcd76fbf5d71458472c593c3277ce8b7f","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                    if self.use_bits:"},{"line_number":310,"context_line":"                        val_diff *\u003d 8"},{"line_number":311,"context_line":"                    # Customer"},{"line_number":312,"context_line":"                    this_dimensions \u003d vnic_dimensions.copy()"},{"line_number":313,"context_line":"                    this_dimensions.update(dims_customer)"},{"line_number":314,"context_line":"                    self.gauge(rate_name, val_diff,"},{"line_number":315,"context_line":"                               dimensions\u003dthis_dimensions,"},{"line_number":316,"context_line":"                               delegated_tenant\u003dinstance_cache.get(inst_name)[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"7aa08908_424fb733","line":313,"range":{"start_line":312,"start_character":20,"end_line":313,"end_character":57},"updated":"2016-06-14 11:56:53.000000000","message":"This seems to reappear a couple of times. Maybe you can extract this to a function too. Like:\n\n@staticmethod\ndef _get_dimensions(vnic_dimensions, dims):\n    dimensions \u003d vnic_dimensions.copy()\n    dimensions.update(dims)\n    return dimensions","commit_id":"236f3692c5dddb497d2df45c8e260946ab6b69b4"},{"author":{"_account_id":15130,"name":"Sonu","email":"sonu.sudhakaran@gmail.com","username":"sonu"},"change_message_id":"26453b98ab7bf03e555c59760436a1c70656d36c","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                    if self.use_bits:"},{"line_number":310,"context_line":"                        val_diff *\u003d 8"},{"line_number":311,"context_line":"                    # Customer"},{"line_number":312,"context_line":"                    this_dimensions \u003d vnic_dimensions.copy()"},{"line_number":313,"context_line":"                    this_dimensions.update(dims_customer)"},{"line_number":314,"context_line":"                    self.gauge(rate_name, val_diff,"},{"line_number":315,"context_line":"                               dimensions\u003dthis_dimensions,"},{"line_number":316,"context_line":"                               delegated_tenant\u003dinstance_cache.get(inst_name)[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"7aa08908_d9fed268","line":313,"range":{"start_line":312,"start_character":20,"end_line":313,"end_character":57},"in_reply_to":"7aa08908_424fb733","updated":"2016-06-15 05:48:19.000000000","message":"This is good suggestion. I shall address this in my re-factor patch.","commit_id":"236f3692c5dddb497d2df45c8e260946ab6b69b4"}]}