)]}'
{"monasca_setup/detection/plugins/libvirt.py":[{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"e95be33452da0d6e117757903a7bc468ab36fed3","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            # Handle monasca-setup detection arguments, which take precedence"},{"line_number":159,"context_line":"            if self.args:"},{"line_number":160,"context_line":"                for arg in self.args:"},{"line_number":161,"context_line":"                    if arg in acceptable_args:"},{"line_number":162,"context_line":"                        init_config[arg] \u003d self.literal_eval(self.args[arg])"},{"line_number":163,"context_line":"                    else:"},{"line_number":164,"context_line":"                        log.warn(\"Invalid argument \u0027{0}\u0027 \""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_49711744","line":161,"range":{"start_line":161,"start_character":23,"end_line":161,"end_character":26},"updated":"2016-06-10 15:53:33.000000000","message":"In args_plugin.py we have a function called _check_required_args(). Do you think you can call that function here?","commit_id":"cc30df7ff177bec1572f94bfb6f446a67ae79e4d"},{"author":{"_account_id":14838,"name":"Gandharva","email":"gandharva666@gmail.com","username":"Gandharva"},"change_message_id":"03cbf487d623ed11de8203d240f12e99c9c540a5","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            # Handle monasca-setup detection arguments, which take precedence"},{"line_number":159,"context_line":"            if self.args:"},{"line_number":160,"context_line":"                for arg in self.args:"},{"line_number":161,"context_line":"                    if arg in acceptable_args:"},{"line_number":162,"context_line":"                        init_config[arg] \u003d self.literal_eval(self.args[arg])"},{"line_number":163,"context_line":"                    else:"},{"line_number":164,"context_line":"                        log.warn(\"Invalid argument \u0027{0}\u0027 \""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_15d0e4f6","line":161,"range":{"start_line":161,"start_character":23,"end_line":161,"end_character":26},"in_reply_to":"7aa08908_49711744","updated":"2016-06-16 04:41:19.000000000","message":"Hi Kaiyan Sheng,\n\nAs I see that _check_required_args() is used to verify whether all the the required args is passed or not. But here we are trying to neglect the invalid args if passed.","commit_id":"cc30df7ff177bec1572f94bfb6f446a67ae79e4d"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"0b534e3cdc4515dff19f4506fd6f851bef918b06","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                        init_config[arg] \u003d self.literal_eval(self.args[arg])"},{"line_number":163,"context_line":"                    else:"},{"line_number":164,"context_line":"                        log.warn(\"Invalid argument \u0027{0}\u0027 \""},{"line_number":165,"context_line":"                                 \"has been provided!!!\".format(arg))"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"            config[\u0027libvirt\u0027] \u003d {\u0027init_config\u0027: init_config,"},{"line_number":168,"context_line":"                                 \u0027instances\u0027: []}"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_14844eaf","line":165,"range":{"start_line":165,"start_character":51,"end_line":165,"end_character":56},"updated":"2016-06-10 14:07:17.000000000","message":"i dont think you need the !!! on the log message. Also should we support we ignore case when they are passing in arguments to see if they are valid?","commit_id":"cc30df7ff177bec1572f94bfb6f446a67ae79e4d"},{"author":{"_account_id":14838,"name":"Gandharva","email":"gandharva666@gmail.com","username":"Gandharva"},"change_message_id":"03cbf487d623ed11de8203d240f12e99c9c540a5","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                        init_config[arg] \u003d self.literal_eval(self.args[arg])"},{"line_number":163,"context_line":"                    else:"},{"line_number":164,"context_line":"                        log.warn(\"Invalid argument \u0027{0}\u0027 \""},{"line_number":165,"context_line":"                                 \"has been provided!!!\".format(arg))"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"            config[\u0027libvirt\u0027] \u003d {\u0027init_config\u0027: init_config,"},{"line_number":168,"context_line":"                                 \u0027instances\u0027: []}"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_b5d470bd","line":165,"range":{"start_line":165,"start_character":51,"end_line":165,"end_character":56},"in_reply_to":"7aa08908_14844eaf","updated":"2016-06-16 04:41:19.000000000","message":"Done","commit_id":"cc30df7ff177bec1572f94bfb6f446a67ae79e4d"}]}