)]}'
{"monasca_agent/collector/checks_d/libvirt.py":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"73bf390aa2eb0c6b9e6eef46120a4fc8cb230465","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                if ip[\u0027OS-EXT-IPS:type\u0027] \u003d\u003d \u0027fixed\u0027 and ip[\u0027version\u0027] \u003d\u003d 4:"},{"line_number":169,"context_line":"                    subnet_id \u003d None"},{"line_number":170,"context_line":"                    nsuuid \u003d None"},{"line_number":171,"context_line":"                    for port in port_cache:"},{"line_number":172,"context_line":"                        if ((port[\u0027mac_address\u0027] \u003d\u003d ip[\u0027OS-EXT-IPS-MAC:mac_addr\u0027] and"},{"line_number":173,"context_line":"                             port[\u0027tenant_id\u0027] \u003d\u003d instance.tenant_id and"},{"line_number":174,"context_line":"                             port[\u0027status\u0027] \u003d\u003d \u0027ACTIVE\u0027)):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_198bac69","line":171,"range":{"start_line":171,"start_character":32,"end_line":171,"end_character":42},"updated":"2016-06-13 06:55:09.000000000","message":"Shouldn\u0027t similar check be done here as well, like the one you\u0027ve made above ? You added checking if port_cache is set in one place but it looks like there are several affected by the bug you are fixing, am I right ?","commit_id":"a28e73866daf1a0dc285e169e5a022b679b53add"},{"author":{"_account_id":15130,"name":"Sonu","email":"sonu.sudhakaran@gmail.com","username":"sonu"},"change_message_id":"9d881a26bcd4c417b9841fcf7ef85dd8e71a9862","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                if ip[\u0027OS-EXT-IPS:type\u0027] \u003d\u003d \u0027fixed\u0027 and ip[\u0027version\u0027] \u003d\u003d 4:"},{"line_number":169,"context_line":"                    subnet_id \u003d None"},{"line_number":170,"context_line":"                    nsuuid \u003d None"},{"line_number":171,"context_line":"                    for port in port_cache:"},{"line_number":172,"context_line":"                        if ((port[\u0027mac_address\u0027] \u003d\u003d ip[\u0027OS-EXT-IPS-MAC:mac_addr\u0027] and"},{"line_number":173,"context_line":"                             port[\u0027tenant_id\u0027] \u003d\u003d instance.tenant_id and"},{"line_number":174,"context_line":"                             port[\u0027status\u0027] \u003d\u003d \u0027ACTIVE\u0027)):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_79d4701f","line":171,"range":{"start_line":171,"start_character":32,"end_line":171,"end_character":42},"in_reply_to":"7aa08908_198bac69","updated":"2016-06-13 07:03:49.000000000","message":"I think it is not needed.The function _build_ip_list is called only if netns is set, and that is set when port_cache is also set.\nLittle confusing, but I don\u0027t want to change in too many places to fix this bug.","commit_id":"a28e73866daf1a0dc285e169e5a022b679b53add"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"32816d077b942974381b6e17ab531b7ba7a103eb","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                if ip[\u0027OS-EXT-IPS:type\u0027] \u003d\u003d \u0027fixed\u0027 and ip[\u0027version\u0027] \u003d\u003d 4:"},{"line_number":169,"context_line":"                    subnet_id \u003d None"},{"line_number":170,"context_line":"                    nsuuid \u003d None"},{"line_number":171,"context_line":"                    for port in port_cache:"},{"line_number":172,"context_line":"                        if ((port[\u0027mac_address\u0027] \u003d\u003d ip[\u0027OS-EXT-IPS-MAC:mac_addr\u0027] and"},{"line_number":173,"context_line":"                             port[\u0027tenant_id\u0027] \u003d\u003d instance.tenant_id and"},{"line_number":174,"context_line":"                             port[\u0027status\u0027] \u003d\u003d \u0027ACTIVE\u0027)):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_990e7c8a","line":171,"range":{"start_line":171,"start_character":32,"end_line":171,"end_character":42},"in_reply_to":"7aa08908_79d4701f","updated":"2016-06-13 07:16:18.000000000","message":"Fair enough for me.","commit_id":"a28e73866daf1a0dc285e169e5a022b679b53add"}]}