)]}'
{"monasca_agent/collector/checks_d/libvirt.py":[{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"f518d4377584cb73846ba659fb8b1a522902bdd4","unresolved":false,"context_lines":[{"line_number":527,"context_line":"                self.log.debug(\"Balloon driver not active/available on guest {0} ({1})\".format(inst_name,"},{"line_number":528,"context_line":"                                                                                               instance_cache.get(inst_name)[\u0027hostname\u0027]))"},{"line_number":529,"context_line":"            # Test instance\u0027s remote responsiveness (ping check) if possible"},{"line_number":530,"context_line":"            if self.init_config.get(\u0027ping_check\u0027) and \u0027network\u0027 in instance_cache.get(inst_name):"},{"line_number":531,"context_line":"                for net in instance_cache.get(inst_name)[\u0027network\u0027]:"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"                    ping_cmd \u003d self.init_config.get(\u0027ping_check\u0027).replace(\u0027NAMESPACE\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_41796b92","line":530,"range":{"start_line":530,"start_character":20,"end_line":530,"end_character":31},"updated":"2016-06-14 14:30:02.000000000","message":"For the ping_check test what we need is a way to turn it off in the detection plugin if there isn\u0027t already a way.","commit_id":"4afd5b01dbfbb15e81abcbd168813737cb11e801"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"018f17f4bd771c5b858b33706b22968fb7b06993","unresolved":false,"context_lines":[{"line_number":527,"context_line":"                self.log.debug(\"Balloon driver not active/available on guest {0} ({1})\".format(inst_name,"},{"line_number":528,"context_line":"                                                                                               instance_cache.get(inst_name)[\u0027hostname\u0027]))"},{"line_number":529,"context_line":"            # Test instance\u0027s remote responsiveness (ping check) if possible"},{"line_number":530,"context_line":"            if self.init_config.get(\u0027ping_check\u0027) and \u0027network\u0027 in instance_cache.get(inst_name):"},{"line_number":531,"context_line":"                for net in instance_cache.get(inst_name)[\u0027network\u0027]:"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"                    ping_cmd \u003d self.init_config.get(\u0027ping_check\u0027).replace(\u0027NAMESPACE\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_a4a93d92","line":530,"range":{"start_line":530,"start_character":20,"end_line":530,"end_character":31},"in_reply_to":"7aa08908_41796b92","updated":"2016-06-14 14:46:27.000000000","message":"I think if you set ping_check to be False, it will disable the ping checks.","commit_id":"4afd5b01dbfbb15e81abcbd168813737cb11e801"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"9ae93d891c1112feeea386b838c6bfebdefa53a2","unresolved":false,"context_lines":[{"line_number":527,"context_line":"                self.log.debug(\"Balloon driver not active/available on guest {0} ({1})\".format(inst_name,"},{"line_number":528,"context_line":"                                                                                               instance_cache.get(inst_name)[\u0027hostname\u0027]))"},{"line_number":529,"context_line":"            # Test instance\u0027s remote responsiveness (ping check) if possible"},{"line_number":530,"context_line":"            if self.init_config.get(\u0027ping_check\u0027) and \u0027network\u0027 in instance_cache.get(inst_name):"},{"line_number":531,"context_line":"                for net in instance_cache.get(inst_name)[\u0027network\u0027]:"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"                    ping_cmd \u003d self.init_config.get(\u0027ping_check\u0027).replace(\u0027NAMESPACE\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_95e6edad","line":530,"range":{"start_line":530,"start_character":20,"end_line":530,"end_character":31},"in_reply_to":"7aa08908_a4a93d92","updated":"2016-06-14 15:29:04.000000000","message":"Yup but the detection plugin from monasca_setup will always set the ping_check flag to True if it finds valid environment settings where it could work.  We need the detection plugin to accept arguments to disable ping_check even if the environment could support it.","commit_id":"4afd5b01dbfbb15e81abcbd168813737cb11e801"}]}
