)]}'
{"conf.d/ovs.yaml.example":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"66b47ed375bce5a636217adcdd2bc89bef35d05d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    use_rate_metrics \u003d true"},{"line_number":29,"context_line":"    # If set, will submit the health related metrics from ovs-vsctl command"},{"line_number":30,"context_line":"    # output for the given network interface."},{"line_number":31,"context_line":"    use_health_metrics \u003d true"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"instances:"},{"line_number":34,"context_line":"    # Instances are not used and should be empty in `ovs.yaml` because like the"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"3aaa91ec_822d5c00","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":22},"updated":"2016-06-23 20:15:09.000000000","message":"I think we should consider renaming to something that is more in line with the enable options in libvirt to be a little more consistent. See, https://github.com/openstack/monasca-agent/blob/master/docs/Libvirt.md#configuration\n\nSo, something along the lines of \n\nrate_metrics_enable\nhealth_metrics_enable\n\nMight be a little more consistent.","commit_id":"854ab04f21a3bef50da90a419272245becb2a9aa"}],"monasca_agent/collector/checks_d/ovs.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"e1972a621d4868bc96fb426e245770fd698a049e","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                    metric_name_abs \u003d \"vswitch.{0}\".format(metric_name)"},{"line_number":186,"context_line":"                if not self.use_health_metrics:"},{"line_number":187,"context_line":"                    if interface_stats_key in HEALTH_METRICS:"},{"line_number":188,"context_line":"                        continue"},{"line_number":189,"context_line":"                ops_dimensions \u003d this_dimensions.copy()"},{"line_number":190,"context_line":"                ops_dimensions.update({\u0027tenant_id\u0027: tenant_id})"},{"line_number":191,"context_line":"                if self.use_rate_metrics:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_dd258509","line":188,"range":{"start_line":188,"start_character":24,"end_line":188,"end_character":32},"updated":"2016-06-23 21:25:07.000000000","message":"Would moving this check up a few lines to right after line 177 make more sense to avoid copying customer dimensions and setting the subsequent values?\n\nWould you want to right this as a single if statement as follows?\n\nif not self.use_health_metrics and interface_stats_key in HEALTH_METRICS:\n    continue","commit_id":"854ab04f21a3bef50da90a419272245becb2a9aa"},{"author":{"_account_id":10781,"name":"selvakumar","email":"selvakumar.s2@hpe.com","username":"selvakumar"},"change_message_id":"5c22008879197776d3fa4765f39238bf1e415e2d","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                    metric_name_abs \u003d \"vswitch.{0}\".format(metric_name)"},{"line_number":186,"context_line":"                if not self.use_health_metrics:"},{"line_number":187,"context_line":"                    if interface_stats_key in HEALTH_METRICS:"},{"line_number":188,"context_line":"                        continue"},{"line_number":189,"context_line":"                ops_dimensions \u003d this_dimensions.copy()"},{"line_number":190,"context_line":"                ops_dimensions.update({\u0027tenant_id\u0027: tenant_id})"},{"line_number":191,"context_line":"                if self.use_rate_metrics:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_fc502034","line":188,"range":{"start_line":188,"start_character":24,"end_line":188,"end_character":32},"in_reply_to":"3aaa91ec_dd258509","updated":"2016-06-24 13:21:29.000000000","message":"Done","commit_id":"854ab04f21a3bef50da90a419272245becb2a9aa"}]}
