)]}'
{"conf.d/solidfire.yaml.example":[{"author":{"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},"change_message_id":"56dc3c514ec05be1481c170786a2d476f488d880","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 NetApp, Inc."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"instances:"},{"line_number":4,"context_line":"    # Each cluster can be monitored with a separate instance."},{"line_number":5,"context_line":"    - name: rack_d_cluster"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"bacf61ea_41d5381a","line":2,"updated":"2016-07-29 16:12:41.000000000","message":"This works if we add:\n\ninit_config: null\n\nhere.","commit_id":"84bea3e06043d12d84b8df41b2ea2a0ddc157791"},{"author":{"_account_id":16627,"name":"Chris Morrell","email":"gomeler@gmail.com","username":"Chris_Morrell"},"change_message_id":"0edc0d18e1beeba3040c9c174d548d11fba2e616","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 NetApp, Inc."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"instances:"},{"line_number":4,"context_line":"    # Each cluster can be monitored with a separate instance."},{"line_number":5,"context_line":"    - name: rack_d_cluster"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"bacf61ea_7f2357bd","line":2,"in_reply_to":"bacf61ea_41d5381a","updated":"2016-08-01 21:53:04.000000000","message":"Done","commit_id":"84bea3e06043d12d84b8df41b2ea2a0ddc157791"}],"docs/Plugins.md":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"3e7209ec587231d6c187281d2b6fadae80afafac","unresolved":false,"context_lines":[{"line_number":1395,"context_line":""},{"line_number":1396,"context_line":"| Metric Name | Dimensions | Semantics |"},{"line_number":1397,"context_line":"| ----------- | ---------- | --------- |"},{"line_number":1398,"context_line":"| solidfire.active_block_space        | service\u003dsolidfire, cluster | Amount of space consumed by the block services, including cruft |"},{"line_number":1399,"context_line":"| solidfire.active_cluster_faults     | service\u003dsolidfire, cluster | Amount of active cluster faults, such as failed drives |"},{"line_number":1400,"context_line":"| solidfire.active_meta_space         | service\u003dsolidfire, cluster | Amount of space consumed by the metadata services |"},{"line_number":1401,"context_line":"| solidfire.active_snapshot_space     | service\u003dsolidfire, cluster | Amount of space consumed by the metadata services for snapshots |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"fad55976_890cd995","line":1398,"updated":"2016-07-15 23:19:55.000000000","message":"We\u0027ve been using a naming convention when it is the amount of space, that has the units listed in the name. such as solidfire.active_block_bytes or solidfire.active_block_mb","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":16627,"name":"Chris Morrell","email":"gomeler@gmail.com","username":"Chris_Morrell"},"change_message_id":"08880d5e9395d023391b37d1dfb0d07dcc7109c6","unresolved":false,"context_lines":[{"line_number":1395,"context_line":""},{"line_number":1396,"context_line":"| Metric Name | Dimensions | Semantics |"},{"line_number":1397,"context_line":"| ----------- | ---------- | --------- |"},{"line_number":1398,"context_line":"| solidfire.active_block_space        | service\u003dsolidfire, cluster | Amount of space consumed by the block services, including cruft |"},{"line_number":1399,"context_line":"| solidfire.active_cluster_faults     | service\u003dsolidfire, cluster | Amount of active cluster faults, such as failed drives |"},{"line_number":1400,"context_line":"| solidfire.active_meta_space         | service\u003dsolidfire, cluster | Amount of space consumed by the metadata services |"},{"line_number":1401,"context_line":"| solidfire.active_snapshot_space     | service\u003dsolidfire, cluster | Amount of space consumed by the metadata services for snapshots |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"dada55a8_dd8d597d","line":1398,"in_reply_to":"fad55976_890cd995","updated":"2016-07-26 21:11:21.000000000","message":"Updated the documentation and plugin, switched from _space to _bytes(everything\u0027s reported in bytes) where applicable.","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"3e7209ec587231d6c187281d2b6fadae80afafac","unresolved":false,"context_lines":[{"line_number":1397,"context_line":"| ----------- | ---------- | --------- |"},{"line_number":1398,"context_line":"| solidfire.active_block_space        | service\u003dsolidfire, cluster | Amount of space consumed by the block services, including cruft |"},{"line_number":1399,"context_line":"| solidfire.active_cluster_faults     | service\u003dsolidfire, cluster | Amount of active cluster faults, such as failed drives |"},{"line_number":1400,"context_line":"| solidfire.active_meta_space         | service\u003dsolidfire, cluster | Amount of space consumed by the metadata services |"},{"line_number":1401,"context_line":"| solidfire.active_snapshot_space     | service\u003dsolidfire, cluster | Amount of space consumed by the metadata services for snapshots |"},{"line_number":1402,"context_line":"| solidfire.average_iops              | service\u003dsolidfire, cluster | Average IOPs since midnight UTC |"},{"line_number":1403,"context_line":"| solidfire.clusterUtilization        | service\u003dsolidfire, cluster | Overall cluster IOP utilization |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"fad55976_8c3b47eb","line":1400,"range":{"start_line":1400,"start_character":2,"end_line":1400,"end_character":11},"updated":"2016-07-15 23:19:55.000000000","message":"Similar comment to up above, but adding the units in bytes or mb would probably be preferable.","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":16627,"name":"Chris Morrell","email":"gomeler@gmail.com","username":"Chris_Morrell"},"change_message_id":"08880d5e9395d023391b37d1dfb0d07dcc7109c6","unresolved":false,"context_lines":[{"line_number":1397,"context_line":"| ----------- | ---------- | --------- |"},{"line_number":1398,"context_line":"| solidfire.active_block_space        | service\u003dsolidfire, cluster | Amount of space consumed by the block services, including cruft |"},{"line_number":1399,"context_line":"| solidfire.active_cluster_faults     | service\u003dsolidfire, cluster | Amount of active cluster faults, such as failed drives |"},{"line_number":1400,"context_line":"| solidfire.active_meta_space         | service\u003dsolidfire, cluster | Amount of space consumed by the metadata services |"},{"line_number":1401,"context_line":"| solidfire.active_snapshot_space     | service\u003dsolidfire, cluster | Amount of space consumed by the metadata services for snapshots |"},{"line_number":1402,"context_line":"| solidfire.average_iops              | service\u003dsolidfire, cluster | Average IOPs since midnight UTC |"},{"line_number":1403,"context_line":"| solidfire.clusterUtilization        | service\u003dsolidfire, cluster | Overall cluster IOP utilization |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"dada55a8_fdd5bd42","line":1400,"range":{"start_line":1400,"start_character":2,"end_line":1400,"end_character":11},"in_reply_to":"fad55976_8c3b47eb","updated":"2016-07-26 21:11:21.000000000","message":"Done","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"3e7209ec587231d6c187281d2b6fadae80afafac","unresolved":false,"context_lines":[{"line_number":1398,"context_line":"| solidfire.active_block_space        | service\u003dsolidfire, cluster | Amount of space consumed by the block services, including cruft |"},{"line_number":1399,"context_line":"| solidfire.active_cluster_faults     | service\u003dsolidfire, cluster | Amount of active cluster faults, such as failed drives |"},{"line_number":1400,"context_line":"| solidfire.active_meta_space         | service\u003dsolidfire, cluster | Amount of space consumed by the metadata services |"},{"line_number":1401,"context_line":"| solidfire.active_snapshot_space     | service\u003dsolidfire, cluster | Amount of space consumed by the metadata services for snapshots |"},{"line_number":1402,"context_line":"| solidfire.average_iops              | service\u003dsolidfire, cluster | Average IOPs since midnight UTC |"},{"line_number":1403,"context_line":"| solidfire.clusterUtilization        | service\u003dsolidfire, cluster | Overall cluster IOP utilization |"},{"line_number":1404,"context_line":"| solidfire.current_iops              | service\u003dsolidfire, cluster | Average IOPs over the last 5 seconds |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"fad55976_6c17f351","line":1401,"range":{"start_line":1401,"start_character":12,"end_line":1401,"end_character":33},"updated":"2016-07-15 23:19:55.000000000","message":"Same comment as previous.","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":16627,"name":"Chris Morrell","email":"gomeler@gmail.com","username":"Chris_Morrell"},"change_message_id":"08880d5e9395d023391b37d1dfb0d07dcc7109c6","unresolved":false,"context_lines":[{"line_number":1398,"context_line":"| solidfire.active_block_space        | service\u003dsolidfire, cluster | Amount of space consumed by the block services, including cruft |"},{"line_number":1399,"context_line":"| solidfire.active_cluster_faults     | service\u003dsolidfire, cluster | Amount of active cluster faults, such as failed drives |"},{"line_number":1400,"context_line":"| solidfire.active_meta_space         | service\u003dsolidfire, cluster | Amount of space consumed by the metadata services |"},{"line_number":1401,"context_line":"| solidfire.active_snapshot_space     | service\u003dsolidfire, cluster | Amount of space consumed by the metadata services for snapshots |"},{"line_number":1402,"context_line":"| solidfire.average_iops              | service\u003dsolidfire, cluster | Average IOPs since midnight UTC |"},{"line_number":1403,"context_line":"| solidfire.clusterUtilization        | service\u003dsolidfire, cluster | Overall cluster IOP utilization |"},{"line_number":1404,"context_line":"| solidfire.current_iops              | service\u003dsolidfire, cluster | Average IOPs over the last 5 seconds |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"dada55a8_3dcc75ba","line":1401,"range":{"start_line":1401,"start_character":12,"end_line":1401,"end_character":33},"in_reply_to":"fad55976_6c17f351","updated":"2016-07-26 21:11:21.000000000","message":"Done","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"3e7209ec587231d6c187281d2b6fadae80afafac","unresolved":false,"context_lines":[{"line_number":1399,"context_line":"| solidfire.active_cluster_faults     | service\u003dsolidfire, cluster | Amount of active cluster faults, such as failed drives |"},{"line_number":1400,"context_line":"| solidfire.active_meta_space         | service\u003dsolidfire, cluster | Amount of space consumed by the metadata services |"},{"line_number":1401,"context_line":"| solidfire.active_snapshot_space     | service\u003dsolidfire, cluster | Amount of space consumed by the metadata services for snapshots |"},{"line_number":1402,"context_line":"| solidfire.average_iops              | service\u003dsolidfire, cluster | Average IOPs since midnight UTC |"},{"line_number":1403,"context_line":"| solidfire.clusterUtilization        | service\u003dsolidfire, cluster | Overall cluster IOP utilization |"},{"line_number":1404,"context_line":"| solidfire.current_iops              | service\u003dsolidfire, cluster | Average IOPs over the last 5 seconds |"},{"line_number":1405,"context_line":"| solidfire.iscsi_sessions            | service\u003dsolidfire, cluster | Amount of active iSCSI sessions connected to the cluster |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"fad55976_e6d82220","line":1402,"range":{"start_line":1402,"start_character":12,"end_line":1402,"end_character":24},"updated":"2016-07-15 23:19:55.000000000","message":"I wondering if you should just report num_iops. Monasca support avg and max functions on metrics, both in the Threshold Engine and via queries. A query that limits to the start and end time to a 24 hour period starting at midnight UTC, and a period of 24 hours (whatever that is in seconds) I think would return the same thing.\n\nAlso, see the io names at, https://github.com/openstack/monasca-agent/blob/master/docs/Plugins.md#disk","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":16627,"name":"Chris Morrell","email":"gomeler@gmail.com","username":"Chris_Morrell"},"change_message_id":"08880d5e9395d023391b37d1dfb0d07dcc7109c6","unresolved":false,"context_lines":[{"line_number":1399,"context_line":"| solidfire.active_cluster_faults     | service\u003dsolidfire, cluster | Amount of active cluster faults, such as failed drives |"},{"line_number":1400,"context_line":"| solidfire.active_meta_space         | service\u003dsolidfire, cluster | Amount of space consumed by the metadata services |"},{"line_number":1401,"context_line":"| solidfire.active_snapshot_space     | service\u003dsolidfire, cluster | Amount of space consumed by the metadata services for snapshots |"},{"line_number":1402,"context_line":"| solidfire.average_iops              | service\u003dsolidfire, cluster | Average IOPs since midnight UTC |"},{"line_number":1403,"context_line":"| solidfire.clusterUtilization        | service\u003dsolidfire, cluster | Overall cluster IOP utilization |"},{"line_number":1404,"context_line":"| solidfire.current_iops              | service\u003dsolidfire, cluster | Average IOPs over the last 5 seconds |"},{"line_number":1405,"context_line":"| solidfire.iscsi_sessions            | service\u003dsolidfire, cluster | Amount of active iSCSI sessions connected to the cluster |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"dada55a8_3d43d514","line":1402,"range":{"start_line":1402,"start_character":12,"end_line":1402,"end_character":24},"in_reply_to":"fad55976_e6d82220","updated":"2016-07-26 21:11:21.000000000","message":"Unfortunately the UTC IOP stats I\u0027m reporting are tallied by the cluster, I was simply passing it through as it\u0027s available for free with the capacity call. Not ideal, but it\u0027s what I\u0027ve got.","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"3e7209ec587231d6c187281d2b6fadae80afafac","unresolved":false,"context_lines":[{"line_number":1400,"context_line":"| solidfire.active_meta_space         | service\u003dsolidfire, cluster | Amount of space consumed by the metadata services |"},{"line_number":1401,"context_line":"| solidfire.active_snapshot_space     | service\u003dsolidfire, cluster | Amount of space consumed by the metadata services for snapshots |"},{"line_number":1402,"context_line":"| solidfire.average_iops              | service\u003dsolidfire, cluster | Average IOPs since midnight UTC |"},{"line_number":1403,"context_line":"| solidfire.clusterUtilization        | service\u003dsolidfire, cluster | Overall cluster IOP utilization |"},{"line_number":1404,"context_line":"| solidfire.current_iops              | service\u003dsolidfire, cluster | Average IOPs over the last 5 seconds |"},{"line_number":1405,"context_line":"| solidfire.iscsi_sessions            | service\u003dsolidfire, cluster | Amount of active iSCSI sessions connected to the cluster |"},{"line_number":1406,"context_line":"| solidfire.max_block_space           | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the block services |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"fad55976_c6db5eec","line":1403,"range":{"start_line":1403,"start_character":11,"end_line":1403,"end_character":12},"updated":"2016-07-15 23:19:55.000000000","message":"The naming convention for metrics is snake case, so I\u0027m wondering if cluster_utilization, would be better. I\u0027m assuming that this is a percent, and a value between 0 and 1.","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":16627,"name":"Chris Morrell","email":"gomeler@gmail.com","username":"Chris_Morrell"},"change_message_id":"08880d5e9395d023391b37d1dfb0d07dcc7109c6","unresolved":false,"context_lines":[{"line_number":1400,"context_line":"| solidfire.active_meta_space         | service\u003dsolidfire, cluster | Amount of space consumed by the metadata services |"},{"line_number":1401,"context_line":"| solidfire.active_snapshot_space     | service\u003dsolidfire, cluster | Amount of space consumed by the metadata services for snapshots |"},{"line_number":1402,"context_line":"| solidfire.average_iops              | service\u003dsolidfire, cluster | Average IOPs since midnight UTC |"},{"line_number":1403,"context_line":"| solidfire.clusterUtilization        | service\u003dsolidfire, cluster | Overall cluster IOP utilization |"},{"line_number":1404,"context_line":"| solidfire.current_iops              | service\u003dsolidfire, cluster | Average IOPs over the last 5 seconds |"},{"line_number":1405,"context_line":"| solidfire.iscsi_sessions            | service\u003dsolidfire, cluster | Amount of active iSCSI sessions connected to the cluster |"},{"line_number":1406,"context_line":"| solidfire.max_block_space           | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the block services |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"dada55a8_5d55e9bf","line":1403,"range":{"start_line":1403,"start_character":11,"end_line":1403,"end_character":12},"in_reply_to":"fad55976_c6db5eec","updated":"2016-07-26 21:11:21.000000000","message":"Done","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"3e7209ec587231d6c187281d2b6fadae80afafac","unresolved":false,"context_lines":[{"line_number":1401,"context_line":"| solidfire.active_snapshot_space     | service\u003dsolidfire, cluster | Amount of space consumed by the metadata services for snapshots |"},{"line_number":1402,"context_line":"| solidfire.average_iops              | service\u003dsolidfire, cluster | Average IOPs since midnight UTC |"},{"line_number":1403,"context_line":"| solidfire.clusterUtilization        | service\u003dsolidfire, cluster | Overall cluster IOP utilization |"},{"line_number":1404,"context_line":"| solidfire.current_iops              | service\u003dsolidfire, cluster | Average IOPs over the last 5 seconds |"},{"line_number":1405,"context_line":"| solidfire.iscsi_sessions            | service\u003dsolidfire, cluster | Amount of active iSCSI sessions connected to the cluster |"},{"line_number":1406,"context_line":"| solidfire.max_block_space           | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the block services |"},{"line_number":1407,"context_line":"| solidfire.max_iops                  | service\u003dsolidfire, cluster | Theoretical maximum amount of IOPs |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"fad55976_6649d28b","line":1404,"range":{"start_line":1404,"start_character":2,"end_line":1404,"end_character":11},"updated":"2016-07-15 23:19:55.000000000","message":"We have some pre-existing load metrics that are names as follow, https://github.com/openstack/monasca-agent/blob/master/docs/Plugins.md#load. \n\nIf we following that convention then a name like solidfire.avg_iops_5_sec or solidfire.iops.avg_5_sec, might fit better.","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":16627,"name":"Chris Morrell","email":"gomeler@gmail.com","username":"Chris_Morrell"},"change_message_id":"08880d5e9395d023391b37d1dfb0d07dcc7109c6","unresolved":false,"context_lines":[{"line_number":1401,"context_line":"| solidfire.active_snapshot_space     | service\u003dsolidfire, cluster | Amount of space consumed by the metadata services for snapshots |"},{"line_number":1402,"context_line":"| solidfire.average_iops              | service\u003dsolidfire, cluster | Average IOPs since midnight UTC |"},{"line_number":1403,"context_line":"| solidfire.clusterUtilization        | service\u003dsolidfire, cluster | Overall cluster IOP utilization |"},{"line_number":1404,"context_line":"| solidfire.current_iops              | service\u003dsolidfire, cluster | Average IOPs over the last 5 seconds |"},{"line_number":1405,"context_line":"| solidfire.iscsi_sessions            | service\u003dsolidfire, cluster | Amount of active iSCSI sessions connected to the cluster |"},{"line_number":1406,"context_line":"| solidfire.max_block_space           | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the block services |"},{"line_number":1407,"context_line":"| solidfire.max_iops                  | service\u003dsolidfire, cluster | Theoretical maximum amount of IOPs |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"dada55a8_5d0cc9eb","line":1404,"range":{"start_line":1404,"start_character":2,"end_line":1404,"end_character":11},"in_reply_to":"fad55976_6649d28b","updated":"2016-07-26 21:11:21.000000000","message":"Went with solidfire.iops.* and noted the range for the various metrics, like avg_5_sec.","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"3e7209ec587231d6c187281d2b6fadae80afafac","unresolved":false,"context_lines":[{"line_number":1402,"context_line":"| solidfire.average_iops              | service\u003dsolidfire, cluster | Average IOPs since midnight UTC |"},{"line_number":1403,"context_line":"| solidfire.clusterUtilization        | service\u003dsolidfire, cluster | Overall cluster IOP utilization |"},{"line_number":1404,"context_line":"| solidfire.current_iops              | service\u003dsolidfire, cluster | Average IOPs over the last 5 seconds |"},{"line_number":1405,"context_line":"| solidfire.iscsi_sessions            | service\u003dsolidfire, cluster | Amount of active iSCSI sessions connected to the cluster |"},{"line_number":1406,"context_line":"| solidfire.max_block_space           | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the block services |"},{"line_number":1407,"context_line":"| solidfire.max_iops                  | service\u003dsolidfire, cluster | Theoretical maximum amount of IOPs |"},{"line_number":1408,"context_line":"| solidfire.max_meta_space            | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the metadata services |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"fad55976_8920599d","line":1405,"range":{"start_line":1405,"start_character":12,"end_line":1405,"end_character":26},"updated":"2016-07-15 23:19:55.000000000","message":"Would prefer num_iscsi_sessions, as the \"num\" perfix is typically what we\u0027ve been using for counters.","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":16627,"name":"Chris Morrell","email":"gomeler@gmail.com","username":"Chris_Morrell"},"change_message_id":"08880d5e9395d023391b37d1dfb0d07dcc7109c6","unresolved":false,"context_lines":[{"line_number":1402,"context_line":"| solidfire.average_iops              | service\u003dsolidfire, cluster | Average IOPs since midnight UTC |"},{"line_number":1403,"context_line":"| solidfire.clusterUtilization        | service\u003dsolidfire, cluster | Overall cluster IOP utilization |"},{"line_number":1404,"context_line":"| solidfire.current_iops              | service\u003dsolidfire, cluster | Average IOPs over the last 5 seconds |"},{"line_number":1405,"context_line":"| solidfire.iscsi_sessions            | service\u003dsolidfire, cluster | Amount of active iSCSI sessions connected to the cluster |"},{"line_number":1406,"context_line":"| solidfire.max_block_space           | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the block services |"},{"line_number":1407,"context_line":"| solidfire.max_iops                  | service\u003dsolidfire, cluster | Theoretical maximum amount of IOPs |"},{"line_number":1408,"context_line":"| solidfire.max_meta_space            | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the metadata services |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"dada55a8_9dfac1bb","line":1405,"range":{"start_line":1405,"start_character":12,"end_line":1405,"end_character":26},"in_reply_to":"fad55976_8920599d","updated":"2016-07-26 21:11:21.000000000","message":"Done","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"3e7209ec587231d6c187281d2b6fadae80afafac","unresolved":false,"context_lines":[{"line_number":1403,"context_line":"| solidfire.clusterUtilization        | service\u003dsolidfire, cluster | Overall cluster IOP utilization |"},{"line_number":1404,"context_line":"| solidfire.current_iops              | service\u003dsolidfire, cluster | Average IOPs over the last 5 seconds |"},{"line_number":1405,"context_line":"| solidfire.iscsi_sessions            | service\u003dsolidfire, cluster | Amount of active iSCSI sessions connected to the cluster |"},{"line_number":1406,"context_line":"| solidfire.max_block_space           | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the block services |"},{"line_number":1407,"context_line":"| solidfire.max_iops                  | service\u003dsolidfire, cluster | Theoretical maximum amount of IOPs |"},{"line_number":1408,"context_line":"| solidfire.max_meta_space            | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the metadata services |"},{"line_number":1409,"context_line":"| solidfire.max_overprovisioned_space | service\u003dsolidfire, cluster | Max provisionable space * 5, artificial safety limit |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"fad55976_895859fc","line":1406,"updated":"2016-07-15 23:19:55.000000000","message":"So, could a num_block_space value be reported, and then the max function that is built-in be used to derive the max.","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":16627,"name":"Chris Morrell","email":"gomeler@gmail.com","username":"Chris_Morrell"},"change_message_id":"08880d5e9395d023391b37d1dfb0d07dcc7109c6","unresolved":false,"context_lines":[{"line_number":1403,"context_line":"| solidfire.clusterUtilization        | service\u003dsolidfire, cluster | Overall cluster IOP utilization |"},{"line_number":1404,"context_line":"| solidfire.current_iops              | service\u003dsolidfire, cluster | Average IOPs over the last 5 seconds |"},{"line_number":1405,"context_line":"| solidfire.iscsi_sessions            | service\u003dsolidfire, cluster | Amount of active iSCSI sessions connected to the cluster |"},{"line_number":1406,"context_line":"| solidfire.max_block_space           | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the block services |"},{"line_number":1407,"context_line":"| solidfire.max_iops                  | service\u003dsolidfire, cluster | Theoretical maximum amount of IOPs |"},{"line_number":1408,"context_line":"| solidfire.max_meta_space            | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the metadata services |"},{"line_number":1409,"context_line":"| solidfire.max_overprovisioned_space | service\u003dsolidfire, cluster | Max provisionable space * 5, artificial safety limit |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"dada55a8_bdd505e6","line":1406,"in_reply_to":"fad55976_895859fc","updated":"2016-07-26 21:11:21.000000000","message":"This stat is simply the maximum limit for the cluster, which is affected by the number of active block drives. It\u0027s only adjusted by losing block drives to failure, or adding capacity. For max_block_bytes and max_meta_bytes, max may not be the best choice. It\u0027s the current upper capacity, maybe something like raw_block_capacity_bytes and raw_meta_capacity_bytes instead?","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"3e7209ec587231d6c187281d2b6fadae80afafac","unresolved":false,"context_lines":[{"line_number":1404,"context_line":"| solidfire.current_iops              | service\u003dsolidfire, cluster | Average IOPs over the last 5 seconds |"},{"line_number":1405,"context_line":"| solidfire.iscsi_sessions            | service\u003dsolidfire, cluster | Amount of active iSCSI sessions connected to the cluster |"},{"line_number":1406,"context_line":"| solidfire.max_block_space           | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the block services |"},{"line_number":1407,"context_line":"| solidfire.max_iops                  | service\u003dsolidfire, cluster | Theoretical maximum amount of IOPs |"},{"line_number":1408,"context_line":"| solidfire.max_meta_space            | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the metadata services |"},{"line_number":1409,"context_line":"| solidfire.max_overprovisioned_space | service\u003dsolidfire, cluster | Max provisionable space * 5, artificial safety limit |"},{"line_number":1410,"context_line":"| solidfire.max_provisioned_space     | service\u003dsolidfire, cluster | Max provisionable space if 100% metadata space used |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"fad55976_499b01ca","line":1407,"updated":"2016-07-15 23:19:55.000000000","message":"Is this like a capacity metric. Would a name like max_capacity_iops, be a preferable name?\n\nAlso, going through this list there appear to be a lot or metrics with the name \"iops\" in them. I\u0027m wondering if it would be better to group all the iops metrics together as in\n\nsolidfire.iops.num\nsolidfire.iops.avg_5_sec\nsolidfire.iops.max","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":16627,"name":"Chris Morrell","email":"gomeler@gmail.com","username":"Chris_Morrell"},"change_message_id":"08880d5e9395d023391b37d1dfb0d07dcc7109c6","unresolved":false,"context_lines":[{"line_number":1404,"context_line":"| solidfire.current_iops              | service\u003dsolidfire, cluster | Average IOPs over the last 5 seconds |"},{"line_number":1405,"context_line":"| solidfire.iscsi_sessions            | service\u003dsolidfire, cluster | Amount of active iSCSI sessions connected to the cluster |"},{"line_number":1406,"context_line":"| solidfire.max_block_space           | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the block services |"},{"line_number":1407,"context_line":"| solidfire.max_iops                  | service\u003dsolidfire, cluster | Theoretical maximum amount of IOPs |"},{"line_number":1408,"context_line":"| solidfire.max_meta_space            | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the metadata services |"},{"line_number":1409,"context_line":"| solidfire.max_overprovisioned_space | service\u003dsolidfire, cluster | Max provisionable space * 5, artificial safety limit |"},{"line_number":1410,"context_line":"| solidfire.max_provisioned_space     | service\u003dsolidfire, cluster | Max provisionable space if 100% metadata space used |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"dada55a8_5dfb297b","line":1407,"in_reply_to":"fad55976_499b01ca","updated":"2016-07-26 21:11:21.000000000","message":"Done","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"3e7209ec587231d6c187281d2b6fadae80afafac","unresolved":false,"context_lines":[{"line_number":1405,"context_line":"| solidfire.iscsi_sessions            | service\u003dsolidfire, cluster | Amount of active iSCSI sessions connected to the cluster |"},{"line_number":1406,"context_line":"| solidfire.max_block_space           | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the block services |"},{"line_number":1407,"context_line":"| solidfire.max_iops                  | service\u003dsolidfire, cluster | Theoretical maximum amount of IOPs |"},{"line_number":1408,"context_line":"| solidfire.max_meta_space            | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the metadata services |"},{"line_number":1409,"context_line":"| solidfire.max_overprovisioned_space | service\u003dsolidfire, cluster | Max provisionable space * 5, artificial safety limit |"},{"line_number":1410,"context_line":"| solidfire.max_provisioned_space     | service\u003dsolidfire, cluster | Max provisionable space if 100% metadata space used |"},{"line_number":1411,"context_line":"| solidfire.non_zero_blocks           | service\u003dsolidfire, cluster | Number of 4KiB blocks with data after the last garbage collection |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"fad55976_c920914c","line":1408,"range":{"start_line":1408,"start_character":2,"end_line":1408,"end_character":11},"updated":"2016-07-15 23:19:55.000000000","message":"Same comment as above for the max_block_space.","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":16627,"name":"Chris Morrell","email":"gomeler@gmail.com","username":"Chris_Morrell"},"change_message_id":"08880d5e9395d023391b37d1dfb0d07dcc7109c6","unresolved":false,"context_lines":[{"line_number":1405,"context_line":"| solidfire.iscsi_sessions            | service\u003dsolidfire, cluster | Amount of active iSCSI sessions connected to the cluster |"},{"line_number":1406,"context_line":"| solidfire.max_block_space           | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the block services |"},{"line_number":1407,"context_line":"| solidfire.max_iops                  | service\u003dsolidfire, cluster | Theoretical maximum amount of IOPs |"},{"line_number":1408,"context_line":"| solidfire.max_meta_space            | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the metadata services |"},{"line_number":1409,"context_line":"| solidfire.max_overprovisioned_space | service\u003dsolidfire, cluster | Max provisionable space * 5, artificial safety limit |"},{"line_number":1410,"context_line":"| solidfire.max_provisioned_space     | service\u003dsolidfire, cluster | Max provisionable space if 100% metadata space used |"},{"line_number":1411,"context_line":"| solidfire.non_zero_blocks           | service\u003dsolidfire, cluster | Number of 4KiB blocks with data after the last garbage collection |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"dada55a8_3d00f565","line":1408,"range":{"start_line":1408,"start_character":2,"end_line":1408,"end_character":11},"in_reply_to":"fad55976_c920914c","updated":"2016-07-26 21:11:21.000000000","message":"Done","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"3e7209ec587231d6c187281d2b6fadae80afafac","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"| solidfire.max_block_space           | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the block services |"},{"line_number":1407,"context_line":"| solidfire.max_iops                  | service\u003dsolidfire, cluster | Theoretical maximum amount of IOPs |"},{"line_number":1408,"context_line":"| solidfire.max_meta_space            | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the metadata services |"},{"line_number":1409,"context_line":"| solidfire.max_overprovisioned_space | service\u003dsolidfire, cluster | Max provisionable space * 5, artificial safety limit |"},{"line_number":1410,"context_line":"| solidfire.max_provisioned_space     | service\u003dsolidfire, cluster | Max provisionable space if 100% metadata space used |"},{"line_number":1411,"context_line":"| solidfire.non_zero_blocks           | service\u003dsolidfire, cluster | Number of 4KiB blocks with data after the last garbage collection |"},{"line_number":1412,"context_line":"| solidfire.peak_iops                 | service\u003dsolidfire, cluster | Peak IOPS since midnight UTC |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"fad55976_9a57f901","line":1409,"range":{"start_line":1409,"start_character":12,"end_line":1409,"end_character":37},"updated":"2016-07-15 23:19:55.000000000","message":"See comments above about space vs bytes or mbytes","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":16627,"name":"Chris Morrell","email":"gomeler@gmail.com","username":"Chris_Morrell"},"change_message_id":"08880d5e9395d023391b37d1dfb0d07dcc7109c6","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"| solidfire.max_block_space           | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the block services |"},{"line_number":1407,"context_line":"| solidfire.max_iops                  | service\u003dsolidfire, cluster | Theoretical maximum amount of IOPs |"},{"line_number":1408,"context_line":"| solidfire.max_meta_space            | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the metadata services |"},{"line_number":1409,"context_line":"| solidfire.max_overprovisioned_space | service\u003dsolidfire, cluster | Max provisionable space * 5, artificial safety limit |"},{"line_number":1410,"context_line":"| solidfire.max_provisioned_space     | service\u003dsolidfire, cluster | Max provisionable space if 100% metadata space used |"},{"line_number":1411,"context_line":"| solidfire.non_zero_blocks           | service\u003dsolidfire, cluster | Number of 4KiB blocks with data after the last garbage collection |"},{"line_number":1412,"context_line":"| solidfire.peak_iops                 | service\u003dsolidfire, cluster | Peak IOPS since midnight UTC |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"dada55a8_7df6ed8f","line":1409,"range":{"start_line":1409,"start_character":12,"end_line":1409,"end_character":37},"in_reply_to":"fad55976_9a57f901","updated":"2016-07-26 21:11:21.000000000","message":"Done","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"3e7209ec587231d6c187281d2b6fadae80afafac","unresolved":false,"context_lines":[{"line_number":1407,"context_line":"| solidfire.max_iops                  | service\u003dsolidfire, cluster | Theoretical maximum amount of IOPs |"},{"line_number":1408,"context_line":"| solidfire.max_meta_space            | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the metadata services |"},{"line_number":1409,"context_line":"| solidfire.max_overprovisioned_space | service\u003dsolidfire, cluster | Max provisionable space * 5, artificial safety limit |"},{"line_number":1410,"context_line":"| solidfire.max_provisioned_space     | service\u003dsolidfire, cluster | Max provisionable space if 100% metadata space used |"},{"line_number":1411,"context_line":"| solidfire.non_zero_blocks           | service\u003dsolidfire, cluster | Number of 4KiB blocks with data after the last garbage collection |"},{"line_number":1412,"context_line":"| solidfire.peak_iops                 | service\u003dsolidfire, cluster | Peak IOPS since midnight UTC |"},{"line_number":1413,"context_line":"| solidfire.provisioned_space         | service\u003dsolidfire, cluster | Total number of provisioned bytes |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"fad55976_5a74619b","line":1410,"range":{"start_line":1410,"start_character":2,"end_line":1410,"end_character":11},"updated":"2016-07-15 23:19:55.000000000","message":"Same comment.","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":16627,"name":"Chris Morrell","email":"gomeler@gmail.com","username":"Chris_Morrell"},"change_message_id":"08880d5e9395d023391b37d1dfb0d07dcc7109c6","unresolved":false,"context_lines":[{"line_number":1407,"context_line":"| solidfire.max_iops                  | service\u003dsolidfire, cluster | Theoretical maximum amount of IOPs |"},{"line_number":1408,"context_line":"| solidfire.max_meta_space            | service\u003dsolidfire, cluster | Maximum amount of bytes allocated to the metadata services |"},{"line_number":1409,"context_line":"| solidfire.max_overprovisioned_space | service\u003dsolidfire, cluster | Max provisionable space * 5, artificial safety limit |"},{"line_number":1410,"context_line":"| solidfire.max_provisioned_space     | service\u003dsolidfire, cluster | Max provisionable space if 100% metadata space used |"},{"line_number":1411,"context_line":"| solidfire.non_zero_blocks           | service\u003dsolidfire, cluster | Number of 4KiB blocks with data after the last garbage collection |"},{"line_number":1412,"context_line":"| solidfire.peak_iops                 | service\u003dsolidfire, cluster | Peak IOPS since midnight UTC |"},{"line_number":1413,"context_line":"| solidfire.provisioned_space         | service\u003dsolidfire, cluster | Total number of provisioned bytes |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"dada55a8_ddef19af","line":1410,"range":{"start_line":1410,"start_character":2,"end_line":1410,"end_character":11},"in_reply_to":"fad55976_5a74619b","updated":"2016-07-26 21:11:21.000000000","message":"Done","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"3e7209ec587231d6c187281d2b6fadae80afafac","unresolved":false,"context_lines":[{"line_number":1409,"context_line":"| solidfire.max_overprovisioned_space | service\u003dsolidfire, cluster | Max provisionable space * 5, artificial safety limit |"},{"line_number":1410,"context_line":"| solidfire.max_provisioned_space     | service\u003dsolidfire, cluster | Max provisionable space if 100% metadata space used |"},{"line_number":1411,"context_line":"| solidfire.non_zero_blocks           | service\u003dsolidfire, cluster | Number of 4KiB blocks with data after the last garbage collection |"},{"line_number":1412,"context_line":"| solidfire.peak_iops                 | service\u003dsolidfire, cluster | Peak IOPS since midnight UTC |"},{"line_number":1413,"context_line":"| solidfire.provisioned_space         | service\u003dsolidfire, cluster | Total number of provisioned bytes |"},{"line_number":1414,"context_line":"| solidfire.unique_blocks             | service\u003dsolidfire, cluster | Number of blocks(not always 4KiB) stored on block drives |"},{"line_number":1415,"context_line":"| solidfire.unique_blocks_used_space  | service\u003dsolidfire, cluster | Amount of space the unique blocks take on the block drives |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"fad55976_9a41b90e","line":1412,"range":{"start_line":1412,"start_character":12,"end_line":1412,"end_character":21},"updated":"2016-07-15 23:19:55.000000000","message":"Possible name proposal would be\n\nsolidfire.iops.peak\n\nAlso, comments above related to using the avg function, might be applicable here, if the max function can be used and a start/end time.","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":16627,"name":"Chris Morrell","email":"gomeler@gmail.com","username":"Chris_Morrell"},"change_message_id":"08880d5e9395d023391b37d1dfb0d07dcc7109c6","unresolved":false,"context_lines":[{"line_number":1409,"context_line":"| solidfire.max_overprovisioned_space | service\u003dsolidfire, cluster | Max provisionable space * 5, artificial safety limit |"},{"line_number":1410,"context_line":"| solidfire.max_provisioned_space     | service\u003dsolidfire, cluster | Max provisionable space if 100% metadata space used |"},{"line_number":1411,"context_line":"| solidfire.non_zero_blocks           | service\u003dsolidfire, cluster | Number of 4KiB blocks with data after the last garbage collection |"},{"line_number":1412,"context_line":"| solidfire.peak_iops                 | service\u003dsolidfire, cluster | Peak IOPS since midnight UTC |"},{"line_number":1413,"context_line":"| solidfire.provisioned_space         | service\u003dsolidfire, cluster | Total number of provisioned bytes |"},{"line_number":1414,"context_line":"| solidfire.unique_blocks             | service\u003dsolidfire, cluster | Number of blocks(not always 4KiB) stored on block drives |"},{"line_number":1415,"context_line":"| solidfire.unique_blocks_used_space  | service\u003dsolidfire, cluster | Amount of space the unique blocks take on the block drives |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"dada55a8_bd4345ae","line":1412,"range":{"start_line":1412,"start_character":12,"end_line":1412,"end_character":21},"in_reply_to":"fad55976_9a41b90e","updated":"2016-07-26 21:11:21.000000000","message":"Similar to the avg_utc metric, this is simply another pass-through.","commit_id":"9cbc47a17729775297b0a1c618f96b596db65d3d"},{"author":{"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},"change_message_id":"81d8f3b1648e3b26e263fd973148bd879add5bdf","unresolved":false,"context_lines":[{"line_number":1395,"context_line":""},{"line_number":1396,"context_line":"| Metric Name | Dimensions | Semantics |"},{"line_number":1397,"context_line":"| ----------- | ---------- | --------- |"},{"line_number":1398,"context_line":"| solidfire.active_cluster_faults     | service\u003dsolidfire, cluster | Amount of active cluster faults, such as failed drives |"},{"line_number":1399,"context_line":"| solidfire.cluster_utilization       | service\u003dsolidfire, cluster | Overall cluster IOP utilization |"},{"line_number":1400,"context_line":"| solidfire.num_iscsi_sessions        | service\u003dsolidfire, cluster | Amount of active iSCSI sessions connected to the cluster |"},{"line_number":1401,"context_line":"| solidfire.iops.avg_5_sec            | service\u003dsolidfire, cluster | Average IOPs over the last 5 seconds |"}],"source_content_type":"text/x-markdown","patch_set":4,"id":"dada55a8_38574227","line":1398,"updated":"2016-07-27 13:36:15.000000000","message":"maybe a \u0027sf\u0027 prefix?  would shorten all the names a bit...","commit_id":"84bea3e06043d12d84b8df41b2ea2a0ddc157791"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"ad69d84ea6adb788094301b42db6365970c521ed","unresolved":false,"context_lines":[{"line_number":1395,"context_line":""},{"line_number":1396,"context_line":"| Metric Name | Dimensions | Semantics |"},{"line_number":1397,"context_line":"| ----------- | ---------- | --------- |"},{"line_number":1398,"context_line":"| solidfire.active_cluster_faults     | service\u003dsolidfire, cluster | Amount of active cluster faults, such as failed drives |"},{"line_number":1399,"context_line":"| solidfire.cluster_utilization       | service\u003dsolidfire, cluster | Overall cluster IOP utilization |"},{"line_number":1400,"context_line":"| solidfire.num_iscsi_sessions        | service\u003dsolidfire, cluster | Amount of active iSCSI sessions connected to the cluster |"},{"line_number":1401,"context_line":"| solidfire.iops.avg_5_sec            | service\u003dsolidfire, cluster | Average IOPs over the last 5 seconds |"}],"source_content_type":"text/x-markdown","patch_set":4,"id":"bacf61ea_c351a510","line":1398,"in_reply_to":"bacf61ea_256fe993","updated":"2016-07-29 15:04:50.000000000","message":"Personally, I like the full \"solidfire\" prefix. It isn\u0027t that long.","commit_id":"84bea3e06043d12d84b8df41b2ea2a0ddc157791"},{"author":{"_account_id":16627,"name":"Chris Morrell","email":"gomeler@gmail.com","username":"Chris_Morrell"},"change_message_id":"49f06dc1399038c46a85c1d17af592e49a7ea445","unresolved":false,"context_lines":[{"line_number":1395,"context_line":""},{"line_number":1396,"context_line":"| Metric Name | Dimensions | Semantics |"},{"line_number":1397,"context_line":"| ----------- | ---------- | --------- |"},{"line_number":1398,"context_line":"| solidfire.active_cluster_faults     | service\u003dsolidfire, cluster | Amount of active cluster faults, such as failed drives |"},{"line_number":1399,"context_line":"| solidfire.cluster_utilization       | service\u003dsolidfire, cluster | Overall cluster IOP utilization |"},{"line_number":1400,"context_line":"| solidfire.num_iscsi_sessions        | service\u003dsolidfire, cluster | Amount of active iSCSI sessions connected to the cluster |"},{"line_number":1401,"context_line":"| solidfire.iops.avg_5_sec            | service\u003dsolidfire, cluster | Average IOPs over the last 5 seconds |"}],"source_content_type":"text/x-markdown","patch_set":4,"id":"bacf61ea_256fe993","line":1398,"in_reply_to":"dada55a8_38574227","updated":"2016-07-27 16:48:33.000000000","message":"Is the metric name length a concern? I figured it\u0027d all be queried programmatically outside of some initial prototyping/configuration. I tend to learn towards verbosity and clarity, keystrokes are cheap!","commit_id":"84bea3e06043d12d84b8df41b2ea2a0ddc157791"}],"monasca_agent/collector/checks_d/solidfire.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"ad69d84ea6adb788094301b42db6365970c521ed","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class SolidFire(checks.AgentCheck):"},{"line_number":17,"context_line":"    \"\"\"Proof of concept plugin to explore Monasca.\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    def __init__(self, name, init_config, agent_config):"},{"line_number":20,"context_line":"        super(SolidFire, self).__init__(name, init_config, agent_config)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_43dad579","line":17,"range":{"start_line":17,"start_character":16,"end_line":17,"end_character":23},"updated":"2016-07-29 15:04:50.000000000","message":"Do you want to update this comment to remove the Proof of concept part?\" I was assuming that this was production ready or more than a proof-of-concept.","commit_id":"84bea3e06043d12d84b8df41b2ea2a0ddc157791"},{"author":{"_account_id":16627,"name":"Chris Morrell","email":"gomeler@gmail.com","username":"Chris_Morrell"},"change_message_id":"0edc0d18e1beeba3040c9c174d548d11fba2e616","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class SolidFire(checks.AgentCheck):"},{"line_number":17,"context_line":"    \"\"\"Proof of concept plugin to explore Monasca.\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    def __init__(self, name, init_config, agent_config):"},{"line_number":20,"context_line":"        super(SolidFire, self).__init__(name, init_config, agent_config)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_192fe288","line":17,"range":{"start_line":17,"start_character":16,"end_line":17,"end_character":23},"in_reply_to":"bacf61ea_43dad579","updated":"2016-08-01 21:53:04.000000000","message":"I can update that comment. I\u0027d still consider it a PoC though, this was just enough to get a customer\u0027s eyes on it. I\u0027d imagine there\u0027ll be a good bit of work pending their requests.","commit_id":"84bea3e06043d12d84b8df41b2ea2a0ddc157791"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"ad69d84ea6adb788094301b42db6365970c521ed","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        dimensions \u003d {\u0027service\u0027: \u0027solidfire\u0027,"},{"line_number":28,"context_line":"                      \u0027cluster\u0027: self.cluster}"},{"line_number":29,"context_line":"        data \u003d {}"},{"line_number":30,"context_line":"        num_of_metrics \u003d 0"},{"line_number":31,"context_line":"        # Extract cluster auth information"},{"line_number":32,"context_line":"        auth \u003d self._pull_auth(instance)"},{"line_number":33,"context_line":"        self.sf \u003d SolidFireLib(auth)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_63027940","line":30,"updated":"2016-07-29 15:04:50.000000000","message":"I think a variable name of num_metrics would be a little nicer.","commit_id":"84bea3e06043d12d84b8df41b2ea2a0ddc157791"},{"author":{"_account_id":16627,"name":"Chris Morrell","email":"gomeler@gmail.com","username":"Chris_Morrell"},"change_message_id":"0edc0d18e1beeba3040c9c174d548d11fba2e616","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        dimensions \u003d {\u0027service\u0027: \u0027solidfire\u0027,"},{"line_number":28,"context_line":"                      \u0027cluster\u0027: self.cluster}"},{"line_number":29,"context_line":"        data \u003d {}"},{"line_number":30,"context_line":"        num_of_metrics \u003d 0"},{"line_number":31,"context_line":"        # Extract cluster auth information"},{"line_number":32,"context_line":"        auth \u003d self._pull_auth(instance)"},{"line_number":33,"context_line":"        self.sf \u003d SolidFireLib(auth)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_d93f0ab2","line":30,"in_reply_to":"bacf61ea_63027940","updated":"2016-08-01 21:53:04.000000000","message":"Works for me","commit_id":"84bea3e06043d12d84b8df41b2ea2a0ddc157791"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"ad69d84ea6adb788094301b42db6365970c521ed","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            self.gauge(key, value, dimensions)"},{"line_number":47,"context_line":"            num_of_metrics +\u003d 1"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        LOG.info(\u0027Collected %s metrics\u0027 % (num_of_metrics))"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _pull_auth(self, instance):"},{"line_number":52,"context_line":"        \"\"\"Extract auth data from instance data."}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_9e9f025f","line":49,"updated":"2016-07-29 15:04:50.000000000","message":"Not really sure you want to add a log info statement, as that will clutter up the log files with lot\u0027s of data. Would a log debug message be sufficient?","commit_id":"84bea3e06043d12d84b8df41b2ea2a0ddc157791"},{"author":{"_account_id":16627,"name":"Chris Morrell","email":"gomeler@gmail.com","username":"Chris_Morrell"},"change_message_id":"0edc0d18e1beeba3040c9c174d548d11fba2e616","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            self.gauge(key, value, dimensions)"},{"line_number":47,"context_line":"            num_of_metrics +\u003d 1"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        LOG.info(\u0027Collected %s metrics\u0027 % (num_of_metrics))"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _pull_auth(self, instance):"},{"line_number":52,"context_line":"        \"\"\"Extract auth data from instance data."}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_394bc65a","line":49,"in_reply_to":"bacf61ea_9e9f025f","updated":"2016-08-01 21:53:04.000000000","message":"Done","commit_id":"84bea3e06043d12d84b8df41b2ea2a0ddc157791"}]}