)]}'
{"monasca_setup/detection/plugins/kafka_consumer.py":[{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"8c6c5b8eda26e6804c3242a7757beffc51a26977","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            kafka_connect_str \u003d self._find_kafka_connection()"},{"line_number":129,"context_line":"            consumers \u003d {}"},{"line_number":130,"context_line":"            if \u0027service_name\u0027 in self.args:"},{"line_number":131,"context_line":"                service_name \u003d \u0027_\u0027 + str(self.args[\u0027service_name\u0027])"},{"line_number":132,"context_line":"                del self.args[\u0027service_name\u0027]"},{"line_number":133,"context_line":"            else:"},{"line_number":134,"context_line":"                service_name \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_77c86e57","line":131,"range":{"start_line":131,"start_character":0,"end_line":131,"end_character":67},"updated":"2016-07-14 02:39:04.000000000","message":"You can use the dictionary pop method to return and remove a key all at once.\n\nI think it would be more clear to build the final name string all in one operation.  Rather than prepending _ to service_name here you could do it when you combine kafka_connect_str and service_name further down.","commit_id":"ec64f8c7d4d4e0b0dd16cce9aafa22c94f67afa3"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"8c6c5b8eda26e6804c3242a7757beffc51a26977","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                value_dict \u003d {topic: [] for topic in value.split(\u0027/\u0027)}"},{"line_number":137,"context_line":"                consumers[key] \u003d value_dict"},{"line_number":138,"context_line":"                self.config[\u0027kafka_consumer\u0027] \u003d {\u0027init_config\u0027: None,"},{"line_number":139,"context_line":"                                                 \u0027instances\u0027: [{\u0027name\u0027: (kafka_connect_str + service_name),"},{"line_number":140,"context_line":"                                                                \u0027kafka_connect_str\u0027: kafka_connect_str,"},{"line_number":141,"context_line":"                                                                \u0027per_partition\u0027: False,"},{"line_number":142,"context_line":"                                                                \u0027consumer_groups\u0027: consumers}]}"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_57f3b29f","line":139,"range":{"start_line":139,"start_character":72,"end_line":139,"end_character":73},"updated":"2016-07-14 02:39:04.000000000","message":"If we\u0027re not using ( to do any line wrapping here it may be worth leaving them off so it doesn\u0027t look like we\u0027re trying to do anything with a tuple.","commit_id":"ec64f8c7d4d4e0b0dd16cce9aafa22c94f67afa3"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"cb4bce835579727a31afd2260cc5b34a058f01ae","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            kafka_connect_str \u003d self._find_kafka_connection()"},{"line_number":129,"context_line":"            consumers \u003d {}"},{"line_number":130,"context_line":"            if \u0027service_name\u0027 in self.args:"},{"line_number":131,"context_line":"                service_name \u003d str(self.args.pop([\u0027service_name\u0027])"},{"line_number":132,"context_line":"            else:"},{"line_number":133,"context_line":"                service_name \u003d \u0027\u0027"},{"line_number":134,"context_line":"            for key, value in self.args.iteritems():"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_aab36ce8","line":131,"range":{"start_line":131,"start_character":65,"end_line":131,"end_character":66},"updated":"2016-07-14 16:12:17.000000000","message":"miss another ) here?","commit_id":"043e040c74667dd0ae592b2bd1d0dee8cd3fe10e"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"4591a8eb8f9d159ba71d849f79928806b54bbd98","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2015 Hewlett Packard Enterprise Development Company LP"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import logging"},{"line_number":4,"context_line":"import re"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_4d4822cd","line":1,"range":{"start_line":1,"start_character":29,"end_line":1,"end_character":36},"updated":"2016-07-14 16:36:19.000000000","message":"Change the copyright please","commit_id":"c41d699aa58db1789af501ea9d3bfe350ebf4c77"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"4e7bae280c672815b518768e6334bafac9595d9e","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            kafka_connect_str \u003d self._find_kafka_connection()"},{"line_number":129,"context_line":"            consumers \u003d {}"},{"line_number":130,"context_line":"            if \u0027service_name\u0027 in self.args:"},{"line_number":131,"context_line":"                service_name \u003d str(self.args.pop([\u0027service_name\u0027]))"},{"line_number":132,"context_line":"            else:"},{"line_number":133,"context_line":"                service_name \u003d \u0027\u0027"},{"line_number":134,"context_line":"            for key, value in self.args.iteritems():"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_18a7690c","line":131,"range":{"start_line":131,"start_character":49,"end_line":131,"end_character":50},"updated":"2016-07-14 21:39:24.000000000","message":"shouldn\u0027t be in a list","commit_id":"afed9e38ca1ad1f54b5d72e838daea5f796b5556"},{"author":{"_account_id":22157,"name":"Andrea Adams","email":"aadams@hpe.com","username":"andrea.adams"},"change_message_id":"c3d1ba6b9097c466ab5bc07ee7659bc2a286668a","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            kafka_connect_str \u003d self._find_kafka_connection()"},{"line_number":129,"context_line":"            consumers \u003d {}"},{"line_number":130,"context_line":"            if \u0027service_name\u0027 in self.args:"},{"line_number":131,"context_line":"                service_name \u003d str(self.args.pop([\u0027service_name\u0027]))"},{"line_number":132,"context_line":"            else:"},{"line_number":133,"context_line":"                service_name \u003d \u0027\u0027"},{"line_number":134,"context_line":"            for key, value in self.args.iteritems():"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_d832010f","line":131,"range":{"start_line":131,"start_character":49,"end_line":131,"end_character":50},"in_reply_to":"1aa78d24_18a7690c","updated":"2016-07-14 22:00:39.000000000","message":"Done","commit_id":"afed9e38ca1ad1f54b5d72e838daea5f796b5556"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"8a99dc7fca705de470ed47136fc47f3b522d5f24","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            for key, value in self.args.iteritems():"},{"line_number":135,"context_line":"                value_dict \u003d {topic: [] for topic in value.split(\u0027/\u0027)}"},{"line_number":136,"context_line":"                consumers[key] \u003d value_dict"},{"line_number":137,"context_line":"                self.config[\u0027kafka_consumer\u0027] \u003d {\u0027init_config\u0027: None,"},{"line_number":138,"context_line":"                                                 \u0027instances\u0027: [{\u0027name\u0027: kafka_connect_str + \u0027_\u0027 + service_name,"},{"line_number":139,"context_line":"                                                                \u0027kafka_connect_str\u0027: kafka_connect_str,"},{"line_number":140,"context_line":"                                                                \u0027per_partition\u0027: False,"},{"line_number":141,"context_line":"                                                                \u0027consumer_groups\u0027: consumers}]}"},{"line_number":142,"context_line":"        elif self.zk_url is not None:"},{"line_number":143,"context_line":"            self._detect_consumers()"},{"line_number":144,"context_line":"        return self.config"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_78e66d17","line":141,"range":{"start_line":137,"start_character":16,"end_line":141,"end_character":95},"updated":"2016-07-14 21:42:49.000000000","message":"Why is this indented under the for loop? Don\u0027t we only want to execute this once?","commit_id":"afed9e38ca1ad1f54b5d72e838daea5f796b5556"},{"author":{"_account_id":22157,"name":"Andrea Adams","email":"aadams@hpe.com","username":"andrea.adams"},"change_message_id":"c3d1ba6b9097c466ab5bc07ee7659bc2a286668a","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            for key, value in self.args.iteritems():"},{"line_number":135,"context_line":"                value_dict \u003d {topic: [] for topic in value.split(\u0027/\u0027)}"},{"line_number":136,"context_line":"                consumers[key] \u003d value_dict"},{"line_number":137,"context_line":"                self.config[\u0027kafka_consumer\u0027] \u003d {\u0027init_config\u0027: None,"},{"line_number":138,"context_line":"                                                 \u0027instances\u0027: [{\u0027name\u0027: kafka_connect_str + \u0027_\u0027 + service_name,"},{"line_number":139,"context_line":"                                                                \u0027kafka_connect_str\u0027: kafka_connect_str,"},{"line_number":140,"context_line":"                                                                \u0027per_partition\u0027: False,"},{"line_number":141,"context_line":"                                                                \u0027consumer_groups\u0027: consumers}]}"},{"line_number":142,"context_line":"        elif self.zk_url is not None:"},{"line_number":143,"context_line":"            self._detect_consumers()"},{"line_number":144,"context_line":"        return self.config"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_383a25e8","line":141,"range":{"start_line":137,"start_character":16,"end_line":141,"end_character":95},"in_reply_to":"1aa78d24_78e66d17","updated":"2016-07-14 22:00:39.000000000","message":"Done","commit_id":"afed9e38ca1ad1f54b5d72e838daea5f796b5556"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"eda377c56a1506a1949733a2c5bd7dcd115e5f67","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                value_dict \u003d {topic: [] for topic in value.split(\u0027/\u0027)}"},{"line_number":136,"context_line":"                consumers[key] \u003d value_dict"},{"line_number":137,"context_line":"            self.config[\u0027kafka_consumer\u0027] \u003d {\u0027init_config\u0027: None,"},{"line_number":138,"context_line":"                                             \u0027instances\u0027: [{\u0027name\u0027: kafka_connect_str + \u0027_\u0027 + service_name,"},{"line_number":139,"context_line":"                                                            \u0027kafka_connect_str\u0027: kafka_connect_str,"},{"line_number":140,"context_line":"                                                            \u0027per_partition\u0027: False,"},{"line_number":141,"context_line":"                                                            \u0027consumer_groups\u0027: consumers}]}"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_939b1b66","line":138,"range":{"start_line":138,"start_character":68,"end_line":138,"end_character":106},"updated":"2016-07-15 13:43:14.000000000","message":"If a service_name is not passed in, then this will result in the name being the\nkafka_connect_str with an underscored appended to it. That does not seem helpful. Maybe not add the underscore if service_name is empty?","commit_id":"6cb9e15071f5603ebc6c25737fa5d4c1fb6535b9"},{"author":{"_account_id":22157,"name":"Andrea Adams","email":"aadams@hpe.com","username":"andrea.adams"},"change_message_id":"1f668eb5acbb8be31fd90d4bef82a7fbda5e5983","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                value_dict \u003d {topic: [] for topic in value.split(\u0027/\u0027)}"},{"line_number":136,"context_line":"                consumers[key] \u003d value_dict"},{"line_number":137,"context_line":"            self.config[\u0027kafka_consumer\u0027] \u003d {\u0027init_config\u0027: None,"},{"line_number":138,"context_line":"                                             \u0027instances\u0027: [{\u0027name\u0027: kafka_connect_str + \u0027_\u0027 + service_name,"},{"line_number":139,"context_line":"                                                            \u0027kafka_connect_str\u0027: kafka_connect_str,"},{"line_number":140,"context_line":"                                                            \u0027per_partition\u0027: False,"},{"line_number":141,"context_line":"                                                            \u0027consumer_groups\u0027: consumers}]}"}],"source_content_type":"text/x-python","patch_set":6,"id":"fad55976_644606c1","line":138,"range":{"start_line":138,"start_character":68,"end_line":138,"end_character":106},"in_reply_to":"1aa78d24_939b1b66","updated":"2016-07-15 15:54:13.000000000","message":"Done","commit_id":"6cb9e15071f5603ebc6c25737fa5d4c1fb6535b9"}]}