)]}'
{"monasca_agent/collector/checks_d/http_check.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"0853bcf7a46a52896bc26f955f61a0c633e0f568","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                length \u003d int((time.time() - start) * 1000)"},{"line_number":110,"context_line":"                error_msg \u003d \u0027error: {0}. Connection failed after {1} \u0027 \\"},{"line_number":111,"context_line":"                            \u0027ms\u0027.format(repr(e), length)"},{"line_number":112,"context_line":"                warn_string \u003d \u0027{0} is DOWN, \u0027.format(addr) + error_msg"},{"line_number":113,"context_line":"                if addr not in self._socket_errors:"},{"line_number":114,"context_line":"                    self._socket_errors.add(addr)"},{"line_number":115,"context_line":"                    self.log.warn(warn_string)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_c4863dda","line":112,"range":{"start_line":112,"start_character":16,"end_line":112,"end_character":27},"updated":"2016-07-20 14:17:17.000000000","message":"not big deal but you use warn_string here and warning_string above. Can we match that name throughout?","commit_id":"38c0b1018e61e20872d535409ea79c2377a025ea"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"802084676e2b6cdf09518a193dbf61ec545e5cec","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                length \u003d int((time.time() - start) * 1000)"},{"line_number":110,"context_line":"                error_msg \u003d \u0027error: {0}. Connection failed after {1} \u0027 \\"},{"line_number":111,"context_line":"                            \u0027ms\u0027.format(repr(e), length)"},{"line_number":112,"context_line":"                warn_string \u003d \u0027{0} is DOWN, \u0027.format(addr) + error_msg"},{"line_number":113,"context_line":"                if addr not in self._socket_errors:"},{"line_number":114,"context_line":"                    self._socket_errors.add(addr)"},{"line_number":115,"context_line":"                    self.log.warn(warn_string)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_a164cdb8","line":112,"updated":"2016-07-20 17:31:45.000000000","message":"This should be inside the if below. It is only used if that if evaluates true. And it is weird to mix the format() with the +. Better to use format() for both","commit_id":"80932c44c4e61c9c216d8124c87190e2dbd6c952"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"0cd939cc822c5cafbcd9e8484fd8d6dc70d9dbb0","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                length \u003d int((time.time() - start) * 1000)"},{"line_number":110,"context_line":"                error_msg \u003d \u0027error: {0}. Connection failed after {1} \u0027 \\"},{"line_number":111,"context_line":"                            \u0027ms\u0027.format(repr(e), length)"},{"line_number":112,"context_line":"                warn_string \u003d \u0027{0} is DOWN, \u0027.format(addr) + error_msg"},{"line_number":113,"context_line":"                if addr not in self._socket_errors:"},{"line_number":114,"context_line":"                    self._socket_errors.add(addr)"},{"line_number":115,"context_line":"                    self.log.warn(warn_string)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_17b872c7","line":112,"in_reply_to":"dada55a8_a164cdb8","updated":"2016-07-20 22:01:31.000000000","message":"Thank you Craig!","commit_id":"80932c44c4e61c9c216d8124c87190e2dbd6c952"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"802084676e2b6cdf09518a193dbf61ec545e5cec","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                length \u003d int((time.time() - start) * 1000)"},{"line_number":120,"context_line":"                error_msg \u003d \u0027error: {0}. Network is not routable after {1} \u0027 \\"},{"line_number":121,"context_line":"                            \u0027ms\u0027.format(repr(e), length)"},{"line_number":122,"context_line":"                warn_string \u003d \u0027{0} is DOWN, \u0027.format(addr) + error_msg"},{"line_number":123,"context_line":"                if addr not in self._response_not_ready:"},{"line_number":124,"context_line":"                    self._response_not_ready.add(addr)"},{"line_number":125,"context_line":"                    self.log.warn(warn_string)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_41e991e5","line":122,"updated":"2016-07-20 17:31:45.000000000","message":"See above","commit_id":"80932c44c4e61c9c216d8124c87190e2dbd6c952"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"802084676e2b6cdf09518a193dbf61ec545e5cec","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            except Exception as e:"},{"line_number":129,"context_line":"                length \u003d int((time.time() - start) * 1000)"},{"line_number":130,"context_line":"                error_msg \u003d \u0027error: {0}. Connection failed after {1} ms\u0027.format(repr(e), length)"},{"line_number":131,"context_line":"                error_string \u003d \u0027{0} is DOWN, \u0027.format(addr) + error_msg"},{"line_number":132,"context_line":"                if addr not in self._general_exception:"},{"line_number":133,"context_line":"                    self._general_exception.add(addr)"},{"line_number":134,"context_line":"                    self.log.error(error_string)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_4174f166","line":131,"updated":"2016-07-20 17:31:45.000000000","message":"See above","commit_id":"80932c44c4e61c9c216d8124c87190e2dbd6c952"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"802084676e2b6cdf09518a193dbf61ec545e5cec","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                if use_keystone and int(resp.status) \u003d\u003d 401:"},{"line_number":144,"context_line":"                    if retry:"},{"line_number":145,"context_line":"                        error_msg \u003d \u0027unable to get a valid token to connect with\u0027"},{"line_number":146,"context_line":"                        error_string \u003d \u0027{0} is DOWN, \u0027.format(addr) + error_msg"},{"line_number":147,"context_line":"                        if addr not in self._invalid_token:"},{"line_number":148,"context_line":"                            self._invalid_token.add(addr)"},{"line_number":149,"context_line":"                            self.log.error(error_string)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_616775b7","line":146,"updated":"2016-07-20 17:31:45.000000000","message":"See above","commit_id":"80932c44c4e61c9c216d8124c87190e2dbd6c952"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"802084676e2b6cdf09518a193dbf61ec545e5cec","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                        continue"},{"line_number":157,"context_line":"                else:"},{"line_number":158,"context_line":"                    warn_msg \u003d \u0027error code: {0}\u0027.format(str(resp.status))"},{"line_number":159,"context_line":"                    warn_string \u003d \u0027{0} is DOWN, \u0027.format(addr) + warn_msg"},{"line_number":160,"context_line":"                    if addr not in self._warn_msg:"},{"line_number":161,"context_line":"                        self._warn_msg.add(addr)"},{"line_number":162,"context_line":"                        self.log.warn(warn_string)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_a1320da5","line":159,"range":{"start_line":159,"start_character":20,"end_line":159,"end_character":73},"updated":"2016-07-20 17:31:45.000000000","message":"See above","commit_id":"80932c44c4e61c9c216d8124c87190e2dbd6c952"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"93c9be61a9744a046e7248f7bc736e524427819d","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                    headers[\"Content-type\"] \u003d \"application/json\""},{"line_number":93,"context_line":"                else:"},{"line_number":94,"context_line":"                    error_msg \u003d \"Unable to get token. Keystone API server \" \\"},{"line_number":95,"context_line":"                                \"may be down. \""},{"line_number":96,"context_line":"                    warn_string \u003d error_msg + \u0027Skipping check for {0}\u0027.format(addr)"},{"line_number":97,"context_line":"                    self.log.warning(warn_string)"},{"line_number":98,"context_line":"                    return False, error_msg"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_f27facdd","line":95,"range":{"start_line":95,"start_character":45,"end_line":95,"end_character":46},"updated":"2016-07-20 22:35:09.000000000","message":"error_msg should not have a trailing space","commit_id":"ffce1278a9c6648b5a124e7893824aaaea76b947"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"93c9be61a9744a046e7248f7bc736e524427819d","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                else:"},{"line_number":94,"context_line":"                    error_msg \u003d \"Unable to get token. Keystone API server \" \\"},{"line_number":95,"context_line":"                                \"may be down. \""},{"line_number":96,"context_line":"                    warn_string \u003d error_msg + \u0027Skipping check for {0}\u0027.format(addr)"},{"line_number":97,"context_line":"                    self.log.warning(warn_string)"},{"line_number":98,"context_line":"                    return False, error_msg"},{"line_number":99,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_726c5c35","line":96,"range":{"start_line":96,"start_character":34,"end_line":96,"end_character":83},"updated":"2016-07-20 22:35:09.000000000","message":"Sorry, forgot to point out the mixed + and format() calls on this one","commit_id":"ffce1278a9c6648b5a124e7893824aaaea76b947"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"4785b020c4b2d72025b5ad07d7a01ab08eeaad4b","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                else:"},{"line_number":94,"context_line":"                    error_msg \u003d \"Unable to get token. Keystone API server \" \\"},{"line_number":95,"context_line":"                                \"may be down. \""},{"line_number":96,"context_line":"                    warn_string \u003d error_msg + \u0027Skipping check for {0}\u0027.format(addr)"},{"line_number":97,"context_line":"                    self.log.warning(warn_string)"},{"line_number":98,"context_line":"                    return False, error_msg"},{"line_number":99,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_1297e0ec","line":96,"range":{"start_line":96,"start_character":34,"end_line":96,"end_character":83},"in_reply_to":"dada55a8_726c5c35","updated":"2016-07-20 22:39:26.000000000","message":"Sorry I missed it too.","commit_id":"ffce1278a9c6648b5a124e7893824aaaea76b947"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"93c9be61a9744a046e7248f7bc736e524427819d","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                if addr not in self._socket_errors:"},{"line_number":113,"context_line":"                    self._socket_errors.add(addr)"},{"line_number":114,"context_line":"                    warn_string \u003d \u0027{0} is DOWN, {1}\u0027.format(addr, error_msg)"},{"line_number":115,"context_line":"                    self.log.warn(warn_string)"},{"line_number":116,"context_line":"                return False, error_msg"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"            except httplib.ResponseNotReady as e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_b249b4b9","line":115,"range":{"start_line":115,"start_character":34,"end_line":115,"end_character":45},"updated":"2016-07-20 22:35:09.000000000","message":"Should you just inline warn_string now? I\u0027m fine with either way, it is just a question of style. Use whichever you feel is easiest to read","commit_id":"ffce1278a9c6648b5a124e7893824aaaea76b947"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"4785b020c4b2d72025b5ad07d7a01ab08eeaad4b","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                if addr not in self._socket_errors:"},{"line_number":113,"context_line":"                    self._socket_errors.add(addr)"},{"line_number":114,"context_line":"                    warn_string \u003d \u0027{0} is DOWN, {1}\u0027.format(addr, error_msg)"},{"line_number":115,"context_line":"                    self.log.warn(warn_string)"},{"line_number":116,"context_line":"                return False, error_msg"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"            except httplib.ResponseNotReady as e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_327024dc","line":115,"range":{"start_line":115,"start_character":34,"end_line":115,"end_character":45},"in_reply_to":"dada55a8_b249b4b9","updated":"2016-07-20 22:39:26.000000000","message":"Personally I think using warn_string is easier to read :-)","commit_id":"ffce1278a9c6648b5a124e7893824aaaea76b947"}]}