)]}'
{"tests/test_metrics.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"6d277fe1d3d48663fd25095b2613607518b01d44","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        self.assertEqual(measurement[\u0027value\u0027], 5)"},{"line_number":129,"context_line":"        self.assertEqual(measurement[\u0027timestamp\u0027], 3000)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        rate.sample(10, SAMPLE_RATE, 3)"},{"line_number":132,"context_line":"        self.assertEqual(rate.flush(), [])"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        rate.sample(10, SAMPLE_RATE, 4)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_5131a804","line":131,"range":{"start_line":131,"start_character":20,"end_line":131,"end_character":22},"updated":"2016-08-09 19:46:18.000000000","message":"This would be a better test if this was 12 and the next value sent was \u003e 12. That would ensure that this value was saved","commit_id":"c00cd803cf958340983140f0a67a2e4186f18d7a"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"81abe5505bdac67add83f5de2bd8c941ca4528e9","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        self.assertEqual(measurement[\u0027value\u0027], 5)"},{"line_number":129,"context_line":"        self.assertEqual(measurement[\u0027timestamp\u0027], 3000)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        rate.sample(10, SAMPLE_RATE, 3)"},{"line_number":132,"context_line":"        self.assertEqual(rate.flush(), [])"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        rate.sample(10, SAMPLE_RATE, 4)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_a5b7fed6","line":131,"range":{"start_line":131,"start_character":20,"end_line":131,"end_character":22},"in_reply_to":"9ad45d7e_5131a804","updated":"2016-08-09 21:18:38.000000000","message":"Done","commit_id":"c00cd803cf958340983140f0a67a2e4186f18d7a"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"6d277fe1d3d48663fd25095b2613607518b01d44","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        self.assertEqual(measurement[\u0027name\u0027], metric_name)"},{"line_number":140,"context_line":"        self.assertEqual(measurement[\u0027dimensions\u0027], dimensions)"},{"line_number":141,"context_line":"        self.assertEqual(measurement[\u0027value\u0027], 0.0)"},{"line_number":142,"context_line":"        self.assertEqual(measurement[\u0027timestamp\u0027], 4000)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_f40fea2b","line":142,"updated":"2016-08-09 19:46:18.000000000","message":"You should add a test for a decrease in value but a larger timestamp","commit_id":"c00cd803cf958340983140f0a67a2e4186f18d7a"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"81abe5505bdac67add83f5de2bd8c941ca4528e9","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        self.assertEqual(measurement[\u0027name\u0027], metric_name)"},{"line_number":140,"context_line":"        self.assertEqual(measurement[\u0027dimensions\u0027], dimensions)"},{"line_number":141,"context_line":"        self.assertEqual(measurement[\u0027value\u0027], 0.0)"},{"line_number":142,"context_line":"        self.assertEqual(measurement[\u0027timestamp\u0027], 4000)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_e5b1f6e2","line":142,"in_reply_to":"9ad45d7e_f40fea2b","updated":"2016-08-09 21:18:38.000000000","message":"Done","commit_id":"c00cd803cf958340983140f0a67a2e4186f18d7a"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"ce996161c1d8a158952928766bd1f885a9877711","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        rate.sample(5, SAMPLE_RATE, 2)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        envelope \u003d rate.flush()[0]"},{"line_number":114,"context_line":"        measurement \u003d envelope[\u0027measurement\u0027]"},{"line_number":115,"context_line":"        self.assertEqual(envelope[\u0027tenant_id\u0027], tenant_name)"},{"line_number":116,"context_line":"        self.assertEqual(measurement[\u0027name\u0027], metric_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_b1cfd654","line":113,"range":{"start_line":113,"start_character":19,"end_line":113,"end_character":34},"updated":"2016-08-11 14:25:39.000000000","message":"This reports an \u0027index out of range\u0027 for me and the test fails","commit_id":"b80f070c574044c25d15270f1c1afbde5eedc077"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"b5626c2e1d6e0288ce385a964eb2377bcc34ad46","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        rate.sample(5, SAMPLE_RATE, 2)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        envelope \u003d rate.flush()[0]"},{"line_number":114,"context_line":"        measurement \u003d envelope[\u0027measurement\u0027]"},{"line_number":115,"context_line":"        self.assertEqual(envelope[\u0027tenant_id\u0027], tenant_name)"},{"line_number":116,"context_line":"        self.assertEqual(measurement[\u0027name\u0027], metric_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_f4a77ca4","line":113,"range":{"start_line":113,"start_character":19,"end_line":113,"end_character":34},"in_reply_to":"9ad45d7e_b1cfd654","updated":"2016-08-11 14:36:42.000000000","message":"It will report that without Kaiyan\u0027s patch set.  I added the depends-on to make it pass check but it sounds like it\u0027s not respecting that when you just download this patch set.","commit_id":"b80f070c574044c25d15270f1c1afbde5eedc077"}]}
