)]}'
{"monasca_agent/collector/checks_d/ntp.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"73dd156642c6ddfda25673b681c604c1ffbfcd56","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2015 Hewlett Packard Enterprise Development Company LP"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import ntplib"},{"line_number":4,"context_line":"import time"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_0fd8e61c","line":1,"range":{"start_line":1,"start_character":29,"end_line":1,"end_character":36},"updated":"2016-08-31 14:33:35.000000000","message":"make sure you address the copyright","commit_id":"15d17579c9fee4fa5f2a5f3eb6fec4a837d08908"},{"author":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"change_message_id":"e088c4be6e34ad4ee6c43e2ff424514bb0925850","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2015 Hewlett Packard Enterprise Development Company LP"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import ntplib"},{"line_number":4,"context_line":"import time"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_757ea0af","line":1,"range":{"start_line":1,"start_character":29,"end_line":1,"end_character":36},"in_reply_to":"fa7ab95a_0fd8e61c","updated":"2016-08-31 15:45:27.000000000","message":"Done","commit_id":"15d17579c9fee4fa5f2a5f3eb6fec4a837d08908"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"73dd156642c6ddfda25673b681c604c1ffbfcd56","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        except ntplib.NTPException as err:"},{"line_number":28,"context_line":"            self.log.error(\"Could not connect to NTP Server: %s\" % err)"},{"line_number":29,"context_line":"            # Report very large offset (57005) to indicate a problem"},{"line_number":30,"context_line":"            self.gauge(\u0027ntp.offset\u0027, 0xdead, timestamp\u003dtime.time(),"},{"line_number":31,"context_line":"                       dimensions\u003ddimensions)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_6f59728e","line":30,"range":{"start_line":30,"start_character":28,"end_line":30,"end_character":34},"updated":"2016-08-31 14:33:35.000000000","message":"i wonder if instead of doing this we have a ntp.connection metric that we report as down here. and up when we can connect. What are your thoughts?","commit_id":"15d17579c9fee4fa5f2a5f3eb6fec4a837d08908"},{"author":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"change_message_id":"e088c4be6e34ad4ee6c43e2ff424514bb0925850","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        except ntplib.NTPException as err:"},{"line_number":28,"context_line":"            self.log.error(\"Could not connect to NTP Server: %s\" % err)"},{"line_number":29,"context_line":"            # Report very large offset (57005) to indicate a problem"},{"line_number":30,"context_line":"            self.gauge(\u0027ntp.offset\u0027, 0xdead, timestamp\u003dtime.time(),"},{"line_number":31,"context_line":"                       dimensions\u003ddimensions)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_804cc077","line":30,"range":{"start_line":30,"start_character":28,"end_line":30,"end_character":34},"in_reply_to":"fa7ab95a_6f59728e","updated":"2016-08-31 15:45:27.000000000","message":"I wondered about that, but did not see a similar design pattern elsewhere. As a possible alternate to a new metric, I updated the docs to explain what a large offset means.","commit_id":"15d17579c9fee4fa5f2a5f3eb6fec4a837d08908"}]}