)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"change_message_id":"8d497fe6bce5df34f7b1082e77061c10c0f4e240","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ntp connection status metric"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0caf4ccc51693d0008fa509526a633280955cd6a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa7ab95a_95a4b6a6","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":8},"updated":"2016-09-01 16:35:19.000000000","message":"Closes-bug missing","commit_id":"924b9cfcb4d57573b77727cefe63c358f580912e"}],"monasca_agent/collector/checks_d/ntp.py":[{"author":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"change_message_id":"dd72c25e90346065c815d23e63c87ab88f5b72f7","unresolved":false,"context_lines":[{"line_number":26,"context_line":"            ntp_stats \u003d ntplib.NTPClient().request(**req_args)"},{"line_number":27,"context_line":"        except ntplib.NTPException as err:"},{"line_number":28,"context_line":"            self.log.error(\"Could not connect to NTP Server: %s\" % err)"},{"line_number":29,"context_line":"            self.gauge(\u0027ntp.connection_status\u0027, 1, dimensions\u003ddimensions)"},{"line_number":30,"context_line":"        else:"},{"line_number":31,"context_line":"            ntp_offset \u003d ntp_stats.offset"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_ed49ae32","line":29,"range":{"start_line":29,"start_character":62,"end_line":29,"end_character":72},"updated":"2016-09-01 20:08:29.000000000","message":"Can you add ntp.server as a dimension? Speeds up interpretation of an alarm because the name will be right there in the dimensions (assuming good choice of match_by). The alternative is that an operator will need to look at conf files or the log to find the name.  httpcheck uses the url dimension for similar reasons.","commit_id":"924b9cfcb4d57573b77727cefe63c358f580912e"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"7da4a538eac4987b09bddd55321a3ec2da81f62d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"            ntp_stats \u003d ntplib.NTPClient().request(**req_args)"},{"line_number":28,"context_line":"        except ntplib.NTPException as err:"},{"line_number":29,"context_line":"            self.log.error(\"Could not connect to NTP Server: %s\" % err)"},{"line_number":30,"context_line":"            self.gauge(\u0027ntp.connection_status\u0027, 1, dimensions\u003ddimensions)"},{"line_number":31,"context_line":"        else:"},{"line_number":32,"context_line":"            ntp_offset \u003d ntp_stats.offset"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_28022f3f","line":30,"range":{"start_line":30,"start_character":17,"end_line":30,"end_character":22},"updated":"2016-09-02 21:10:46.000000000","message":"Does it make sense to put the message from err into the value_meta?","commit_id":"1a9d3a861652eeba431b15e20b94c02b4d781340"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"dd418d3bb9a1cb5c9f1ba91fdd76f84d3779119a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"            ntp_stats \u003d ntplib.NTPClient().request(**req_args)"},{"line_number":28,"context_line":"        except ntplib.NTPException as err:"},{"line_number":29,"context_line":"            self.log.error(\"Could not connect to NTP Server: %s\" % err)"},{"line_number":30,"context_line":"            self.gauge(\u0027ntp.connection_status\u0027, 1, dimensions\u003ddimensions)"},{"line_number":31,"context_line":"        else:"},{"line_number":32,"context_line":"            ntp_offset \u003d ntp_stats.offset"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_735df1e8","line":30,"range":{"start_line":30,"start_character":17,"end_line":30,"end_character":22},"in_reply_to":"9a89bdaa_28022f3f","updated":"2016-09-04 21:22:22.000000000","message":"If there\u0027s a way to display this somewhere, somehow - why not.","commit_id":"1a9d3a861652eeba431b15e20b94c02b4d781340"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"542fcf4b9dce0418c50b7d6a5811c3788b6c8a9a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"            ntp_stats \u003d ntplib.NTPClient().request(**req_args)"},{"line_number":28,"context_line":"        except ntplib.NTPException as err:"},{"line_number":29,"context_line":"            self.log.error(\"Could not connect to NTP Server: %s\" % err)"},{"line_number":30,"context_line":"            self.gauge(\u0027ntp.connection_status\u0027, 1, dimensions\u003ddimensions)"},{"line_number":31,"context_line":"        else:"},{"line_number":32,"context_line":"            ntp_offset \u003d ntp_stats.offset"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_68eda924","line":30,"range":{"start_line":30,"start_character":17,"end_line":30,"end_character":22},"in_reply_to":"9a89bdaa_735df1e8","updated":"2016-09-06 15:46:55.000000000","message":"I\u0027m going to approve this now and the value_meta can be added in a follow commit.","commit_id":"1a9d3a861652eeba431b15e20b94c02b4d781340"}]}