)]}'
{"monasca_setup/detection/args_plugin.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"74067fbed636a44d42b553a1f9fe9f7c966a36ba","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        if \u0027dimensions\u0027 in self.args:"},{"line_number":25,"context_line":"            instance[\u0027dimensions\u0027] \u003d dict(item.strip().split(\":\") for item in self.args[\u0027dimensions\u0027].split(\",\"))"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        if \u0027keystone_config\u0027 in self.args:"},{"line_number":28,"context_line":"            instance[\u0027keystone_config\u0027] \u003d dict(item.strip().split(\":\", 1) for item in self.args[\u0027keystone_config\u0027].split(\",\"))"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        for arg in arg_list:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_c23349f5","line":27,"range":{"start_line":27,"start_character":12,"end_line":27,"end_character":27},"updated":"2016-09-19 20:09:33.000000000","message":"this should just go in the http check. Doesnt seem like it applies to any other args plugin to go into the super class","commit_id":"30d818aab8cc508b0af8498db5f39e0c236661ce"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"45506177b5061c7f4bbc88ac7814b9a8e0c71b45","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        if \u0027dimensions\u0027 in self.args:"},{"line_number":25,"context_line":"            instance[\u0027dimensions\u0027] \u003d dict(item.strip().split(\":\") for item in self.args[\u0027dimensions\u0027].split(\",\"))"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        if \u0027keystone_config\u0027 in self.args:"},{"line_number":28,"context_line":"            instance[\u0027keystone_config\u0027] \u003d dict(item.strip().split(\":\", 1) for item in self.args[\u0027keystone_config\u0027].split(\",\"))"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        for arg in arg_list:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_4259f98d","line":27,"range":{"start_line":27,"start_character":12,"end_line":27,"end_character":27},"in_reply_to":"7a8ec9b2_c23349f5","updated":"2016-09-19 20:25:42.000000000","message":"Good point! Thank you!","commit_id":"30d818aab8cc508b0af8498db5f39e0c236661ce"}],"monasca_setup/main.py":[{"author":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"change_message_id":"5fdd1ac0061f0f10a5dbc13604d99f7ceaf926ea","unresolved":false,"context_lines":[{"line_number":228,"context_line":"    parser.add_argument(\u0027-a\u0027, \u0027--detection_args\u0027, help\u003d\"A string of arguments that will be passed to detection \" +"},{"line_number":229,"context_line":"                                                       \"plugins. Only certain detection plugins use arguments.\")"},{"line_number":230,"context_line":"    parser.add_argument(\u0027-ks\u0027, \u0027--keystone_config\u0027,"},{"line_number":231,"context_line":"                        help\u003d\"Keystone credential config specified by users in json format.\")"},{"line_number":232,"context_line":"    parser.add_argument(\u0027--check_frequency\u0027, help\u003d\"How often to run metric collection in seconds\","},{"line_number":233,"context_line":"                        type\u003dvalidate_positive, default\u003d30)"},{"line_number":234,"context_line":"    parser.add_argument(\u0027--num_collector_threads\u0027, help\u003d\"Number of Threads to use in Collector \" +"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_bebfaace","line":231,"updated":"2016-09-21 22:28:46.000000000","message":"Could we have a more generic argument name here so that it can be used to pass json to any plugin?  I liked Alexis name for --detection_args_json. Then if that is defined you can pass it to the detection plugin instead of args.","commit_id":"f110f54c6a8b17ded75fc38135a78b6849a75897"}]}