)]}'
{"monasca_setup/detection/plugins/process.py":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"fd5964c159ffc4b4e52abe56db7b4347a0994c75","unresolved":false,"context_lines":[{"line_number":10,"context_line":"log \u003d logging.getLogger(__name__)"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"class ProcessCheck(ArgsPlugin):"},{"line_number":14,"context_line":"    \"\"\"Setup a process check according to the passed in arguments."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"       A process can be monitored by process_names or by process_username. Pass in the process_names list"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_a4e28d2d","line":13,"updated":"2016-09-20 18:09:05.000000000","message":"I think that this would look better having module imports.","commit_id":"045a0f3e3e339d1877b66bf9256ca235702cf3a2"},{"author":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"change_message_id":"3e3e1c99cfb14a30c7b292e3b7ba27c7262618a6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"log \u003d logging.getLogger(__name__)"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"class ProcessCheck(ArgsPlugin):"},{"line_number":14,"context_line":"    \"\"\"Setup a process check according to the passed in arguments."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"       A process can be monitored by process_names or by process_username. Pass in the process_names list"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_c63841f1","line":13,"in_reply_to":"7a8ec9b2_4bc4665e","updated":"2016-09-21 15:30:15.000000000","message":"I will do this, thanks!  Just spending some time re-working the code now that I am supporting a config file.","commit_id":"045a0f3e3e339d1877b66bf9256ca235702cf3a2"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"0d7eb759a3373d530a4a1e15945b157854df4871","unresolved":false,"context_lines":[{"line_number":10,"context_line":"log \u003d logging.getLogger(__name__)"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"class ProcessCheck(ArgsPlugin):"},{"line_number":14,"context_line":"    \"\"\"Setup a process check according to the passed in arguments."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"       A process can be monitored by process_names or by process_username. Pass in the process_names list"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_4bc4665e","line":13,"in_reply_to":"7a8ec9b2_a4e28d2d","updated":"2016-09-21 05:10:40.000000000","message":"Found relevant article about imports \u003d\u003e http://docs.openstack.org/developer/hacking/#imports","commit_id":"045a0f3e3e339d1877b66bf9256ca235702cf3a2"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"c5cb07f253db2884a128a02f6a2d1dbfcf0164bd","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"       Monitor by process_names example:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"       monasca-setup -d ProcessCheck -a \"process_names\u003dmonasca-api,monasca-persister \\"},{"line_number":28,"context_line":"                                         dimensions\u003dservice:monitoring,component:monasca\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"       Monitor by process_username example:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_5a6d2498","line":27,"range":{"start_line":27,"start_character":41,"end_line":27,"end_character":84},"updated":"2016-09-20 18:58:55.000000000","message":"I don\u0027t think this is going to work with how we currently parse command line arguments.  Any process identifier that contains an \u003d or a space will cause the parsing to fail.  Our default process search is so broad that we\u0027ve seen people having to specify full paths and occasionally command line arguments to find the proper process.  I\u0027d expect that scenario to break our argument parsing.","commit_id":"045a0f3e3e339d1877b66bf9256ca235702cf3a2"},{"author":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"change_message_id":"3e3e1c99cfb14a30c7b292e3b7ba27c7262618a6","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"       Monitor by process_names example:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"       monasca-setup -d ProcessCheck -a \"process_names\u003dmonasca-api,monasca-persister \\"},{"line_number":28,"context_line":"                                         dimensions\u003dservice:monitoring,component:monasca\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"       Monitor by process_username example:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_a6509533","line":27,"range":{"start_line":27,"start_character":41,"end_line":27,"end_character":84},"in_reply_to":"7a8ec9b2_22e398a5","updated":"2016-09-21 15:30:15.000000000","message":"I\u0027m re-working the code now to accept a config file or args.  I\u0027m hopeful the config file will allow us to pass in process names with space and \u003d embedded.  Thanks for your comments!","commit_id":"045a0f3e3e339d1877b66bf9256ca235702cf3a2"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"0d7eb759a3373d530a4a1e15945b157854df4871","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"       Monitor by process_names example:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"       monasca-setup -d ProcessCheck -a \"process_names\u003dmonasca-api,monasca-persister \\"},{"line_number":28,"context_line":"                                         dimensions\u003dservice:monitoring,component:monasca\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"       Monitor by process_username example:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_ab824afe","line":27,"range":{"start_line":27,"start_character":41,"end_line":27,"end_character":84},"in_reply_to":"7a8ec9b2_5a6d2498","updated":"2016-09-21 05:10:40.000000000","message":"Couldn\u0027t such scenario be put inside the unit test ?","commit_id":"045a0f3e3e339d1877b66bf9256ca235702cf3a2"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"456bc76b808996900ebc55deadbc2be4915a33db","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"       Monitor by process_names example:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"       monasca-setup -d ProcessCheck -a \"process_names\u003dmonasca-api,monasca-persister \\"},{"line_number":28,"context_line":"                                         dimensions\u003dservice:monitoring,component:monasca\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"       Monitor by process_username example:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_22e398a5","line":27,"range":{"start_line":27,"start_character":41,"end_line":27,"end_character":84},"in_reply_to":"7a8ec9b2_ab824afe","updated":"2016-09-21 14:18:18.000000000","message":"Yeah, easily but we already tried it by hand an know it breaks.  Once we get better parsing in place, and I\u0027m not sure where that\u0027ll end up right now, we should add unit tests at whatever level is appropriate and ensure that it deals with these situations.","commit_id":"045a0f3e3e339d1877b66bf9256ca235702cf3a2"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"fd5964c159ffc4b4e52abe56db7b4347a0994c75","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            if len(self.found_processes) \u003e 0:"},{"line_number":51,"context_line":"                self.available \u003d True"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        if self._check_required_args([\u0027process_username\u0027, \u0027dimensions\u0027]) and \u0027component\u0027 in self.dimensions:"},{"line_number":54,"context_line":"            self.available \u003d True"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def monitor_by_process_name(self, process_name, exact_match\u003dTrue, detailed\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_44f9c9c7","line":53,"updated":"2016-09-20 18:09:05.000000000","message":"Fom the documentation above it does not look like process_username is required argument. I did not check how \n\n _check_required_args\n\nreally works, but anyway name suggests that both dimensions and process_username should be given otherwise world goes crazy. Is that really the case, or should be like those arguments are mutually exclusive or can coexist ?","commit_id":"045a0f3e3e339d1877b66bf9256ca235702cf3a2"}]}