)]}'
{"monasca_agent/common/keystone.py":[{"author":{"_account_id":23624,"name":"Pablo Rodriguez","email":"pablo.rodriguezarchilla@telefonica.com","username":"pratid"},"change_message_id":"50a5b79192a5cc515cca1eae15f7445338d02eb9","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        if endpoint_type:"},{"line_number":76,"context_line":"            kc_args.update({\u0027endpoint_type\u0027: endpoint_type})"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        return ksclient.KSClient(**kc_args)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def get_monasca_url(self):"},{"line_number":81,"context_line":"        if not self._keystone_client:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_3acfc8b1","line":78,"updated":"2016-09-22 09:58:21.000000000","message":"If you take a closer look, Keystone.get_credential_args() method hasn\u0027t been altered and initialization of keystoneclient.v3.client.Client doesn\u0027t change:\n\n- The keywords (service_type, endpoint_type) are only added to the dict to initialize monascaclient.ksclient.KSClient\n\n- KSClient.__init__(**kwargs) filters out auth-related keywords into a separate \"kc_args\" dict, used to initialize Client (see https://github.com/openstack/python-monascaclient/blob/master/monascaclient/ksclient.py#L69), and therefore these new keywords aren\u0027t considered.\n\n- KSClient.monasca_url() uses the keywords from \"_kwargs\" referencing the initialization kwargs, so that the service_type and the endpoint_type are available for querying Service Catalog (see https://github.com/openstack/python-monascaclient/blob/master/monascaclient/ksclient.py#L99).","commit_id":"97d4d459bf6b8f168b84ad453db9bfe171bbc830"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"a78ef33d6ccb9480cf618d405ef4310edcbdf99a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        region_name \u003d self.config.get(\u0027region_name\u0027, None)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        kc_args \u003d self.get_credential_args()"},{"line_number":75,"context_line":"        if service_type:"},{"line_number":76,"context_line":"            kc_args.update({\u0027service_type\u0027: service_type})"},{"line_number":77,"context_line":"        if endpoint_type:"},{"line_number":78,"context_line":"            kc_args.update({\u0027endpoint_type\u0027: endpoint_type})"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_cd7894fb","line":75,"updated":"2016-10-19 10:46:41.000000000","message":"Shouldn\u0027t it be like:\n\n- you give service_type so endpoint_type and (maybe) region_name are required ? Only if service is given it makes sense to retrieve endpoint from it and benefit from region I guess. Otherwise we can just assume that we fallback to old behaviour ?","commit_id":"0556ea6888d55c2308d80e78d0b578f5169772e1"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"5344e6cf8fcf47815694c7366ae4c185c3f13f2d","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        region_name \u003d self.config.get(\u0027region_name\u0027, None)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        kc_args \u003d self.get_credential_args()"},{"line_number":75,"context_line":"        if service_type:"},{"line_number":76,"context_line":"            kc_args.update({\u0027service_type\u0027: service_type})"},{"line_number":77,"context_line":"        if endpoint_type:"},{"line_number":78,"context_line":"            kc_args.update({\u0027endpoint_type\u0027: endpoint_type})"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_6ebd89b6","line":75,"in_reply_to":"fa6399be_cd7894fb","updated":"2016-11-01 20:18:30.000000000","message":"I think it is the case that if endpoint_type and region_name are supplied, then service_type would be provided too, but I think it is acceptable as is, where the default will be used, if service_type is not supplied, but endpoint_type and region_name are supplied.","commit_id":"0556ea6888d55c2308d80e78d0b578f5169772e1"}],"tests/test_keystone.py":[{"author":{"_account_id":23624,"name":"Pablo Rodriguez","email":"pablo.rodriguezarchilla@telefonica.com","username":"pratid"},"change_message_id":"50a5b79192a5cc515cca1eae15f7445338d02eb9","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            self.assertTrue(client.called)"},{"line_number":56,"context_line":"            self.assertIn(\u0027auth_url\u0027, client.call_args[client.call_count])"},{"line_number":57,"context_line":"            self.assertNotIn(\u0027service_type\u0027, client.call_args[client.call_count])"},{"line_number":58,"context_line":"            self.assertNotIn(\u0027endpoint_type\u0027, client.call_args[client.call_count])"},{"line_number":59,"context_line":"            client.return_value.service_catalog.url_for.assert_has_calls(["},{"line_number":60,"context_line":"                mock.call(endpoint_type\u003dendpoint_type, service_type\u003d\u0027monitoring\u0027)"},{"line_number":61,"context_line":"            ])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_ba55981e","line":58,"updated":"2016-09-22 09:58:21.000000000","message":"Please note new testcases assert that the two keywords are NEVER passed to the keystoneclient.v3.client.Client initialization:\n\n- self.assertNotIn(\u0027service_type\u0027, client.call_args[client.call_count])\n- self.assertNotIn(\u0027endpoint_type\u0027, client.call_args[client.call_count])","commit_id":"97d4d459bf6b8f168b84ad453db9bfe171bbc830"}]}