)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"2553af7c9b5a904052e4d8651c1e775ab08f6e09","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kaiyan Sheng \u003ckaiyan.sheng@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-13 16:14:36 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add documentation for mapping metrics to tuning knobs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Tuning knobs are configuration parameters in config file"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa6399be_4e6e9397","line":7,"range":{"start_line":7,"start_character":41,"end_line":7,"end_character":47},"updated":"2016-10-17 15:14:01.000000000","message":"take out tuning knobs?","commit_id":"5075a38db6f4250a55ac53288c1c6945b99209d7"}],"docs/Libvirt.md":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"3b2f35beaa2db5a7229a2a770d1f21f4aa7df5af","unresolved":false,"context_lines":[{"line_number":348,"context_line":"* Does the command `ip netns list |grep qrouter` produce any output on the compute node?  If not, perhaps Neutron is not configured in DVR mode, or no VMs are present on that compute node."},{"line_number":349,"context_line":"* Is the `ping_check` command defined `/etc/monasca/agent/conf.d/libvirt.yaml`?  If not, try running `monasca-setup -d libvirt` as root from within the appropriate Python virtual environment"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"## Mapping Metrics to Tuning Knobs"},{"line_number":352,"context_line":"| Tuning Knob | Admin Metric Name | Tenant Metric Name |"},{"line_number":353,"context_line":"| ----------- | ----------------- | ------------------ |"},{"line_number":354,"context_line":"|vm_cpu_check_enable | vm.cpu.time_ns | cpu.time_ns |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"fa6399be_61ddf313","line":351,"range":{"start_line":351,"start_character":0,"end_line":351,"end_character":34},"updated":"2016-10-11 22:19:25.000000000","message":"A little bit of text about what this table is showing would be good. Also, these aren\u0027t called \"Tuning Knobs\" above. Maybe use \"Configuration Parameter\"?","commit_id":"aeddef4825827e7b75df700d1a2a32271b652993"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"e553c128c65cbcc53e690cb4c3831c0bbc278727","unresolved":false,"context_lines":[{"line_number":348,"context_line":"* Does the command `ip netns list |grep qrouter` produce any output on the compute node?  If not, perhaps Neutron is not configured in DVR mode, or no VMs are present on that compute node."},{"line_number":349,"context_line":"* Is the `ping_check` command defined `/etc/monasca/agent/conf.d/libvirt.yaml`?  If not, try running `monasca-setup -d libvirt` as root from within the appropriate Python virtual environment"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"## Mapping Metrics to Tuning Knobs"},{"line_number":352,"context_line":"| Tuning Knob | Admin Metric Name | Tenant Metric Name |"},{"line_number":353,"context_line":"| ----------- | ----------------- | ------------------ |"},{"line_number":354,"context_line":"|vm_cpu_check_enable | vm.cpu.time_ns | cpu.time_ns |"}],"source_content_type":"text/x-markdown","patch_set":3,"id":"fa6399be_40e95ee5","line":351,"range":{"start_line":351,"start_character":0,"end_line":351,"end_character":34},"in_reply_to":"fa6399be_61ddf313","updated":"2016-10-13 22:15:38.000000000","message":"Good point! Thank you!","commit_id":"aeddef4825827e7b75df700d1a2a32271b652993"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"2553af7c9b5a904052e4d8651c1e775ab08f6e09","unresolved":false,"context_lines":[{"line_number":349,"context_line":"* Is the `ping_check` command defined `/etc/monasca/agent/conf.d/libvirt.yaml`?  If not, try running `monasca-setup -d libvirt` as root from within the appropriate Python virtual environment"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"## Mapping Metrics to Configuration Parameters"},{"line_number":352,"context_line":"Configuration parameters are added to control which metrics are reported by libvirt plugin. There are 5 parameters currently in libvirt config file: vm_cpu_check_enable, vm_disks_check_enable, vm_network_check_enable, vm_ping_check_enable and vm_extended_disks_check_enable."},{"line_number":353,"context_line":""},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"| Configuration Parameter | Admin Metric Name | Tenant Metric Name |"}],"source_content_type":"text/x-markdown","patch_set":4,"id":"fa6399be_ce61c3aa","line":352,"range":{"start_line":352,"start_character":34,"end_line":352,"end_character":35},"updated":"2016-10-17 15:14:01.000000000","message":"we should put the default value for each configuration parameter in the table so it is consolidated to one location","commit_id":"5075a38db6f4250a55ac53288c1c6945b99209d7"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"2050f9c8e7a6a2ca3aec939a5f8d73023d9622d4","unresolved":false,"context_lines":[{"line_number":58,"context_line":"`vnic_collection_period` will cause vnic metrics to be output at a minimum `vnic_collection_period` second interval. This can be optionally set to have vnic metrics be outputted less often to reduce metric load on the system. If this is less than the agent collection period, it will be ignored. The default value is 0."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"`vm_cpu_check_enable` enables collecting of VM CPU metrics. (Default True)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"`vm_disks_check_enable` enables collecting of VM Disk metrics. (Default True)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":5,"id":"fa6399be_44e47d3a","line":61,"range":{"start_line":61,"start_character":73,"end_line":61,"end_character":74},"updated":"2016-10-18 17:26:48.000000000","message":"Maybe add something like \"See Mapping Metrics to Configuration Parameters below for what metrics are controlled by this flag\" ?","commit_id":"57eab7597057c7ca60ac24efaa7694cb32c595d0"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"2050f9c8e7a6a2ca3aec939a5f8d73023d9622d4","unresolved":false,"context_lines":[{"line_number":349,"context_line":"* Is the `ping_check` command defined `/etc/monasca/agent/conf.d/libvirt.yaml`?  If not, try running `monasca-setup -d libvirt` as root from within the appropriate Python virtual environment"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"## Mapping Metrics to Configuration Parameters"},{"line_number":352,"context_line":"Configuration parameters are added to control which metrics are reported by libvirt plugin. There are 5 parameters currently in libvirt config file: vm_cpu_check_enable, vm_disks_check_enable, vm_network_check_enable, vm_ping_check_enable and vm_extended_disks_check_enable."},{"line_number":353,"context_line":""},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"| Configuration Parameter | Admin Metric Name | Tenant Metric Name |"}],"source_content_type":"text/x-markdown","patch_set":5,"id":"fa6399be_642501ad","line":352,"range":{"start_line":352,"start_character":25,"end_line":352,"end_character":34},"updated":"2016-10-18 17:26:48.000000000","message":"can be used","commit_id":"57eab7597057c7ca60ac24efaa7694cb32c595d0"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b36e758663cddd6f26535805bd669dc956507040","unresolved":false,"context_lines":[{"line_number":381,"context_line":"| | vm.disk.capacity | disk.capacity |"},{"line_number":382,"context_line":"| | vm.disk.physical | disk.physical |"},{"line_number":383,"context_line":"| | vm.disk.allocation_total | disk.allocation_total |"},{"line_number":384,"context_line":"|vm_disks_check_enable and vm_extended_disks_check_enable (default: True) | vm.io.errors_total | io.errors_total |"},{"line_number":385,"context_line":"| | vm.io.errors_total_sec | io.errors_total_sec |"},{"line_number":386,"context_line":"| | vm.io.read_bytes_total | io.read_bytes_total |"},{"line_number":387,"context_line":"| | vm.io.read_bytes_total_sec | io.read_bytes_total_sec |"}],"source_content_type":"text/x-markdown","patch_set":8,"id":"fa6399be_cb2fb586","line":384,"range":{"start_line":384,"start_character":1,"end_line":384,"end_character":22},"updated":"2016-10-18 21:08:15.000000000","message":"Should list default for this one","commit_id":"d9a1c72ad5f0fc39fc5b1705a8ae1bc35dc24a3f"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"ece19c56c764589a69b34a813142b6c53803a212","unresolved":false,"context_lines":[{"line_number":381,"context_line":"| | vm.disk.capacity | disk.capacity |"},{"line_number":382,"context_line":"| | vm.disk.physical | disk.physical |"},{"line_number":383,"context_line":"| | vm.disk.allocation_total | disk.allocation_total |"},{"line_number":384,"context_line":"|vm_disks_check_enable and vm_extended_disks_check_enable (default: True) | vm.io.errors_total | io.errors_total |"},{"line_number":385,"context_line":"| | vm.io.errors_total_sec | io.errors_total_sec |"},{"line_number":386,"context_line":"| | vm.io.read_bytes_total | io.read_bytes_total |"},{"line_number":387,"context_line":"| | vm.io.read_bytes_total_sec | io.read_bytes_total_sec |"}],"source_content_type":"text/x-markdown","patch_set":8,"id":"fa6399be_ab6c419d","line":384,"range":{"start_line":384,"start_character":1,"end_line":384,"end_character":22},"in_reply_to":"fa6399be_cb2fb586","updated":"2016-10-18 21:16:41.000000000","message":"vm_disks_check_enable defaults to be true (line 362) and vm_extended_disks_check_enable defaults to be true (line 380). Thats why I put \"default: True\" here.","commit_id":"d9a1c72ad5f0fc39fc5b1705a8ae1bc35dc24a3f"}],"docs/Ovs.md":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b36e758663cddd6f26535805bd669dc956507040","unresolved":false,"context_lines":[{"line_number":160,"context_line":"| | ovs.vrouter.in_errors_sec | vrouter.in_errors_sec |"},{"line_number":161,"context_line":"| | ovs.vrouter.out_dropped_sec | vrouter.out_dropped_sec |"},{"line_number":162,"context_line":"| | ovs.vrouter.out_errors_sec | vrouter.out_errors_sec |"},{"line_number":163,"context_line":"| use_health_metrics with use_absolute_metrics (default: False)| ovs.vrouter.in_dropped | vrouter.in_dropped |"},{"line_number":164,"context_line":"| | ovs.vrouter.in_errors | vrouter.in_errors |"},{"line_number":165,"context_line":"| | ovs.vrouter.out_dropped | vrouter.out_dropped |"},{"line_number":166,"context_line":"| | ovs.vrouter.out_errors | vrouter.out_errors |"}],"source_content_type":"text/x-markdown","patch_set":8,"id":"fa6399be_8b0e9d30","line":163,"range":{"start_line":163,"start_character":2,"end_line":163,"end_character":20},"updated":"2016-10-18 21:08:15.000000000","message":"What is the default for use_health_metrics?","commit_id":"d9a1c72ad5f0fc39fc5b1705a8ae1bc35dc24a3f"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"ece19c56c764589a69b34a813142b6c53803a212","unresolved":false,"context_lines":[{"line_number":160,"context_line":"| | ovs.vrouter.in_errors_sec | vrouter.in_errors_sec |"},{"line_number":161,"context_line":"| | ovs.vrouter.out_dropped_sec | vrouter.out_dropped_sec |"},{"line_number":162,"context_line":"| | ovs.vrouter.out_errors_sec | vrouter.out_errors_sec |"},{"line_number":163,"context_line":"| use_health_metrics with use_absolute_metrics (default: False)| ovs.vrouter.in_dropped | vrouter.in_dropped |"},{"line_number":164,"context_line":"| | ovs.vrouter.in_errors | vrouter.in_errors |"},{"line_number":165,"context_line":"| | ovs.vrouter.out_dropped | vrouter.out_dropped |"},{"line_number":166,"context_line":"| | ovs.vrouter.out_errors | vrouter.out_errors |"}],"source_content_type":"text/x-markdown","patch_set":8,"id":"fa6399be_6bc4e991","line":163,"range":{"start_line":163,"start_character":2,"end_line":163,"end_character":20},"in_reply_to":"fa6399be_8b0e9d30","updated":"2016-10-18 21:16:41.000000000","message":"I put the defaults in line 172. use_health_metrics\u003dfalse","commit_id":"d9a1c72ad5f0fc39fc5b1705a8ae1bc35dc24a3f"}]}