)]}'
{"conf.d/cadvisor.yaml.example":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"dfd3b3ee9a2487f3ced6bba9020360ac90c06004","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2016 Hewlett Packard Enterprise Development LP"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"init_config:"},{"line_number":4,"context_line":"    # Timeout on GET requests to the Cadvisor endpoints"},{"line_number":5,"context_line":"    connection_timeout: 3"},{"line_number":6,"context_line":"instances:"},{"line_number":7,"context_line":"    # Set to the host of where cadvisor instance is running you want to connect to"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"ba5da102_e869b4bf","line":4,"updated":"2016-10-31 20:13:39.000000000","message":"Apparently, \"Cadvisor\" should be spelled \"cAdvisor\".","commit_id":"783b29aaa57709d9e8a0a558c3023c95846d2111"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"99e86df21bc48903a3fee3cba7e5a734cef7fdb9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2016 Hewlett Packard Enterprise Development LP"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"init_config:"},{"line_number":4,"context_line":"    # Timeout on GET requests to the Cadvisor endpoints"},{"line_number":5,"context_line":"    connection_timeout: 3"},{"line_number":6,"context_line":"instances:"},{"line_number":7,"context_line":"    # Set to the host of where cadvisor instance is running you want to connect to"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"ba5da102_c848708a","line":4,"in_reply_to":"ba5da102_e869b4bf","updated":"2016-10-31 20:37:09.000000000","message":"i know..","commit_id":"783b29aaa57709d9e8a0a558c3023c95846d2111"}],"docs/Plugins.md":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"bc07f215e985a766adfeac8892ff45888849f067","unresolved":false,"context_lines":[{"line_number":478,"context_line":"See [the example configuration](https://github.com/openstack/monasca-agent/blob/master/conf.d/cacti.yaml.example) for how to configure the Cacti plugin."},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"## Cadvisor"},{"line_number":481,"context_line":"This plugin collects metrics about docker containers from a given cadvisor instance. "},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"It connects to the spec endpoint to get the dimensions and then the metric endpoint for the data."},{"line_number":484,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":3,"id":"ba5da102_3ef32a75","line":481,"range":{"start_line":481,"start_character":84,"end_line":481,"end_character":85},"updated":"2016-10-28 21:53:05.000000000","message":"Trailing space","commit_id":"8d271135bc595181dd6e5f8ead56f754ff0802bc"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"41a402b3fc7edb1ea99e6e47ad518ffa0f971351","unresolved":false,"context_lines":[{"line_number":482,"context_line":""},{"line_number":483,"context_line":"It connects to the spec endpoint to get the dimensions and then the metric endpoint for the data. When setting the dimensions it automatically checks if there are kubernetes metadata about the container running under a pod and sets the pod_name and namespace as dimensions."},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"At this time it only supports getting data from one cadvisor endpoint and in result only one instance in the config file."},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"Sample config:"},{"line_number":488,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":4,"id":"ba5da102_e378fdc6","line":485,"range":{"start_line":485,"start_character":70,"end_line":485,"end_character":101},"updated":"2016-10-31 18:43:55.000000000","message":"Not clear what this means","commit_id":"783b29aaa57709d9e8a0a558c3023c95846d2111"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"dfd3b3ee9a2487f3ced6bba9020360ac90c06004","unresolved":false,"context_lines":[{"line_number":489,"context_line":"```"},{"line_number":490,"context_line":"init_config:"},{"line_number":491,"context_line":"    # Timeout on GET requests to the Cadvisor endpoints"},{"line_number":492,"context_line":"    connection_timeout: 3"},{"line_number":493,"context_line":"instances:"},{"line_number":494,"context_line":"    # Set to the url of the cadvisor instance you want to connect to"},{"line_number":495,"context_line":"    - host: \"127.0.0.1\""}],"source_content_type":"text/x-markdown","patch_set":4,"id":"ba5da102_286e4c95","line":492,"updated":"2016-10-31 20:13:39.000000000","message":"Just want to make sure the units are consistent, but are we using seconds or msecs in the case of specifying a connection timeout in other areas?","commit_id":"783b29aaa57709d9e8a0a558c3023c95846d2111"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"99e86df21bc48903a3fee3cba7e5a734cef7fdb9","unresolved":false,"context_lines":[{"line_number":489,"context_line":"```"},{"line_number":490,"context_line":"init_config:"},{"line_number":491,"context_line":"    # Timeout on GET requests to the Cadvisor endpoints"},{"line_number":492,"context_line":"    connection_timeout: 3"},{"line_number":493,"context_line":"instances:"},{"line_number":494,"context_line":"    # Set to the url of the cadvisor instance you want to connect to"},{"line_number":495,"context_line":"    - host: \"127.0.0.1\""}],"source_content_type":"text/x-markdown","patch_set":4,"id":"ba5da102_a86edcfe","line":492,"in_reply_to":"ba5da102_286e4c95","updated":"2016-10-31 20:37:09.000000000","message":"i thought seconds but maybe i am wrong i will check","commit_id":"783b29aaa57709d9e8a0a558c3023c95846d2111"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"41a402b3fc7edb1ea99e6e47ad518ffa0f971351","unresolved":false,"context_lines":[{"line_number":498,"context_line":""},{"line_number":499,"context_line":"The Cadvisor check returns the following metrics:"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"| Metric Name | Dimensions | Addtional Dimensions (if container under a kubernetes pod) | Semantics |"},{"line_number":502,"context_line":"| ----------- | ---------- | --------- | --------- | ---------"},{"line_number":503,"context_line":"| container.cpu.system_time | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Cumulative system CPU time consumed in seconds"},{"line_number":504,"context_line":"| container.cpu.system_time_sec | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Rate of system CPU time consumed in seconds"}],"source_content_type":"text/x-markdown","patch_set":4,"id":"ba5da102_c33f79d4","line":501,"range":{"start_line":501,"start_character":29,"end_line":501,"end_character":38},"updated":"2016-10-31 18:43:55.000000000","message":"Misspelled","commit_id":"783b29aaa57709d9e8a0a558c3023c95846d2111"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"99e86df21bc48903a3fee3cba7e5a734cef7fdb9","unresolved":false,"context_lines":[{"line_number":498,"context_line":""},{"line_number":499,"context_line":"The Cadvisor check returns the following metrics:"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"| Metric Name | Dimensions | Addtional Dimensions (if container under a kubernetes pod) | Semantics |"},{"line_number":502,"context_line":"| ----------- | ---------- | --------- | --------- | ---------"},{"line_number":503,"context_line":"| container.cpu.system_time | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Cumulative system CPU time consumed in seconds"},{"line_number":504,"context_line":"| container.cpu.system_time_sec | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Rate of system CPU time consumed in seconds"}],"source_content_type":"text/x-markdown","patch_set":4,"id":"ba5da102_e878d4c6","line":501,"range":{"start_line":501,"start_character":29,"end_line":501,"end_character":38},"in_reply_to":"ba5da102_c33f79d4","updated":"2016-10-31 20:37:09.000000000","message":"do you expect anything less :)","commit_id":"783b29aaa57709d9e8a0a558c3023c95846d2111"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"dfd3b3ee9a2487f3ced6bba9020360ac90c06004","unresolved":false,"context_lines":[{"line_number":506,"context_line":"| container.cpu.total_time_sec | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Rate of CPU time consumed in seconds"},{"line_number":507,"context_line":"| container.cpu.user_time | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Cumulative user cpu time consumed in seconds"},{"line_number":508,"context_line":"| container.cpu.user_time_sec | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Rate of user CPU time consumed in seconds"},{"line_number":509,"context_line":"| container.fs.capacity_bytes | hostname, image, container_name, device | kubernetes_pod_name, kubernetes_namespace | Number of bytes available"},{"line_number":510,"context_line":"| container.fs.usage_bytes | hostname, image, container_name, device | kubernetes_pod_name, kubernetes_namespace | Number of bytes consumed"},{"line_number":511,"context_line":"| container.mem.cache | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Number of bytes of page cache memory"},{"line_number":512,"context_line":"| container.mem.rss | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Size of rss in bytes"}],"source_content_type":"text/x-markdown","patch_set":4,"id":"ba5da102_68ea0411","line":509,"updated":"2016-10-31 20:13:39.000000000","message":"Does this metric name kinda match an existing metric name for the total capacity that is available?\n\nJust wondering if we should be used something like \"total\" or \"max\". I don\u0027t recall seeing \"capacity\" being used anywhere so far.","commit_id":"783b29aaa57709d9e8a0a558c3023c95846d2111"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"99e86df21bc48903a3fee3cba7e5a734cef7fdb9","unresolved":false,"context_lines":[{"line_number":506,"context_line":"| container.cpu.total_time_sec | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Rate of CPU time consumed in seconds"},{"line_number":507,"context_line":"| container.cpu.user_time | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Cumulative user cpu time consumed in seconds"},{"line_number":508,"context_line":"| container.cpu.user_time_sec | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Rate of user CPU time consumed in seconds"},{"line_number":509,"context_line":"| container.fs.capacity_bytes | hostname, image, container_name, device | kubernetes_pod_name, kubernetes_namespace | Number of bytes available"},{"line_number":510,"context_line":"| container.fs.usage_bytes | hostname, image, container_name, device | kubernetes_pod_name, kubernetes_namespace | Number of bytes consumed"},{"line_number":511,"context_line":"| container.mem.cache | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Number of bytes of page cache memory"},{"line_number":512,"context_line":"| container.mem.rss | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Size of rss in bytes"}],"source_content_type":"text/x-markdown","patch_set":4,"id":"ba5da102_2883ac99","line":509,"in_reply_to":"ba5da102_68ea0411","updated":"2016-10-31 20:37:09.000000000","message":"yes we could use total i agree that is probably a better name","commit_id":"783b29aaa57709d9e8a0a558c3023c95846d2111"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"dfd3b3ee9a2487f3ced6bba9020360ac90c06004","unresolved":false,"context_lines":[{"line_number":507,"context_line":"| container.cpu.user_time | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Cumulative user cpu time consumed in seconds"},{"line_number":508,"context_line":"| container.cpu.user_time_sec | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Rate of user CPU time consumed in seconds"},{"line_number":509,"context_line":"| container.fs.capacity_bytes | hostname, image, container_name, device | kubernetes_pod_name, kubernetes_namespace | Number of bytes available"},{"line_number":510,"context_line":"| container.fs.usage_bytes | hostname, image, container_name, device | kubernetes_pod_name, kubernetes_namespace | Number of bytes consumed"},{"line_number":511,"context_line":"| container.mem.cache | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Number of bytes of page cache memory"},{"line_number":512,"context_line":"| container.mem.rss | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Size of rss in bytes"},{"line_number":513,"context_line":"| container.mem.swap | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Swap usage in memory in bytes"}],"source_content_type":"text/x-markdown","patch_set":4,"id":"ba5da102_e8de146c","line":510,"range":{"start_line":510,"start_character":2,"end_line":510,"end_character":11},"updated":"2016-10-31 20:13:39.000000000","message":"Should \"usage\" be \"used\"?","commit_id":"783b29aaa57709d9e8a0a558c3023c95846d2111"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"99e86df21bc48903a3fee3cba7e5a734cef7fdb9","unresolved":false,"context_lines":[{"line_number":507,"context_line":"| container.cpu.user_time | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Cumulative user cpu time consumed in seconds"},{"line_number":508,"context_line":"| container.cpu.user_time_sec | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Rate of user CPU time consumed in seconds"},{"line_number":509,"context_line":"| container.fs.capacity_bytes | hostname, image, container_name, device | kubernetes_pod_name, kubernetes_namespace | Number of bytes available"},{"line_number":510,"context_line":"| container.fs.usage_bytes | hostname, image, container_name, device | kubernetes_pod_name, kubernetes_namespace | Number of bytes consumed"},{"line_number":511,"context_line":"| container.mem.cache | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Number of bytes of page cache memory"},{"line_number":512,"context_line":"| container.mem.rss | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Size of rss in bytes"},{"line_number":513,"context_line":"| container.mem.swap | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Swap usage in memory in bytes"}],"source_content_type":"text/x-markdown","patch_set":4,"id":"ba5da102_684be487","line":510,"range":{"start_line":510,"start_character":2,"end_line":510,"end_character":11},"in_reply_to":"ba5da102_e8de146c","updated":"2016-10-31 20:37:09.000000000","message":"yes","commit_id":"783b29aaa57709d9e8a0a558c3023c95846d2111"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"dfd3b3ee9a2487f3ced6bba9020360ac90c06004","unresolved":false,"context_lines":[{"line_number":508,"context_line":"| container.cpu.user_time_sec | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Rate of user CPU time consumed in seconds"},{"line_number":509,"context_line":"| container.fs.capacity_bytes | hostname, image, container_name, device | kubernetes_pod_name, kubernetes_namespace | Number of bytes available"},{"line_number":510,"context_line":"| container.fs.usage_bytes | hostname, image, container_name, device | kubernetes_pod_name, kubernetes_namespace | Number of bytes consumed"},{"line_number":511,"context_line":"| container.mem.cache | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Number of bytes of page cache memory"},{"line_number":512,"context_line":"| container.mem.rss | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Size of rss in bytes"},{"line_number":513,"context_line":"| container.mem.swap | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Swap usage in memory in bytes"},{"line_number":514,"context_line":"| container.mem.usage | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Current memory in use in bytes"}],"source_content_type":"text/x-markdown","patch_set":4,"id":"ba5da102_28572ccf","line":511,"range":{"start_line":511,"start_character":12,"end_line":511,"end_character":15},"updated":"2016-10-31 20:13:39.000000000","message":"Shouldn\u0027t all the following \"mem\" metrics have units on them, such as mbytes?","commit_id":"783b29aaa57709d9e8a0a558c3023c95846d2111"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"99e86df21bc48903a3fee3cba7e5a734cef7fdb9","unresolved":false,"context_lines":[{"line_number":508,"context_line":"| container.cpu.user_time_sec | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Rate of user CPU time consumed in seconds"},{"line_number":509,"context_line":"| container.fs.capacity_bytes | hostname, image, container_name, device | kubernetes_pod_name, kubernetes_namespace | Number of bytes available"},{"line_number":510,"context_line":"| container.fs.usage_bytes | hostname, image, container_name, device | kubernetes_pod_name, kubernetes_namespace | Number of bytes consumed"},{"line_number":511,"context_line":"| container.mem.cache | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Number of bytes of page cache memory"},{"line_number":512,"context_line":"| container.mem.rss | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Size of rss in bytes"},{"line_number":513,"context_line":"| container.mem.swap | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Swap usage in memory in bytes"},{"line_number":514,"context_line":"| container.mem.usage | hostname, image, container_name | kubernetes_pod_name, kubernetes_namespace | Current memory in use in bytes"}],"source_content_type":"text/x-markdown","patch_set":4,"id":"ba5da102_a845fc70","line":511,"range":{"start_line":511,"start_character":12,"end_line":511,"end_character":15},"in_reply_to":"ba5da102_28572ccf","updated":"2016-10-31 20:37:09.000000000","message":"yes, they are in bytes","commit_id":"783b29aaa57709d9e8a0a558c3023c95846d2111"}],"monasca_agent/collector/checks_d/cadvisor.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"bc07f215e985a766adfeac8892ff45888849f067","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def __init__(self, name, init_config, agent_config, instances\u003dNone):"},{"line_number":51,"context_line":"        AgentCheck.__init__(self, name, init_config, agent_config, instances)"},{"line_number":52,"context_line":"        if instances is not None and len(instances) \u003e 1:"},{"line_number":53,"context_line":"            raise Exception(\u0027Cadvisor check only supports one configured instance.\u0027)"},{"line_number":54,"context_line":"        instance \u003d self.instances[0]"},{"line_number":55,"context_line":"        self.connection_timeout \u003d int(init_config.get(\u0027connection_timeout\u0027, DEFAULT_TIMEOUT))"},{"line_number":56,"context_line":"        cadvisor_url \u003d instance.get(\u0027url\u0027, CADVISOR_URL)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_f14a9fab","line":53,"range":{"start_line":53,"start_character":29,"end_line":53,"end_character":82},"updated":"2016-10-28 21:53:05.000000000","message":"Not documented in Plugins.md","commit_id":"8d271135bc595181dd6e5f8ead56f754ff0802bc"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"bc07f215e985a766adfeac8892ff45888849f067","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        instance \u003d self.instances[0]"},{"line_number":55,"context_line":"        self.connection_timeout \u003d int(init_config.get(\u0027connection_timeout\u0027, DEFAULT_TIMEOUT))"},{"line_number":56,"context_line":"        cadvisor_url \u003d instance.get(\u0027url\u0027, CADVISOR_URL)"},{"line_number":57,"context_line":"        self.cadvisor_metric_url \u003d cadvisor_url + \":4194/\" + METRICS_ENDPOINT"},{"line_number":58,"context_line":"        self.cadvisor_spec_url \u003d cadvisor_url + \":4194/\" + SPEC_ENDPOINT"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def check(self, instance):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_11c8f321","line":57,"range":{"start_line":57,"start_character":52,"end_line":57,"end_character":56},"updated":"2016-10-28 21:53:05.000000000","message":"Can this be changed? Should be a constant if not","commit_id":"8d271135bc595181dd6e5f8ead56f754ff0802bc"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"bc07f215e985a766adfeac8892ff45888849f067","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        self.cadvisor_spec_url \u003d cadvisor_url + \":4194/\" + SPEC_ENDPOINT"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def check(self, instance):"},{"line_number":61,"context_line":"        dimensions \u003d self._set_dimensions(instance)"},{"line_number":62,"context_line":"        containers_spec \u003d self._get_result(self.cadvisor_spec_url)"},{"line_number":63,"context_line":"        containers_metrics \u003d self._get_result(self.cadvisor_metric_url)"},{"line_number":64,"context_line":"        self._parse_send_metrics(containers_metrics, containers_spec, dimensions)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_b18587ae","line":61,"range":{"start_line":61,"start_character":26,"end_line":61,"end_character":41},"updated":"2016-10-28 21:53:05.000000000","message":"Need to pass another arg","commit_id":"8d271135bc595181dd6e5f8ead56f754ff0802bc"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"bc07f215e985a766adfeac8892ff45888849f067","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self._parse_send_metrics(containers_metrics, containers_spec, dimensions)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _get_result(self, request_url):"},{"line_number":67,"context_line":"        result \u003d requests.get(request_url, self.connection_timeout)"},{"line_number":68,"context_line":"        return result.json()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def _send_metrics(self, metric_name, value, dimensions, metric_types):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_31c097e0","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":67},"updated":"2016-10-28 21:53:05.000000000","message":"There should be some exception handling for this call so there is decent messages about what went wrong.","commit_id":"8d271135bc595181dd6e5f8ead56f754ff0802bc"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"bc07f215e985a766adfeac8892ff45888849f067","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        labels \u003d container_spec.get(\"labels\", None)"},{"line_number":124,"context_line":"        if labels:"},{"line_number":125,"context_line":"            for label_name, dimension_name in KUBERNETES_DIMENSIONS.iteritems():"},{"line_number":126,"context_line":"                if labels[label_name]:"},{"line_number":127,"context_line":"                    dimensions[dimension_name] \u003d labels[label_name]"},{"line_number":128,"context_line":"        # Container image being used"},{"line_number":129,"context_line":"        dimensions[\u0027image\u0027] \u003d container_spec[\u0027image\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_d1591b5c","line":126,"range":{"start_line":126,"start_character":19,"end_line":126,"end_character":37},"updated":"2016-10-28 21:53:05.000000000","message":"Do you have to check that this exists first?","commit_id":"8d271135bc595181dd6e5f8ead56f754ff0802bc"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"41a402b3fc7edb1ea99e6e47ad518ffa0f971351","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        AgentCheck.__init__(self, name, init_config, agent_config, instances)"},{"line_number":53,"context_line":"        if instances is not None and len(instances) \u003e 1:"},{"line_number":54,"context_line":"            raise Exception(\u0027Cadvisor check only supports one configured instance.\u0027)"},{"line_number":55,"context_line":"        instance \u003d self.instances[0]"},{"line_number":56,"context_line":"        self.connection_timeout \u003d int(init_config.get(\u0027connection_timeout\u0027, DEFAULT_TIMEOUT))"},{"line_number":57,"context_line":"        cadvisor_host \u003d instance.get(\u0027host\u0027, CADVISOR_HOST)"},{"line_number":58,"context_line":"        cadvisor_port \u003d instance.get(\u0027port\u0027, CADVISOR_PORT)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_32f319d8","line":55,"range":{"start_line":55,"start_character":19,"end_line":55,"end_character":36},"updated":"2016-10-31 18:43:55.000000000","message":"You don\u0027t check that this exists first.","commit_id":"783b29aaa57709d9e8a0a558c3023c95846d2111"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"99e86df21bc48903a3fee3cba7e5a734cef7fdb9","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        AgentCheck.__init__(self, name, init_config, agent_config, instances)"},{"line_number":53,"context_line":"        if instances is not None and len(instances) \u003e 1:"},{"line_number":54,"context_line":"            raise Exception(\u0027Cadvisor check only supports one configured instance.\u0027)"},{"line_number":55,"context_line":"        instance \u003d self.instances[0]"},{"line_number":56,"context_line":"        self.connection_timeout \u003d int(init_config.get(\u0027connection_timeout\u0027, DEFAULT_TIMEOUT))"},{"line_number":57,"context_line":"        cadvisor_host \u003d instance.get(\u0027host\u0027, CADVISOR_HOST)"},{"line_number":58,"context_line":"        cadvisor_port \u003d instance.get(\u0027port\u0027, CADVISOR_PORT)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_6864c421","line":55,"range":{"start_line":55,"start_character":19,"end_line":55,"end_character":36},"in_reply_to":"ba5da102_32f319d8","updated":"2016-10-31 20:37:09.000000000","message":"will change","commit_id":"783b29aaa57709d9e8a0a558c3023c95846d2111"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"41a402b3fc7edb1ea99e6e47ad518ffa0f971351","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            raise Exception(\u0027Cadvisor check only supports one configured instance.\u0027)"},{"line_number":55,"context_line":"        instance \u003d self.instances[0]"},{"line_number":56,"context_line":"        self.connection_timeout \u003d int(init_config.get(\u0027connection_timeout\u0027, DEFAULT_TIMEOUT))"},{"line_number":57,"context_line":"        cadvisor_host \u003d instance.get(\u0027host\u0027, CADVISOR_HOST)"},{"line_number":58,"context_line":"        cadvisor_port \u003d instance.get(\u0027port\u0027, CADVISOR_PORT)"},{"line_number":59,"context_line":"        cadvisor_url \u003d \"http://{}:{}/\".format(cadvisor_host, cadvisor_port)"},{"line_number":60,"context_line":"        self.cadvisor_metric_url \u003d cadvisor_url + METRICS_ENDPOINT"},{"line_number":61,"context_line":"        self.cadvisor_spec_url \u003d cadvisor_url + SPEC_ENDPOINT"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def check(self, instance):"},{"line_number":64,"context_line":"        dimensions \u003d self._set_dimensions(None, instance)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_f2cfe17c","line":61,"range":{"start_line":57,"start_character":0,"end_line":61,"end_character":61},"updated":"2016-10-31 18:43:55.000000000","message":"Why don\u0027t you do this in check() since you have the instance?","commit_id":"783b29aaa57709d9e8a0a558c3023c95846d2111"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"99e86df21bc48903a3fee3cba7e5a734cef7fdb9","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            raise Exception(\u0027Cadvisor check only supports one configured instance.\u0027)"},{"line_number":55,"context_line":"        instance \u003d self.instances[0]"},{"line_number":56,"context_line":"        self.connection_timeout \u003d int(init_config.get(\u0027connection_timeout\u0027, DEFAULT_TIMEOUT))"},{"line_number":57,"context_line":"        cadvisor_host \u003d instance.get(\u0027host\u0027, CADVISOR_HOST)"},{"line_number":58,"context_line":"        cadvisor_port \u003d instance.get(\u0027port\u0027, CADVISOR_PORT)"},{"line_number":59,"context_line":"        cadvisor_url \u003d \"http://{}:{}/\".format(cadvisor_host, cadvisor_port)"},{"line_number":60,"context_line":"        self.cadvisor_metric_url \u003d cadvisor_url + METRICS_ENDPOINT"},{"line_number":61,"context_line":"        self.cadvisor_spec_url \u003d cadvisor_url + SPEC_ENDPOINT"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def check(self, instance):"},{"line_number":64,"context_line":"        dimensions \u003d self._set_dimensions(None, instance)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_28ac8c33","line":61,"range":{"start_line":57,"start_character":0,"end_line":61,"end_character":61},"in_reply_to":"ba5da102_f2cfe17c","updated":"2016-10-31 20:37:09.000000000","message":"so I do not do it ever check iteration","commit_id":"783b29aaa57709d9e8a0a558c3023c95846d2111"}]}