)]}'
{"monasca_agent/statsd/udp.py":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"65b83d451c3913328150284ae5c645f00d521aa0","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                if m[1] \u003d\u003d \u0027{\u0027:"},{"line_number":94,"context_line":"                    dimensions \u003d ast.literal_eval(m[1:])"},{"line_number":95,"context_line":"                else:"},{"line_number":96,"context_line":"                    dimensions \u003d Server._parse_dogstatsd_tags(m)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        return name, value, metric_type, dimensions, sample_rate"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_afa5b147","line":96,"updated":"2017-01-30 12:18:39.000000000","message":"self, would be sufficient.","commit_id":"3911818e231d73b58865e961c7559b8e417051b6"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"50155ad224c57502c91006a89fe7a520f07855d6","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                if m[1] \u003d\u003d \u0027{\u0027:"},{"line_number":94,"context_line":"                    dimensions \u003d ast.literal_eval(m[1:])"},{"line_number":95,"context_line":"                else:"},{"line_number":96,"context_line":"                    dimensions \u003d Server._parse_dogstatsd_tags(m)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        return name, value, metric_type, dimensions, sample_rate"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_e7a39a4d","line":96,"updated":"2017-02-22 06:21:18.000000000","message":"Just wondering if there is a clearer to to express this conditional. I\u0027m thinking something like\n\nif not dogstatsd_message(m):\n    Server._parse_monasca_statsd_tags(m)\nelse:\n    Server._parse_dogstatsd_tags(m)","commit_id":"5dab31e1ccd0bb4fcbb3e21741eb298e0e404bef"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"5559f43a8ee22a35caa7cf011b32c825e1d29759","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        return name, value, metric_type, dimensions, sample_rate"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @staticmethod"},{"line_number":101,"context_line":"    def _parse_dogstatsd_tags(statsd_msg):"},{"line_number":102,"context_line":"        dimensions \u003d {}"},{"line_number":103,"context_line":"        s \u003d \u0027\u0027"},{"line_number":104,"context_line":"        key \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_e5390e43","line":101,"range":{"start_line":101,"start_character":29,"end_line":101,"end_character":30},"updated":"2017-02-02 14:32:39.000000000","message":"should we document anywhere we support dogstatsd messages?","commit_id":"5dab31e1ccd0bb4fcbb3e21741eb298e0e404bef"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"e981d49adc8aaf4ff49c370a4e7e0206afca5c22","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        return name, value, metric_type, dimensions, sample_rate"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @staticmethod"},{"line_number":101,"context_line":"    def _parse_dogstatsd_tags(statsd_msg):"},{"line_number":102,"context_line":"        dimensions \u003d {}"},{"line_number":103,"context_line":"        s \u003d \u0027\u0027"},{"line_number":104,"context_line":"        key \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_c3d91785","line":101,"range":{"start_line":101,"start_character":29,"end_line":101,"end_character":30},"in_reply_to":"1a430d35_5e10144f","updated":"2017-02-13 16:45:35.000000000","message":"With respect to histograms, I agree this would be extremely useful. Histograms are now supported via the Prometheus client library. I think we should split the work out to support histograms via dogstatsd into a separate review though.\n\nDo you know how Datadog handles this? For example, do they approach it the same way as the Prometheus client libraries do, by creating independent metrics, using tags to identity the interval of the histogram. The other approach would be direct support in the Datadog API for histograms.\n\nI don\u0027t have another approach for supporting tags without values. I thought that this was the only method that Datadog supported when we first started developing Monasca, but I don\u0027t see us adding support for tags without values anytime soon. So, setting the value to True, or something else that possibly makes more sense is the only way that I see this being addressed.\n\nWith this change, should monasca-statsd be deprecated or moved to the attic, and then deprecated? I\u0027m not seeing a need to continue with monasca-statsd. We would want to announce our intentions and allow folks to transition. Support for histograms would help in that transition, but since that wasn\u0027t already supported, it should be too much of an issue.","commit_id":"5dab31e1ccd0bb4fcbb3e21741eb298e0e404bef"},{"author":{"_account_id":17244,"name":"Joachim Barheine","email":"joachim.barheine@sap.com","username":"jobrs"},"change_message_id":"e6b02256834de5274e07dfed7dc5e80f9081cad7","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        return name, value, metric_type, dimensions, sample_rate"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @staticmethod"},{"line_number":101,"context_line":"    def _parse_dogstatsd_tags(statsd_msg):"},{"line_number":102,"context_line":"        dimensions \u003d {}"},{"line_number":103,"context_line":"        s \u003d \u0027\u0027"},{"line_number":104,"context_line":"        key \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_5e10144f","line":101,"range":{"start_line":101,"start_character":29,"end_line":101,"end_character":30},"in_reply_to":"3a461143_e5390e43","updated":"2017-02-03 08:44:02.000000000","message":"I think so. I just wonder whether we could extend the coverage further, most notably support histograms. The next question is what happens to monasca-statsd? I would be glad if somebody could contribute this. Also we should decide whether we want to support dogstatsd tags without value, e.g. by setting the value to \"True\" if it is missing.","commit_id":"5dab31e1ccd0bb4fcbb3e21741eb298e0e404bef"}],"tests/test_metrics.py":[{"author":{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},"change_message_id":"7f3e7d1bba68d85a1d3de9baa0027844dd9254f1","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        counter \u003d metrics.Counter(metric_name, dimensions, tenant_name)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"\t# single counter value"},{"line_number":61,"context_line":"        counter.sample(5, SAMPLE_RATE, 1)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        envelope \u003d counter.flush()[0]"}],"source_content_type":"text/x-python","patch_set":13,"id":"5fc1f717_6ac27336","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":1},"updated":"2019-04-09 20:39:08.000000000","message":"Ugh, these are tab indents!","commit_id":"170c3e45e8a7875b9127109fbff8818fd81c6c69"}]}