)]}'
{"docs/Plugins.md":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"66fca4d0d6751ea0d11a7eea24a637dcb866d0d3","unresolved":false,"context_lines":[{"line_number":487,"context_line":""},{"line_number":488,"context_line":"It connects to the cAdvisor instance and queries the stats API about the host."},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"There is two ways to configure the plugin."},{"line_number":491,"context_line":"* Set cAdvisor url"},{"line_number":492,"context_line":"* Set kubernetes detect url to True. In this instance we are assuming that the agent is running in a Kubernetes"},{"line_number":493,"context_line":"container. It will obtain the cAdvisor url by first querying the Kubernetes API to ask which node it is running on and"}],"source_content_type":"text/x-markdown","patch_set":6,"id":"fa31d9ce_fc4a6e82","line":490,"updated":"2017-02-12 03:43:07.000000000","message":"There are","commit_id":"7238c87bbbd43917eb64728715c8202d9680a21d"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"66fca4d0d6751ea0d11a7eea24a637dcb866d0d3","unresolved":false,"context_lines":[{"line_number":489,"context_line":""},{"line_number":490,"context_line":"There is two ways to configure the plugin."},{"line_number":491,"context_line":"* Set cAdvisor url"},{"line_number":492,"context_line":"* Set kubernetes detect url to True. In this instance we are assuming that the agent is running in a Kubernetes"},{"line_number":493,"context_line":"container. It will obtain the cAdvisor url by first querying the Kubernetes API to ask which node it is running on and"},{"line_number":494,"context_line":"then from there hit the local cAdvisor on that node that is included in the kubelet."},{"line_number":495,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":6,"id":"fa31d9ce_3c45e66f","line":492,"updated":"2017-02-12 03:43:07.000000000","message":"If True, the assumption is that the Agent...","commit_id":"7238c87bbbd43917eb64728715c8202d9680a21d"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"66fca4d0d6751ea0d11a7eea24a637dcb866d0d3","unresolved":false,"context_lines":[{"line_number":490,"context_line":"There is two ways to configure the plugin."},{"line_number":491,"context_line":"* Set cAdvisor url"},{"line_number":492,"context_line":"* Set kubernetes detect url to True. In this instance we are assuming that the agent is running in a Kubernetes"},{"line_number":493,"context_line":"container. It will obtain the cAdvisor url by first querying the Kubernetes API to ask which node it is running on and"},{"line_number":494,"context_line":"then from there hit the local cAdvisor on that node that is included in the kubelet."},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"At this time the plugin only supports getting data from one cAdvisor endpoint. In result the config yaml file should"}],"source_content_type":"text/x-markdown","patch_set":6,"id":"fa31d9ce_5c48da87","line":493,"updated":"2017-02-12 03:43:07.000000000","message":"The Agent will","commit_id":"7238c87bbbd43917eb64728715c8202d9680a21d"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"66fca4d0d6751ea0d11a7eea24a637dcb866d0d3","unresolved":false,"context_lines":[{"line_number":493,"context_line":"container. It will obtain the cAdvisor url by first querying the Kubernetes API to ask which node it is running on and"},{"line_number":494,"context_line":"then from there hit the local cAdvisor on that node that is included in the kubelet."},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"At this time the plugin only supports getting data from one cAdvisor endpoint. In result the config yaml file should"},{"line_number":497,"context_line":"only have one instance defined under instances. (Example showed below)"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"Sample config (passing in cAdvisor url):"}],"source_content_type":"text/x-markdown","patch_set":6,"id":"fa31d9ce_7c5f5e41","line":496,"updated":"2017-02-12 03:43:07.000000000","message":"As a result","commit_id":"7238c87bbbd43917eb64728715c8202d9680a21d"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"66fca4d0d6751ea0d11a7eea24a637dcb866d0d3","unresolved":false,"context_lines":[{"line_number":494,"context_line":"then from there hit the local cAdvisor on that node that is included in the kubelet."},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"At this time the plugin only supports getting data from one cAdvisor endpoint. In result the config yaml file should"},{"line_number":497,"context_line":"only have one instance defined under instances. (Example showed below)"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"Sample config (passing in cAdvisor url):"},{"line_number":500,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":6,"id":"fa31d9ce_9c5a524f","line":497,"updated":"2017-02-12 03:43:07.000000000","message":"shown i think","commit_id":"7238c87bbbd43917eb64728715c8202d9680a21d"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"3bd5dbe308c78b395b598cbc8fe48e76e0d19d36","unresolved":false,"context_lines":[{"line_number":487,"context_line":""},{"line_number":488,"context_line":"It connects to the cAdvisor instance and queries the stats API about the host."},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"There is two ways to configure the plugin."},{"line_number":491,"context_line":"* Set cAdvisor url"},{"line_number":492,"context_line":"* Set kubernetes detect url to True. If true, the assumption is that the Agent is running in a Kubernetes"},{"line_number":493,"context_line":"container. The agent will obtain the cAdvisor url by first querying the Kubernetes API to ask which node it is running on and"}],"source_content_type":"text/x-markdown","patch_set":9,"id":"9a30ddce_58270912","line":490,"range":{"start_line":490,"start_character":6,"end_line":490,"end_character":8},"updated":"2017-03-08 02:52:06.000000000","message":"are","commit_id":"8b587d80ca1696a756fb4166fc584f3c1e0d8339"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"914e433ead4571d932172e11b9c8bf8699a5107d","unresolved":false,"context_lines":[{"line_number":487,"context_line":""},{"line_number":488,"context_line":"It connects to the cAdvisor instance and queries the stats API about the host."},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"There is two ways to configure the plugin."},{"line_number":491,"context_line":"* Set cAdvisor url"},{"line_number":492,"context_line":"* Set kubernetes detect url to True. If true, the assumption is that the Agent is running in a Kubernetes"},{"line_number":493,"context_line":"container. The agent will obtain the cAdvisor url by first querying the Kubernetes API to ask which node it is running on and"}],"source_content_type":"text/x-markdown","patch_set":9,"id":"9a30ddce_ad2b5293","line":490,"range":{"start_line":490,"start_character":6,"end_line":490,"end_character":8},"in_reply_to":"9a30ddce_58270912","updated":"2017-03-08 14:27:44.000000000","message":"got it","commit_id":"8b587d80ca1696a756fb4166fc584f3c1e0d8339"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"3bd5dbe308c78b395b598cbc8fe48e76e0d19d36","unresolved":false,"context_lines":[{"line_number":493,"context_line":"container. The agent will obtain the cAdvisor url by first querying the Kubernetes API to ask which node it is running on and"},{"line_number":494,"context_line":"then from there hit the local cAdvisor on that node that is included in the kubelet."},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"As a result the plugin only supports getting data from one cAdvisor endpoint. In result the config yaml file should"},{"line_number":497,"context_line":"only have one instance defined under instances. (Example shown below)"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"Sample config (passing in cAdvisor url):"}],"source_content_type":"text/x-markdown","patch_set":9,"id":"9a30ddce_d8605938","line":496,"range":{"start_line":496,"start_character":109,"end_line":496,"end_character":115},"updated":"2017-03-08 02:52:06.000000000","message":"must","commit_id":"8b587d80ca1696a756fb4166fc584f3c1e0d8339"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"3bd5dbe308c78b395b598cbc8fe48e76e0d19d36","unresolved":false,"context_lines":[{"line_number":493,"context_line":"container. The agent will obtain the cAdvisor url by first querying the Kubernetes API to ask which node it is running on and"},{"line_number":494,"context_line":"then from there hit the local cAdvisor on that node that is included in the kubelet."},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"As a result the plugin only supports getting data from one cAdvisor endpoint. In result the config yaml file should"},{"line_number":497,"context_line":"only have one instance defined under instances. (Example shown below)"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"Sample config (passing in cAdvisor url):"}],"source_content_type":"text/x-markdown","patch_set":9,"id":"9a30ddce_9878a1f4","line":496,"range":{"start_line":496,"start_character":76,"end_line":496,"end_character":87},"updated":"2017-03-08 02:52:06.000000000","message":"so","commit_id":"8b587d80ca1696a756fb4166fc584f3c1e0d8339"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"914e433ead4571d932172e11b9c8bf8699a5107d","unresolved":false,"context_lines":[{"line_number":493,"context_line":"container. The agent will obtain the cAdvisor url by first querying the Kubernetes API to ask which node it is running on and"},{"line_number":494,"context_line":"then from there hit the local cAdvisor on that node that is included in the kubelet."},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"As a result the plugin only supports getting data from one cAdvisor endpoint. In result the config yaml file should"},{"line_number":497,"context_line":"only have one instance defined under instances. (Example shown below)"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"Sample config (passing in cAdvisor url):"}],"source_content_type":"text/x-markdown","patch_set":9,"id":"9a30ddce_4d0d763d","line":496,"range":{"start_line":496,"start_character":109,"end_line":496,"end_character":115},"in_reply_to":"9a30ddce_d8605938","updated":"2017-03-08 14:27:44.000000000","message":"got it","commit_id":"8b587d80ca1696a756fb4166fc584f3c1e0d8339"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"3bd5dbe308c78b395b598cbc8fe48e76e0d19d36","unresolved":false,"context_lines":[{"line_number":524,"context_line":""},{"line_number":525,"context_line":"| Metric Name | Dimensions | Semantics |"},{"line_number":526,"context_line":"| ----------- | ---------- | --------- |"},{"line_number":527,"context_line":"| cpu.system_time | hostname | Cumulative system CPU time consumed in seconds"},{"line_number":528,"context_line":"| cpu.system_time_sec | hostname | Rate of system CPU time consumed in seconds"},{"line_number":529,"context_line":"| cpu.total_time | hostname | Cumulative CPU time consumed in seconds"},{"line_number":530,"context_line":"| cpu.total_time_sec | hostname | Rate of CPU time consumed in seconds"}],"source_content_type":"text/x-markdown","patch_set":9,"id":"9a30ddce_a3fd3a3c","line":527,"range":{"start_line":527,"start_character":2,"end_line":527,"end_character":77},"updated":"2017-03-08 02:52:06.000000000","message":"I\u0027m not sure anyone cares about the cumulative cpu metrics. I think the rate is the only thing that matters, but if anyone has a reason why cumulative matters, I would be interested.","commit_id":"8b587d80ca1696a756fb4166fc584f3c1e0d8339"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"afc47561dbe4de76dcf85877b8f894b7bf7695f5","unresolved":false,"context_lines":[{"line_number":524,"context_line":""},{"line_number":525,"context_line":"| Metric Name | Dimensions | Semantics |"},{"line_number":526,"context_line":"| ----------- | ---------- | --------- |"},{"line_number":527,"context_line":"| cpu.system_time | hostname | Cumulative system CPU time consumed in seconds"},{"line_number":528,"context_line":"| cpu.system_time_sec | hostname | Rate of system CPU time consumed in seconds"},{"line_number":529,"context_line":"| cpu.total_time | hostname | Cumulative CPU time consumed in seconds"},{"line_number":530,"context_line":"| cpu.total_time_sec | hostname | Rate of CPU time consumed in seconds"}],"source_content_type":"text/x-markdown","patch_set":9,"id":"9a30ddce_d9b924cd","line":527,"range":{"start_line":527,"start_character":2,"end_line":527,"end_character":77},"in_reply_to":"9a30ddce_5eac3a35","updated":"2017-03-08 15:53:00.000000000","message":"ish we are grabbing all of what cadvisor is reporting we dont have much flexibility past that. I mean we could try to match up names to the other plugins when appropriate, is that what you are asking?","commit_id":"8b587d80ca1696a756fb4166fc584f3c1e0d8339"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"914e433ead4571d932172e11b9c8bf8699a5107d","unresolved":false,"context_lines":[{"line_number":524,"context_line":""},{"line_number":525,"context_line":"| Metric Name | Dimensions | Semantics |"},{"line_number":526,"context_line":"| ----------- | ---------- | --------- |"},{"line_number":527,"context_line":"| cpu.system_time | hostname | Cumulative system CPU time consumed in seconds"},{"line_number":528,"context_line":"| cpu.system_time_sec | hostname | Rate of system CPU time consumed in seconds"},{"line_number":529,"context_line":"| cpu.total_time | hostname | Cumulative CPU time consumed in seconds"},{"line_number":530,"context_line":"| cpu.total_time_sec | hostname | Rate of CPU time consumed in seconds"}],"source_content_type":"text/x-markdown","patch_set":9,"id":"9a30ddce_c0ff6dff","line":527,"range":{"start_line":527,"start_character":2,"end_line":527,"end_character":77},"in_reply_to":"9a30ddce_a3fd3a3c","updated":"2017-03-08 14:27:44.000000000","message":"i dont think so either, maybe put a flag to disable or just take out?","commit_id":"8b587d80ca1696a756fb4166fc584f3c1e0d8339"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"ec19a0cbbc69d5fe434f1d3e8b41f65831efa996","unresolved":false,"context_lines":[{"line_number":524,"context_line":""},{"line_number":525,"context_line":"| Metric Name | Dimensions | Semantics |"},{"line_number":526,"context_line":"| ----------- | ---------- | --------- |"},{"line_number":527,"context_line":"| cpu.system_time | hostname | Cumulative system CPU time consumed in seconds"},{"line_number":528,"context_line":"| cpu.system_time_sec | hostname | Rate of system CPU time consumed in seconds"},{"line_number":529,"context_line":"| cpu.total_time | hostname | Cumulative CPU time consumed in seconds"},{"line_number":530,"context_line":"| cpu.total_time_sec | hostname | Rate of CPU time consumed in seconds"}],"source_content_type":"text/x-markdown","patch_set":9,"id":"9a30ddce_5eac3a35","line":527,"range":{"start_line":527,"start_character":2,"end_line":527,"end_character":77},"in_reply_to":"9a30ddce_c0ff6dff","updated":"2017-03-08 15:37:40.000000000","message":"I would take them out. Let\u0027s reduce the number of metrics.\n\nA global question: Since this plugin is to be used to replace other plugins such as cpu.py, disk.py, etc. when the agent is run in a container, should it output the same metrics as much as possible?","commit_id":"8b587d80ca1696a756fb4166fc584f3c1e0d8339"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b5289f5ee40d3a07005cceb0f1ca45cafef73017","unresolved":false,"context_lines":[{"line_number":524,"context_line":""},{"line_number":525,"context_line":"| Metric Name | Dimensions | Semantics |"},{"line_number":526,"context_line":"| ----------- | ---------- | --------- |"},{"line_number":527,"context_line":"| cpu.system_time | hostname | Cumulative system CPU time consumed in seconds"},{"line_number":528,"context_line":"| cpu.system_time_sec | hostname | Rate of system CPU time consumed in seconds"},{"line_number":529,"context_line":"| cpu.total_time | hostname | Cumulative CPU time consumed in seconds"},{"line_number":530,"context_line":"| cpu.total_time_sec | hostname | Rate of CPU time consumed in seconds"}],"source_content_type":"text/x-markdown","patch_set":9,"id":"9a30ddce_d4348bfc","line":527,"range":{"start_line":527,"start_character":2,"end_line":527,"end_character":77},"in_reply_to":"9a30ddce_d9b924cd","updated":"2017-03-08 16:22:12.000000000","message":"Yes, match metric names","commit_id":"8b587d80ca1696a756fb4166fc584f3c1e0d8339"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"3bd5dbe308c78b395b598cbc8fe48e76e0d19d36","unresolved":false,"context_lines":[{"line_number":525,"context_line":"| Metric Name | Dimensions | Semantics |"},{"line_number":526,"context_line":"| ----------- | ---------- | --------- |"},{"line_number":527,"context_line":"| cpu.system_time | hostname | Cumulative system CPU time consumed in seconds"},{"line_number":528,"context_line":"| cpu.system_time_sec | hostname | Rate of system CPU time consumed in seconds"},{"line_number":529,"context_line":"| cpu.total_time | hostname | Cumulative CPU time consumed in seconds"},{"line_number":530,"context_line":"| cpu.total_time_sec | hostname | Rate of CPU time consumed in seconds"},{"line_number":531,"context_line":"| cpu.user_time | hostname | Cumulative user cpu time consumed in seconds"}],"source_content_type":"text/x-markdown","patch_set":9,"id":"9a30ddce_38d5f5b8","line":528,"range":{"start_line":528,"start_character":71,"end_line":528,"end_character":78},"updated":"2017-03-08 02:52:06.000000000","message":"Probably should be \"seconds per seconds\"","commit_id":"8b587d80ca1696a756fb4166fc584f3c1e0d8339"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"914e433ead4571d932172e11b9c8bf8699a5107d","unresolved":false,"context_lines":[{"line_number":525,"context_line":"| Metric Name | Dimensions | Semantics |"},{"line_number":526,"context_line":"| ----------- | ---------- | --------- |"},{"line_number":527,"context_line":"| cpu.system_time | hostname | Cumulative system CPU time consumed in seconds"},{"line_number":528,"context_line":"| cpu.system_time_sec | hostname | Rate of system CPU time consumed in seconds"},{"line_number":529,"context_line":"| cpu.total_time | hostname | Cumulative CPU time consumed in seconds"},{"line_number":530,"context_line":"| cpu.total_time_sec | hostname | Rate of CPU time consumed in seconds"},{"line_number":531,"context_line":"| cpu.user_time | hostname | Cumulative user cpu time consumed in seconds"}],"source_content_type":"text/x-markdown","patch_set":9,"id":"9a30ddce_000a6521","line":528,"range":{"start_line":528,"start_character":71,"end_line":528,"end_character":78},"in_reply_to":"9a30ddce_38d5f5b8","updated":"2017-03-08 14:27:44.000000000","message":"yes","commit_id":"8b587d80ca1696a756fb4166fc584f3c1e0d8339"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"3bd5dbe308c78b395b598cbc8fe48e76e0d19d36","unresolved":false,"context_lines":[{"line_number":533,"context_line":"| fs.total_bytes | hostname, device | Number of bytes available"},{"line_number":534,"context_line":"| fs.usage_bytes | hostname, device | Number of bytes consumed"},{"line_number":535,"context_line":"| mem.cache_bytes | hostname | Number of bytes of page cache memory"},{"line_number":536,"context_line":"| mem.rss_bytes | hostname | Size of rss in bytes"},{"line_number":537,"context_line":"| mem.swap_bytes | hostname | Swap usage in memory in bytes"},{"line_number":538,"context_line":"| mem.used_bytes | hostname | Current memory in use in bytes"},{"line_number":539,"context_line":"| mem.fail_count | hostname | Number of memory usage limit hits"}],"source_content_type":"text/x-markdown","patch_set":9,"id":"9a30ddce_5e4c5142","line":536,"range":{"start_line":536,"start_character":2,"end_line":536,"end_character":15},"updated":"2017-03-08 02:52:06.000000000","message":"What does this mean on a server? I can see on a container, but these are supposed to be server metrics.","commit_id":"8b587d80ca1696a756fb4166fc584f3c1e0d8339"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"914e433ead4571d932172e11b9c8bf8699a5107d","unresolved":false,"context_lines":[{"line_number":533,"context_line":"| fs.total_bytes | hostname, device | Number of bytes available"},{"line_number":534,"context_line":"| fs.usage_bytes | hostname, device | Number of bytes consumed"},{"line_number":535,"context_line":"| mem.cache_bytes | hostname | Number of bytes of page cache memory"},{"line_number":536,"context_line":"| mem.rss_bytes | hostname | Size of rss in bytes"},{"line_number":537,"context_line":"| mem.swap_bytes | hostname | Swap usage in memory in bytes"},{"line_number":538,"context_line":"| mem.used_bytes | hostname | Current memory in use in bytes"},{"line_number":539,"context_line":"| mem.fail_count | hostname | Number of memory usage limit hits"}],"source_content_type":"text/x-markdown","patch_set":9,"id":"9a30ddce_803575db","line":536,"range":{"start_line":536,"start_character":2,"end_line":536,"end_character":15},"in_reply_to":"9a30ddce_5e4c5142","updated":"2017-03-08 14:27:44.000000000","message":"let me look into it","commit_id":"8b587d80ca1696a756fb4166fc584f3c1e0d8339"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"3bd5dbe308c78b395b598cbc8fe48e76e0d19d36","unresolved":false,"context_lines":[{"line_number":536,"context_line":"| mem.rss_bytes | hostname | Size of rss in bytes"},{"line_number":537,"context_line":"| mem.swap_bytes | hostname | Swap usage in memory in bytes"},{"line_number":538,"context_line":"| mem.used_bytes | hostname | Current memory in use in bytes"},{"line_number":539,"context_line":"| mem.fail_count | hostname | Number of memory usage limit hits"},{"line_number":540,"context_line":"| net.in_bytes | hostname, interface | Total network bytes received"},{"line_number":541,"context_line":"| net.in_bytes_sec | hostname, interface | Number of network bytes received per second"},{"line_number":542,"context_line":"| net.in_dropped_packets | hostname, interface | Total inbound network packets dropped"}],"source_content_type":"text/x-markdown","patch_set":9,"id":"9a30ddce_fe6185a9","line":539,"range":{"start_line":539,"start_character":2,"end_line":539,"end_character":16},"updated":"2017-03-08 02:52:06.000000000","message":"What does this mean on a server?","commit_id":"8b587d80ca1696a756fb4166fc584f3c1e0d8339"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"914e433ead4571d932172e11b9c8bf8699a5107d","unresolved":false,"context_lines":[{"line_number":536,"context_line":"| mem.rss_bytes | hostname | Size of rss in bytes"},{"line_number":537,"context_line":"| mem.swap_bytes | hostname | Swap usage in memory in bytes"},{"line_number":538,"context_line":"| mem.used_bytes | hostname | Current memory in use in bytes"},{"line_number":539,"context_line":"| mem.fail_count | hostname | Number of memory usage limit hits"},{"line_number":540,"context_line":"| net.in_bytes | hostname, interface | Total network bytes received"},{"line_number":541,"context_line":"| net.in_bytes_sec | hostname, interface | Number of network bytes received per second"},{"line_number":542,"context_line":"| net.in_dropped_packets | hostname, interface | Total inbound network packets dropped"}],"source_content_type":"text/x-markdown","patch_set":9,"id":"9a30ddce_603de1ba","line":539,"range":{"start_line":539,"start_character":2,"end_line":539,"end_character":16},"in_reply_to":"9a30ddce_fe6185a9","updated":"2017-03-08 14:27:44.000000000","message":"maybe when you run out of memory on the machine? I am not sure though again carried over from containers. Need to investigate more","commit_id":"8b587d80ca1696a756fb4166fc584f3c1e0d8339"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"3bd5dbe308c78b395b598cbc8fe48e76e0d19d36","unresolved":false,"context_lines":[{"line_number":537,"context_line":"| mem.swap_bytes | hostname | Swap usage in memory in bytes"},{"line_number":538,"context_line":"| mem.used_bytes | hostname | Current memory in use in bytes"},{"line_number":539,"context_line":"| mem.fail_count | hostname | Number of memory usage limit hits"},{"line_number":540,"context_line":"| net.in_bytes | hostname, interface | Total network bytes received"},{"line_number":541,"context_line":"| net.in_bytes_sec | hostname, interface | Number of network bytes received per second"},{"line_number":542,"context_line":"| net.in_dropped_packets | hostname, interface | Total inbound network packets dropped"},{"line_number":543,"context_line":"| net.in_dropped_packets_sec | hostname, interface | Number of inbound network packets dropped per second"}],"source_content_type":"text/x-markdown","patch_set":9,"id":"9a30ddce_1e273965","line":540,"range":{"start_line":540,"start_character":2,"end_line":540,"end_character":14},"updated":"2017-03-08 02:52:06.000000000","message":"I\u0027m not sure anyone cares about cumulative on these, either","commit_id":"8b587d80ca1696a756fb4166fc584f3c1e0d8339"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"914e433ead4571d932172e11b9c8bf8699a5107d","unresolved":false,"context_lines":[{"line_number":537,"context_line":"| mem.swap_bytes | hostname | Swap usage in memory in bytes"},{"line_number":538,"context_line":"| mem.used_bytes | hostname | Current memory in use in bytes"},{"line_number":539,"context_line":"| mem.fail_count | hostname | Number of memory usage limit hits"},{"line_number":540,"context_line":"| net.in_bytes | hostname, interface | Total network bytes received"},{"line_number":541,"context_line":"| net.in_bytes_sec | hostname, interface | Number of network bytes received per second"},{"line_number":542,"context_line":"| net.in_dropped_packets | hostname, interface | Total inbound network packets dropped"},{"line_number":543,"context_line":"| net.in_dropped_packets_sec | hostname, interface | Number of inbound network packets dropped per second"}],"source_content_type":"text/x-markdown","patch_set":9,"id":"9a30ddce_c0268db9","line":540,"range":{"start_line":540,"start_character":2,"end_line":540,"end_character":14},"in_reply_to":"9a30ddce_1e273965","updated":"2017-03-08 14:27:44.000000000","message":"probably not, again flag to disable or just take out?","commit_id":"8b587d80ca1696a756fb4166fc584f3c1e0d8339"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"ec19a0cbbc69d5fe434f1d3e8b41f65831efa996","unresolved":false,"context_lines":[{"line_number":537,"context_line":"| mem.swap_bytes | hostname | Swap usage in memory in bytes"},{"line_number":538,"context_line":"| mem.used_bytes | hostname | Current memory in use in bytes"},{"line_number":539,"context_line":"| mem.fail_count | hostname | Number of memory usage limit hits"},{"line_number":540,"context_line":"| net.in_bytes | hostname, interface | Total network bytes received"},{"line_number":541,"context_line":"| net.in_bytes_sec | hostname, interface | Number of network bytes received per second"},{"line_number":542,"context_line":"| net.in_dropped_packets | hostname, interface | Total inbound network packets dropped"},{"line_number":543,"context_line":"| net.in_dropped_packets_sec | hostname, interface | Number of inbound network packets dropped per second"}],"source_content_type":"text/x-markdown","patch_set":9,"id":"9a30ddce_1e71e2e0","line":540,"range":{"start_line":540,"start_character":2,"end_line":540,"end_character":14},"in_reply_to":"9a30ddce_c0268db9","updated":"2017-03-08 15:37:40.000000000","message":"Remove","commit_id":"8b587d80ca1696a756fb4166fc584f3c1e0d8339"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"58cc13d5e7f8330afa4a30ed31551d2dcdfb4c0b","unresolved":false,"context_lines":[{"line_number":532,"context_line":"| Metric Name | Dimensions | Semantics |"},{"line_number":533,"context_line":"| ----------- | ---------- | --------- |"},{"line_number":534,"context_line":"| cpu.system_time | hostname, unit | Cumulative system CPU time consumed in seconds"},{"line_number":535,"context_line":"| cpu.system_time_sec | hostname, unit | Rate of system CPU time consumed in seconds per second"},{"line_number":536,"context_line":"| cpu.total_time | hostname, unit | Cumulative CPU time consumed in seconds"},{"line_number":537,"context_line":"| cpu.total_time_sec | hostname, unit | Rate of CPU time consumed in seconds"},{"line_number":538,"context_line":"| cpu.user_time | hostname, unit | Cumulative user cpu time consumed in seconds"}],"source_content_type":"text/x-markdown","patch_set":12,"id":"9a30ddce_0fccb2b9","line":535,"updated":"2017-03-13 16:26:57.000000000","message":"I\u0027m just a little confused by this naming convention. We\u0027ve often used the convention, cpu.system_time_sec, to define rates. For example, the libvirt plugin, https://github.com/openstack/monasca-agent/blob/master/docs/Libvirt.md. \n\nThe problem is that the cpu.system_time is unitless, but the description says it is in seconds. Should this be cpu.system_time_total_sec?","commit_id":"d6b3ae827e8bf4448474763c0f97c251bc8663be"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"a7d3b922d123c280dd03c1d4c4559620553d6136","unresolved":false,"context_lines":[{"line_number":532,"context_line":"| Metric Name | Dimensions | Semantics |"},{"line_number":533,"context_line":"| ----------- | ---------- | --------- |"},{"line_number":534,"context_line":"| cpu.system_time | hostname, unit | Cumulative system CPU time consumed in seconds"},{"line_number":535,"context_line":"| cpu.system_time_sec | hostname, unit | Rate of system CPU time consumed in seconds per second"},{"line_number":536,"context_line":"| cpu.total_time | hostname, unit | Cumulative CPU time consumed in seconds"},{"line_number":537,"context_line":"| cpu.total_time_sec | hostname, unit | Rate of CPU time consumed in seconds"},{"line_number":538,"context_line":"| cpu.user_time | hostname, unit | Cumulative user cpu time consumed in seconds"}],"source_content_type":"text/x-markdown","patch_set":12,"id":"3a1ff146_3430aa01","line":535,"in_reply_to":"9a30ddce_0fccb2b9","updated":"2017-03-15 15:01:31.000000000","message":"Sorry Roland I forgot to reply. \"_sec\" is for rates. We think this case cpu.system_time has unit\"core seconds\" and it\u0027s not a rate metric. \"cpu.system_time_sec\" is the rate metric with unit \"core seconds per second\".","commit_id":"d6b3ae827e8bf4448474763c0f97c251bc8663be"}],"monasca_agent/collector/checks_d/cadvisor.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"914e433ead4571d932172e11b9c8bf8699a5107d","unresolved":false,"context_lines":[{"line_number":8,"context_line":"METRICS \u003d {"},{"line_number":9,"context_line":"    \"cpu_metrics\": {"},{"line_number":10,"context_line":"        \"system\": (\"system_time\", [\"gauge\", \"rate\"],"},{"line_number":11,"context_line":"                   [\"seconds\", \"cores_per_second\"]),"},{"line_number":12,"context_line":"        \"total\": (\"total_time\", [\"gauge\", \"rate\"],"},{"line_number":13,"context_line":"                  [\"seconds\", \"cores_per_second\"]),"},{"line_number":14,"context_line":"        \"user\": (\"user_time\", [\"gauge\", \"rate\"],"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_8063b5db","line":11,"range":{"start_line":11,"start_character":32,"end_line":11,"end_character":48},"updated":"2017-03-08 14:27:44.000000000","message":"we should document this, as an dimension coming out in the Plugins.md as well as maybe a units table?","commit_id":"8b587d80ca1696a756fb4166fc584f3c1e0d8339"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"07c757d36c141c308f9deee10558350a93ffd35a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"METRICS \u003d {"},{"line_number":9,"context_line":"    \"cpu_metrics\": {"},{"line_number":10,"context_line":"        \"system\": (\"system_time\", [\"gauge\", \"rate\"],"},{"line_number":11,"context_line":"                   [\"seconds\", \"cores_per_second\"]),"},{"line_number":12,"context_line":"        \"total\": (\"total_time\", [\"gauge\", \"rate\"],"},{"line_number":13,"context_line":"                  [\"seconds\", \"cores_per_second\"]),"},{"line_number":14,"context_line":"        \"user\": (\"user_time\", [\"gauge\", \"rate\"],"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_4b5f190e","line":11,"range":{"start_line":11,"start_character":32,"end_line":11,"end_character":48},"in_reply_to":"9a30ddce_8063b5db","updated":"2017-03-08 16:47:20.000000000","message":"I agree. Can we add another column in Plugins.md for units or you think a separate table is better?","commit_id":"8b587d80ca1696a756fb4166fc584f3c1e0d8339"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"3bd5dbe308c78b395b598cbc8fe48e76e0d19d36","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                                       metric_types, metric_units)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def _parse_diskio(self, diskio_data, dimensions):"},{"line_number":117,"context_line":"        diskio_metrics \u003d METRICS[\u0027filesystem_metrics\u0027]"},{"line_number":118,"context_line":"        disk_io \u003d diskio_data[\u0027io_service_bytes\u0027][0][\u0027stats\u0027]"},{"line_number":119,"context_line":"        for cadvisor_key, (metric_name, metric_types, metric_units) in diskio_metrics.iteritems():"},{"line_number":120,"context_line":"            if cadvisor_key in disk_io:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_63b1828f","line":117,"range":{"start_line":117,"start_character":34,"end_line":117,"end_character":52},"updated":"2017-03-08 02:52:06.000000000","message":"Shouldn\u0027t this be diskio_metrics?","commit_id":"8b587d80ca1696a756fb4166fc584f3c1e0d8339"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"914e433ead4571d932172e11b9c8bf8699a5107d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                                       metric_types, metric_units)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def _parse_diskio(self, diskio_data, dimensions):"},{"line_number":117,"context_line":"        diskio_metrics \u003d METRICS[\u0027filesystem_metrics\u0027]"},{"line_number":118,"context_line":"        disk_io \u003d diskio_data[\u0027io_service_bytes\u0027][0][\u0027stats\u0027]"},{"line_number":119,"context_line":"        for cadvisor_key, (metric_name, metric_types, metric_units) in diskio_metrics.iteritems():"},{"line_number":120,"context_line":"            if cadvisor_key in disk_io:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_ed662a28","line":117,"range":{"start_line":117,"start_character":34,"end_line":117,"end_character":52},"in_reply_to":"9a30ddce_63b1828f","updated":"2017-03-08 14:27:44.000000000","message":"yes i will change this, the diskio metrics need a lot of work we should actually comment this out until i can get back to it","commit_id":"8b587d80ca1696a756fb4166fc584f3c1e0d8339"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"3bd5dbe308c78b395b598cbc8fe48e76e0d19d36","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def _parse_diskio(self, diskio_data, dimensions):"},{"line_number":117,"context_line":"        diskio_metrics \u003d METRICS[\u0027filesystem_metrics\u0027]"},{"line_number":118,"context_line":"        disk_io \u003d diskio_data[\u0027io_service_bytes\u0027][0][\u0027stats\u0027]"},{"line_number":119,"context_line":"        for cadvisor_key, (metric_name, metric_types, metric_units) in diskio_metrics.iteritems():"},{"line_number":120,"context_line":"            if cadvisor_key in disk_io:"},{"line_number":121,"context_line":"                self._send_metrics(\"io.\" + metric_name, disk_io[cadvisor_key], dimensions,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_be8c6d80","line":118,"range":{"start_line":118,"start_character":49,"end_line":118,"end_character":52},"updated":"2017-03-08 02:52:06.000000000","message":"Is [0] special? It doesn\u0027t look special on the cAdvisor endpoint that I hit. Although, I wonder if we should even bother with diskio. I doubt anyone cares that much.","commit_id":"8b587d80ca1696a756fb4166fc584f3c1e0d8339"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"914e433ead4571d932172e11b9c8bf8699a5107d","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def _parse_diskio(self, diskio_data, dimensions):"},{"line_number":117,"context_line":"        diskio_metrics \u003d METRICS[\u0027filesystem_metrics\u0027]"},{"line_number":118,"context_line":"        disk_io \u003d diskio_data[\u0027io_service_bytes\u0027][0][\u0027stats\u0027]"},{"line_number":119,"context_line":"        for cadvisor_key, (metric_name, metric_types, metric_units) in diskio_metrics.iteritems():"},{"line_number":120,"context_line":"            if cadvisor_key in disk_io:"},{"line_number":121,"context_line":"                self._send_metrics(\"io.\" + metric_name, disk_io[cadvisor_key], dimensions,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_2d3f62d7","line":118,"range":{"start_line":118,"start_character":49,"end_line":118,"end_character":52},"in_reply_to":"9a30ddce_be8c6d80","updated":"2017-03-08 14:27:44.000000000","message":"see comment above. and it depends on the cAdvisor endpoint you hit it made sense when first looking into it for containers but for / (host) it doesnt we need to match up id to the disks\u0027 ids for getting correct i/o. I say we remove this until we can figure that out","commit_id":"8b587d80ca1696a756fb4166fc584f3c1e0d8339"}],"monasca_agent/collector/checks_d/cadvisor_host.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"847e67982f223d79c5662f5d9d25c91ed977cc99","unresolved":false,"context_lines":[{"line_number":49,"context_line":"}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class Cadvisor(AgentCheck):"},{"line_number":53,"context_line":"    \"\"\"Queries given cAdvisor API for node metrics"},{"line_number":54,"context_line":"    \"\"\""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"7a25e98e_26f8ab7c","line":52,"range":{"start_line":52,"start_character":6,"end_line":52,"end_character":14},"updated":"2017-03-13 22:40:28.000000000","message":"should we change this to match cadvisor host?","commit_id":"81bb9377ebc6e9994d5f651639e379fb37c6be10"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"58d2eb62a39ea64e0b971ce8db08cf8edbcf7f90","unresolved":false,"context_lines":[{"line_number":49,"context_line":"}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class Cadvisor(AgentCheck):"},{"line_number":53,"context_line":"    \"\"\"Queries given cAdvisor API for node metrics"},{"line_number":54,"context_line":"    \"\"\""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"7a25e98e_a6ed7b90","line":52,"range":{"start_line":52,"start_character":6,"end_line":52,"end_character":14},"in_reply_to":"7a25e98e_26f8ab7c","updated":"2017-03-13 22:46:15.000000000","message":"Good catch!!! yes!","commit_id":"81bb9377ebc6e9994d5f651639e379fb37c6be10"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"c3171b3a52774092896286c7e0798ebb2b0c6484","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                    host \u003d kubernetes_connector.get_agent_pod_host()"},{"line_number":69,"context_line":"                    cadvisor_url \u003d \"http://{}:4194\".format(host)"},{"line_number":70,"context_line":"                else:"},{"line_number":71,"context_line":"                    exception_message \u003d \"Either cAdvisor url or kubernetes detect cAdvisor must be set when \" \\"},{"line_number":72,"context_line":"                                        \"monitoring a Kubernetes Node.\""},{"line_number":73,"context_line":"                    self.log.exception(exception_message)"},{"line_number":74,"context_line":"                    raise exception_message"},{"line_number":75,"context_line":"            self.cadvisor_url \u003d \"{}/{}\".format(cadvisor_url, \"api/v2.0/stats?count\u003d1\")"},{"line_number":76,"context_line":"        dimensions \u003d self._set_dimensions(None, instance)"},{"line_number":77,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a1ff146_ca81954f","line":74,"range":{"start_line":71,"start_character":20,"end_line":74,"end_character":43},"updated":"2017-03-14 22:03:07.000000000","message":"Does this work?","commit_id":"e47800a77049e50a6cd401fe5ed43c9272af3948"}]}