)]}'
{"monasca_agent/collector/checks_d/ceph.py":[{"author":{"_account_id":20033,"name":"Artur Basiak","email":"artur.basiak@ts.fujitsu.com","username":"abasiak"},"change_message_id":"9c0b063c4a5a0daf439c800eb60cbc46e1178c95","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                                               \u0027\u0027,"},{"line_number":46,"context_line":"                                               timeout\u003dself.timeout)"},{"line_number":47,"context_line":"        ceph_health \u003d json.loads(ceph_status[1])"},{"line_number":48,"context_line":"        if ceph_health[\u0027health\u0027][\u0027overall_status\u0027] \u003d\u003d \u0027HEALTH_OK\u0027:"},{"line_number":49,"context_line":"            self.gauge(\u0027ceph.health\u0027,"},{"line_number":50,"context_line":"                       0,"},{"line_number":51,"context_line":"                       dimensions\u003ddimensions)"},{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            self.gauge(\u0027ceph.health\u0027,"},{"line_number":54,"context_line":"                       1,"},{"line_number":55,"context_line":"                       dimensions\u003ddimensions)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffe62b97_3ea71eaa","line":55,"range":{"start_line":48,"start_character":7,"end_line":55,"end_character":45},"updated":"2017-03-28 04:56:46.000000000","message":"This metric should be also described in documentation. Please provide in doc which value defines which ceph status.\nPlease provide also unit test if it possible.","commit_id":"3e1aa994898db5e51428eca3757b365ac698c322"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"ea098e7c62c6a989e080391658993d3e742e26ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"from __future__ import absolute_import"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import json"},{"line_number":4,"context_line":"import os"}],"source_content_type":"text/x-python","patch_set":10,"id":"bff0334d_48e0accd","line":1,"updated":"2017-04-11 17:47:13.000000000","message":"No Copyright","commit_id":"bcbb0515b2222004fdbab3d8cfe5899460de99f5"},{"author":{"_account_id":20033,"name":"Artur Basiak","email":"artur.basiak@ts.fujitsu.com","username":"abasiak"},"change_message_id":"99ad77ffaeeb30e36dc4b0be4d1fc671f7525db5","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import json"},{"line_number":4,"context_line":"import os"},{"line_number":5,"context_line":"import rados"},{"line_number":6,"context_line":"import sys"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"from monasca_agent.collector import checks"}],"source_content_type":"text/x-python","patch_set":10,"id":"bff0334d_f01993d6","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":12},"updated":"2017-04-12 06:32:46.000000000","message":"I agree here with Tomasz. Please provide try catch for importing this module, the same as it is done in other plugins:\nhttps://github.com/openstack/monasca-agent/blob/master/monasca_agent/collector/checks_d/mongo.py#L94","commit_id":"bcbb0515b2222004fdbab3d8cfe5899460de99f5"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"ea098e7c62c6a989e080391658993d3e742e26ea","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import json"},{"line_number":4,"context_line":"import os"},{"line_number":5,"context_line":"import rados"},{"line_number":6,"context_line":"import sys"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"from monasca_agent.collector import checks"}],"source_content_type":"text/x-python","patch_set":10,"id":"bff0334d_a8c97859","line":5,"updated":"2017-04-11 17:47:13.000000000","message":"Is this python-rados library (https://testpypi.python.org/pypi/rados) ? If that\u0027s true this is an external dependency that won\u0027t be shipped together with an agent. That said, this check won\u0027t simple work.\n\nI\u0027d add some sort of check first (maybe use oslo_utils.import_utils and method try_import) to verify if such library is present first. If not, return reasonable error message to the user. There\u0027s prepare_run (I guess this is correct name) method available from AgentCheck, perhaps there ?\n\nBTW. Usually such check would be part of auto-detection plugin for Ceph.","commit_id":"bcbb0515b2222004fdbab3d8cfe5899460de99f5"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"ea098e7c62c6a989e080391658993d3e742e26ea","unresolved":false,"context_lines":[{"line_number":22,"context_line":"                                           DEFAULT_TIMEOUT))"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def check(self, instance):"},{"line_number":25,"context_line":"        ceph_configfile \u003d instance.get(\u0027config_file\u0027, DEFAULT_CONF_FILE)"},{"line_number":26,"context_line":"        ceph_keyring \u003d instance.get(\u0027keyring\u0027, DEFAULT_KEYRING)"},{"line_number":27,"context_line":"        try:"},{"line_number":28,"context_line":"            cluster \u003d rados.Rados(conffile\u003dceph_configfile,"}],"source_content_type":"text/x-python","patch_set":10,"id":"bff0334d_c8fcbc71","line":25,"updated":"2017-04-11 17:47:13.000000000","message":"Lines from 25 to 34, I;d move to prepare_run method and leave actual metric collection in check.","commit_id":"bcbb0515b2222004fdbab3d8cfe5899460de99f5"}],"requirements.txt":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"ea098e7c62c6a989e080391658993d3e742e26ea","unresolved":false,"context_lines":[{"line_number":22,"context_line":"supervisor\u003e\u003d3.1.3,\u003c3.4"},{"line_number":23,"context_line":"stevedore\u003e\u003d1.17.1 # Apache-2.0"},{"line_number":24,"context_line":"tornado\u003e\u003d4.3"},{"line_number":25,"context_line":"python-cephlibs\u003e\u003d0.94"}],"source_content_type":"text/plain","patch_set":10,"id":"bff0334d_e8366051","line":25,"updated":"2017-04-11 17:47:13.000000000","message":"I don\u0027t think that\u0027s good idea. That\u0027s not hard requirement for entire monasca agent.","commit_id":"bcbb0515b2222004fdbab3d8cfe5899460de99f5"}]}