)]}'
{"monasca_agent/collector/checks/check.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b051018357c127c7ac54bd00113b76869a4cc032","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self.name \u003d name"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        self.init_config \u003d init_config"},{"line_number":36,"context_line":"        self.white_list \u003d white_list"},{"line_number":37,"context_line":"        self.hostname \u003d util.get_hostname()"},{"line_number":38,"context_line":"        self.log \u003d logging.getLogger(\u0027%s.%s\u0027 % (__name__, name))"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a1ced50_c528df9c","line":36,"range":{"start_line":36,"start_character":26,"end_line":36,"end_character":36},"updated":"2017-03-22 22:40:05.000000000","message":"How about you initialized this with: init_config.get(\u0027white_list\u0027, None)\n\nIf you did that and didn\u0027t try and pass white_list through the constructor, I think it would be supported for all plugins, just like collect_period is. And the default behavior would be exactly what we want.","commit_id":"90381992754d1a2de2c5e98ddd2f956a80d09137"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"26880ca27d72773d37e04e3651dcbd8797f1f748","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self.name \u003d name"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        self.init_config \u003d init_config"},{"line_number":36,"context_line":"        self.white_list \u003d white_list"},{"line_number":37,"context_line":"        self.hostname \u003d util.get_hostname()"},{"line_number":38,"context_line":"        self.log \u003d logging.getLogger(\u0027%s.%s\u0027 % (__name__, name))"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ffe62b97_eded5cf0","line":36,"range":{"start_line":36,"start_character":26,"end_line":36,"end_character":36},"in_reply_to":"1a1ced50_c528df9c","updated":"2017-03-28 22:58:23.000000000","message":"Yes you are right! Thanks!","commit_id":"90381992754d1a2de2c5e98ddd2f956a80d09137"}],"monasca_agent/common/aggregator.py":[{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"d61fb63d0ee1cb9a2ab34d3439055162228de86b","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        # If there is no white list then report all the metrics"},{"line_number":125,"context_line":"        # If there is a white list only report the metrics listed in white list"},{"line_number":126,"context_line":"        if white_list is not None and name not in white_list:"},{"line_number":127,"context_line":"            return"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        if dimensions:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_429ee563","line":126,"range":{"start_line":126,"start_character":8,"end_line":126,"end_character":21},"updated":"2017-03-21 16:33:53.000000000","message":"This might make more sense in AgentCheck, since it already has all the info needed.","commit_id":"1bdb8af2db6d523a7b07ca29d3259837c81a43bb"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"64f9807477ff43cf8b38fbed8d155e4fab3c2940","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        # If there is no white list then report all the metrics"},{"line_number":125,"context_line":"        # If there is a white list only report the metrics listed in white list"},{"line_number":126,"context_line":"        if white_list is not None and name not in white_list:"},{"line_number":127,"context_line":"            return"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        if dimensions:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_a0530c38","line":126,"range":{"start_line":126,"start_character":8,"end_line":126,"end_character":21},"in_reply_to":"1a1ced50_429ee563","updated":"2017-03-21 19:39:50.000000000","message":"Yeah I agree but then the same code will be repeated four times in AgentCheck hmm. I dont know which way is better hmm","commit_id":"1bdb8af2db6d523a7b07ca29d3259837c81a43bb"}],"monasca_agent/common/util.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"7d9e180eaf9bb3e02eda5a2ca16c81b1dda6975b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2015-2017 Hewlett Packard Enterprise Development Company LP"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import glob"},{"line_number":4,"context_line":"import hashlib"}],"source_content_type":"text/x-python","patch_set":9,"id":"bff0334d_c3db764c","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":25},"updated":"2017-04-11 22:30:25.000000000","message":"You aren\u0027t making any changes to this file so don\u0027t update copyright","commit_id":"c90f58b151e6edc507e1eb9e926d6cf8b5f2a53f"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"21a4019eef76cbed10ea6e0ed19cb56b322d112b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2015-2017 Hewlett Packard Enterprise Development Company LP"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import glob"},{"line_number":4,"context_line":"import hashlib"}],"source_content_type":"text/x-python","patch_set":9,"id":"bff0334d_f63defc3","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":25},"in_reply_to":"bff0334d_c3db764c","updated":"2017-04-12 20:28:00.000000000","message":"oops sorry thats a mistake. Done.","commit_id":"c90f58b151e6edc507e1eb9e926d6cf8b5f2a53f"}],"tests/checks_d/test_json_plugin.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"7d9e180eaf9bb3e02eda5a2ca16c81b1dda6975b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2016 Hewlett Packard Enterprise Development LP"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import fcntl"},{"line_number":4,"context_line":"import json"}],"source_content_type":"text/x-python","patch_set":9,"id":"bff0334d_a3de323b","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2017-04-11 22:30:25.000000000","message":"Is this change required for the whitelist? If so, update copyright.","commit_id":"c90f58b151e6edc507e1eb9e926d6cf8b5f2a53f"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"21a4019eef76cbed10ea6e0ed19cb56b322d112b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2016 Hewlett Packard Enterprise Development LP"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import fcntl"},{"line_number":4,"context_line":"import json"}],"source_content_type":"text/x-python","patch_set":9,"id":"bff0334d_d670ab74","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"bff0334d_a3de323b","updated":"2017-04-12 20:28:00.000000000","message":"Yes otherwise the unit tests will not pass. I think it\u0027s a bug on the test part and this is the fix.","commit_id":"c90f58b151e6edc507e1eb9e926d6cf8b5f2a53f"}]}
