)]}'
{"monasca_setup/detection/plugins/magnum.py":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"60db73e88cde909635cf7da48ac5910d907968e2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"import monasca_setup.detection"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"class Magnum(monasca_setup.detection.ServicePlugin):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_981f375a","line":1,"updated":"2017-04-11 07:41:25.000000000","message":"Copyright needs to be added","commit_id":"d5bc0f9ef864453ef84ee9a9869ff0b9e1743d68"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"7e12b7cb5e3c093e820cfd455a878e117adeacac","unresolved":false,"context_lines":[{"line_number":1,"context_line":"import monasca_setup.detection"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"class Magnum(monasca_setup.detection.ServicePlugin):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_a874d8cf","line":1,"in_reply_to":"bff0334d_429e4eb9","updated":"2017-04-11 17:54:54.000000000","message":"Well, at Fujitsu we\u0027ve added Fujitsu copyright to plugins we\u0027ve created (see kibana for instance). As far as I can see, you guys are from Suse, so as far as I am concerned, put the same copyright as in RPM specs in OBS (for example).\n\nmonasca is multi-vendored project, that said - HPE puts their copyright for their mods, Fujitsu for their and Suse should do the same :)","commit_id":"d5bc0f9ef864453ef84ee9a9869ff0b9e1743d68"},{"author":{"_account_id":24612,"name":"Mike Worley","email":"mworley@suse.com","username":"mikesworking"},"change_message_id":"fc81b781d9c186dfa48fbedc416522d1979f153c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"import monasca_setup.detection"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"class Magnum(monasca_setup.detection.ServicePlugin):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_429e4eb9","line":1,"in_reply_to":"bff0334d_981f375a","updated":"2017-04-11 15:29:01.000000000","message":"If this is developed by a non-HPE person does that person still need to add HPE copyright?  If not HPE what copyright is needed.","commit_id":"d5bc0f9ef864453ef84ee9a9869ff0b9e1743d68"},{"author":{"_account_id":10992,"name":"Michael Tupitsyn","email":"michael.tupitsyn@suse.com","username":"tupitsyn"},"change_message_id":"f6a74178132ad9d19237676399107bc327361c4f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"import monasca_setup.detection"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"class Magnum(monasca_setup.detection.ServicePlugin):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_5a862bbb","line":1,"in_reply_to":"bff0334d_a874d8cf","updated":"2017-04-11 20:53:18.000000000","message":"Done","commit_id":"d5bc0f9ef864453ef84ee9a9869ff0b9e1743d68"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"60db73e88cde909635cf7da48ac5910d907968e2","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"class Magnum(monasca_setup.detection.ServicePlugin):"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    \"\"\"Detect Magnum daemons and setup configuration to monitor them.\"\"\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    def __init__(self, template_dir, overwrite\u003dTrue, args\u003dNone):"},{"line_number":9,"context_line":"        service_params \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_583d2fc2","line":6,"updated":"2017-04-11 07:41:25.000000000","message":"There shouldn\u0027t be an empty line here, remove empty line from 5th one.","commit_id":"d5bc0f9ef864453ef84ee9a9869ff0b9e1743d68"},{"author":{"_account_id":10992,"name":"Michael Tupitsyn","email":"michael.tupitsyn@suse.com","username":"tupitsyn"},"change_message_id":"f6a74178132ad9d19237676399107bc327361c4f","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"class Magnum(monasca_setup.detection.ServicePlugin):"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    \"\"\"Detect Magnum daemons and setup configuration to monitor them.\"\"\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    def __init__(self, template_dir, overwrite\u003dTrue, args\u003dNone):"},{"line_number":9,"context_line":"        service_params \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_3a9127f2","line":6,"in_reply_to":"bff0334d_583d2fc2","updated":"2017-04-11 20:53:18.000000000","message":"Done","commit_id":"d5bc0f9ef864453ef84ee9a9869ff0b9e1743d68"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"60db73e88cde909635cf7da48ac5910d907968e2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"            \u0027template_dir\u0027: template_dir,"},{"line_number":12,"context_line":"            \u0027overwrite\u0027: overwrite,"},{"line_number":13,"context_line":"            \u0027service_name\u0027: \u0027container-infra\u0027,"},{"line_number":14,"context_line":"            \u0027process_names\u0027: [\u0027magnum-api \u0027, \u0027magnum-conductor\u0027],"},{"line_number":15,"context_line":"            \u0027service_api_url\u0027: \u0027http://localhost:9511\u0027,"},{"line_number":16,"context_line":"            \u0027search_pattern\u0027: \u0027.*versions.*\u0027,"},{"line_number":17,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_8de7fbac","line":14,"updated":"2017-04-11 07:41:25.000000000","message":"there\u0027s whitespace here and because of that magnum-api process is not detected in the system","commit_id":"d5bc0f9ef864453ef84ee9a9869ff0b9e1743d68"},{"author":{"_account_id":10992,"name":"Michael Tupitsyn","email":"michael.tupitsyn@suse.com","username":"tupitsyn"},"change_message_id":"f6a74178132ad9d19237676399107bc327361c4f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"            \u0027template_dir\u0027: template_dir,"},{"line_number":12,"context_line":"            \u0027overwrite\u0027: overwrite,"},{"line_number":13,"context_line":"            \u0027service_name\u0027: \u0027container-infra\u0027,"},{"line_number":14,"context_line":"            \u0027process_names\u0027: [\u0027magnum-api \u0027, \u0027magnum-conductor\u0027],"},{"line_number":15,"context_line":"            \u0027service_api_url\u0027: \u0027http://localhost:9511\u0027,"},{"line_number":16,"context_line":"            \u0027search_pattern\u0027: \u0027.*versions.*\u0027,"},{"line_number":17,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_fac05fe3","line":14,"in_reply_to":"bff0334d_8de7fbac","updated":"2017-04-11 20:53:18.000000000","message":"Done","commit_id":"d5bc0f9ef864453ef84ee9a9869ff0b9e1743d68"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"effddf0de20d654ddbae62ac096e910723db4dd1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"################################################################"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import monasca_setup.detection"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class Magnum(monasca_setup.detection.ServicePlugin):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_e3e2fad4","line":21,"updated":"2017-04-11 22:38:23.000000000","message":"While we\u0027re at -1 (sorry, had to ;-]) can you change this line to\n\n  from monasca_setup import detection\n\nseems more consistent inside OpenStack IMHO.","commit_id":"8866b44080128fcdbcc53b2ffbde138facf2f5a5"},{"author":{"_account_id":10992,"name":"Michael Tupitsyn","email":"michael.tupitsyn@suse.com","username":"tupitsyn"},"change_message_id":"132e8e85f426296f7f079b064e6673106610cd4f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"################################################################"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import monasca_setup.detection"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class Magnum(monasca_setup.detection.ServicePlugin):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_cee27dd5","line":21,"in_reply_to":"bff0334d_e3e2fad4","updated":"2017-04-11 23:24:47.000000000","message":"No problem :) - done.","commit_id":"8866b44080128fcdbcc53b2ffbde138facf2f5a5"}]}