)]}'
{"conf.d/cadvisor_host.yaml.example":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"207dd77b09529ed20599dcba77023a189302e873","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  # connection_timeout: 3"},{"line_number":5,"context_line":"  # white_list:"},{"line_number":6,"context_line":"  #   - cpu.system_time_sec"},{"line_number":7,"context_line":"  #     dimensions\u003dworkspace_id:12345uuid,hostname:host_default"},{"line_number":8,"context_line":"  #   - mem.used_bytes"},{"line_number":9,"context_line":"  #     dimensions\u003dworkspace_id:56789uuid"},{"line_number":10,"context_line":"  #   - net.in_bytes_sec"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5ff73747_2fa9847a","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":63},"updated":"2017-04-24 22:58:43.000000000","message":"Would be better to express this in yaml syntax","commit_id":"45352d65d91f2897806fab9b90dd99242c932a84"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"7b7b63b3de36c64f6a6501e60c8ec23eb675fcbd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  # connection_timeout: 3"},{"line_number":5,"context_line":"  # white_list:"},{"line_number":6,"context_line":"  #   - cpu.system_time_sec"},{"line_number":7,"context_line":"  #     dimensions\u003dworkspace_id:12345uuid,hostname:host_default"},{"line_number":8,"context_line":"  #   - mem.used_bytes"},{"line_number":9,"context_line":"  #     dimensions\u003dworkspace_id:56789uuid"},{"line_number":10,"context_line":"  #   - net.in_bytes_sec"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5ff73747_7438693c","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":63},"in_reply_to":"5ff73747_2fa9847a","updated":"2017-04-25 15:22:00.000000000","message":"Done","commit_id":"45352d65d91f2897806fab9b90dd99242c932a84"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"ae4e5d9c9427db8960f004664825b97cf819ef18","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  # connection_timeout: 3"},{"line_number":5,"context_line":"  # white_list:"},{"line_number":6,"context_line":"  #   cpu.system_time_sec:"},{"line_number":7,"context_line":"  #     dimensions: {workspace_id: 12345uuid, hostname: host_default}"},{"line_number":8,"context_line":"  #   mem.used_bytes:"},{"line_number":9,"context_line":"  #     dimensions: {workspace_id: 56789uuid}"},{"line_number":10,"context_line":"  #   net.in_bytes_sec:"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5ff73747_2dadf087","line":7,"range":{"start_line":7,"start_character":20,"end_line":7,"end_character":69},"updated":"2017-04-25 16:24:47.000000000","message":"Use the normal yaml syntax:\n\ndimensions:\n    workspace_id: 12345uuid\n    hostname: host_default","commit_id":"bdd08611f73d02cdff9f57540cc8ef9cf34f7458"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"b4192ada5f9be8d378f9cb1baa069605ff344ffe","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  # connection_timeout: 3"},{"line_number":5,"context_line":"  # white_list:"},{"line_number":6,"context_line":"  #   cpu.system_time_sec:"},{"line_number":7,"context_line":"  #     dimensions: {workspace_id: 12345uuid, hostname: host_default}"},{"line_number":8,"context_line":"  #   mem.used_bytes:"},{"line_number":9,"context_line":"  #     dimensions: {workspace_id: 56789uuid}"},{"line_number":10,"context_line":"  #   net.in_bytes_sec:"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5ff73747_d0172051","line":7,"range":{"start_line":7,"start_character":20,"end_line":7,"end_character":69},"in_reply_to":"5ff73747_2dadf087","updated":"2017-04-26 18:10:16.000000000","message":"Done","commit_id":"bdd08611f73d02cdff9f57540cc8ef9cf34f7458"}],"monasca_agent/collector/checks/check.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"ae4e5d9c9427db8960f004664825b97cf819ef18","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    for dim_key in dim_keys:"},{"line_number":78,"context_line":"                        if dim_key not in dimensions.keys():"},{"line_number":79,"context_line":"                            dim_value \u003d dim_key_values.get(dim_key)"},{"line_number":80,"context_line":"                            dimensions[dim_key] \u003d dim_value"},{"line_number":81,"context_line":"                self.aggregator.submit_metric(metric,"},{"line_number":82,"context_line":"                                              value,"},{"line_number":83,"context_line":"                                              metric_type,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_0d73544f","line":80,"range":{"start_line":80,"start_character":28,"end_line":80,"end_character":38},"updated":"2017-04-25 16:24:47.000000000","message":"Dangerous to modify dimensions as it might be used by other metrics.","commit_id":"bdd08611f73d02cdff9f57540cc8ef9cf34f7458"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"ae4e5d9c9427db8960f004664825b97cf819ef18","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                # set to the corresponding value in white list."},{"line_number":74,"context_line":"                dim_key_values \u003d self.white_list.get(metric).values()[0]"},{"line_number":75,"context_line":"                if dim_key_values:"},{"line_number":76,"context_line":"                    dim_keys \u003d dim_key_values.keys()"},{"line_number":77,"context_line":"                    for dim_key in dim_keys:"},{"line_number":78,"context_line":"                        if dim_key not in dimensions.keys():"},{"line_number":79,"context_line":"                            dim_value \u003d dim_key_values.get(dim_key)"},{"line_number":80,"context_line":"                            dimensions[dim_key] \u003d dim_value"},{"line_number":81,"context_line":"                self.aggregator.submit_metric(metric,"},{"line_number":82,"context_line":"                                              value,"},{"line_number":83,"context_line":"                                              metric_type,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_2dca906c","line":80,"range":{"start_line":76,"start_character":0,"end_line":80,"end_character":59},"updated":"2017-04-25 16:24:47.000000000","message":"If you use items(), this would be shorter and simpler","commit_id":"bdd08611f73d02cdff9f57540cc8ef9cf34f7458"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"b4192ada5f9be8d378f9cb1baa069605ff344ffe","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    for dim_key in dim_keys:"},{"line_number":78,"context_line":"                        if dim_key not in dimensions.keys():"},{"line_number":79,"context_line":"                            dim_value \u003d dim_key_values.get(dim_key)"},{"line_number":80,"context_line":"                            dimensions[dim_key] \u003d dim_value"},{"line_number":81,"context_line":"                self.aggregator.submit_metric(metric,"},{"line_number":82,"context_line":"                                              value,"},{"line_number":83,"context_line":"                                              metric_type,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_e99eaeb6","line":80,"range":{"start_line":80,"start_character":28,"end_line":80,"end_character":38},"in_reply_to":"5ff73747_0d73544f","updated":"2017-04-26 18:10:16.000000000","message":"Good point! Thanks! Done","commit_id":"bdd08611f73d02cdff9f57540cc8ef9cf34f7458"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"b4192ada5f9be8d378f9cb1baa069605ff344ffe","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                # set to the corresponding value in white list."},{"line_number":74,"context_line":"                dim_key_values \u003d self.white_list.get(metric).values()[0]"},{"line_number":75,"context_line":"                if dim_key_values:"},{"line_number":76,"context_line":"                    dim_keys \u003d dim_key_values.keys()"},{"line_number":77,"context_line":"                    for dim_key in dim_keys:"},{"line_number":78,"context_line":"                        if dim_key not in dimensions.keys():"},{"line_number":79,"context_line":"                            dim_value \u003d dim_key_values.get(dim_key)"},{"line_number":80,"context_line":"                            dimensions[dim_key] \u003d dim_value"},{"line_number":81,"context_line":"                self.aggregator.submit_metric(metric,"},{"line_number":82,"context_line":"                                              value,"},{"line_number":83,"context_line":"                                              metric_type,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_867ef916","line":80,"range":{"start_line":76,"start_character":0,"end_line":80,"end_character":59},"in_reply_to":"5ff73747_2dca906c","updated":"2017-04-26 18:10:16.000000000","message":"Done","commit_id":"bdd08611f73d02cdff9f57540cc8ef9cf34f7458"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"ae4e5d9c9427db8960f004664825b97cf819ef18","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                        if dim_key not in dimensions.keys():"},{"line_number":79,"context_line":"                            dim_value \u003d dim_key_values.get(dim_key)"},{"line_number":80,"context_line":"                            dimensions[dim_key] \u003d dim_value"},{"line_number":81,"context_line":"                self.aggregator.submit_metric(metric,"},{"line_number":82,"context_line":"                                              value,"},{"line_number":83,"context_line":"                                              metric_type,"},{"line_number":84,"context_line":"                                              dimensions,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_ed8a6819","line":81,"range":{"start_line":81,"start_character":32,"end_line":81,"end_character":46},"updated":"2017-04-25 16:24:47.000000000","message":"Shouldn\u0027t have two calls to submit_metric.","commit_id":"bdd08611f73d02cdff9f57540cc8ef9cf34f7458"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"b4192ada5f9be8d378f9cb1baa069605ff344ffe","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                        if dim_key not in dimensions.keys():"},{"line_number":79,"context_line":"                            dim_value \u003d dim_key_values.get(dim_key)"},{"line_number":80,"context_line":"                            dimensions[dim_key] \u003d dim_value"},{"line_number":81,"context_line":"                self.aggregator.submit_metric(metric,"},{"line_number":82,"context_line":"                                              value,"},{"line_number":83,"context_line":"                                              metric_type,"},{"line_number":84,"context_line":"                                              dimensions,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_099c3abe","line":81,"range":{"start_line":81,"start_character":32,"end_line":81,"end_character":46},"in_reply_to":"5ff73747_ed8a6819","updated":"2017-04-26 18:10:16.000000000","message":"Done","commit_id":"bdd08611f73d02cdff9f57540cc8ef9cf34f7458"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"10e5cd5f73ee8ac76d78a670b61f3cd3b1fd820d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                    dim_key_values \u003d self.white_list.get(metric).values()[0]"},{"line_number":68,"context_line":"                    for dim_kv in dim_key_values.items():"},{"line_number":69,"context_line":"                        if dim_kv[0] not in dimensions_white_list.keys():"},{"line_number":70,"context_line":"                            dimensions_white_list[dim_kv[0]] \u003d dim_kv[1]"},{"line_number":71,"context_line":"        self.aggregator.submit_metric(metric,"},{"line_number":72,"context_line":"                                      value,"},{"line_number":73,"context_line":"                                      metric_type,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f044301_a9136866","line":70,"updated":"2017-05-04 14:26:13.000000000","message":"this dimension thing is so weird to me almost would make more sense to set default dimensions per a plugin not per a metric. What would be an example use case for this?","commit_id":"383e5bf22cf0ac88b2e5be547648bb34e6462906"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"d5301e56554c30c825db7899d2f02eea13894aa4","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                    dim_key_values \u003d self.white_list.get(metric).values()[0]"},{"line_number":68,"context_line":"                    for dim_kv in dim_key_values.items():"},{"line_number":69,"context_line":"                        if dim_kv[0] not in dimensions_white_list.keys():"},{"line_number":70,"context_line":"                            dimensions_white_list[dim_kv[0]] \u003d dim_kv[1]"},{"line_number":71,"context_line":"        self.aggregator.submit_metric(metric,"},{"line_number":72,"context_line":"                                      value,"},{"line_number":73,"context_line":"                                      metric_type,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f044301_9fd0dacb","line":70,"in_reply_to":"3f044301_a9136866","updated":"2017-05-04 15:10:08.000000000","message":"Good point! We can just split the white-list into two sections, one for metric names and another for dimensions. My only concern is do you think there will be cases these default dimensions have different default values for different metrics in the same plugin?","commit_id":"383e5bf22cf0ac88b2e5be547648bb34e6462906"}]}