)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23043,"name":"Jakub Wachowski","email":"jakub.wachowski@ts.fujitsu.com","username":"wachowskij"},"change_message_id":"a834a826e5dbd24d67aaec81b6b457fedc262950","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Integrate with keystoneauth"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Following commits makes following enhancements to the"},{"line_number":10,"context_line":"keystone handling inside monasca-agent:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* using generic password approach that abstracts from underlying"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"3f044301_117428fd","line":9,"range":{"start_line":9,"start_character":10,"end_line":9,"end_character":23},"updated":"2017-05-12 11:58:01.000000000","message":"commit makes or commits make ?","commit_id":"1afbe812d53b136be3fab35eb6e095dcf7f40988"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d5556bcf89808003468df79e777f58a0917db5ec","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Integrate with keystoneauth"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Following commits makes following enhancements to the"},{"line_number":10,"context_line":"keystone handling inside monasca-agent:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* using generic password approach that abstracts from underlying"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"1f013ff3_a9837456","line":9,"range":{"start_line":9,"start_character":10,"end_line":9,"end_character":23},"in_reply_to":"3f044301_117428fd","updated":"2017-05-14 21:26:53.000000000","message":"Done","commit_id":"1afbe812d53b136be3fab35eb6e095dcf7f40988"},{"author":{"_account_id":23043,"name":"Jakub Wachowski","email":"jakub.wachowski@ts.fujitsu.com","username":"wachowskij"},"change_message_id":"a834a826e5dbd24d67aaec81b6b457fedc262950","unresolved":false,"context_lines":[{"line_number":22,"context_line":"* extracted methods get_session and get_client utilize an aproach"},{"line_number":23,"context_line":"presented above and can be used outside of monasca_agent.common.keystone"},{"line_number":24,"context_line":"inside checks or detection plugins"},{"line_number":25,"context_line":"* removed insecure flag - it made no sens from POV of keystoneauth"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Story: 2000995"},{"line_number":28,"context_line":"Task: 4191"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"3f044301_316ba41e","line":25,"range":{"start_line":25,"start_character":37,"end_line":25,"end_character":41},"updated":"2017-05-12 11:58:01.000000000","message":"type: sens \u003d\u003e sense","commit_id":"1afbe812d53b136be3fab35eb6e095dcf7f40988"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d5556bcf89808003468df79e777f58a0917db5ec","unresolved":false,"context_lines":[{"line_number":22,"context_line":"* extracted methods get_session and get_client utilize an aproach"},{"line_number":23,"context_line":"presented above and can be used outside of monasca_agent.common.keystone"},{"line_number":24,"context_line":"inside checks or detection plugins"},{"line_number":25,"context_line":"* removed insecure flag - it made no sens from POV of keystoneauth"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Story: 2000995"},{"line_number":28,"context_line":"Task: 4191"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"1f013ff3_8988b871","line":25,"range":{"start_line":25,"start_character":37,"end_line":25,"end_character":41},"in_reply_to":"3f044301_316ba41e","updated":"2017-05-14 21:26:53.000000000","message":"Flag has been restored.","commit_id":"1afbe812d53b136be3fab35eb6e095dcf7f40988"}],"docs/Agent.md":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"a929b48efe6ed553fb9bfede62974da7dc4232ba","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"#### A note around using monasca-agent with different versions of Keystone"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Keystone comes in two version: **v2.0** and **v3**. Those versions differs between each"},{"line_number":118,"context_line":"other when it comes to the set of acceptable parameters that client library can sent to Keystone API."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"monasca-agent can work with either of versions mentioned above."}],"source_content_type":"text/x-markdown","patch_set":32,"id":"3f1d235d_6cf7f85a","line":117,"range":{"start_line":117,"start_character":52,"end_line":117,"end_character":57},"updated":"2017-07-06 11:43:11.000000000","message":"These","commit_id":"8e51045a7322a76152db41d093e219d372a6db9f"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"a929b48efe6ed553fb9bfede62974da7dc4232ba","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"#### A note around using monasca-agent with different versions of Keystone"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Keystone comes in two version: **v2.0** and **v3**. Those versions differs between each"},{"line_number":118,"context_line":"other when it comes to the set of acceptable parameters that client library can sent to Keystone API."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"monasca-agent can work with either of versions mentioned above."}],"source_content_type":"text/x-markdown","patch_set":32,"id":"3f1d235d_2c9b4018","line":117,"range":{"start_line":117,"start_character":67,"end_line":117,"end_character":74},"updated":"2017-07-06 11:43:11.000000000","message":"differ","commit_id":"8e51045a7322a76152db41d093e219d372a6db9f"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"57e968dff258a01abe228794068f1f14c8008ce3","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"#### A note around using monasca-agent with different versions of Keystone"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Keystone comes in two version: **v2.0** and **v3**. Those versions differs between each"},{"line_number":118,"context_line":"other when it comes to the set of acceptable parameters that client library can sent to Keystone API."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"monasca-agent can work with either of versions mentioned above."}],"source_content_type":"text/x-markdown","patch_set":32,"id":"3f1d235d_f24f5668","line":117,"range":{"start_line":117,"start_character":67,"end_line":117,"end_character":74},"in_reply_to":"3f1d235d_2c9b4018","updated":"2017-07-06 11:56:49.000000000","message":"Done","commit_id":"8e51045a7322a76152db41d093e219d372a6db9f"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"57e968dff258a01abe228794068f1f14c8008ce3","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"#### A note around using monasca-agent with different versions of Keystone"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Keystone comes in two version: **v2.0** and **v3**. Those versions differs between each"},{"line_number":118,"context_line":"other when it comes to the set of acceptable parameters that client library can sent to Keystone API."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"monasca-agent can work with either of versions mentioned above."}],"source_content_type":"text/x-markdown","patch_set":32,"id":"3f1d235d_d2521a13","line":117,"range":{"start_line":117,"start_character":52,"end_line":117,"end_character":57},"in_reply_to":"3f1d235d_6cf7f85a","updated":"2017-07-06 11:56:49.000000000","message":"Done","commit_id":"8e51045a7322a76152db41d093e219d372a6db9f"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"a929b48efe6ed553fb9bfede62974da7dc4232ba","unresolved":false,"context_lines":[{"line_number":115,"context_line":"#### A note around using monasca-agent with different versions of Keystone"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Keystone comes in two version: **v2.0** and **v3**. Those versions differs between each"},{"line_number":118,"context_line":"other when it comes to the set of acceptable parameters that client library can sent to Keystone API."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"monasca-agent can work with either of versions mentioned above."},{"line_number":121,"context_line":"However there are certain limitations. Examine a list below to see what"}],"source_content_type":"text/x-markdown","patch_set":32,"id":"3f1d235d_eca0a844","line":118,"range":{"start_line":118,"start_character":80,"end_line":118,"end_character":84},"updated":"2017-07-06 11:43:11.000000000","message":"send","commit_id":"8e51045a7322a76152db41d093e219d372a6db9f"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"57e968dff258a01abe228794068f1f14c8008ce3","unresolved":false,"context_lines":[{"line_number":115,"context_line":"#### A note around using monasca-agent with different versions of Keystone"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Keystone comes in two version: **v2.0** and **v3**. Those versions differs between each"},{"line_number":118,"context_line":"other when it comes to the set of acceptable parameters that client library can sent to Keystone API."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"monasca-agent can work with either of versions mentioned above."},{"line_number":121,"context_line":"However there are certain limitations. Examine a list below to see what"}],"source_content_type":"text/x-markdown","patch_set":32,"id":"3f1d235d_b2555efc","line":118,"range":{"start_line":118,"start_character":80,"end_line":118,"end_character":84},"in_reply_to":"3f1d235d_eca0a844","updated":"2017-07-06 11:56:49.000000000","message":"Done","commit_id":"8e51045a7322a76152db41d093e219d372a6db9f"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"a929b48efe6ed553fb9bfede62974da7dc4232ba","unresolved":false,"context_lines":[{"line_number":120,"context_line":"monasca-agent can work with either of versions mentioned above."},{"line_number":121,"context_line":"However there are certain limitations. Examine a list below to see what"},{"line_number":122,"context_line":"parameters should be provided via monasca-setup (or manually in agent.yaml) to"},{"line_number":123,"context_line":"successfully configure connectivity with keystone."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"For **v2_0** arguments are:"},{"line_number":126,"context_line":"* ```username```"}],"source_content_type":"text/x-markdown","patch_set":32,"id":"3f1d235d_4c667c2c","line":123,"range":{"start_line":123,"start_character":41,"end_line":123,"end_character":49},"updated":"2017-07-06 11:43:11.000000000","message":"Keystone","commit_id":"8e51045a7322a76152db41d093e219d372a6db9f"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"57e968dff258a01abe228794068f1f14c8008ce3","unresolved":false,"context_lines":[{"line_number":120,"context_line":"monasca-agent can work with either of versions mentioned above."},{"line_number":121,"context_line":"However there are certain limitations. Examine a list below to see what"},{"line_number":122,"context_line":"parameters should be provided via monasca-setup (or manually in agent.yaml) to"},{"line_number":123,"context_line":"successfully configure connectivity with keystone."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"For **v2_0** arguments are:"},{"line_number":126,"context_line":"* ```username```"}],"source_content_type":"text/x-markdown","patch_set":32,"id":"3f1d235d_72434643","line":123,"range":{"start_line":123,"start_character":41,"end_line":123,"end_character":49},"in_reply_to":"3f1d235d_4c667c2c","updated":"2017-07-06 11:56:49.000000000","message":"Done","commit_id":"8e51045a7322a76152db41d093e219d372a6db9f"}],"monasca_agent/common/config.py":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"6f7cd041b6a39afc9b477cb9798197b3258467d1","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                                \u0027project_domain_name\u0027: \u0027\u0027,"},{"line_number":62,"context_line":"                                \u0027project_domain_id\u0027: \u0027\u0027,"},{"line_number":63,"context_line":"                                \u0027ca_file\u0027: \u0027\u0027,"},{"line_number":64,"context_line":"                                \u0027insecure\u0027: \u0027\u0027,"},{"line_number":65,"context_line":"                                \u0027username\u0027: \u0027\u0027,"},{"line_number":66,"context_line":"                                \u0027password\u0027: \u0027\u0027,"},{"line_number":67,"context_line":"                                \u0027use_keystone\u0027: True,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_dcaffe27","side":"PARENT","line":64,"range":{"start_line":64,"start_character":32,"end_line":64,"end_character":47},"updated":"2017-05-12 11:35:04.000000000","message":"insecure may be needed to disable certificate check when keystone is using ssl","commit_id":"e04f5df4ad3aa832d024a1ca1f2471443d115dd0"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"b773ced13dbf157e388ce98d3f3e2b32806f7e79","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                                \u0027project_domain_name\u0027: \u0027\u0027,"},{"line_number":62,"context_line":"                                \u0027project_domain_id\u0027: \u0027\u0027,"},{"line_number":63,"context_line":"                                \u0027ca_file\u0027: \u0027\u0027,"},{"line_number":64,"context_line":"                                \u0027insecure\u0027: \u0027\u0027,"},{"line_number":65,"context_line":"                                \u0027username\u0027: \u0027\u0027,"},{"line_number":66,"context_line":"                                \u0027password\u0027: \u0027\u0027,"},{"line_number":67,"context_line":"                                \u0027use_keystone\u0027: True,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_f1989c75","side":"PARENT","line":64,"range":{"start_line":64,"start_character":32,"end_line":64,"end_character":47},"in_reply_to":"3f044301_91b3980a","updated":"2017-05-12 11:43:57.000000000","message":"Yeah, check here keystoneauth1/session.py:315. That\u0027s the reference to insecure. Updating the code now. Thx","commit_id":"e04f5df4ad3aa832d024a1ca1f2471443d115dd0"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d211e5a387753982c72733e058dba3af8af3bb66","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                                \u0027project_domain_name\u0027: \u0027\u0027,"},{"line_number":62,"context_line":"                                \u0027project_domain_id\u0027: \u0027\u0027,"},{"line_number":63,"context_line":"                                \u0027ca_file\u0027: \u0027\u0027,"},{"line_number":64,"context_line":"                                \u0027insecure\u0027: \u0027\u0027,"},{"line_number":65,"context_line":"                                \u0027username\u0027: \u0027\u0027,"},{"line_number":66,"context_line":"                                \u0027password\u0027: \u0027\u0027,"},{"line_number":67,"context_line":"                                \u0027use_keystone\u0027: True,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_114668c1","side":"PARENT","line":64,"range":{"start_line":64,"start_character":32,"end_line":64,"end_character":47},"in_reply_to":"3f044301_b1957435","updated":"2017-05-12 11:52:23.000000000","message":"Check recent patchset.","commit_id":"e04f5df4ad3aa832d024a1ca1f2471443d115dd0"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"c572ceb7c9599fea489ebf23d8d839604f4ddb1c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                                \u0027project_domain_name\u0027: \u0027\u0027,"},{"line_number":62,"context_line":"                                \u0027project_domain_id\u0027: \u0027\u0027,"},{"line_number":63,"context_line":"                                \u0027ca_file\u0027: \u0027\u0027,"},{"line_number":64,"context_line":"                                \u0027insecure\u0027: \u0027\u0027,"},{"line_number":65,"context_line":"                                \u0027username\u0027: \u0027\u0027,"},{"line_number":66,"context_line":"                                \u0027password\u0027: \u0027\u0027,"},{"line_number":67,"context_line":"                                \u0027use_keystone\u0027: True,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_91b3980a","side":"PARENT","line":64,"range":{"start_line":64,"start_character":32,"end_line":64,"end_character":47},"in_reply_to":"3f044301_d12fe03c","updated":"2017-05-12 11:42:19.000000000","message":"On 2nd thought, maybe insecure here can be translated to to session.Session(verify) argument that can be either true/false. However the same argument can also accept a path to ca_cert which we already have.\n\nI\u0027ll try to dig in a bit more here to see what are the differences.","commit_id":"e04f5df4ad3aa832d024a1ca1f2471443d115dd0"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"e954fa496e2b64d6cdc53e2dcd37623cc443529a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                                \u0027project_domain_name\u0027: \u0027\u0027,"},{"line_number":62,"context_line":"                                \u0027project_domain_id\u0027: \u0027\u0027,"},{"line_number":63,"context_line":"                                \u0027ca_file\u0027: \u0027\u0027,"},{"line_number":64,"context_line":"                                \u0027insecure\u0027: \u0027\u0027,"},{"line_number":65,"context_line":"                                \u0027username\u0027: \u0027\u0027,"},{"line_number":66,"context_line":"                                \u0027password\u0027: \u0027\u0027,"},{"line_number":67,"context_line":"                                \u0027use_keystone\u0027: True,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_d12fe03c","side":"PARENT","line":64,"range":{"start_line":64,"start_character":32,"end_line":64,"end_character":47},"in_reply_to":"3f044301_dcaffe27","updated":"2017-05-12 11:38:29.000000000","message":"Hmm...did you manage to track down if there\u0027s corresponding flag anywhere inside keystoneauth or client on it\u0027s own ? I went as far as to using cert to verify session and saw no insecure. From my POV the insecure was custom addition of monasca-agent but I might be wrong.","commit_id":"e04f5df4ad3aa832d024a1ca1f2471443d115dd0"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"9d40b571d20f953b4d4e485353f3cb3ef03595fb","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                                \u0027project_domain_name\u0027: \u0027\u0027,"},{"line_number":62,"context_line":"                                \u0027project_domain_id\u0027: \u0027\u0027,"},{"line_number":63,"context_line":"                                \u0027ca_file\u0027: \u0027\u0027,"},{"line_number":64,"context_line":"                                \u0027insecure\u0027: \u0027\u0027,"},{"line_number":65,"context_line":"                                \u0027username\u0027: \u0027\u0027,"},{"line_number":66,"context_line":"                                \u0027password\u0027: \u0027\u0027,"},{"line_number":67,"context_line":"                                \u0027use_keystone\u0027: True,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_b1957435","side":"PARENT","line":64,"range":{"start_line":64,"start_character":32,"end_line":64,"end_character":47},"in_reply_to":"3f044301_f1989c75","updated":"2017-05-12 11:46:06.000000000","message":"This one? https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L186-L191","commit_id":"e04f5df4ad3aa832d024a1ca1f2471443d115dd0"}],"monasca_agent/common/keystone.py":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"f62f0c965c6635b74a68fd0fc1774058751f83b1","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                           app_version\u003dma_version.version_string,"},{"line_number":136,"context_line":"                           user_agent\u003d\u0027monasca-agent\u0027,"},{"line_number":137,"context_line":"                           timeout\u003dkwargs.get(\u0027keystone_timeout\u0027, None),"},{"line_number":138,"context_line":"                           verify\u003dnot kwargs.get(\u0027insecure\u0027, False),"},{"line_number":139,"context_line":"                           cert\u003dkwargs.get(\u0027ca_file\u0027, None))"},{"line_number":140,"context_line":"    return sess"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"3f1d235d_258135fc","line":138,"range":{"start_line":138,"start_character":27,"end_line":138,"end_character":68},"updated":"2017-07-05 13:55:38.000000000","message":"I guess you should add \u0027insecure\u0027 to get_credential_args as well, right? Or am I missing something?","commit_id":"be0efe0803e7db11df8b82e12659e0d6eb0941ae"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"1b50fbf7fdbfd6d6cb32409898dda08e8337e28e","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                           app_version\u003dma_version.version_string,"},{"line_number":136,"context_line":"                           user_agent\u003d\u0027monasca-agent\u0027,"},{"line_number":137,"context_line":"                           timeout\u003dkwargs.get(\u0027keystone_timeout\u0027, None),"},{"line_number":138,"context_line":"                           verify\u003dnot kwargs.get(\u0027insecure\u0027, False),"},{"line_number":139,"context_line":"                           cert\u003dkwargs.get(\u0027ca_file\u0027, None))"},{"line_number":140,"context_line":"    return sess"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"3f1d235d_35314aa4","line":138,"range":{"start_line":138,"start_character":27,"end_line":138,"end_character":68},"in_reply_to":"3f1d235d_258135fc","updated":"2017-07-06 04:32:49.000000000","message":"Yes it should. That values comes from CLI so best to have it done there.","commit_id":"be0efe0803e7db11df8b82e12659e0d6eb0941ae"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"8759da1be6f7eb67a78ba9d172f59b479969d887","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                           app_version\u003dma_version.version_string,"},{"line_number":136,"context_line":"                           user_agent\u003d\u0027monasca-agent\u0027,"},{"line_number":137,"context_line":"                           timeout\u003dkwargs.get(\u0027keystone_timeout\u0027, None),"},{"line_number":138,"context_line":"                           verify\u003dnot kwargs.get(\u0027insecure\u0027, False),"},{"line_number":139,"context_line":"                           cert\u003dkwargs.get(\u0027ca_file\u0027, None))"},{"line_number":140,"context_line":"    return sess"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"3f1d235d_a07bda25","line":138,"range":{"start_line":138,"start_character":27,"end_line":138,"end_character":68},"in_reply_to":"3f1d235d_35314aa4","updated":"2017-07-06 05:18:40.000000000","message":"Witek see latest PS, that should be now handled in a right way.","commit_id":"be0efe0803e7db11df8b82e12659e0d6eb0941ae"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"a929b48efe6ed553fb9bfede62974da7dc4232ba","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                           app_name\u003d\u0027monasca-agent\u0027,"},{"line_number":139,"context_line":"                           app_version\u003dma_version.version_string,"},{"line_number":140,"context_line":"                           user_agent\u003d\u0027monasca-agent\u0027,"},{"line_number":141,"context_line":"                           timeout\u003dkwargs.get(\u0027keystone_timeout\u0027, None),"},{"line_number":142,"context_line":"                           verify\u003dnot kwargs.get(\u0027insecure\u0027, False),"},{"line_number":143,"context_line":"                           cert\u003dkwargs.get(\u0027ca_file\u0027, None))"},{"line_number":144,"context_line":"    return sess"}],"source_content_type":"text/x-python","patch_set":32,"id":"3f1d235d_470bf5d4","line":141,"range":{"start_line":141,"start_character":47,"end_line":141,"end_character":63},"updated":"2017-07-06 11:43:11.000000000","message":"should be `timeout`","commit_id":"8e51045a7322a76152db41d093e219d372a6db9f"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"57e968dff258a01abe228794068f1f14c8008ce3","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                           app_name\u003d\u0027monasca-agent\u0027,"},{"line_number":139,"context_line":"                           app_version\u003dma_version.version_string,"},{"line_number":140,"context_line":"                           user_agent\u003d\u0027monasca-agent\u0027,"},{"line_number":141,"context_line":"                           timeout\u003dkwargs.get(\u0027keystone_timeout\u0027, None),"},{"line_number":142,"context_line":"                           verify\u003dnot kwargs.get(\u0027insecure\u0027, False),"},{"line_number":143,"context_line":"                           cert\u003dkwargs.get(\u0027ca_file\u0027, None))"},{"line_number":144,"context_line":"    return sess"}],"source_content_type":"text/x-python","patch_set":32,"id":"3f1d235d_920a621d","line":141,"range":{"start_line":141,"start_character":47,"end_line":141,"end_character":63},"in_reply_to":"3f1d235d_470bf5d4","updated":"2017-07-06 11:56:49.000000000","message":"nope -\u003e https://github.com/openstack/monasca-agent/blob/master/monasca_agent/common/config.py#L69","commit_id":"8e51045a7322a76152db41d093e219d372a6db9f"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"9fa408d8c4460d728a4d2ef20d99987f3b263c52","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                           app_name\u003d\u0027monasca-agent\u0027,"},{"line_number":139,"context_line":"                           app_version\u003dma_version.version_string,"},{"line_number":140,"context_line":"                           user_agent\u003d\u0027monasca-agent\u0027,"},{"line_number":141,"context_line":"                           timeout\u003dkwargs.get(\u0027keystone_timeout\u0027, None),"},{"line_number":142,"context_line":"                           verify\u003dnot kwargs.get(\u0027insecure\u0027, False),"},{"line_number":143,"context_line":"                           cert\u003dkwargs.get(\u0027ca_file\u0027, None))"},{"line_number":144,"context_line":"    return sess"}],"source_content_type":"text/x-python","patch_set":32,"id":"3f1d235d_6d7c7671","line":141,"range":{"start_line":141,"start_character":47,"end_line":141,"end_character":63},"in_reply_to":"3f1d235d_68c8f672","updated":"2017-07-06 22:11:11.000000000","message":"Yeah, I got little lost here. Fixed that in get_args method to set keystone_timeout key inside the dict instead of timeout. Now it should be ok. Thx","commit_id":"8e51045a7322a76152db41d093e219d372a6db9f"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"5dee464f14ea2b2ae046fc3e0f10b462fd218fd1","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                           app_name\u003d\u0027monasca-agent\u0027,"},{"line_number":139,"context_line":"                           app_version\u003dma_version.version_string,"},{"line_number":140,"context_line":"                           user_agent\u003d\u0027monasca-agent\u0027,"},{"line_number":141,"context_line":"                           timeout\u003dkwargs.get(\u0027keystone_timeout\u0027, None),"},{"line_number":142,"context_line":"                           verify\u003dnot kwargs.get(\u0027insecure\u0027, False),"},{"line_number":143,"context_line":"                           cert\u003dkwargs.get(\u0027ca_file\u0027, None))"},{"line_number":144,"context_line":"    return sess"}],"source_content_type":"text/x-python","patch_set":32,"id":"3f1d235d_68c8f672","line":141,"range":{"start_line":141,"start_character":47,"end_line":141,"end_character":63},"in_reply_to":"3f1d235d_920a621d","updated":"2017-07-06 14:11:52.000000000","message":"But you have https://review.openstack.org/#/c/463111/33/monasca_agent/common/keystone.py@229","commit_id":"8e51045a7322a76152db41d093e219d372a6db9f"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"4c24d256c6661b01d8e04b153f3b9493f0e3bb28","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    :param string trust_id: Trust ID for authentication."},{"line_number":95,"context_line":"    :param string default_domain_id: Default domain ID for authentication."},{"line_number":96,"context_line":"    :param string default_domain_name: Default domain name for authentication"},{"line_number":97,"context_line":"    :param float timeout: A timeout to pass to requests. This should be a"},{"line_number":98,"context_line":"                      numerical value indicating some amount (or fraction)"},{"line_number":99,"context_line":"                      of seconds or 0 for no timeout. (optional, defaults"},{"line_number":100,"context_line":"                      to 0)"}],"source_content_type":"text/x-python","patch_set":34,"id":"3f1d235d_5fdc7117","line":97,"range":{"start_line":97,"start_character":17,"end_line":97,"end_character":24},"updated":"2017-07-10 15:34:11.000000000","message":"Could you check once again please if documentation is in sync with code? I guess \u0027ca_file\u0027 is missing as well.","commit_id":"1aea689713168234f39462ba010685cf0ee434ed"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"484c970fe24c85812f941f0774fede37baa5c174","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    :param string trust_id: Trust ID for authentication."},{"line_number":95,"context_line":"    :param string default_domain_id: Default domain ID for authentication."},{"line_number":96,"context_line":"    :param string default_domain_name: Default domain name for authentication"},{"line_number":97,"context_line":"    :param float timeout: A timeout to pass to requests. This should be a"},{"line_number":98,"context_line":"                      numerical value indicating some amount (or fraction)"},{"line_number":99,"context_line":"                      of seconds or 0 for no timeout. (optional, defaults"},{"line_number":100,"context_line":"                      to 0)"}],"source_content_type":"text/x-python","patch_set":34,"id":"3f1d235d_578323aa","line":97,"range":{"start_line":97,"start_character":17,"end_line":97,"end_character":24},"in_reply_to":"3f1d235d_5fdc7117","updated":"2017-07-11 07:02:49.000000000","message":"Should be keystone_timeout +1. \nca_file is at L#103","commit_id":"1aea689713168234f39462ba010685cf0ee434ed"}]}