)]}'
{"monasca_agent/collector/checks_d/kafka_consumer.py":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"695c31820c1e2b11862ae954d7da12c24fc46b55","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    import monasca_common.kafka_lib.common as common"},{"line_number":10,"context_line":"    import monasca_common.kafka_lib.consumer as consumer"},{"line_number":11,"context_line":"except ImportError:"},{"line_number":12,"context_line":"    raise Exception(\u0027Missing python dependency: monasca-common \u0027"},{"line_number":13,"context_line":"                    \u0027(https://github.com/openstack/monasca-common)\u0027)"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_3aab22d7","line":12,"updated":"2017-05-29 17:16:30.000000000","message":"I still propose to add this as extra dependency to setup.cfg. Similar to https://github.com/openstack/monasca-agent/blob/master/setup.cfg#L46.\n\n  setup.cfg\n  [extras]\n  d_kafka \u003d \n    monasca-common \u003e\u003d X.X.X\n\nThat way we could later on write here\n\n  pip install monasca-agent[d_kafka] \n\nas in d_kafka \u003d\u003d detection_kafka\n\n(I think I got the syntax of installing extras correctly","commit_id":"3210cfa1f9056aefd32b5261df935ace952c7769"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"55cea2d5b3f5b24e1b6a3485462b35abc9a24283","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    import monasca_common.kafka_lib.common as common"},{"line_number":10,"context_line":"    import monasca_common.kafka_lib.consumer as consumer"},{"line_number":11,"context_line":"except ImportError:"},{"line_number":12,"context_line":"    raise Exception(\u0027Missing python dependency: monasca-common \u0027"},{"line_number":13,"context_line":"                    \u0027(https://github.com/openstack/monasca-common)\u0027)"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_9af22e06","line":12,"in_reply_to":"df140735_3aab22d7","updated":"2017-05-29 17:19:13.000000000","message":"The reason I am mentioning this is mentioned in the extras documentation [https://setuptools.readthedocs.io/en/latest/setuptools.html#declaring-extras-optional-features-with-their-own-dependencies]. In other words, in order to use kafka-autodetection you require certain libs available in the system/virtualenv that are not necessarily required for entire application to run.\n\nHowever we\u0027re clearly showing what dependencies are required where + can put version constraints on them","commit_id":"3210cfa1f9056aefd32b5261df935ace952c7769"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"a741cd99c73fead2a55c924066c6fcee5966589e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    import monasca_common.kafka_lib.common as common"},{"line_number":10,"context_line":"    import monasca_common.kafka_lib.consumer as consumer"},{"line_number":11,"context_line":"except ImportError:"},{"line_number":12,"context_line":"    raise Exception(\u0027Missing python dependency: monasca-common \u0027"},{"line_number":13,"context_line":"                    \u0027(https://github.com/openstack/monasca-common)\u0027)"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_1af3bea0","line":12,"in_reply_to":"df140735_9af22e06","updated":"2017-05-29 17:54:00.000000000","message":"Ready to use example would be:\n\n  [extras]\n  d_kafka \u003d\n     monasca-common\u003c\u003d2.0.0\n\nand in the comment here. \n  \n  Missing python dependency: monasca-common.\\n\n  Please install with with pip install monasca-agent[d_kafka]","commit_id":"3210cfa1f9056aefd32b5261df935ace952c7769"}],"monasca_setup/detection/plugins/kafka_consumer.py":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"e6c3fdf7f655b10b94131ad922d66eae79a1b1fb","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        return self.config"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    def dependencies_installed(self):"},{"line_number":318,"context_line":"        return importutils.try_import(\u0027monasca_common\u0027, False)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_ac700474","line":318,"updated":"2017-05-30 17:36:52.000000000","message":"+1","commit_id":"b9095716e1093caa6aa02c1aff4647bf2eee2418"}],"test-requirements.txt":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"e142eda5e87642037f331ea91d28e47bfd9fbb6f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"hacking\u003e\u003d0.12.0,!\u003d0.13.0,\u003c0.14  # Apache-2.0"},{"line_number":5,"context_line":"bandit\u003e\u003d1.1.0 # Apache-2.0"},{"line_number":6,"context_line":"mock\u003e\u003d2.0 # BSD"},{"line_number":7,"context_line":"monasca-common\u003e\u003d1.4.0 # Apache-2.0"},{"line_number":8,"context_line":"coverage\u003e\u003d4.0  # Apache-2.0"},{"line_number":9,"context_line":"oslotest\u003e\u003d1.10.0 # Apache-2.0"},{"line_number":10,"context_line":"os-testr\u003e\u003d0.8.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"ff0f0b1f_6ccc3861","line":7,"updated":"2017-05-26 19:24:25.000000000","message":"are we really sure that it should be a dependency ?\nit will be used by just one plugin, so might be good idea to add this to setup.cfg extras instead of keeping it here.","commit_id":"d5f3751557327fb89f4ec02ba97d50178d8953f6"}]}