)]}'
{"conf.d/libvirt.yaml.example":[{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"b48472d5a20283ca4c533c48291476ba81f6ae41","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    - scale_group"},{"line_number":34,"context_line":"    # Configuration parameters can be used to control which metrics are reported"},{"line_number":35,"context_line":"    # by libvirt plugin."},{"line_number":36,"context_line":"    vm_cpu_check_enable: True"},{"line_number":37,"context_line":"    vm_disks_check_enable: True"},{"line_number":38,"context_line":"    vm_network_check_enable: True"},{"line_number":39,"context_line":"    vm_ping_check_enable: True"},{"line_number":40,"context_line":"    vm_extended_disks_check_enable: True"},{"line_number":41,"context_line":"instances:"},{"line_number":42,"context_line":"    # Instances are automatically detected through queries to the Nova API,"},{"line_number":43,"context_line":"    # and therefore do not need to be listed here, so this remains empty."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"df3967d1_25609dce","line":40,"range":{"start_line":36,"start_character":0,"end_line":40,"end_character":40},"updated":"2017-07-31 14:51:22.000000000","message":"Could we configure such parameters before?  If it couldn\u0027t, this patchset seems to make it configurable for libvirt plugin parameters.","commit_id":"491cc747378b8fbdbf95031eec84ef50402170c7"},{"author":{"_account_id":17981,"name":"Haruki Yamanashi","email":"h.yamanashi@jp.fujitsu.com","username":"Haruki"},"change_message_id":"3871c5e3d205b09a038f3edfa908f90fa8d7cd68","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    - scale_group"},{"line_number":34,"context_line":"    # Configuration parameters can be used to control which metrics are reported"},{"line_number":35,"context_line":"    # by libvirt plugin."},{"line_number":36,"context_line":"    vm_cpu_check_enable: True"},{"line_number":37,"context_line":"    vm_disks_check_enable: True"},{"line_number":38,"context_line":"    vm_network_check_enable: True"},{"line_number":39,"context_line":"    vm_ping_check_enable: True"},{"line_number":40,"context_line":"    vm_extended_disks_check_enable: True"},{"line_number":41,"context_line":"instances:"},{"line_number":42,"context_line":"    # Instances are automatically detected through queries to the Nova API,"},{"line_number":43,"context_line":"    # and therefore do not need to be listed here, so this remains empty."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"df3967d1_e945be71","line":40,"range":{"start_line":36,"start_character":0,"end_line":40,"end_character":40},"in_reply_to":"df3967d1_25609dce","updated":"2017-08-01 03:41:38.000000000","message":"We can configure these parameters (by monasca-setup or manually) but it\u0027s not necessary to configure in this file because this is just a template file.\n\nActually, configuration file(/etc/monasca/agent/conf.d/libvirt.yaml) is created by auto-detection (monasca-setup) or manually, and parameters can be configured in both ways.\n\n- create by monasca-setup\n\nWhen monasca-setup is executed, these parameters are set as default value of following file.\nhttps://github.com/openstack/monasca-agent/blob/master/monasca_setup/detection/plugins/libvirt.py#L202\nWe can also configure parameters by using \"-a\" option of monasca-setup like below.\nmonasca-setup -d libvirt -a \"vm_cpu_check_enable\u003dFalse\"\n\n- create manually\n\nMonasca user create this file in \"/etc/monasca/agent/conf.d libvirt.yaml\" and set some parameters. They will refer this template file when create the file. At that time, they can not configure these parameters (because there are no parameters in template file) though it\u0027s necessary to configure to make libvirt monitoring work well. This is reason why I add these parameters in template file.","commit_id":"491cc747378b8fbdbf95031eec84ef50402170c7"}],"monasca_setup/detection/plugins/libvirt.py":[{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"b48472d5a20283ca4c533c48291476ba81f6ae41","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            \u0027vm_disks_check_enable\u0027: True,"},{"line_number":204,"context_line":"            \u0027vm_network_check_enable\u0027: True,"},{"line_number":205,"context_line":"            \u0027vm_ping_check_enable\u0027: True,"},{"line_number":206,"context_line":"            \u0027vm_extended_disks_check_enable\u0027: True,"},{"line_number":207,"context_line":"            \u0027ping_check\u0027: False,"},{"line_number":208,"context_line":"            \u0027username\u0027: keystone_auth_section[\u0027username\u0027],"},{"line_number":209,"context_line":"            \u0027password\u0027: keystone_auth_section[\u0027password\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_a5824d4e","line":206,"range":{"start_line":206,"start_character":46,"end_line":206,"end_character":50},"updated":"2017-07-31 14:51:22.000000000","message":"It seems to be changed default value.  You should also include releasenote in this commit.","commit_id":"491cc747378b8fbdbf95031eec84ef50402170c7"}]}