)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},"change_message_id":"c0957c87e0beda0b3641d20a47973076c87605f5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"The agent will create a map between the number of Congestion Encountered(CE) packets/bytes"},{"line_number":12,"context_line":"and the source ip address responsible of the congestion. The source could be a compute or"},{"line_number":13,"context_line":"(if activated) a set of VMs deployed in a compute. First, we ensure that ECN marking is"},{"line_number":14,"context_line":"enabled for both edges. Second, we check ecn_packets and enc_bytes associated to each"},{"line_number":15,"context_line":"source of congestion. Last, the agent sends these values and their timestamp to monasca API"},{"line_number":16,"context_line":"for any further processing and keeps the metric counters into a cache file. This piece of"},{"line_number":17,"context_line":"information could be used to trigger a new kind of performance alarm based on congestion"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f4b6375_6172cd4b","line":14,"range":{"start_line":14,"start_character":57,"end_line":14,"end_character":66},"updated":"2017-11-01 14:40:23.000000000","message":"I think you mean ecn_bytes, as that is what the code is checking for.","commit_id":"edfac71014d039d6c5ed67be737d27cb5b48bfbe"},{"author":{"_account_id":26886,"name":"Fouad Benamrane","email":"benamranefouade@gmail.com","username":"Fouad_Benamrane"},"change_message_id":"e8ec18e34527ca66b54acca225d3de8782b30445","unresolved":false,"context_lines":[{"line_number":11,"context_line":"The agent will create a map between the number of Congestion Encountered(CE) packets/bytes"},{"line_number":12,"context_line":"and the source ip address responsible of the congestion. The source could be a compute or"},{"line_number":13,"context_line":"(if activated) a set of VMs deployed in a compute. First, we ensure that ECN marking is"},{"line_number":14,"context_line":"enabled for both edges. Second, we check ecn_packets and enc_bytes associated to each"},{"line_number":15,"context_line":"source of congestion. Last, the agent sends these values and their timestamp to monasca API"},{"line_number":16,"context_line":"for any further processing and keeps the metric counters into a cache file. This piece of"},{"line_number":17,"context_line":"information could be used to trigger a new kind of performance alarm based on congestion"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f4b6375_e598066b","line":14,"range":{"start_line":14,"start_character":57,"end_line":14,"end_character":66},"in_reply_to":"3f4b6375_6172cd4b","updated":"2017-11-02 10:54:51.000000000","message":"Done","commit_id":"edfac71014d039d6c5ed67be737d27cb5b48bfbe"},{"author":{"_account_id":26886,"name":"Fouad Benamrane","email":"benamranefouade@gmail.com","username":"Fouad_Benamrane"},"change_message_id":"16dafa096ad7858b1bc08cb0305b4a4fb066c9e4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"The agent will create a map between the number of Congestion Encountered(CE) packets/bytes"},{"line_number":12,"context_line":"and the source ip address responsible of the congestion. The source could be a compute or"},{"line_number":13,"context_line":"(if activated) a set of VMs deployed in a compute. First, we ensure that ECN marking is"},{"line_number":14,"context_line":"enabled for both edges. Second, we check ecn_packets and ecn_bytes associated to each"},{"line_number":15,"context_line":"source of congestion. Last, the agent sends these values and their timestamp to monasca API"},{"line_number":16,"context_line":"for any further processing and keeps the metric counters into a cache file. This piece of"},{"line_number":17,"context_line":"information could be used to trigger a new kind of performance alarm based on congestion"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f4b6375_dc7286ad","line":14,"range":{"start_line":14,"start_character":57,"end_line":14,"end_character":66},"updated":"2017-11-01 15:04:39.000000000","message":"Done,it use just a typo.","commit_id":"051d05ebe295b16c6343723ab5f7a2612b407a8f"}],"docs/Plugins.md":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"53a1995b59cd82a1d300de43ad00162307d6fa8f","unresolved":false,"context_lines":[{"line_number":839,"context_line":""},{"line_number":840,"context_line":"## Congestion"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"This section describes the congestion check performed by monasca-agent. Congestion check collects metrics from special iptable chain created by the agent called congestion. Metric names that are cross-posted to the infrastructure project will have the ecn. prefix.   "},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"Configuration"},{"line_number":845,"context_line":"The congestion check requires a configuration file called congestion.yaml to be available in the agent conf.d configuration directory. An example of the configuration is given below."}],"source_content_type":"text/x-markdown","patch_set":12,"id":"df87a7cf_ad74dbfe","line":842,"updated":"2017-12-12 15:54:23.000000000","message":"Please remove trailing whitespaces and wrap the lines in the complete section.","commit_id":"08ac1308b88271f8b8d6c86defe0ffc7544bf575"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"53a1995b59cd82a1d300de43ad00162307d6fa8f","unresolved":false,"context_lines":[{"line_number":841,"context_line":""},{"line_number":842,"context_line":"This section describes the congestion check performed by monasca-agent. Congestion check collects metrics from special iptable chain created by the agent called congestion. Metric names that are cross-posted to the infrastructure project will have the ecn. prefix.   "},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"Configuration"},{"line_number":845,"context_line":"The congestion check requires a configuration file called congestion.yaml to be available in the agent conf.d configuration directory. An example of the configuration is given below."},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"`auth_url` is the keystone endpoint for authentication"}],"source_content_type":"text/x-markdown","patch_set":12,"id":"df87a7cf_3ff470f0","line":844,"updated":"2017-12-12 15:54:23.000000000","message":"Should be:\n\n ### Configuration\n\nDon\u0027t forget to add empty line after.","commit_id":"08ac1308b88271f8b8d6c86defe0ffc7544bf575"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"53a1995b59cd82a1d300de43ad00162307d6fa8f","unresolved":false,"context_lines":[{"line_number":886,"context_line":"```"},{"line_number":887,"context_line":""},{"line_number":888,"context_line":"The congestion checks return the following metrics:"},{"line_number":889,"context_line":"| Metric Name\t| Dimensions                                              | Semantics                                                |"},{"line_number":890,"context_line":"|---------------| --------------------------------------------------------| ---------------------------------------------------------|"},{"line_number":891,"context_line":"| ecn.packets\t| hostname, device, component\u003dNeutron, service\u003dnetworking | Number of packets marked as Congestion Experienced       |"},{"line_number":892,"context_line":"| ecn.bytes     | hostname, device, component\u003dNeutron, service\u003dnetworking | Number of bytes marked as Congestion Experienced         |"}],"source_content_type":"text/x-markdown","patch_set":12,"id":"df87a7cf_9f001cad","line":889,"range":{"start_line":889,"start_character":13,"end_line":889,"end_character":14},"updated":"2017-12-12 15:54:23.000000000","message":"Please use spaces instead of tabs.","commit_id":"08ac1308b88271f8b8d6c86defe0ffc7544bf575"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"53a1995b59cd82a1d300de43ad00162307d6fa8f","unresolved":false,"context_lines":[{"line_number":894,"context_line":""},{"line_number":895,"context_line":"There is a detection plugin that should be used to configure this plugin. It is invoked as:"},{"line_number":896,"context_line":""},{"line_number":897,"context_line":"$ monasca-setup -d congestion"},{"line_number":898,"context_line":""},{"line_number":899,"context_line":"You can check the current congestion status of the network by simply running"},{"line_number":900,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":12,"id":"df87a7cf_3f5b10f6","line":897,"updated":"2017-12-12 15:54:23.000000000","message":"Put in the code span please:\n\n ```\n $ monasca-setup -d congestion\n ```","commit_id":"08ac1308b88271f8b8d6c86defe0ffc7544bf575"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"53a1995b59cd82a1d300de43ad00162307d6fa8f","unresolved":false,"context_lines":[{"line_number":896,"context_line":""},{"line_number":897,"context_line":"$ monasca-setup -d congestion"},{"line_number":898,"context_line":""},{"line_number":899,"context_line":"You can check the current congestion status of the network by simply running"},{"line_number":900,"context_line":""},{"line_number":901,"context_line":"$ sudo monasca-collector -v check congestion"},{"line_number":902,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":12,"id":"df87a7cf_7f0af8d1","line":899,"updated":"2017-12-12 15:54:23.000000000","message":"Please add trailing :","commit_id":"08ac1308b88271f8b8d6c86defe0ffc7544bf575"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"53a1995b59cd82a1d300de43ad00162307d6fa8f","unresolved":false,"context_lines":[{"line_number":898,"context_line":""},{"line_number":899,"context_line":"You can check the current congestion status of the network by simply running"},{"line_number":900,"context_line":""},{"line_number":901,"context_line":"$ sudo monasca-collector -v check congestion"},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"## Couch"},{"line_number":904,"context_line":"See [the example configuration](https://github.com/openstack/monasca-agent/blob/master/conf.d/couch.yaml.example) for how to configure the Couch plugin."}],"source_content_type":"text/x-markdown","patch_set":12,"id":"df87a7cf_5f07f4ca","line":901,"updated":"2017-12-12 15:54:23.000000000","message":"Put in the code span please.","commit_id":"08ac1308b88271f8b8d6c86defe0ffc7544bf575"}],"monasca_agent/collector/checks_d/congestion.py":[{"author":{"_account_id":14123,"name":"Stefano Canepa","email":"sc@linux.it","username":"sc"},"change_message_id":"13b0fd6b8e83d089632fa5e1d17c668df1a23bda","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/env python"},{"line_number":2,"context_line":"# (C) Copyright 2016 Hewlett Packard Enterprise Development Company LP"},{"line_number":3,"context_line":"# Copyright 2017 OrangeLabs"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"\"\"\"Monasca Agent interface for congestion metrics\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"ff82abbf_aba5f248","line":2,"range":{"start_line":2,"start_character":6,"end_line":2,"end_character":15},"updated":"2017-11-27 16:13:37.000000000","message":"There is no need for this line. This code is yours so apply the copyright that is correct based on the rules in your country/work contract","commit_id":"08bd7b16fb917f42f1eb3c34c6d6db83ccf89d6d"},{"author":{"_account_id":26886,"name":"Fouad Benamrane","email":"benamranefouade@gmail.com","username":"Fouad_Benamrane"},"change_message_id":"fd37240b8c7ff7ea059e3807a5b34298fd96cf6c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/env python"},{"line_number":2,"context_line":"# (C) Copyright 2016 Hewlett Packard Enterprise Development Company LP"},{"line_number":3,"context_line":"# Copyright 2017 OrangeLabs"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"\"\"\"Monasca Agent interface for congestion metrics\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"ff82abbf_a4475f4c","line":2,"range":{"start_line":2,"start_character":6,"end_line":2,"end_character":15},"in_reply_to":"ff82abbf_aba5f248","updated":"2017-11-27 17:21:31.000000000","message":"Done.","commit_id":"08bd7b16fb917f42f1eb3c34c6d6db83ccf89d6d"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"53a1995b59cd82a1d300de43ad00162307d6fa8f","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2017 OrangeLabs"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"from copy import deepcopy"},{"line_number":6,"context_line":"import json"},{"line_number":7,"context_line":"import logging"},{"line_number":8,"context_line":"import math"}],"source_content_type":"text/x-python","patch_set":12,"id":"df87a7cf_9fc7bc64","line":5,"updated":"2017-12-12 15:54:23.000000000","message":"Please use PEP8 import order [1].\n\n[1] https://docs.openstack.org/hacking/latest/user/hacking.html#imports","commit_id":"08ac1308b88271f8b8d6c86defe0ffc7544bf575"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"53a1995b59cd82a1d300de43ad00162307d6fa8f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        \"\"\"Extend check method to collect and update congestion metrics."},{"line_number":54,"context_line":"        \"\"\""},{"line_number":55,"context_line":"        dimensions \u003d self._set_dimensions({\u0027service\u0027: \u0027networking\u0027,"},{"line_number":56,"context_line":"                                           \u0027component\u0027: \u0027Neutron\u0027}, instance)"},{"line_number":57,"context_line":"        self.sample_time \u003d float(\"{:9f}\".format(time.time()))"},{"line_number":58,"context_line":"        \"\"\"Check iptables information and verify/install the ECN rule for"},{"line_number":59,"context_line":"        specific hypervisor\"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"df87a7cf_7fe2f8d6","line":56,"range":{"start_line":56,"start_character":57,"end_line":56,"end_character":64},"updated":"2017-12-12 15:54:23.000000000","message":"Please use small case and update the doc accordingly.","commit_id":"08ac1308b88271f8b8d6c86defe0ffc7544bf575"}],"monasca_setup/detection/plugins/congestion.py":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"53a1995b59cd82a1d300de43ad00162307d6fa8f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 OrangeLabs"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import ConfigParser"},{"line_number":4,"context_line":"import logging"},{"line_number":5,"context_line":"from monasca_agent.common.psutil_wrapper import psutil"},{"line_number":6,"context_line":"import monasca_setup.agent_config"}],"source_content_type":"text/x-python","patch_set":12,"id":"df87a7cf_bf972045","line":3,"updated":"2017-12-12 15:54:23.000000000","message":"Please see previous comment.","commit_id":"08ac1308b88271f8b8d6c86defe0ffc7544bf575"}]}