)]}'
{"docs/Libvirt.md":[{"author":{"_account_id":17981,"name":"Haruki Yamanashi","email":"h.yamanashi@jp.fujitsu.com","username":"Haruki"},"change_message_id":"e12818aefdae43e3b664b8732467e2d82cdcc05a","unresolved":false,"context_lines":[{"line_number":463,"context_line":"| nova.vm.disk.total_allocated_gb | Total Gbytes of disk space allocated to all VMs             |"},{"line_number":464,"context_line":"| nova.vm.mem.total_allocated_mb  | Total Mbytes of memory allocated to all VMs                 |"},{"line_number":465,"context_line":"| vm.host_alive_count.total       | Total number of VMs on host                                 |"},{"line_number":466,"context_line":"| vm.host_alive_count.blocked     | Total number of VMs in state blocked on host                |"},{"line_number":467,"context_line":"| vm.host_alive_count.blocked     | Percentage of VMs in state blocked on host                  |"},{"line_number":468,"context_line":"| vm.host_alive_count.crashed     | Total number of VMs in state crashed on host                |"},{"line_number":469,"context_line":"| vm.host_alive_count.crashed     | Percentage of VMs in state crashed on host                  |"},{"line_number":470,"context_line":"| vm.host_alive_count.nostate     | Total number of VMs with no state on host                   |"},{"line_number":471,"context_line":"| vm.host_alive_count.nostate     | Percentage of VMs with no state on host                     |"},{"line_number":472,"context_line":"| vm.host_alive_count.paused      | Total number of VMs in state paused on host                 |"},{"line_number":473,"context_line":"| vm.host_alive_count.paused      | Percentage of VMs in state paused on host                   |"},{"line_number":474,"context_line":"| vm.host_alive_count.suspended   | Total number of VMs in state suspended on host              |"},{"line_number":475,"context_line":"| vm.host_alive_count.suspended   | Percentage of VMs in state suspended on host                |"},{"line_number":476,"context_line":"| vm.host_alive_count.running     | Total number of VMs in state running on host                |"},{"line_number":477,"context_line":"| vm.host_alive_count.running     | Percentage of VMs in state running on host                  |"},{"line_number":478,"context_line":"| vm.host_alive_count.shutingdown | Total number of VMs in state shutting down on host          |"},{"line_number":479,"context_line":"| vm.host_alive_count.shutingdown | Percentage of VMs in state shutting down on host            |"},{"line_number":480,"context_line":"| vm.host_alive_count.shutoff     | Total number of VMs in state shutoff/Nova suspended on host |"},{"line_number":481,"context_line":"| vm.host_alive_count.shutoff     | Percentage of VMs in state shutoff/Nova suspended on host   |"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"Aggregate dimensions include hostname and component from the Operations Value column above."},{"line_number":484,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":4,"id":"ff82abbf_b5b9fde9","line":481,"range":{"start_line":466,"start_character":0,"end_line":481,"end_character":97},"updated":"2017-11-24 02:28:44.000000000","message":"`_perc` is missed for each metrics.","commit_id":"cca54302bb1c2e081cf1434595099b7475871bcc"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"c74dd5c5f0197e6b76a5df50beebfe13678ae4a0","unresolved":false,"context_lines":[{"line_number":463,"context_line":"| nova.vm.disk.total_allocated_gb | Total Gbytes of disk space allocated to all VMs             |"},{"line_number":464,"context_line":"| nova.vm.mem.total_allocated_mb  | Total Mbytes of memory allocated to all VMs                 |"},{"line_number":465,"context_line":"| vm.host_alive_count.total       | Total number of VMs on host                                 |"},{"line_number":466,"context_line":"| vm.host_alive_count.blocked     | Total number of VMs in state blocked on host                |"},{"line_number":467,"context_line":"| vm.host_alive_count.blocked     | Percentage of VMs in state blocked on host                  |"},{"line_number":468,"context_line":"| vm.host_alive_count.crashed     | Total number of VMs in state crashed on host                |"},{"line_number":469,"context_line":"| vm.host_alive_count.crashed     | Percentage of VMs in state crashed on host                  |"},{"line_number":470,"context_line":"| vm.host_alive_count.nostate     | Total number of VMs with no state on host                   |"},{"line_number":471,"context_line":"| vm.host_alive_count.nostate     | Percentage of VMs with no state on host                     |"},{"line_number":472,"context_line":"| vm.host_alive_count.paused      | Total number of VMs in state paused on host                 |"},{"line_number":473,"context_line":"| vm.host_alive_count.paused      | Percentage of VMs in state paused on host                   |"},{"line_number":474,"context_line":"| vm.host_alive_count.suspended   | Total number of VMs in state suspended on host              |"},{"line_number":475,"context_line":"| vm.host_alive_count.suspended   | Percentage of VMs in state suspended on host                |"},{"line_number":476,"context_line":"| vm.host_alive_count.running     | Total number of VMs in state running on host                |"},{"line_number":477,"context_line":"| vm.host_alive_count.running     | Percentage of VMs in state running on host                  |"},{"line_number":478,"context_line":"| vm.host_alive_count.shutingdown | Total number of VMs in state shutting down on host          |"},{"line_number":479,"context_line":"| vm.host_alive_count.shutingdown | Percentage of VMs in state shutting down on host            |"},{"line_number":480,"context_line":"| vm.host_alive_count.shutoff     | Total number of VMs in state shutoff/Nova suspended on host |"},{"line_number":481,"context_line":"| vm.host_alive_count.shutoff     | Percentage of VMs in state shutoff/Nova suspended on host   |"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"Aggregate dimensions include hostname and component from the Operations Value column above."},{"line_number":484,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":4,"id":"ff82abbf_f128d6e2","line":481,"range":{"start_line":466,"start_character":0,"end_line":481,"end_character":97},"in_reply_to":"ff82abbf_b5b9fde9","updated":"2017-11-27 08:51:27.000000000","message":"Sorry, missed that column when updating the table for the _perc metrics. Thanks for spotting! Fixed now.","commit_id":"cca54302bb1c2e081cf1434595099b7475871bcc"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"d7ed14e2614f4bae2dc47f94e9544dbb46b0762d","unresolved":false,"context_lines":[{"line_number":462,"context_line":"| nova.vm.cpu.total_allocated          | Total CPUs allocated across all VMs                         |"},{"line_number":463,"context_line":"| nova.vm.disk.total_allocated_gb      | Total Gbytes of disk space allocated to all VMs             |"},{"line_number":464,"context_line":"| nova.vm.mem.total_allocated_mb       | Total Mbytes of memory allocated to all VMs                 |"},{"line_number":465,"context_line":"| vm.host_alive_count.total            | Total number of VMs on host                                 |"},{"line_number":466,"context_line":"| vm.host_alive_count.blocked          | Total number of VMs in state blocked on host                |"},{"line_number":467,"context_line":"| vm.host_alive_count.blocked_perc     | Percentage of VMs in state blocked on host                  |"},{"line_number":468,"context_line":"| vm.host_alive_count.crashed          | Total number of VMs in state crashed on host                |"}],"source_content_type":"text/x-markdown","patch_set":5,"id":"df87a7cf_6bcbe452","line":465,"range":{"start_line":465,"start_character":2,"end_line":465,"end_character":27},"updated":"2017-12-04 14:37:15.000000000","message":"To be consistent with other metric names used here and in other plugins I would suggest naming it: \"nova.vm.total_count\"","commit_id":"8666bffc58370bbf4a9e9b50a8f9b53f95b8e4ee"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"409a490dfbc5b79284346a0f55f7bab91f0a503f","unresolved":false,"context_lines":[{"line_number":462,"context_line":"| nova.vm.cpu.total_allocated          | Total CPUs allocated across all VMs                         |"},{"line_number":463,"context_line":"| nova.vm.disk.total_allocated_gb      | Total Gbytes of disk space allocated to all VMs             |"},{"line_number":464,"context_line":"| nova.vm.mem.total_allocated_mb       | Total Mbytes of memory allocated to all VMs                 |"},{"line_number":465,"context_line":"| vm.host_alive_count.total            | Total number of VMs on host                                 |"},{"line_number":466,"context_line":"| vm.host_alive_count.blocked          | Total number of VMs in state blocked on host                |"},{"line_number":467,"context_line":"| vm.host_alive_count.blocked_perc     | Percentage of VMs in state blocked on host                  |"},{"line_number":468,"context_line":"| vm.host_alive_count.crashed          | Total number of VMs in state crashed on host                |"}],"source_content_type":"text/x-markdown","patch_set":5,"id":"df87a7cf_25d651f3","line":465,"range":{"start_line":465,"start_character":2,"end_line":465,"end_character":27},"in_reply_to":"df87a7cf_6bcbe452","updated":"2017-12-05 09:51:43.000000000","message":"Done","commit_id":"8666bffc58370bbf4a9e9b50a8f9b53f95b8e4ee"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"d7ed14e2614f4bae2dc47f94e9544dbb46b0762d","unresolved":false,"context_lines":[{"line_number":463,"context_line":"| nova.vm.disk.total_allocated_gb      | Total Gbytes of disk space allocated to all VMs             |"},{"line_number":464,"context_line":"| nova.vm.mem.total_allocated_mb       | Total Mbytes of memory allocated to all VMs                 |"},{"line_number":465,"context_line":"| vm.host_alive_count.total            | Total number of VMs on host                                 |"},{"line_number":466,"context_line":"| vm.host_alive_count.blocked          | Total number of VMs in state blocked on host                |"},{"line_number":467,"context_line":"| vm.host_alive_count.blocked_perc     | Percentage of VMs in state blocked on host                  |"},{"line_number":468,"context_line":"| vm.host_alive_count.crashed          | Total number of VMs in state crashed on host                |"},{"line_number":469,"context_line":"| vm.host_alive_count.crashed_perc     | Percentage of VMs in state crashed on host                  |"}],"source_content_type":"text/x-markdown","patch_set":5,"id":"df87a7cf_4bc2a035","line":466,"range":{"start_line":466,"start_character":2,"end_line":466,"end_character":29},"updated":"2017-12-04 14:37:15.000000000","message":"nova.vm.blocked_count","commit_id":"8666bffc58370bbf4a9e9b50a8f9b53f95b8e4ee"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"409a490dfbc5b79284346a0f55f7bab91f0a503f","unresolved":false,"context_lines":[{"line_number":463,"context_line":"| nova.vm.disk.total_allocated_gb      | Total Gbytes of disk space allocated to all VMs             |"},{"line_number":464,"context_line":"| nova.vm.mem.total_allocated_mb       | Total Mbytes of memory allocated to all VMs                 |"},{"line_number":465,"context_line":"| vm.host_alive_count.total            | Total number of VMs on host                                 |"},{"line_number":466,"context_line":"| vm.host_alive_count.blocked          | Total number of VMs in state blocked on host                |"},{"line_number":467,"context_line":"| vm.host_alive_count.blocked_perc     | Percentage of VMs in state blocked on host                  |"},{"line_number":468,"context_line":"| vm.host_alive_count.crashed          | Total number of VMs in state crashed on host                |"},{"line_number":469,"context_line":"| vm.host_alive_count.crashed_perc     | Percentage of VMs in state crashed on host                  |"}],"source_content_type":"text/x-markdown","patch_set":5,"id":"df87a7cf_c5068587","line":466,"range":{"start_line":466,"start_character":2,"end_line":466,"end_character":29},"in_reply_to":"df87a7cf_4bc2a035","updated":"2017-12-05 09:51:43.000000000","message":"Done","commit_id":"8666bffc58370bbf4a9e9b50a8f9b53f95b8e4ee"}],"monasca_agent/collector/checks_d/libvirt.py":[{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"82833ae6625420524eb87928c63260fa154f21e2","unresolved":false,"context_lines":[{"line_number":49,"context_line":"              libvirt.VIR_DOMAIN_SHUTDOWN: \u0027VM is shutting down\u0027,"},{"line_number":50,"context_line":"              libvirt.VIR_DOMAIN_SHUTOFF: \u0027VM has been shut off (other reason)\u0027}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"DOM_ALIVE_NAMES \u003d {libvirt.VIR_DOMAIN_BLOCKED - 1: \u0027blocked\u0027,"},{"line_number":53,"context_line":"                   libvirt.VIR_DOMAIN_CRASHED - 1: \u0027crashed\u0027,"},{"line_number":54,"context_line":"                   libvirt.VIR_DOMAIN_NONE - 1: \u0027nostate\u0027,"},{"line_number":55,"context_line":"                   libvirt.VIR_DOMAIN_PAUSED - 1: \u0027paused\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df87a7cf_3e9649f2","line":52,"range":{"start_line":52,"start_character":19,"end_line":52,"end_character":49},"updated":"2017-12-06 05:43:09.000000000","message":"Looks good but I did have a question on these lines.  This seems to -1 all the constants to generate keys for the dict.  We also seem to apply a -1 to the dom_status variable in _inspect_state so I\u0027m assuming the -1 to the constants here is to let things line up properly with that function.\n\nI\u0027m wondering if it\u0027s worth while to have these -1 values scattered about or if we should just return the dom_state value that matches the libvirt constants from _inspect_state and adjust the reported metrics in _inspect_state appropriately.","commit_id":"b527cada5b2e923de487b3a060c11f1177d061bf"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"01518c53d93edca8eec758741fd182f9466b1b49","unresolved":false,"context_lines":[{"line_number":49,"context_line":"              libvirt.VIR_DOMAIN_SHUTDOWN: \u0027VM is shutting down\u0027,"},{"line_number":50,"context_line":"              libvirt.VIR_DOMAIN_SHUTOFF: \u0027VM has been shut off (other reason)\u0027}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"DOM_ALIVE_NAMES \u003d {libvirt.VIR_DOMAIN_BLOCKED - 1: \u0027blocked\u0027,"},{"line_number":53,"context_line":"                   libvirt.VIR_DOMAIN_CRASHED - 1: \u0027crashed\u0027,"},{"line_number":54,"context_line":"                   libvirt.VIR_DOMAIN_NONE - 1: \u0027nostate\u0027,"},{"line_number":55,"context_line":"                   libvirt.VIR_DOMAIN_PAUSED - 1: \u0027paused\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df87a7cf_97cbaa70","line":52,"range":{"start_line":52,"start_character":19,"end_line":52,"end_character":49},"in_reply_to":"df87a7cf_2164e521","updated":"2017-12-06 16:27:02.000000000","message":"You\u0027re right. For the aggregate metrics the -1 is definitely not needed (The numeric value of the key is only used as an index to associate a libvirt status value with a symbolic name. It really does not matter whether this index is shifted by -1. I removed this and changed the return value of _inspect_state() to the unaltered libvirt status now.","commit_id":"b527cada5b2e923de487b3a060c11f1177d061bf"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"f3cf06203c8791fc5ecdcbd06ab36328114d9bc5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"              libvirt.VIR_DOMAIN_SHUTDOWN: \u0027VM is shutting down\u0027,"},{"line_number":50,"context_line":"              libvirt.VIR_DOMAIN_SHUTOFF: \u0027VM has been shut off (other reason)\u0027}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"DOM_ALIVE_NAMES \u003d {libvirt.VIR_DOMAIN_BLOCKED - 1: \u0027blocked\u0027,"},{"line_number":53,"context_line":"                   libvirt.VIR_DOMAIN_CRASHED - 1: \u0027crashed\u0027,"},{"line_number":54,"context_line":"                   libvirt.VIR_DOMAIN_NONE - 1: \u0027nostate\u0027,"},{"line_number":55,"context_line":"                   libvirt.VIR_DOMAIN_PAUSED - 1: \u0027paused\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df87a7cf_2164e521","line":52,"range":{"start_line":52,"start_character":19,"end_line":52,"end_character":49},"in_reply_to":"df87a7cf_3e9649f2","updated":"2017-12-06 10:03:48.000000000","message":"+1\n\n_inspect_state is used only once, so changing the return value will not hurt. Joe\u0027s suggestions seems cleaner.","commit_id":"b527cada5b2e923de487b3a060c11f1177d061bf"}]}