)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"1ccadfac5195d6523d3f066338a916d2ab1b1c75","unresolved":false,"context_lines":[{"line_number":11,"context_line":"only interested in the options --config-file and --config-dir."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I72dc53d8ee6dc7b0784e6931a19c461cdb322851"},{"line_number":14,"context_line":"Story: 2001303"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"df87a7cf_6e15d6e4","line":14,"updated":"2017-12-18 15:55:02.000000000","message":"Please add task number.","commit_id":"8fc9cfdf4cded55d7d42163ebb5726e76d68bf13"},{"author":{"_account_id":26639,"name":"Tobias Johansson","email":"tjohansson@op5.com","username":"tobiajo"},"change_message_id":"fe85913bff091c54e6fd71a380646930bf7336ff","unresolved":false,"context_lines":[{"line_number":11,"context_line":"only interested in the options --config-file and --config-dir."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I72dc53d8ee6dc7b0784e6931a19c461cdb322851"},{"line_number":14,"context_line":"Story: 2001303"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"df87a7cf_0d72fead","line":14,"in_reply_to":"df87a7cf_6e15d6e4","updated":"2017-12-19 08:54:58.000000000","message":"Done","commit_id":"8fc9cfdf4cded55d7d42163ebb5726e76d68bf13"}],"monasca_setup/detection/utils.py":[{"author":{"_account_id":26733,"name":"Amir Mofakhar","email":"amir@mofakhar.info","username":"amofakhar"},"change_message_id":"e4948c1fda88ddde92ae645e08ecbed598fb8963","unresolved":false,"context_lines":[{"line_number":190,"context_line":"    parser.add_argument(\u0027--config-file\u0027)"},{"line_number":191,"context_line":"    parser.add_argument(\u0027--config-dir\u0027)"},{"line_number":192,"context_line":"    namespace, _ \u003d parser.parse_known_args(from_cmd[2:])"},{"line_number":193,"context_line":"    if namespace.config_file is not None:"},{"line_number":194,"context_line":"        args.append(\u0027--config-file\u0027)"},{"line_number":195,"context_line":"        args.append(namespace.config_file)"},{"line_number":196,"context_line":"    if namespace.config_dir is not None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_1e2f09f7","line":193,"updated":"2017-12-01 09:09:25.000000000","message":"This is the same and more clear :\n if namespace.config_file:","commit_id":"522103ebfadf2edac56b3bf7b151f1a56c0f4dcf"},{"author":{"_account_id":26639,"name":"Tobias Johansson","email":"tjohansson@op5.com","username":"tobiajo"},"change_message_id":"fe85913bff091c54e6fd71a380646930bf7336ff","unresolved":false,"context_lines":[{"line_number":190,"context_line":"    parser.add_argument(\u0027--config-file\u0027)"},{"line_number":191,"context_line":"    parser.add_argument(\u0027--config-dir\u0027)"},{"line_number":192,"context_line":"    namespace, _ \u003d parser.parse_known_args(from_cmd[2:])"},{"line_number":193,"context_line":"    if namespace.config_file is not None:"},{"line_number":194,"context_line":"        args.append(\u0027--config-file\u0027)"},{"line_number":195,"context_line":"        args.append(namespace.config_file)"},{"line_number":196,"context_line":"    if namespace.config_dir is not None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_529d8064","line":193,"in_reply_to":"ff82abbf_1e2f09f7","updated":"2017-12-19 08:54:58.000000000","message":"Done","commit_id":"522103ebfadf2edac56b3bf7b151f1a56c0f4dcf"},{"author":{"_account_id":26733,"name":"Amir Mofakhar","email":"amir@mofakhar.info","username":"amofakhar"},"change_message_id":"e4948c1fda88ddde92ae645e08ecbed598fb8963","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    if namespace.config_file is not None:"},{"line_number":194,"context_line":"        args.append(\u0027--config-file\u0027)"},{"line_number":195,"context_line":"        args.append(namespace.config_file)"},{"line_number":196,"context_line":"    if namespace.config_dir is not None:"},{"line_number":197,"context_line":"        args.append(\u0027--config-dir\u0027)"},{"line_number":198,"context_line":"        args.append(namespace.config_dir)"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_de8681dc","line":196,"updated":"2017-12-01 09:09:25.000000000","message":"if namespace.config_dir:","commit_id":"522103ebfadf2edac56b3bf7b151f1a56c0f4dcf"},{"author":{"_account_id":26639,"name":"Tobias Johansson","email":"tjohansson@op5.com","username":"tobiajo"},"change_message_id":"fe85913bff091c54e6fd71a380646930bf7336ff","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    if namespace.config_file is not None:"},{"line_number":194,"context_line":"        args.append(\u0027--config-file\u0027)"},{"line_number":195,"context_line":"        args.append(namespace.config_file)"},{"line_number":196,"context_line":"    if namespace.config_dir is not None:"},{"line_number":197,"context_line":"        args.append(\u0027--config-dir\u0027)"},{"line_number":198,"context_line":"        args.append(namespace.config_dir)"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_328ebc2e","line":196,"in_reply_to":"ff82abbf_de8681dc","updated":"2017-12-19 08:54:58.000000000","message":"Done","commit_id":"522103ebfadf2edac56b3bf7b151f1a56c0f4dcf"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"1ccadfac5195d6523d3f066338a916d2ab1b1c75","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 OP5 AB"},{"line_number":2,"context_line":"# Copyright 2017 SUSE Linux GmbH"},{"line_number":3,"context_line":"# (C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"df87a7cf_53443f47","line":1,"updated":"2017-12-18 15:55:02.000000000","message":"I\u0027m not an expert on this but why are you reordering the copyrights? I think it should be added as the third one.","commit_id":"8fc9cfdf4cded55d7d42163ebb5726e76d68bf13"},{"author":{"_account_id":26639,"name":"Tobias Johansson","email":"tjohansson@op5.com","username":"tobiajo"},"change_message_id":"fe85913bff091c54e6fd71a380646930bf7336ff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 OP5 AB"},{"line_number":2,"context_line":"# Copyright 2017 SUSE Linux GmbH"},{"line_number":3,"context_line":"# (C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"df87a7cf_cd3e56b7","line":1,"in_reply_to":"df87a7cf_53443f47","updated":"2017-12-19 08:54:58.000000000","message":"Had the impression it should be the other way around. Changed to adding after if you think that is what\u0027s right.","commit_id":"8fc9cfdf4cded55d7d42163ebb5726e76d68bf13"}],"tests/detection/test_utils.py":[{"author":{"_account_id":26733,"name":"Amir Mofakhar","email":"amir@mofakhar.info","username":"amofakhar"},"change_message_id":"e003b29b771a1101560afb65e362bfd91545ec32","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        self.assertIsNot(cfg_1, cfg_2)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_distinct_oslo_confs_should_contain_different_opts(self):"},{"line_number":68,"context_line":"        # test ensures that each instance created via load_oslo_configuration"},{"line_number":69,"context_line":"        # contains different values of the same opts"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_87cae84c","line":67,"updated":"2017-12-01 10:04:41.000000000","message":"update test case to cover --config-file also","commit_id":"522103ebfadf2edac56b3bf7b151f1a56c0f4dcf"},{"author":{"_account_id":26639,"name":"Tobias Johansson","email":"tjohansson@op5.com","username":"tobiajo"},"change_message_id":"fe85913bff091c54e6fd71a380646930bf7336ff","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        self.assertIsNot(cfg_1, cfg_2)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_distinct_oslo_confs_should_contain_different_opts(self):"},{"line_number":68,"context_line":"        # test ensures that each instance created via load_oslo_configuration"},{"line_number":69,"context_line":"        # contains different values of the same opts"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_9293085d","line":67,"in_reply_to":"ff82abbf_87cae84c","updated":"2017-12-19 08:54:58.000000000","message":"Done","commit_id":"522103ebfadf2edac56b3bf7b151f1a56c0f4dcf"},{"author":{"_account_id":26733,"name":"Amir Mofakhar","email":"amir@mofakhar.info","username":"amofakhar"},"change_message_id":"e4948c1fda88ddde92ae645e08ecbed598fb8963","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        )"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.assertIsNot(cfg_1, cfg_2)"},{"line_number":92,"context_line":"        self.assertNotEqual(cfg_1, cfg_2)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_just_keep_built_in_options(self):"},{"line_number":95,"context_line":"        # test ensures that non built-in oslo.config options to"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_a1935ca3","line":92,"updated":"2017-12-01 09:09:25.000000000","message":"why did you remove testing empty \"from_cmd\"? I think it was necessary to cover all cases.","commit_id":"522103ebfadf2edac56b3bf7b151f1a56c0f4dcf"},{"author":{"_account_id":26639,"name":"Tobias Johansson","email":"tjohansson@op5.com","username":"tobiajo"},"change_message_id":"fe85913bff091c54e6fd71a380646930bf7336ff","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        )"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.assertIsNot(cfg_1, cfg_2)"},{"line_number":92,"context_line":"        self.assertNotEqual(cfg_1, cfg_2)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_just_keep_built_in_options(self):"},{"line_number":95,"context_line":"        # test ensures that non built-in oslo.config options to"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_52ab4074","line":92,"in_reply_to":"ff82abbf_a1935ca3","updated":"2017-12-19 08:54:58.000000000","message":"i don\u0027t agree.","commit_id":"522103ebfadf2edac56b3bf7b151f1a56c0f4dcf"},{"author":{"_account_id":26733,"name":"Amir Mofakhar","email":"amir@mofakhar.info","username":"amofakhar"},"change_message_id":"ae38e976a450bbdeafa8c2d9967ca831ef69222e","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        if dir_1 \u003d\u003d dir_2:"},{"line_number":121,"context_line":"            self.assertEqual(cfg_1, cfg_2)"},{"line_number":122,"context_line":"        else:"},{"line_number":123,"context_line":"            self.assertNotEqual(cfg_1, cfg_2)"},{"line_number":124,"context_line":"        self.assertNotEqual(cfg_3, cfg_4)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def test_just_keep_built_in_options(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff82abbf_b3adee32","line":123,"updated":"2017-12-01 13:07:34.000000000","message":"1. dir_1 and dir_2 are equal always, what\u0027s the use of this IF condition?\n2. and the main question is that what\u0027s the use of dir_2 if it is same as dir_1?\n3. using \".\" is not a good idea for testing, it is better to use a specific directory instead.","commit_id":"9578c4736f617a0d50538a25aae7d0ea2bfe0dcc"},{"author":{"_account_id":26639,"name":"Tobias Johansson","email":"tjohansson@op5.com","username":"tobiajo"},"change_message_id":"fe85913bff091c54e6fd71a380646930bf7336ff","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        if dir_1 \u003d\u003d dir_2:"},{"line_number":121,"context_line":"            self.assertEqual(cfg_1, cfg_2)"},{"line_number":122,"context_line":"        else:"},{"line_number":123,"context_line":"            self.assertNotEqual(cfg_1, cfg_2)"},{"line_number":124,"context_line":"        self.assertNotEqual(cfg_3, cfg_4)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def test_just_keep_built_in_options(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"df87a7cf_610496c7","line":123,"in_reply_to":"ff82abbf_b3adee32","updated":"2017-12-19 08:54:58.000000000","message":"Done","commit_id":"9578c4736f617a0d50538a25aae7d0ea2bfe0dcc"}]}