)]}'
{"monasca_agent/collector/checks_d/kubernetes.py":[{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"ceebc46d4968c678481a228c400b4de28193e98f","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                    if self.report_container_mem_percent:"},{"line_number":231,"context_line":"                        container_key \u003d container_name + \" \" + container_dimensions[\"namespace\"]"},{"line_number":232,"context_line":"                        if container_key not in memory_limit_map:"},{"line_number":233,"context_line":"                            memory_limit_map[container_key] \u003d memory_in_bytes"},{"line_number":234,"context_line":"            except KeyError:"},{"line_number":235,"context_line":"                self.log.exception(\"Unable to report container limits for {}\".format(container_name))"},{"line_number":236,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_579d7064","line":233,"updated":"2017-12-13 23:39:20.000000000","message":"I\u0027m not a huge fan of passing in a structure that only exists to be modified by the function.  Is there a way just to return the container limits up to the check function so we can pass that data down to process_containers?  Maybe something generic in case we want to add more limits than just memory in the future?","commit_id":"cc6f1b9ec2a8d178a0b59cffb3063f83b7ffffe5"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"712c8324be406c8b1d6a873082b16fd9b38e9e78","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                    if self.report_container_mem_percent:"},{"line_number":231,"context_line":"                        container_key \u003d container_name + \" \" + container_dimensions[\"namespace\"]"},{"line_number":232,"context_line":"                        if container_key not in memory_limit_map:"},{"line_number":233,"context_line":"                            memory_limit_map[container_key] \u003d memory_in_bytes"},{"line_number":234,"context_line":"            except KeyError:"},{"line_number":235,"context_line":"                self.log.exception(\"Unable to report container limits for {}\".format(container_name))"},{"line_number":236,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_6003fa0e","line":233,"in_reply_to":"df87a7cf_579d7064","updated":"2017-12-14 14:34:48.000000000","message":"I could make a global function I was planning on doing that but that would require clearing and making sure that is in sync which didnt make since we already grab this data every collection cycle. Also isnt that what I do I pass it up to the process_pod method which returns to check that passes it into the process_containers.\n\nWould I want to do in the near feature is make a class that would container dimensions limits metadata so fourth so then im just passing a list of objects but didnt want to bite into that right now.\n\nAm I missing an easier cleaner solution?","commit_id":"cc6f1b9ec2a8d178a0b59cffb3063f83b7ffffe5"}]}