)]}'
{"docs/Plugins.md":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"66ac1ba3a78edb3b20059b29c6711de896be9e32","unresolved":false,"context_lines":[{"line_number":571,"context_line":""},{"line_number":572,"context_line":"| Metric Name | Dimensions | Semantics |"},{"line_number":573,"context_line":"| ----------- | ---------- | --------- |"},{"line_number":574,"context_line":"| cpu.num_cores | hostname, unit | number of cores of host"},{"line_number":575,"context_line":"| cpu.system_time | hostname, unit | Cumulative system CPU time consumed in core seconds"},{"line_number":576,"context_line":"| cpu.system_time_sec | hostname, unit | Rate of system CPU time consumed in core seconds per second"},{"line_number":577,"context_line":"| cpu.total_time | hostname, unit | Cumulative CPU time consumed in core seconds"}],"source_content_type":"text/x-markdown","patch_set":2,"id":"df87a7cf_59d3e238","line":574,"updated":"2017-12-19 15:59:38.000000000","message":"Capitalize number to be consistent with other entries","commit_id":"d452bccffaef8063078d9260549668641527baf8"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"66ac1ba3a78edb3b20059b29c6711de896be9e32","unresolved":false,"context_lines":[{"line_number":580,"context_line":"| cpu.user_time_sec | hostname, unit | Rate of user CPU time consumed in core seconds per second"},{"line_number":581,"context_line":"| fs.total_bytes | hostname, device, unit | Number of bytes available"},{"line_number":582,"context_line":"| fs.usage_bytes | hostname, device, unit | Number of bytes consumed"},{"line_number":583,"context_line":"| fs.usage_perc | hostname, device, unit | usage of fs as percentage"},{"line_number":584,"context_line":"| io.read_bytes | hostname, unit | Total number of bytes read by all devices"},{"line_number":585,"context_line":"| io.read_bytes_sec | hostname, unit | Total number of bytes read by all devices per second"},{"line_number":586,"context_line":"| io.write_bytes | hostname, unit | Total number of bytes written by all devices"}],"source_content_type":"text/x-markdown","patch_set":2,"id":"df87a7cf_79d82652","line":583,"updated":"2017-12-19 15:59:38.000000000","message":"Capitalize usage","commit_id":"d452bccffaef8063078d9260549668641527baf8"}],"monasca_agent/collector/checks_d/cadvisor_host.py":[{"author":{"_account_id":24580,"name":"James Gu","email":"james.gu@microsoft.com","username":"jamesgu"},"change_message_id":"770aec991653af50f742d0cdc1e40427a3d074a1","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        # store information about # of cores (incl. threads)"},{"line_number":84,"context_line":"        if machine_info[\u0027num_cores\u0027]:"},{"line_number":85,"context_line":"            self.num_cores \u003d int(machine_info[\u0027num_cores\u0027])"},{"line_number":86,"context_line":"            self.log.debug(\"number of cores of machine: {}\".format(self.num_cores))"},{"line_number":87,"context_line":"            self.log.warn(\"number of cores of machine: {}\".format(self.num_cores))"},{"line_number":88,"context_line":"        else:"},{"line_number":89,"context_line":"            self.log.warn(\"Failed to retrieve number of cores of host\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_e9a00045","line":86,"range":{"start_line":86,"start_character":17,"end_line":86,"end_character":20},"updated":"2017-12-18 16:47:24.000000000","message":"remove warn log","commit_id":"d452bccffaef8063078d9260549668641527baf8"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"66ac1ba3a78edb3b20059b29c6711de896be9e32","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                if cadvisor_key \u003d\u003d \"usage\":"},{"line_number":171,"context_line":"                    usage_fs \u003d int(filesystem[cadvisor_key])"},{"line_number":172,"context_line":"                elif cadvisor_key \u003d\u003d \"capacity\":"},{"line_number":173,"context_line":"                    capacity_fs \u003d int(filesystem[cadvisor_key])"},{"line_number":174,"context_line":"            if capacity_fs \u003e 0:"},{"line_number":175,"context_line":"                self._send_metrics(\"fs.usage_perc\","},{"line_number":176,"context_line":"                                   (float(usage_fs) / capacity_fs) * 100,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_798fc629","line":173,"updated":"2017-12-19 15:59:38.000000000","message":"Will this keys always exist? If not the code at line 174 will throw an exception because capacity_fs will not be defined.","commit_id":"d452bccffaef8063078d9260549668641527baf8"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"66ac1ba3a78edb3b20059b29c6711de896be9e32","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                cpu_usage_sec \u003d cpu_usage[cadvisor_key] / 1000000000.0"},{"line_number":219,"context_line":"                self._send_metrics(\"cpu.\" + metric_name, cpu_usage_sec, dimensions, metric_types, metric_units)"},{"line_number":220,"context_line":"                # provide metrics for number of cores"},{"line_number":221,"context_line":"                self._send_metrics(\"cpu.num_cores\", self.num_cores, dimensions, [\"gauge\"], [\"number_of_cores\"])"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    def _parse_send_metrics(self, metrics, dimensions):"},{"line_number":224,"context_line":"        for host, cadvisor_metrics in metrics.items():"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_b970ee41","line":221,"updated":"2017-12-19 15:59:38.000000000","message":"self.num_cores may not exist according to the code above","commit_id":"d452bccffaef8063078d9260549668641527baf8"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b8d28ad3b5c89ab8990b34e3c78ae27bf02778f5","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                    used_mem \u003d int(memory_data[cadvisor_key])"},{"line_number":147,"context_line":"        # calculate memory used percent"},{"line_number":148,"context_line":"        if self.total_mem \u003e 0:"},{"line_number":149,"context_line":"            used_mem_perc \u003d (float(used_mem) / float(self.total_mem)) * 100"},{"line_number":150,"context_line":"            # send metric percent used"},{"line_number":151,"context_line":"            self._send_metrics(\"mem.used_perc\","},{"line_number":152,"context_line":"                               used_mem_perc,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f91af0f_1704ac49","line":149,"updated":"2018-01-03 14:52:34.000000000","message":"Given the if at line 140, it is possible that used_mem is not defined. You should handle that.","commit_id":"6cae45bf1f550cf80939d9e9a3aadea4948006e6"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b8d28ad3b5c89ab8990b34e3c78ae27bf02778f5","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                               dimensions,"},{"line_number":154,"context_line":"                               metric_types, metric_units)"},{"line_number":155,"context_line":"        else:"},{"line_number":156,"context_line":"            self.log.warn(\"no value for total host memory, memory usage (percent) couldn\u0027t be calculated\")"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def _parse_filesystem(self, filesystem_data, dimensions):"},{"line_number":159,"context_line":"        filesystem_metrics \u003d METRICS[\u0027filesystem_metrics\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f91af0f_17602c01","line":156,"updated":"2018-01-03 14:52:34.000000000","message":"Given that you only check the machine info once, it doesn\u0027t make sense to continually log this warning.You already logged it above.","commit_id":"6cae45bf1f550cf80939d9e9a3aadea4948006e6"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b8d28ad3b5c89ab8990b34e3c78ae27bf02778f5","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                    usage_fs \u003d int(filesystem[cadvisor_key])"},{"line_number":171,"context_line":"                elif cadvisor_key \u003d\u003d \"capacity\":"},{"line_number":172,"context_line":"                    capacity_fs \u003d int(filesystem[cadvisor_key])"},{"line_number":173,"context_line":"            if capacity_fs \u003e 0:"},{"line_number":174,"context_line":"                self._send_metrics(\"fs.usage_perc\","},{"line_number":175,"context_line":"                                   (float(usage_fs) / capacity_fs) * 100,"},{"line_number":176,"context_line":"                                   file_dimensions,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f91af0f_579f9402","line":173,"updated":"2018-01-03 14:52:34.000000000","message":"Same here, capacity_fs and usage_fs may not be defined because of if at line 164","commit_id":"6cae45bf1f550cf80939d9e9a3aadea4948006e6"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b8d28ad3b5c89ab8990b34e3c78ae27bf02778f5","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                                   file_dimensions,"},{"line_number":177,"context_line":"                                   [\"gauge\"], [\"percent\"])"},{"line_number":178,"context_line":"            else:"},{"line_number":179,"context_line":"                self.log.warn(\"no value for file system capacity, file system usage (percent) couldn\u0027t be calculated\")"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def _parse_network(self, network_data, dimensions):"},{"line_number":182,"context_line":"        network_interfaces \u003d network_data[\u0027interfaces\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f91af0f_d759645a","line":179,"updated":"2018-01-03 14:52:34.000000000","message":"See above","commit_id":"6cae45bf1f550cf80939d9e9a3aadea4948006e6"},{"author":{"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},"change_message_id":"087c2c5a48cdcea412834ec49abd8930405cd84d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            self.log.debug(\"host memory \u003d {}\".format(self.total_mem))"},{"line_number":81,"context_line":"        else:"},{"line_number":82,"context_line":"            self.log.warn(\"Failed to retrieve host memory size\")"},{"line_number":83,"context_line":"        # store information about # of cores (incl. threads)"},{"line_number":84,"context_line":"        if machine_info[\u0027num_cores\u0027]:"},{"line_number":85,"context_line":"            self.num_cores \u003d int(machine_info[\u0027num_cores\u0027])"},{"line_number":86,"context_line":"            self.log.debug(\"number of cores of machine: {}\".format(self.num_cores))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_50c74e65","line":83,"range":{"start_line":83,"start_character":34,"end_line":83,"end_character":35},"updated":"2018-01-16 14:33:14.000000000","message":"number","commit_id":"f41a65561aca396e2209467b8315168eca9968e7"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"eebd9dd5169c0e19039af264a6d38cbe4b2300b4","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        else:"},{"line_number":112,"context_line":"            if not self.cadvisor_machine_url:"},{"line_number":113,"context_line":"                # Retrieve machine info only once"},{"line_number":114,"context_line":"                split_str \u003d self.cadvisor_url.split(\"/api\")"},{"line_number":115,"context_line":"                if len(split_str) \u003e 0:"},{"line_number":116,"context_line":"                    self.cadvisor_machine_url \u003d \"{}/{}\".format(split_str[0], \"api/v2.0/machine\")"},{"line_number":117,"context_line":"                    try:"},{"line_number":118,"context_line":"                        machine_info \u003d requests.get(self.cadvisor_machine_url).json()"},{"line_number":119,"context_line":"                    except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_af008f02","line":116,"range":{"start_line":114,"start_character":16,"end_line":116,"end_character":96},"updated":"2018-01-17 10:32:21.000000000","message":"I would recommend to use urlparse standard library for getting hostname","commit_id":"5fbaa63a9730916158bca48843b55c8bf8bf90af"}]}
