)]}'
{"monasca_agent/collector/checks_d/kubernetes.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"da211d7300ede1faa87cf0ff7280473e2faa8866","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            container_name \u003d container[\u0027name\u0027]"},{"line_number":216,"context_line":"            container_dimensions \u003d container_dimension_map[name2id[container_name]]"},{"line_number":217,"context_line":"            if \u0027resources\u0027 not in container:"},{"line_number":218,"context_line":"                self.log.info(\"Container {} does not have limits or requests set\")"},{"line_number":219,"context_line":"                continue"},{"line_number":220,"context_line":"            container_resources \u003d container[\u0027resources\u0027]"},{"line_number":221,"context_line":"            if \u0027limits\u0027 not in container_resources:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_8535d948","line":218,"updated":"2018-01-04 05:16:44.000000000","message":"Given how common it is to not have requests or limits, should these all be debug not even info?","commit_id":"8070f19732b9a3c169e7051230988838bc2f578a"},{"author":{"_account_id":26702,"name":"Nicolas Seyvet","email":"nseyvet@op5.com","username":"nseyvet"},"change_message_id":"547027f528e529b681751fe9f9397d6e7cbb2763","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            container_name \u003d container[\u0027name\u0027]"},{"line_number":216,"context_line":"            container_dimensions \u003d container_dimension_map[name2id[container_name]]"},{"line_number":217,"context_line":"            if \u0027resources\u0027 not in container:"},{"line_number":218,"context_line":"                self.log.info(\"Container {} does not have limits or requests set\")"},{"line_number":219,"context_line":"                continue"},{"line_number":220,"context_line":"            container_resources \u003d container[\u0027resources\u0027]"},{"line_number":221,"context_line":"            if \u0027limits\u0027 not in container_resources:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_d24f2032","line":218,"in_reply_to":"9f91af0f_8535d948","updated":"2018-01-04 11:58:21.000000000","message":"Either info/debug are fine but debug is more appropriate IMO.","commit_id":"8070f19732b9a3c169e7051230988838bc2f578a"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"1f98a5331aa0f58be2b288d3cbda90a19a3e168e","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            container_name \u003d container[\u0027name\u0027]"},{"line_number":216,"context_line":"            container_dimensions \u003d container_dimension_map[name2id[container_name]]"},{"line_number":217,"context_line":"            if \u0027resources\u0027 not in container:"},{"line_number":218,"context_line":"                self.log.info(\"Container {} does not have limits or requests set\")"},{"line_number":219,"context_line":"                continue"},{"line_number":220,"context_line":"            container_resources \u003d container[\u0027resources\u0027]"},{"line_number":221,"context_line":"            if \u0027limits\u0027 not in container_resources:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_2b6ff292","line":218,"in_reply_to":"9f91af0f_d24f2032","updated":"2018-01-04 16:12:23.000000000","message":"picky picky craig :) fixed in new patch","commit_id":"8070f19732b9a3c169e7051230988838bc2f578a"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"da211d7300ede1faa87cf0ff7280473e2faa8866","unresolved":false,"context_lines":[{"line_number":244,"context_line":"            if \u0027requests\u0027 not in container_resources:"},{"line_number":245,"context_line":"                self.log.info(\"Container {} does not have requests set\", container_name)"},{"line_number":246,"context_line":"            else:"},{"line_number":247,"context_line":"                container_requests \u003d container[\u0027resources\u0027][\u0027requests\u0027]"},{"line_number":248,"context_line":"                if \u0027cpu\u0027 in container_requests:"},{"line_number":249,"context_line":"                    cpu_request \u003d container_requests[\u0027cpu\u0027]"},{"line_number":250,"context_line":"                    cpu_value \u003d self._convert_cpu_to_cores(cpu_request)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_e52e25f9","line":247,"updated":"2018-01-04 05:16:44.000000000","message":"Should use container_resources here","commit_id":"8070f19732b9a3c169e7051230988838bc2f578a"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"1f98a5331aa0f58be2b288d3cbda90a19a3e168e","unresolved":false,"context_lines":[{"line_number":244,"context_line":"            if \u0027requests\u0027 not in container_resources:"},{"line_number":245,"context_line":"                self.log.info(\"Container {} does not have requests set\", container_name)"},{"line_number":246,"context_line":"            else:"},{"line_number":247,"context_line":"                container_requests \u003d container[\u0027resources\u0027][\u0027requests\u0027]"},{"line_number":248,"context_line":"                if \u0027cpu\u0027 in container_requests:"},{"line_number":249,"context_line":"                    cpu_request \u003d container_requests[\u0027cpu\u0027]"},{"line_number":250,"context_line":"                    cpu_value \u003d self._convert_cpu_to_cores(cpu_request)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_eb682a88","line":247,"in_reply_to":"9f91af0f_e52e25f9","updated":"2018-01-04 16:12:23.000000000","message":"Done","commit_id":"8070f19732b9a3c169e7051230988838bc2f578a"}]}