)]}'
{"monasca_agent/common/keystone.py":[{"author":{"_account_id":24580,"name":"James Gu","email":"james.gu@microsoft.com","username":"jamesgu"},"change_message_id":"c8a986f8637d895a4e063aed2875219fd6069613","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                           app_version\u003dma_version.version_string,"},{"line_number":140,"context_line":"                           user_agent\u003d\u0027monasca-agent\u0027,"},{"line_number":141,"context_line":"                           timeout\u003dkwargs.get(\u0027keystone_timeout\u0027, None),"},{"line_number":142,"context_line":"                           verify\u003dkwargs.get(\u0027verify\u0027, True))"},{"line_number":143,"context_line":"    return sess"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_ba0c4aa5","line":142,"range":{"start_line":142,"start_character":27,"end_line":142,"end_character":33},"updated":"2018-01-09 16:50:25.000000000","message":"See the comments below about the issue that verify is overloaded with cert path is insecure is set to insecure.\nsession constructor expects both verify and cert arguments in the secure mode. The change here I think essentially skips cert verify no matter what is set in the config because \u0027verify\u0027 no longer equals to True","commit_id":"269f6635d8fde36dcdd6c430a363cffb8a2cf384"},{"author":{"_account_id":24580,"name":"James Gu","email":"james.gu@microsoft.com","username":"jamesgu"},"change_message_id":"c8a986f8637d895a4e063aed2875219fd6069613","unresolved":false,"context_lines":[{"line_number":227,"context_line":"    if config.get(\u0027insecure\u0027, False):"},{"line_number":228,"context_line":"        raw_args[\u0027verify\u0027] \u003d False"},{"line_number":229,"context_line":"    else:"},{"line_number":230,"context_line":"        raw_args[\u0027verify\u0027] \u003d config.get(\u0027ca_file\u0027, None)"},{"line_number":231,"context_line":"    clean_args \u003d _sanitize_args(raw_args)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    LOG.debug(\u0027Removed %d keys that did not present values in configuration\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_5aaf3e7c","line":230,"range":{"start_line":230,"start_character":24,"end_line":230,"end_character":26},"updated":"2018-01-09 16:50:25.000000000","message":"Are we overloading verify here with the ca path if insecure is set to False? Once \"verify\" is set to a patch value e.g., \u0027/etc/ssl/certs/ca-cert.crt\u0027, verify \u003d\u003d True becomes False :-). The session constructor is expecting verify to be Boolean True or False.","commit_id":"269f6635d8fde36dcdd6c430a363cffb8a2cf384"}]}