)]}'
{"monasca_agent/collector/checks_d/docker.py":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7993fb2e5b35182abdf0363c13e5320459adcaca","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                        container_network_dimensions[\u0027interface\u0027] \u003d interface_name"},{"line_number":205,"context_line":"                        network_values \u003d cols[1].split()"},{"line_number":206,"context_line":"                        self._report_rate_gauge_metric("},{"line_number":207,"context_line":"                            \"container.net.in_bytes\", int("},{"line_number":208,"context_line":"                                network_values[0]), container_network_dimensions)"},{"line_number":209,"context_line":"                        self._report_rate_gauge_metric("},{"line_number":210,"context_line":"                            \"container.net.out_bytes\", int("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d0800afa","line":207,"range":{"start_line":207,"start_character":54,"end_line":207,"end_character":57},"updated":"2018-06-12 12:51:25.000000000","message":"If the byte counter is very large this could be auto-promoted to a long in Python 2.6 right?","commit_id":"9ba64ccb48d27d6a529c3c3946b9ebc5b10bc0e2"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"ed55e691352536ac4c6e41625d1b3efa5e51d91b","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                        container_network_dimensions[\u0027interface\u0027] \u003d interface_name"},{"line_number":205,"context_line":"                        network_values \u003d cols[1].split()"},{"line_number":206,"context_line":"                        self._report_rate_gauge_metric("},{"line_number":207,"context_line":"                            \"container.net.in_bytes\", int("},{"line_number":208,"context_line":"                                network_values[0]), container_network_dimensions)"},{"line_number":209,"context_line":"                        self._report_rate_gauge_metric("},{"line_number":210,"context_line":"                            \"container.net.out_bytes\", int("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_07d4ef1e","line":207,"range":{"start_line":207,"start_character":54,"end_line":207,"end_character":57},"in_reply_to":"5f7c97a3_5022a453","updated":"2018-06-13 08:25:25.000000000","message":"Agreed it should be fine as of Python 2.2: https://www.python.org/dev/peps/pep-0237/","commit_id":"9ba64ccb48d27d6a529c3c3946b9ebc5b10bc0e2"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"6b37cd56d39ba4b0363f33d69df93ec3c0861d2e","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                        container_network_dimensions[\u0027interface\u0027] \u003d interface_name"},{"line_number":205,"context_line":"                        network_values \u003d cols[1].split()"},{"line_number":206,"context_line":"                        self._report_rate_gauge_metric("},{"line_number":207,"context_line":"                            \"container.net.in_bytes\", int("},{"line_number":208,"context_line":"                                network_values[0]), container_network_dimensions)"},{"line_number":209,"context_line":"                        self._report_rate_gauge_metric("},{"line_number":210,"context_line":"                            \"container.net.out_bytes\", int("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_5022a453","line":207,"range":{"start_line":207,"start_character":54,"end_line":207,"end_character":57},"in_reply_to":"5f7c97a3_d0800afa","updated":"2018-06-13 07:55:00.000000000","message":"Yes, python automatically convert int to long.","commit_id":"9ba64ccb48d27d6a529c3c3946b9ebc5b10bc0e2"}],"monasca_agent/collector/checks_d/jenkins.py":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7993fb2e5b35182abdf0363c13e5320459adcaca","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    except ImportError:"},{"line_number":25,"context_line":"        pass"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"try:"},{"line_number":28,"context_line":"    xrange"},{"line_number":29,"context_line":"except NameError:"},{"line_number":30,"context_line":"    xrange \u003d range"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_70e816de","line":27,"range":{"start_line":27,"start_character":3,"end_line":27,"end_character":4},"updated":"2018-06-12 12:51:25.000000000","message":"Is there a reason for not using the six library? For example I think this is covered by six.moves.range().","commit_id":"9ba64ccb48d27d6a529c3c3946b9ebc5b10bc0e2"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"ce2e618dcfe74f9911710cd2ef59b0c44f317ab4","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    except ImportError:"},{"line_number":25,"context_line":"        pass"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"try:"},{"line_number":28,"context_line":"    xrange"},{"line_number":29,"context_line":"except NameError:"},{"line_number":30,"context_line":"    xrange \u003d range"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_73b7c022","line":27,"range":{"start_line":27,"start_character":3,"end_line":27,"end_character":4},"in_reply_to":"5f7c97a3_70e816de","updated":"2018-06-12 13:18:39.000000000","message":"+1\nThe same applies to six.text_type and six.integer_types in other places.","commit_id":"9ba64ccb48d27d6a529c3c3946b9ebc5b10bc0e2"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"6b37cd56d39ba4b0363f33d69df93ec3c0861d2e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    except ImportError:"},{"line_number":25,"context_line":"        pass"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"try:"},{"line_number":28,"context_line":"    xrange"},{"line_number":29,"context_line":"except NameError:"},{"line_number":30,"context_line":"    xrange \u003d range"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_84d1ddfd","line":27,"range":{"start_line":27,"start_character":3,"end_line":27,"end_character":4},"in_reply_to":"5f7c97a3_70e816de","updated":"2018-06-13 07:55:00.000000000","message":"Done","commit_id":"9ba64ccb48d27d6a529c3c3946b9ebc5b10bc0e2"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"6b37cd56d39ba4b0363f33d69df93ec3c0861d2e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    except ImportError:"},{"line_number":25,"context_line":"        pass"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"try:"},{"line_number":28,"context_line":"    xrange"},{"line_number":29,"context_line":"except NameError:"},{"line_number":30,"context_line":"    xrange \u003d range"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_846d5d33","line":27,"range":{"start_line":27,"start_character":3,"end_line":27,"end_character":4},"in_reply_to":"5f7c97a3_73b7c022","updated":"2018-06-13 07:55:00.000000000","message":"I think is better to  use int, because python2 automatically convert int to long if number is to large.\n\nsix.text_type:\nDone","commit_id":"9ba64ccb48d27d6a529c3c3946b9ebc5b10bc0e2"}],"monasca_agent/common/util.py":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"ed55e691352536ac4c6e41625d1b3efa5e51d91b","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"try:"},{"line_number":47,"context_line":"    long"},{"line_number":48,"context_line":"    NumericTypes \u003d (float, int, long)"},{"line_number":49,"context_line":"except NameError:"},{"line_number":50,"context_line":"    NumericTypes \u003d (float, int)"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_e7cbf3a0","line":48,"updated":"2018-06-13 08:25:25.000000000","message":"I think you could use six.integer_types here to avoid the try/ except.","commit_id":"cb9a3b139f2d16606715022f8a9bf6fa5ac43355"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"6dc91cfd90b7b005855024a50621590ee2ab027b","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"try:"},{"line_number":47,"context_line":"    long"},{"line_number":48,"context_line":"    NumericTypes \u003d (float, int, long)"},{"line_number":49,"context_line":"except NameError:"},{"line_number":50,"context_line":"    NumericTypes \u003d (float, int)"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_da0d6e8f","line":48,"in_reply_to":"5f7c97a3_e7cbf3a0","updated":"2018-06-13 09:06:46.000000000","message":"Done","commit_id":"cb9a3b139f2d16606715022f8a9bf6fa5ac43355"}]}