)]}'
{"README.md":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"b000213ef106bc77abdc881d3490e63cc6a5187c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"* Host alive. The Monasca Agent can perform active checks on a host to determine if it is alive using ping (ICMP) or SSH."},{"line_number":25,"context_line":"* Process checks. The Monasca Agent can check a process and return several"},{"line_number":26,"context_line":"metrics on the process such as number of instances, memory, io and threads."},{"line_number":27,"context_line":"For Docker environment you can specify the path of the process filesystem in"},{"line_number":28,"context_line":"plugin configuration."},{"line_number":29,"context_line":"* Http Endpoint checks. The Monasca Agent can perform active checks on http endpoints by sending an HTTP request to an API."},{"line_number":30,"context_line":"* Service checks. The Agent can check service such as MySQL, RabbitMQ, and many more."},{"line_number":31,"context_line":"* OpenStack metrics.  The agent can perform checks on OpenStack processes."}],"source_content_type":"text/x-gfm","patch_set":4,"id":"5f7c97a3_1e2b3fea","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":21},"updated":"2018-07-03 12:09:41.000000000","message":"What\u0027s the configuration option name? How do you make this process filesystem available in Docker container and why? Please add this information and move to docs/Plugins.md#process-checks","commit_id":"9253b1777047f8ec43eda5baa8b734e2c5bffb5f"}],"conf.d/process.yaml.example":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"b000213ef106bc77abdc881d3490e63cc6a5187c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# filesystem. By default it\u0027s set for: /proc directory."},{"line_number":6,"context_line":"# Example:"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"process_fs_path: /rootfs/proc"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"instances:"},{"line_number":11,"context_line":"#  - name: (required) STRING. It will be used to uniquely identify your metrics as they will be tagged with this name"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5f7c97a3_7e8593ad","line":8,"updated":"2018-07-03 12:09:41.000000000","message":"indentation missing","commit_id":"9253b1777047f8ec43eda5baa8b734e2c5bffb5f"}],"monasca_agent/collector/checks_d/process.py":[{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"c6cfcc9708ca3fab42391167b35b66ff9b622279","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        super(ProcessCheck, self).__init__(name, init_config, agent_config,"},{"line_number":39,"context_line":"                                           instances)"},{"line_number":40,"context_line":"        process_config \u003d cfg.Config().get_config(\u0027Process\u0027)"},{"line_number":41,"context_line":"        if process_config:"},{"line_number":42,"context_line":"            process_fs_path_config \u003d process_config.get(\u0027process_fs_path\u0027, None)"},{"line_number":43,"context_line":"            if process_fs_path_config:"},{"line_number":44,"context_line":"                psutil.PROCFS_PATH \u003d process_fs_path_config"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        self._cached_processes \u003d defaultdict(dict)"},{"line_number":47,"context_line":"        self._current_process_list \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_8a33a4c4","line":44,"range":{"start_line":41,"start_character":7,"end_line":44,"end_character":59},"updated":"2018-07-02 11:49:27.000000000","message":"I think this part should log something in case process_fs_path is not define.","commit_id":"c9e330cd7543eb10786d6c26dbdac97bf3c2395e"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"5badc4032990b903f9a0acd100d41a2752acfd32","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from collections import namedtuple"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import monasca_agent.collector.checks as checks"},{"line_number":21,"context_line":"import monasca_agent.common.config as cfg"},{"line_number":22,"context_line":"from monasca_agent.common.psutil_wrapper import psutil"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"ProcessStruct \u003d namedtuple(\"Process\", \"name pid username cmdline\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_6f2ba494","line":21,"range":{"start_line":21,"start_character":2,"end_line":21,"end_character":41},"updated":"2018-07-03 07:11:39.000000000","message":"please check unused \u0027cfg\u0027 to fix pep8 issue","commit_id":"8599121e4b67292ae4323184f7409f7991db0805"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"50f205732d800930275540391210001ab68b311a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        process_fs_path_config \u003d init_config.get(\u0027process_fs_path\u0027, None)"},{"line_number":40,"context_line":"        if process_fs_path_config:"},{"line_number":41,"context_line":"            psutil.PROCFS_PATH \u003d process_fs_path_config"},{"line_number":42,"context_line":"            self.log.debug(\u0027The path of the process filesystem set to\u0027 % process_fs_path_config)"},{"line_number":43,"context_line":"        else:"},{"line_number":44,"context_line":"            self.log.debug(\u0027The process_fs_path not set. Use default path: proc\u0027)"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_72962c4c","line":42,"range":{"start_line":42,"start_character":12,"end_line":42,"end_character":96},"updated":"2018-07-03 08:39:35.000000000","message":"It returns TypeError. Use instead:\n\n  self.log.debug(\u0027The path of the process filesystem set to %s\u0027, process_fs_path_config)","commit_id":"65a2a7c36a37a1139c8b0af7f5888d0324d08cb5"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"50f205732d800930275540391210001ab68b311a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            psutil.PROCFS_PATH \u003d process_fs_path_config"},{"line_number":42,"context_line":"            self.log.debug(\u0027The path of the process filesystem set to\u0027 % process_fs_path_config)"},{"line_number":43,"context_line":"        else:"},{"line_number":44,"context_line":"            self.log.debug(\u0027The process_fs_path not set. Use default path: proc\u0027)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        self._cached_processes \u003d defaultdict(dict)"},{"line_number":47,"context_line":"        self._current_process_list \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_328af419","line":44,"range":{"start_line":44,"start_character":75,"end_line":44,"end_character":79},"updated":"2018-07-03 08:39:35.000000000","message":"/proc","commit_id":"65a2a7c36a37a1139c8b0af7f5888d0324d08cb5"}],"monasca_agent/common/config.py":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"0b772f38cd6de46e0652ee4878f8c2fff75b5b45","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                                   \u0027monasca_statsd_forward_host\u0027: None,"},{"line_number":91,"context_line":"                                   \u0027monasca_statsd_forward_port\u0027: 8125,"},{"line_number":92,"context_line":"                                   \u0027monasca_statsd_port\u0027: 8125},"},{"line_number":93,"context_line":"                        \u0027Process\u0027: {\u0027process_fs_path\u0027: \u0027/proc\u0027},"},{"line_number":94,"context_line":"                        \u0027Logging\u0027: {\u0027disable_file_logging\u0027: False,"},{"line_number":95,"context_line":"                                    \u0027log_level\u0027: None,"},{"line_number":96,"context_line":"                                    \u0027collector_log_file\u0027: DEFAULT_LOG_DIR + \u0027/collector.log\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_a34b2b84","line":93,"updated":"2018-07-02 15:26:01.000000000","message":"The option fits better in `init_config` section of process check. Please compare similar approach [1].\n\n[1] https://git.openstack.org/cgit/openstack/monasca-agent/diff/monasca_agent/collector/checks_d/http_check.py?id\u003de13de8083e90170b9a90000b534bfd1c1cc88551","commit_id":"c9e330cd7543eb10786d6c26dbdac97bf3c2395e"}]}