)]}'
{"id":"openstack%2Fmonasca-agent~583876","triplet_id":"openstack%2Fmonasca-agent~master~I503d74936f6f37fb261c1592845968319695475a","project":"openstack/monasca-agent","branch":"master","topic":"swift_recon","hashtags":[],"change_id":"I503d74936f6f37fb261c1592845968319695475a","subject":"Add swift_recon check plugin to monasca","status":"MERGED","created":"2018-07-19 07:40:14.000000000","updated":"2019-10-18 12:10:41.000000000","submitted":"2019-10-18 12:10:41.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"583876-1571400641649-b61b701d","meta_rev_id":"8f40b6056db17abb65a4ccbba4790987d4aa9683","_number":583876,"virtual_id_number":583876,"owner":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-18 12:10:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},{"value":0,"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-10-09 17:09:32.000000000","_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},{"value":0,"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-10-18 12:04:25.000000000","_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},{"value":0,"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-18 12:04:25.000000000","updated_by":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"reviewer":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"state":"REVIEWER"},{"updated":"2019-10-18 12:10:41.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"64ddb8de766cb2dd7731b11ea6023682011f948d","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2018-07-19 07:40:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"85ba20001d90db105ddbad2e59498b0a6bd8967e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-19 08:36:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/76/583876/1/check/openstack-tox-pep8/37f65ae/ : SUCCESS in 6m 02s\n- openstack-tox-py27 http://logs.openstack.org/76/583876/1/check/openstack-tox-py27/3748bf2/ : SUCCESS in 5m 04s\n- openstack-tox-py35 http://logs.openstack.org/76/583876/1/check/openstack-tox-py35/a4081be/ : SUCCESS in 7m 20s (non-voting)\n- monasca-tempest-python-influxdb http://logs.openstack.org/76/583876/1/check/monasca-tempest-python-influxdb/14ef3c5/ : SUCCESS in 51m 19s (non-voting)\n- monasca-tempest-java-influxdb http://logs.openstack.org/76/583876/1/check/monasca-tempest-java-influxdb/72e8dc6/ : SUCCESS in 48m 15s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"56199ba06217df309edf9187fda602ed3b520af6","author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"date":"2018-08-08 12:11:32.000000000","message":"Patch Set 1:\n\nJust for reference. There was one already one approach to add swift_recon plugin. You might want to check for ideas.\n\nhttps://review.openstack.org/408653","accounts_in_message":[],"_revision_number":1},{"id":"e4efdfa6a6d47e6aeaadf7fd784bbc597d508827","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2019-04-03 02:42:27.000000000","message":"Patch Set 1:\n\nI\u0027ve commented on the other. From what I see, it would be running swift-recon (the binary) which will in tern go talk to every server. So its really noisy unless it\u0027s only run on one node. And then it also returns a summary (best, worst, avg, etc).\n\nThis hits the recon api on the local node and sends it back. What the swift-recon binary is hitting up on each server. So you get all the data (only once from each server) that you can then manipulate in grafana.\n\nBut I\u0027ll go double check I have that right.","accounts_in_message":[],"_revision_number":1},{"id":"2f3aa20ed1a27dbad600da52345685629247dc7d","author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"date":"2019-04-03 10:03:38.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nOh, man. I have completely lost it from my radar.\n\nCould you please add a documentation section for this plugin?","accounts_in_message":[],"_revision_number":1},{"id":"e4fdd97d1b2d681007820d23c2948aea5d90d7cd","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2019-10-09 02:18:27.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ab8d7a7aa357fc9c3b200717c8b84f335a278475","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2019-10-09 02:21:07.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"bedeec60bd604578dd86f5e77cf89c17c6655b94","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-09 03:11:16.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c8f1f673dde643fbb83b1aa0888ba30a : SUCCESS in 4m 40s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/ca0d16891d064e36822c45d0eae38b36 : SUCCESS in 4m 46s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a30411b977e940afa2f566dede216034 : SUCCESS in 4m 56s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/0f134b9331b54110999681be516fa0fb : SUCCESS in 4m 50s\n- build-monasca-docker-image https://zuul.opendev.org/t/openstack/build/2984011c3b2e4828b134fc2b78f782c3 : SUCCESS in 25m 31s\n- monasca-tempest-python2-influxdb https://zuul.opendev.org/t/openstack/build/4c7b30ebde82492e902257003a347758 : SUCCESS in 38m 10s (non-voting)\n- monasca-tempest-python3-influxdb https://zuul.opendev.org/t/openstack/build/103418e911e74963a07794846c345179 : SUCCESS in 46m 46s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"c083f7d8f4488e538761027092dc580d11240432","author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"date":"2019-10-09 17:06:21.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"153ad7ebfb3530fa6b55fec49b7c2c28e56ff620","author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"date":"2019-10-09 17:09:32.000000000","message":"Patch Set 3: Code-Review+2\n\nThanks a lot! Fixed one typo and wrapped documentation text.","accounts_in_message":[],"_revision_number":3},{"id":"f522e8cd0bc64d5667aaf1e1a3a4a72d1a50beb3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-09 17:51:43.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ba68124cb3db4366890d7bafa4629c3d : SUCCESS in 5m 18s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/c25eb0a56cc248469949762000049ec8 : SUCCESS in 4m 59s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b3c3c1fe50764444baa46a9b2e579f41 : SUCCESS in 4m 39s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/e759d92291f34bc8b1b70e2ba681748c : SUCCESS in 6m 09s\n- build-monasca-docker-image https://zuul.opendev.org/t/openstack/build/69dda5825a5245b68c5c00f95f7aba47 : SUCCESS in 27m 55s\n- monasca-tempest-python2-influxdb https://zuul.opendev.org/t/openstack/build/ad56a860c0964b04aaf81695e781459e : SUCCESS in 42m 26s (non-voting)\n- monasca-tempest-python3-influxdb https://zuul.opendev.org/t/openstack/build/58cd6f8c5ef34a19af6b7ca46aeaf96a : SUCCESS in 39m 00s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"03c993917bf5136a6a65b7c6f9d6ef7e43aede5a","author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"date":"2019-10-18 12:04:25.000000000","message":"Patch Set 3: Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"4bdedcfb577db55522b91034b8893cf2697d945c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-18 12:04:36.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"1418586449d58b2ef96e92ce1bc51de62368a3b4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-18 12:10:41.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5ea6676050bb4185941bb4c62a1de844 : SUCCESS in 5m 00s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/d9b3038303ff490b8772048e2d7b88c3 : SUCCESS in 4m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c3909b9f12744de19356e22d1ab1b36a : SUCCESS in 5m 00s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/6e023251af7441f8863c132fb8e1e9a1 : SUCCESS in 4m 42s","accounts_in_message":[],"_revision_number":3},{"id":"5617f400f03bb4e74550435e5e64cc8ee9ed2c40","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-18 12:10:41.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"0d929d01a864b45b10ed80baef9d4f5b0086dcf8","revisions":{"19c5035148a83f91ee0dc24ea8415fdc1eb9fd25":{"kind":"REWORK","_number":1,"created":"2018-07-19 07:40:14.000000000","uploader":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"ref":"refs/changes/76/583876/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/monasca-agent","ref":"refs/changes/76/583876/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/monasca-agent refs/changes/76/583876/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/monasca-agent refs/changes/76/583876/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/monasca-agent refs/changes/76/583876/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/monasca-agent refs/changes/76/583876/1"}}},"commit":{"parents":[{"commit":"3712e124a6bbde0b01046b32277f06921df2d012","subject":"Trivial fix typo of description","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-agent/commit/3712e124a6bbde0b01046b32277f06921df2d012"}]}],"author":{"name":"Matthew Oliver","email":"matt@oliver.net.au","date":"2018-07-19 07:27:25.000000000","tz":600},"committer":{"name":"Matthew Oliver","email":"matt@oliver.net.au","date":"2018-07-19 07:40:11.000000000","tz":600},"subject":"Add swift_recon check plugin to monasca","message":"Add swift_recon check plugin to monasca\n\nSwift outputs alot of statsd metrics that you can point directly\nat monasca-agents. However there is another swift endpoint,\nrecon, that is used to gather more metrics.\n\nThe Swift recon (or reconnaissance) API is an endpoint each of the\nstorage node servers make available via a REST API. This API can\neither be hit manually or via the swift-recon tool.\n\nThis patch adds a check plugin that hits the recon REST API and\nand send metrics to monasca.\n\nThis is the first of two Swift check plugins I\u0027m working on.\nFor more details see my blog post[1]\n\n[1] - https://oliver.net.au/?p\u003d358\n\nChange-Id: I503d74936f6f37fb261c1592845968319695475a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-agent/commit/19c5035148a83f91ee0dc24ea8415fdc1eb9fd25"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-agent/commit/19c5035148a83f91ee0dc24ea8415fdc1eb9fd25"}]},"branch":"refs/heads/master"},"d26c9da057041c09fe20bb7cf41aca96c7e0bd6f":{"kind":"REWORK","_number":2,"created":"2019-10-09 02:18:27.000000000","uploader":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"ref":"refs/changes/76/583876/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/monasca-agent","ref":"refs/changes/76/583876/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/monasca-agent refs/changes/76/583876/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/monasca-agent refs/changes/76/583876/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/monasca-agent refs/changes/76/583876/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/monasca-agent refs/changes/76/583876/2"}}},"commit":{"parents":[{"commit":"18b3098b1576bb8c4b910304c448d5e51985e8f2","subject":"Add requirement for Prometheus plugin","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-agent/commit/18b3098b1576bb8c4b910304c448d5e51985e8f2"}]}],"author":{"name":"Matthew Oliver","email":"matt@oliver.net.au","date":"2018-07-19 07:27:25.000000000","tz":600},"committer":{"name":"Matthew Oliver","email":"matt@oliver.net.au","date":"2019-10-09 02:18:04.000000000","tz":660},"subject":"Add swift_recon check plugin to monasca","message":"Add swift_recon check plugin to monasca\n\nSwift outputs alot of statsd metrics that you can point directly\nat monasca-agents. However there is another swift endpoint,\nrecon, that is used to gather more metrics.\n\nThe Swift recon (or reconnaissance) API is an endpoint each of the\nstorage node servers make available via a REST API. This API can\neither be hit manually or via the swift-recon tool.\n\nThis patch adds a check plugin that hits the recon REST API and\nand send metrics to monasca.\n\nThis is the first of two Swift check plugins I\u0027m working on.\nFor more details see my blog post[1]\n\n[1] - https://oliver.net.au/?p\u003d358\n\nChange-Id: I503d74936f6f37fb261c1592845968319695475a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-agent/commit/d26c9da057041c09fe20bb7cf41aca96c7e0bd6f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-agent/commit/d26c9da057041c09fe20bb7cf41aca96c7e0bd6f"}]},"branch":"refs/heads/master"},"0d929d01a864b45b10ed80baef9d4f5b0086dcf8":{"kind":"REWORK","_number":3,"created":"2019-10-09 17:06:21.000000000","uploader":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"ref":"refs/changes/76/583876/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/monasca-agent","ref":"refs/changes/76/583876/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/monasca-agent refs/changes/76/583876/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/monasca-agent refs/changes/76/583876/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/monasca-agent refs/changes/76/583876/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/monasca-agent refs/changes/76/583876/3"}}},"commit":{"parents":[{"commit":"18b3098b1576bb8c4b910304c448d5e51985e8f2","subject":"Add requirement for Prometheus plugin","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-agent/commit/18b3098b1576bb8c4b910304c448d5e51985e8f2"}]}],"author":{"name":"Matthew Oliver","email":"matt@oliver.net.au","date":"2018-07-19 07:27:25.000000000","tz":600},"committer":{"name":"Witek Bedyk","email":"witold.bedyk@suse.com","date":"2019-10-09 17:06:08.000000000","tz":120},"subject":"Add swift_recon check plugin to monasca","message":"Add swift_recon check plugin to monasca\n\nSwift outputs alot of statsd metrics that you can point directly\nat monasca-agents. However there is another swift endpoint,\nrecon, that is used to gather more metrics.\n\nThe Swift recon (or reconnaissance) API is an endpoint each of the\nstorage node servers make available via a REST API. This API can\neither be hit manually or via the swift-recon tool.\n\nThis patch adds a check plugin that hits the recon REST API and\nand send metrics to monasca.\n\nThis is the first of two Swift check plugins I\u0027m working on.\nFor more details see my blog post[1]\n\n[1] - https://oliver.net.au/?p\u003d358\n\nChange-Id: I503d74936f6f37fb261c1592845968319695475a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-agent/commit/0d929d01a864b45b10ed80baef9d4f5b0086dcf8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-agent/commit/0d929d01a864b45b10ed80baef9d4f5b0086dcf8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}