)]}'
{"tests/detection/test_http_check.py":[{"author":{"_account_id":23735,"name":"sumitjami","email":"sjamgade@suse.com","username":"nthforloop"},"change_message_id":"b453ec2219ebcb5e141ef5e664a8368f1b2e5f63","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                \u0027keystone_project\u003dtest_project keystone_project_domain\u003dbar \u0027"},{"line_number":30,"context_line":"                \u0027keystone_user_domain\u003dbar use_keystone\u003dTrue \u0027"},{"line_number":31,"context_line":"                \u0027url\u003dhttps://myurl.com\u0027)"},{"line_number":32,"context_line":"        plugin \u003d HttpCheck(None, args\u003dargs)"},{"line_number":33,"context_line":"        conf \u003d plugin.build_config()"},{"line_number":34,"context_line":"        self.assertTrue(\u0027keystone_config\u0027 in conf[\u0027http_check\u0027][\u0027init_config\u0027])"},{"line_number":35,"context_line":"        expected_keystone_config \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_46fbde12","line":32,"range":{"start_line":32,"start_character":38,"end_line":32,"end_character":42},"updated":"2018-12-21 07:23:00.000000000","message":"suggest a suggestion to reduce redundancy:\nyou could pass `args\u003dexpected_keystone_config`\nand then use the same dict for validation, that way we dont have accidentally bugs","commit_id":"dd5441cd401fc875e53a978080627beec2b42fc6"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"eb19e718237bc23073e350e3dddca35bdd7890b5","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                \u0027keystone_project\u003dtest_project keystone_project_domain\u003dbar \u0027"},{"line_number":30,"context_line":"                \u0027keystone_user_domain\u003dbar use_keystone\u003dTrue \u0027"},{"line_number":31,"context_line":"                \u0027url\u003dhttps://myurl.com\u0027)"},{"line_number":32,"context_line":"        plugin \u003d HttpCheck(None, args\u003dargs)"},{"line_number":33,"context_line":"        conf \u003d plugin.build_config()"},{"line_number":34,"context_line":"        self.assertTrue(\u0027keystone_config\u0027 in conf[\u0027http_check\u0027][\u0027init_config\u0027])"},{"line_number":35,"context_line":"        expected_keystone_config \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b8fc4640","line":32,"range":{"start_line":32,"start_character":38,"end_line":32,"end_character":42},"in_reply_to":"3f79a3b5_46fbde12","updated":"2018-12-21 17:26:38.000000000","message":"They are different though. Args is the raw arguments and expected_keystone_config is the processed config.","commit_id":"dd5441cd401fc875e53a978080627beec2b42fc6"}]}
