)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"79fe570986f018523d49255ea7852c358478c24c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change Elasticsearch urls to fix failing metrics retrieval"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The change concerns Elasticsearch 7.3+. The change was made"},{"line_number":10,"context_line":"due to internal changes in Elastisearch, as compared to the"},{"line_number":11,"context_line":"version we\u0027re using now."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3fa7e38b_ee9b13c6","line":9,"updated":"2019-10-09 15:57:17.000000000","message":"I checked and it is also broken in ES 5.6.16.","commit_id":"833cee2413141416a47aaf601755585e864fd140"}],"monasca_agent/collector/checks_d/elastic.py":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"79fe570986f018523d49255ea7852c358478c24c","unresolved":false,"context_lines":[{"line_number":232,"context_line":"            # ES versions 0.90.10 and above"},{"line_number":233,"context_line":"            # Metrics architecture changed starting with version 0.90.10"},{"line_number":234,"context_line":"            self.HEALTH_URL \u003d \"/_cluster/health?pretty\u003dtrue\""},{"line_number":235,"context_line":"            self.STATS_URL \u003d \"/_nodes/stats/_all\""},{"line_number":236,"context_line":"            self.NODES_URL \u003d \"/_nodes/_all\""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"            additional_metrics \u003d {"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_cecdf7b7","line":235,"updated":"2019-10-09 15:57:17.000000000","message":"Does the old method work in ES 2.4? If so, can we add an `if version \u003e\u003d [5,0,0]` or similar for this new URL? Someone might want to use this plugin to monitor a different Elasticsearch instance to that used by Monasca.","commit_id":"833cee2413141416a47aaf601755585e864fd140"},{"author":{"_account_id":30221,"name":"Arseni Lipinski","email":"arseni.lipinski@ts.fujitsu.com","username":"arseni.lipinski"},"change_message_id":"02c32d4c6527d031f36a516a18c81a440a3bd40b","unresolved":false,"context_lines":[{"line_number":232,"context_line":"            # ES versions 0.90.10 and above"},{"line_number":233,"context_line":"            # Metrics architecture changed starting with version 0.90.10"},{"line_number":234,"context_line":"            self.HEALTH_URL \u003d \"/_cluster/health?pretty\u003dtrue\""},{"line_number":235,"context_line":"            self.STATS_URL \u003d \"/_nodes/stats/_all\""},{"line_number":236,"context_line":"            self.NODES_URL \u003d \"/_nodes/_all\""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"            additional_metrics \u003d {"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_4c9a6514","line":235,"in_reply_to":"3fa7e38b_ac03d941","updated":"2019-10-28 08:40:51.000000000","message":"i mean, no additional changes have to be made.","commit_id":"833cee2413141416a47aaf601755585e864fd140"},{"author":{"_account_id":30221,"name":"Arseni Lipinski","email":"arseni.lipinski@ts.fujitsu.com","username":"arseni.lipinski"},"change_message_id":"c72a92450f3c231096292c0d3b7b79610cfd3e48","unresolved":false,"context_lines":[{"line_number":232,"context_line":"            # ES versions 0.90.10 and above"},{"line_number":233,"context_line":"            # Metrics architecture changed starting with version 0.90.10"},{"line_number":234,"context_line":"            self.HEALTH_URL \u003d \"/_cluster/health?pretty\u003dtrue\""},{"line_number":235,"context_line":"            self.STATS_URL \u003d \"/_nodes/stats/_all\""},{"line_number":236,"context_line":"            self.NODES_URL \u003d \"/_nodes/_all\""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"            additional_metrics \u003d {"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_ac03d941","line":235,"in_reply_to":"3fa7e38b_cecdf7b7","updated":"2019-10-28 08:39:44.000000000","message":"Checked and the methods i\u0027ve added work in old ES (2.4.6) as well, so I guess it can remain this way and no changes have to be made besides that.","commit_id":"833cee2413141416a47aaf601755585e864fd140"}]}