)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3b35e0d76a4a913096cc6cbe55084ddf66d82671","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Adrian Czarnecki \u003cadrian.czarnecki@ts.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-05-14 21:01:25 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve error handling in method that creat monasc client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add error handler that prevent crash of forwarded"},{"line_number":10,"context_line":"when agent is not able to connect to keystone"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ff570b3c_da5d9a49","line":7,"range":{"start_line":7,"start_character":38,"end_line":7,"end_character":50},"updated":"2020-05-22 12:53:50.000000000","message":"creates Monasca","commit_id":"76311c359e5a32f3fe30e2430ee326093be395f0"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"9e57077b4781344ccf5c7a7541ad8642534b0182","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Adrian Czarnecki \u003cadrian.czarnecki@ts.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-05-25 09:48:33 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve error handling in method that creat monasc client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add error handler that prevent crash of forwarded"},{"line_number":10,"context_line":"when agent is not able to connect to keystone"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ff570b3c_4a5b512d","line":7,"range":{"start_line":7,"start_character":38,"end_line":7,"end_character":50},"updated":"2020-05-26 10:02:51.000000000","message":"nit: creates Monasca","commit_id":"9c651ac45783da41429e35067ffe61325309a0fb"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"9e57077b4781344ccf5c7a7541ad8642534b0182","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add error handler that prevent crash of forwarded"},{"line_number":10,"context_line":"when agent is not able to connect to keystone"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If6366e5b94f9cbe3f21ce9dbeb26d28e3a36ae88"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ff570b3c_8a3c49c0","line":11,"updated":"2020-05-26 10:02:51.000000000","message":"You\u0027ve lost StoryBoard reference.","commit_id":"9c651ac45783da41429e35067ffe61325309a0fb"}],"monasca_agent/forwarder/api/monasca_api.py":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"416251d1415946bd1232c02e16f4b7657cc8fda3","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                **keystone.get_args(self._config)"},{"line_number":149,"context_line":"            )"},{"line_number":150,"context_line":"            return c"},{"line_number":151,"context_line":"        except keystone.discover.exceptions.DiscoveryFailure as ex:"},{"line_number":152,"context_line":"            log.error(\u0027Failed to connect to keystone. {}\u0027.format(ex))"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _send_message(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_9de0fcce","line":151,"updated":"2020-05-13 10:18:25.000000000","message":"Isn\u0027t it a permanent error? In that case we shouldn\u0027t be catching it here I guess.","commit_id":"b28832c021c5fcf697efa8a17c61d86c6937886d"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"4d1606e589b0507b2c84cca640edf171d2207f10","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                **keystone.get_args(self._config)"},{"line_number":149,"context_line":"            )"},{"line_number":150,"context_line":"            return c"},{"line_number":151,"context_line":"        except keystone.discover.exceptions.DiscoveryFailure as ex:"},{"line_number":152,"context_line":"            log.error(\u0027Failed to connect to keystone. {}\u0027.format(ex))"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _send_message(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_a6711a79","line":151,"in_reply_to":"ff570b3c_5d4bd2ae","updated":"2020-05-18 09:12:06.000000000","message":"+1, it looks like catching the base exception `ClientException` would cover other related failures:\n\n```\nkeystoneauth1/exceptions/auth_plugins.py:class AuthPluginException(base.ClientException):\nkeystoneauth1/exceptions/discovery.py:class DiscoveryFailure(base.ClientException):\nkeystoneauth1/exceptions/connection.py:class ConnectionError(base.ClientException):\nkeystoneauth1/exceptions/catalog.py:class CatalogException(base.ClientException):\nkeystoneauth1/exceptions/response.py:class InvalidResponse(base.ClientException):\nkeystoneauth1/exceptions/service_providers.py:class ServiceProviderNotFound(base.ClientException):\n```","commit_id":"b28832c021c5fcf697efa8a17c61d86c6937886d"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"c55e4d17b1a4b1748ad10510b398e724e3cb8838","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                **keystone.get_args(self._config)"},{"line_number":149,"context_line":"            )"},{"line_number":150,"context_line":"            return c"},{"line_number":151,"context_line":"        except keystone.discover.exceptions.DiscoveryFailure as ex:"},{"line_number":152,"context_line":"            log.error(\u0027Failed to connect to keystone. {}\u0027.format(ex))"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _send_message(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_5d4bd2ae","line":151,"in_reply_to":"ff570b3c_9de0fcce","updated":"2020-05-15 10:53:23.000000000","message":"Get it now. If creating the Monasca client fails the message is stored in a queue and the procedure repeated in the next post attempt.\nIs it the only exception which can be thrown here?","commit_id":"b28832c021c5fcf697efa8a17c61d86c6937886d"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"a33a2b8d5ff31af4668b74704222e892f4560a6c","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                **keystone.get_args(self._config)"},{"line_number":149,"context_line":"            )"},{"line_number":150,"context_line":"            return c"},{"line_number":151,"context_line":"        except keystone.discover.exceptions.DiscoveryFailure as ex:"},{"line_number":152,"context_line":"            log.error(\u0027Failed to connect to keystone. {}\u0027.format(ex))"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _send_message(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_b33553ab","line":151,"in_reply_to":"ff570b3c_a6711a79","updated":"2020-05-25 16:49:21.000000000","message":"Done","commit_id":"b28832c021c5fcf697efa8a17c61d86c6937886d"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3b35e0d76a4a913096cc6cbe55084ddf66d82671","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                **keystone.get_args(self._config)"},{"line_number":149,"context_line":"            )"},{"line_number":150,"context_line":"            return c"},{"line_number":151,"context_line":"        except keystone.discover.exceptions.DiscoveryFailure as ex:"},{"line_number":152,"context_line":"            log.error(\u0027Failed to connect to keystone. {}\u0027.format(ex))"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _send_message(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_3a98161a","line":151,"range":{"start_line":151,"start_character":44,"end_line":151,"end_character":60},"updated":"2020-05-22 12:53:50.000000000","message":"Could we catch ClientException here as Doug suggests?","commit_id":"76311c359e5a32f3fe30e2430ee326093be395f0"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"a33a2b8d5ff31af4668b74704222e892f4560a6c","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                **keystone.get_args(self._config)"},{"line_number":149,"context_line":"            )"},{"line_number":150,"context_line":"            return c"},{"line_number":151,"context_line":"        except keystone.discover.exceptions.DiscoveryFailure as ex:"},{"line_number":152,"context_line":"            log.error(\u0027Failed to connect to keystone. {}\u0027.format(ex))"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _send_message(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_53bb170d","line":151,"range":{"start_line":151,"start_character":44,"end_line":151,"end_character":60},"in_reply_to":"ff570b3c_3a98161a","updated":"2020-05-25 16:49:21.000000000","message":"Done","commit_id":"76311c359e5a32f3fe30e2430ee326093be395f0"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"c55e4d17b1a4b1748ad10510b398e724e3cb8838","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            )"},{"line_number":150,"context_line":"            return c"},{"line_number":151,"context_line":"        except keystone.discover.exceptions.DiscoveryFailure as ex:"},{"line_number":152,"context_line":"            log.error(\u0027Failed to connect to keystone. {}\u0027.format(ex))"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _send_message(self, **kwargs):"},{"line_number":155,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_9dca8a17","line":152,"range":{"start_line":152,"start_character":44,"end_line":152,"end_character":52},"updated":"2020-05-15 10:53:23.000000000","message":"nit: Keystone","commit_id":"76311c359e5a32f3fe30e2430ee326093be395f0"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"a33a2b8d5ff31af4668b74704222e892f4560a6c","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            )"},{"line_number":150,"context_line":"            return c"},{"line_number":151,"context_line":"        except keystone.discover.exceptions.DiscoveryFailure as ex:"},{"line_number":152,"context_line":"            log.error(\u0027Failed to connect to keystone. {}\u0027.format(ex))"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _send_message(self, **kwargs):"},{"line_number":155,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_73be1b00","line":152,"range":{"start_line":152,"start_character":44,"end_line":152,"end_character":52},"in_reply_to":"ff570b3c_9dca8a17","updated":"2020-05-25 16:49:21.000000000","message":"Done","commit_id":"76311c359e5a32f3fe30e2430ee326093be395f0"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"9e57077b4781344ccf5c7a7541ad8642534b0182","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                **keystone.get_args(self._config)"},{"line_number":149,"context_line":"            )"},{"line_number":150,"context_line":"            return c"},{"line_number":151,"context_line":"        except exceptions.ClientException as ex:"},{"line_number":152,"context_line":"            log.error(\u0027Failed to connect to Keystone. {}\u0027.format(ex))"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _send_message(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_8a6569e4","line":151,"range":{"start_line":151,"start_character":15,"end_line":151,"end_character":41},"updated":"2020-05-26 10:02:51.000000000","message":"Should be keystoneauth1.exceptions.base.ClientException","commit_id":"9c651ac45783da41429e35067ffe61325309a0fb"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"9e57077b4781344ccf5c7a7541ad8642534b0182","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            )"},{"line_number":150,"context_line":"            return c"},{"line_number":151,"context_line":"        except exceptions.ClientException as ex:"},{"line_number":152,"context_line":"            log.error(\u0027Failed to connect to Keystone. {}\u0027.format(ex))"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _send_message(self, **kwargs):"},{"line_number":155,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_0a88396f","line":152,"range":{"start_line":152,"start_character":33,"end_line":152,"end_character":52},"updated":"2020-05-26 10:02:51.000000000","message":"Nit: I\u0027d make the message more general now. Something like: \"Failed to initialize Monasca client.\"","commit_id":"9c651ac45783da41429e35067ffe61325309a0fb"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"02d4af05b4ed0b4677bbcb105b990839ae8c4055","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import logging"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from osc_lib import exceptions"},{"line_number":22,"context_line":"from monascaclient import client"},{"line_number":23,"context_line":"from keystoneauth1.exceptions import base as keystoneauth_exception"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from monasca_agent.common import keystone"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_62be2ed5","line":22,"updated":"2020-05-26 20:15:46.000000000","message":"pep8: H306: imports not in alphabetical order (osc_lib.exceptions, monascaclient.client)","commit_id":"bb5a967e9c7b180097c939729d54b511b82f3fa5"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"02d4af05b4ed0b4677bbcb105b990839ae8c4055","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from osc_lib import exceptions"},{"line_number":22,"context_line":"from monascaclient import client"},{"line_number":23,"context_line":"from keystoneauth1.exceptions import base as keystoneauth_exception"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from monasca_agent.common import keystone"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_c2b57af0","line":23,"updated":"2020-05-26 20:15:46.000000000","message":"pep8: H306: imports not in alphabetical order (monascaclient.client, keystoneauth1.exceptions.base)","commit_id":"bb5a967e9c7b180097c939729d54b511b82f3fa5"}]}